[PATCH] gnu: newsbeuter: Supersede.

Done

Details

4 participants

Leo Famulari
Ludovic Courtès
Tobias Geerinckx-Rice
ng0

Owner: unassigned

Submitted by: Tobias Geerinckx-Rice

Severity: normal

Tobias Geerinckx-Rice wrote on 4 Jan 2018 03:21

Recipients:(address . guix-patches@gnu.org)

Message-ID:20180104022157.27354-1-me@tobias.gr

* gnu/packages/syndication.scm (newsbeuter)[properties]: Mark as superseded

by newsboat.

---

Guix,

Newsbeuter has been sufficiently (unpatched-CVE-level) stagnant for long

enough that the last maintainer done went and forked it as Newsboat[0].

While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and

Efraim), and newsbeuter.org might be only temporarily off-line, what do

we think about blessing its successor? Surely it's but a one-line patch.

Kind regards,

T G-R

[0]: https://groups.google.com/forum/#!topic/newsbeuter/RPtlWX8CPGU

gnu/packages/syndication.scm | 97 ++++++++++++++++++++++----------------------

1 file changed, 49 insertions(+), 48 deletions(-)

Toggle diff (114 lines)diff --git a/gnu/packages/syndication.scm b/gnu/packages/syndication.scm
index 086b132b7..6bfbe77cf 100644
--- a/gnu/packages/syndication.scm
+++ b/gnu/packages/syndication.scm
@@ -31,54 +31,6 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages web))
 
-(define-public newsbeuter
-  (package
-    (name "newsbeuter")
-    (version "2.9")
-    (source
-      (origin
-        (method url-fetch)
-        (uri (string-append "https://newsbeuter.org/downloads/newsbeuter-"
-                            version ".tar.gz"))
-        (patches (search-patches "newsbeuter-CVE-2017-12904.patch"
-                                 "newsbeuter-CVE-2017-14500.patch"))
-        (sha256
-         (base32
-          "1j1x0hgwxz11dckk81ncalgylj5y5fgw5bcmp9qb5hq9kc0vza3l"))))
-    (build-system gnu-build-system)
-    (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (replace 'configure
-           (lambda _
-             (substitute* "config.sh"
-               ;; try to remove this at the next release
-               (("ncursesw5") "ncursesw6"))
-             #t)))
-       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
-       #:test-target "test"))
-    (native-inputs
-     `(("gettext" ,gettext-minimal)
-       ("perl" ,perl)
-       ("pkg-config" ,pkg-config)
-       ("ruby" ,ruby))) ; for tests
-    (inputs
-     `(("curl" ,curl)
-       ("json-c" ,json-c-0.12)      ; check whether json-c-0.12 can be removed
-       ("ncurses" ,ncurses)
-       ("stfl" ,stfl)
-       ("sqlite" ,sqlite)
-       ("libxml2" ,libxml2)))
-    (home-page "https://newsbeuter.org/")
-    (synopsis "Text mode rss feed reader with podcast support")
-    (description "Newsbeuter is an innovative RSS feed reader for the text
-console.  It supports OPML import/exports, HTML rendering, podcast (podbeuter),
-offline reading, searching and storing articles to your filesystem, and many
-more features.  Its user interface is coherent, easy to use, and might look
-common to users of @command{mutt} and @command{slrn}.")
-    (license (list license:gpl2+        ; filter/*
-                   license:expat))))    ; everything else
-
 (define-public newsboat
   (package
     (name "newsboat")
@@ -128,3 +80,52 @@ file system, and many more features.
 It started life as a fork of the currently unmaintained Newsbeuter.")
     (license (list license:gpl2+        ; filter/*
                    license:expat))))    ; everything else
+
+(define-public newsbeuter
+  (package
+    (name "newsbeuter")
+    (version "2.9")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://newsbeuter.org/downloads/newsbeuter-"
+                           version ".tar.gz"))
+       (patches (search-patches "newsbeuter-CVE-2017-12904.patch"
+                                "newsbeuter-CVE-2017-14500.patch"))
+       (sha256
+        (base32
+         "1j1x0hgwxz11dckk81ncalgylj5y5fgw5bcmp9qb5hq9kc0vza3l"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda _
+             (substitute* "config.sh"
+               ;; try to remove this at the next release
+               (("ncursesw5") "ncursesw6"))
+             #t)))
+       #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out")))
+       #:test-target "test"))
+    (native-inputs
+     `(("gettext" ,gettext-minimal)
+       ("perl" ,perl)
+       ("pkg-config" ,pkg-config)
+       ("ruby" ,ruby)))                 ; for tests
+    (inputs
+     `(("curl" ,curl)
+       ("json-c" ,json-c-0.12)      ; check whether json-c-0.12 can be removed
+       ("ncurses" ,ncurses)
+       ("stfl" ,stfl)
+       ("sqlite" ,sqlite)
+       ("libxml2" ,libxml2)))
+    (home-page "https://newsbeuter.org/")
+    (synopsis "Text mode rss feed reader with podcast support")
+    (description "Newsbeuter is an innovative RSS feed reader for the text
+console.  It supports OPML import/exports, HTML rendering, podcast (podbeuter),
+offline reading, searching and storing articles to your filesystem, and many
+more features.  Its user interface is coherent, easy to use, and might look
+common to users of @command{mutt} and @command{slrn}.")
+    (license (list license:gpl2+               ; filter/*
+                   license:expat))             ; everything else
+    (properties `((superseded . ,newsboat))))) ; unmaintained
-- 
2.15.0

Leo Famulari wrote on 4 Jan 2018 03:59

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 29973@debbugs.gnu.org)

Message-ID:20180104025937.GA25138@jasmine.lan

On Thu, Jan 04, 2018 at 03:21:57AM +0100, Tobias Geerinckx-Rice wrote:

Toggle quote (19 lines)> * gnu/packages/syndication.scm (newsbeuter)[properties]: Mark as superseded
> by newsboat.
> ---
> 
> Guix,
> 
> Newsbeuter has been sufficiently (unpatched-CVE-level) stagnant for long
> enough that the last maintainer done went and forked it as Newsboat[0].
> 
> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> we think about blessing its successor? Surely it's but a one-line patch.
> 
> Kind regards,
> 
> T G-R
> 
> [0]: https://groups.google.com/forum/#!topic/newsbeuter/RPtlWX8CPGU

I think it's a good idea!

Tobias Geerinckx-Rice wrote on 4 Jan 2018 15:54

Recipients:(address . leo@famulari.name)(address . 29973@debbugs.gnu.org)

Message-ID:6a8f089c-e60e-c4ad-9ec3-e4a82afde605@tobias.gr

Leo,

Leo Famulari wrote on 04/01/18 at 03:59:

Toggle quote (6 lines)

>> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and

>> Efraim), and newsbeuter.org might be only temporarily off-line, what do

>> we think about blessing its successor? Surely it's but a one-line patch.

> I think it's a good idea!

Good to hear! Any chance there's a less silly way to make the change?

Kind regards,

T G-R

Attachment: signature.asc

Leo Famulari wrote on 4 Jan 2018 18:34

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)(address . 29973@debbugs.gnu.org)

Message-ID:20180104173422.GB6465@jasmine.lan

On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:

Toggle quote (11 lines)> Leo,
> 
> Leo Famulari wrote on 04/01/18 at 03:59:
> >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> >> we think about blessing its successor? Surely it's but a one-line patch.
> >
> > I think it's a good idea!
> 
> Good to hear! Any chance there's a less silly way to make the change?

I'm not sure what's silly about it? Is there something that requires the

package definition to be moved?

ng0 wrote on 4 Jan 2018 20:22

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:20180104192253.svadno3qvhsvoq57@abyayala

Leo Famulari transcribed 1.6K bytes:

Toggle quote (15 lines)> On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:
> > Leo,
> > 
> > Leo Famulari wrote on 04/01/18 at 03:59:
> > >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> > >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> > >> we think about blessing its successor? Surely it's but a one-line patch.
> > >
> > > I think it's a good idea!
> > 
> > Good to hear! Any chance there's a less silly way to make the change?
> 
> I'm not sure what's silly about it? Is there something that requires the
> package definition to be moved?

Can't we use the package property superseded? That's how I imagined 'superseded' would work.
What you are doing is dropping it as far as I remember the first email.

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is/a/ ::  https://ea.n0.is

ng0 wrote on 4 Jan 2018 20:23

Recipients:(name . Leo Famulari)(address . leo@famulari.name)

Message-ID:20180104192338.gbdv4pefdbwzkaqf@abyayala

Leo Famulari transcribed 1.6K bytes:

Toggle quote (15 lines)> On Thu, Jan 04, 2018 at 03:54:28PM +0100, Tobias Geerinckx-Rice wrote:
> > Leo,
> > 
> > Leo Famulari wrote on 04/01/18 at 03:59:
> > >> While our Newsbeuter shouldn't be outright vulnerable (thanks to Leo and
> > >> Efraim), and newsbeuter.org might be only temporarily off-line, what do
> > >> we think about blessing its successor? Surely it's but a one-line patch.
> > >
> > > I think it's a good idea!
> > 
> > Good to hear! Any chance there's a less silly way to make the change?
> 
> I'm not sure what's silly about it? Is there something that requires the
> package definition to be moved?

Oops. Nvm my last email.

-- 
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://c.n0.is/ng0_pubkeys/tree/keys
  WWW: https://n0.is/a/ ::  https://ea.n0.is

Tobias Geerinckx-Rice wrote on 4 Jan 2018 20:42

Recipients:(address . leo@famulari.name)(address . 29973@debbugs.gnu.org)

Message-ID:11e8b12c-4ab6-002e-6956-90cd5f7f6a36@tobias.gr

Leo Famulari wrote on 04/01/18 at 18:34:

Toggle quote (2 lines)

> Is there something that requires the package definition to be moved?

newsbeuter refers directly to ,newsboat. I get an error message if

newsboat isn't defined before newsbeuter.

Toggle quote (2 lines)

> I'm not sure what's silly about it?

What I meant to say was: there might be a better way to do this than a

100-line patch, but this is the best I can come up with.

I don't really understand why

(define-public foo (package ... (inputs `(("bar" ,bar)))))

(define-public bar ...)

appears to work, while

(define-public foo (package ... (properties `((superseded . ,bar)))))

(define-public bar ...)

seems to fail.

Hence feeling a bit silly, and vague waving of hands, and whispering

‘probably macros I guess?’

I should really pick up that book about making elephants eat cake again.

Kind regards,

T G-R

Attachment: signature.asc

Ludovic Courtès wrote on 8 Jan 2018 00:13

Recipients:(name . Tobias Geerinckx-Rice)(address . me@tobias.gr)

Message-ID:87wp0tdzyz.fsf@gnu.org

Heya!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

Toggle quote (15 lines)> What I meant to say was: there might be a better way to do this than a
> 100-line patch, but this is the best I can come up with.
>
> I don't really understand why
>
>   (define-public foo (package ... (inputs `(("bar" ,bar)))))
>   (define-public bar ...)
>
> appears to work, while
>
>   (define-public foo (package ... (properties `((superseded . ,bar)))))
>   (define-public bar ...)
>
> seems to fail.

Indeed.

Unless you really want to keep the ‘newsbeuter’ definition around, you

can also simply:

(define-public newsbeuter

(deprecated-package "newsbeuter" newswhatever))

The only value in keeping the old definition is that power users can

still install it with “guix build -e”.

My 2¢,

Ludo’.

Tobias Geerinckx-Rice wrote on 8 Jan 2018 14:48

Recipients:(address . ludo@gnu.org)

Message-ID:25919a25-69bc-b6f4-d5fe-973363e53dab@tobias.gr

Ludo',

Ludovic Courtès wrote on 08/01/18 at 00:13:

Toggle quote (6 lines)

> Unless you really want to keep the ‘newsbeuter’ definition around, you

> can also simply:

> (define-public newsbeuter

> (deprecated-package "newsbeuter" newswhatever))

Oh, perfect!

That is of course exactly what I was looking for, but I only knew

(and more importantly: grepped for) “superseded”...

Toggle quote (3 lines)

> The only value in keeping the old definition is that power users can

> still install it with “guix build -e”.

I don't think that's appropriate here, so I'll use the above.

Thanks!

T G-R

Tobias Geerinckx-Rice wrote on 11 Jan 2018 03:17

[PATCH] gnu: newsbeuter: Supersede.

Recipients:(address . 29973-done@debbugs.gnu.org)

Message-ID:2c1523a0-7aaf-ff79-d6c4-fa5ab0f13991@tobias.gr

Done in f26fa354f1d76ce9cbc43cc553637af3f0c34cc2.

Thanks,

T G-R

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 29973@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 29973

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date