[PATCH] gnu: qemu: Add pulseaudio support.

  • Done
  • quality assurance status badge
Details
2 participants
  • Oleg Pykhalov
  • Marius Bakke
Owner
unassigned
Submitted by
Oleg Pykhalov
Severity
normal
O
O
Oleg Pykhalov wrote on 12 Dec 2017 18:24
(address . guix-patches@gnu.org)
87o9n3kgez.fsf@gmail.com
From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 8 Dec 2017 18:51:10 +0300
Subject: [PATCH] gnu: qemu: Add pulseaudio support.

* gnu/packages/virtualization.scm (qemu): Add pulseaudio support.
---
gnu/packages/virtualization.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

Toggle diff (35 lines)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 85563dde6..1a8e5f73b 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -51,6 +51,7 @@
#:use-module (gnu packages protobuf)
#:use-module (gnu packages python)
#:use-module (gnu packages python-web)
+ #:use-module (gnu packages pulseaudio)
#:use-module (gnu packages selinux)
#:use-module (gnu packages sdl)
#:use-module (gnu packages spice)
@@ -98,7 +99,11 @@
'(;; Running tests in parallel can occasionally lead to failures, like:
;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
#:parallel-tests? #f
- #:configure-flags '("--enable-usb-redir" "--enable-opengl")
+ #:configure-flags
+ (list "--enable-usb-redir"
+ "--enable-opengl"
+ (string-append "--audio-drv-list="
+ (string-join (list "alsa" "pa" "sdl") ",")))
#:phases
(modify-phases %standard-phases
(replace 'configure
@@ -166,6 +171,7 @@
("ncurses" ,ncurses)
;; ("pciutils" ,pciutils)
("pixman" ,pixman)
+ ("pulseaudio" ,pulseaudio)
("sdl" ,sdl)
("spice" ,spice)
("usbredir" ,usbredir)
--
2.15.1
M
M
Marius Bakke wrote on 28 Dec 2017 19:00
87608qd964.fsf@fastmail.com
Oleg Pykhalov <go.wigust@gmail.com> writes:

Toggle quote (7 lines)
> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Fri, 8 Dec 2017 18:51:10 +0300
> Subject: [PATCH] gnu: qemu: Add pulseaudio support.
>
> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support.

Please mention the change to [inputs] and [arguments] here.

[...]

Toggle quote (11 lines)
> @@ -98,7 +99,11 @@
> '(;; Running tests in parallel can occasionally lead to failures, like:
> ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> #:parallel-tests? #f
> - #:configure-flags '("--enable-usb-redir" "--enable-opengl")
> + #:configure-flags
> + (list "--enable-usb-redir"
> + "--enable-opengl"
> + (string-append "--audio-drv-list="
> + (string-join (list "alsa" "pa" "sdl") ",")))

OK!

Toggle quote (9 lines)
> #:phases
> (modify-phases %standard-phases
> (replace 'configure
> @@ -166,6 +171,7 @@
> ("ncurses" ,ncurses)
> ;; ("pciutils" ,pciutils)
> ("pixman" ,pixman)
> + ("pulseaudio" ,pulseaudio)

I see pulseaudio is already in Qemus closure, so this does not add
anything. LGTM!

Toggle quote (5 lines)
> ("sdl" ,sdl)
> ("spice" ,spice)
> ("usbredir" ,usbredir)
> --
> 2.15.1
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlpFMVMACgkQoqBt8qM6
VPqPNAgAwrEzvVA3v1nmZ9sWtYKCg+9phcpHi+9gSplzZLoiXBHerVkGGHIz/CIX
OYBqELG8wfrFE+8idGfvAt8DsNWoTlGYhlXyrHQyEUfd2S78yfp5M6AR4AeyPWzb
FSHchkAjYraEfJiaJzE21LcOOPaPAYS6BXo5ox3isqava+GQnpF86D653SbgHzD7
sfE2EmnizxF+Sm5G94qH9Dd8xOljgPNWDj8KBd93QoMwX7/Zpy6GhYCbnXwazF7T
TxiNpIiuYLhsnehfz+UXiS40q4eItpFF10zKPyUjqppsvDfIT/6YEGI31b7Bg/7I
XSHtwKd9uAlVGzk4FR5mx9lropMkJg==
=H087
-----END PGP SIGNATURE-----

O
O
Oleg Pykhalov wrote on 31 Jan 2018 15:39
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 29678@debbugs.gnu.org)
87y3kexfb4.fsf@gmail.com
Hello Marius,

apologies for a long reply. I fix a comment and have a question about
clojure. Also a new patch is attached.

Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (11 lines)
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Fri, 8 Dec 2017 18:51:10 +0300
>> Subject: [PATCH] gnu: qemu: Add pulseaudio support.
>>
>> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support.
>
> Please mention the change to [inputs] and [arguments] here.

OK.

[...]

Toggle quote (11 lines)
>> #:phases
>> (modify-phases %standard-phases
>> (replace 'configure
>> @@ -166,6 +171,7 @@
>> ("ncurses" ,ncurses)
>> ;; ("pciutils" ,pciutils)
>> ("pixman" ,pixman)
>> + ("pulseaudio" ,pulseaudio)
>
> I see pulseaudio is already in Qemus closure,

How do you see this?

Is that what do you use?
Toggle snippet (3 lines)
guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg

Toggle quote (2 lines)
> so this does not add anything. LGTM!

Hm, seems it doesn't.
Toggle snippet (11 lines)
starting phase `configure'

ERROR: pa check failed
Make sure to have the pa libs and headers installed.

phase `configure' failed after 1.8 seconds
builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1
@ build-failed /gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv - 1 builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed

[...]
From 69c18f461f6a00c7dd25b86e50be95a38d0ca445 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 8 Dec 2017 18:51:10 +0300
Subject: [PATCH] gnu: qemu: Add pulseaudio support.

* gnu/packages/virtualization.scm (qemu)[arguments]: Add pulseaudio support.
[inputs]: Add pulseaudio.
---
gnu/packages/virtualization.scm | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)

Toggle diff (40 lines)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index f4fd4c336..97263382d 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -52,6 +52,7 @@
#:use-module (gnu packages protobuf)
#:use-module (gnu packages python)
#:use-module (gnu packages python-web)
+ #:use-module (gnu packages pulseaudio)
#:use-module (gnu packages selinux)
#:use-module (gnu packages sdl)
#:use-module (gnu packages spice)
@@ -96,10 +97,13 @@
'(;; Running tests in parallel can occasionally lead to failures, like:
;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
#:parallel-tests? #f
- #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
- (string-append "--smbd="
- (assoc-ref %outputs "out")
- "/libexec/samba-wrapper"))
+ #:configure-flags
+ (list "--enable-usb-redir"
+ "--enable-opengl"
+ (string-append "--smbd=" (assoc-ref %outputs "out")
+ "/libexec/samba-wrapper")
+ (string-append "--audio-drv-list="
+ (string-join (list "alsa" "pa" "sdl") ",")))
#:phases
(modify-phases %standard-phases
(replace 'configure
@@ -181,6 +185,7 @@ exec smbd $@")))
("ncurses" ,ncurses)
;; ("pciutils" ,pciutils)
("pixman" ,pixman)
+ ("pulseaudio" ,pulseaudio)
("sdl" ,sdl)
("spice" ,spice)
("usbredir" ,usbredir)
--
2.15.1
Thanks,
Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpx1T8ACgkQckbhHGm3
lWkCfg//RKB7u76bPJDqiKy5oS9ly4l5STA20m3t4Qw+lLOOtn2ax3EeZIliPyGC
+4+NGO5jM/xi2fAYsBqBafBDh5mEXR1U314dI4CGneji4VbPB/d0ot2KLlZEdxDB
dHmgHpHrY3nojWv42jk4DtxWt7NyG67vUiIylTOKwQ2sW8G6xfOydhWYrX28gi/N
pjITGa1IjdtD/x6KkderFQBnNiDJ0woNfNrPTKvbwi3+As/fBHv3Vep6nwQhbGAg
jjK2LMj6ELL6TTC8Zw5N5MFLanOr+NlRaesln0m92beJqYnDUySMBidEgaP41W5d
ct5PucVB1XVILn5zqSRbndAvA4cUasX/+fzxJOlmJ2Wo+cGhKRxMzZKp/kLtKB/R
6nHFgWA93mFSgZDeQcfb5aZOF/oHUzZwx/kr9EXyIxPKIoltLWwBXmoLN0UHhCsV
nmar8WfSsEQdoCKIzcUiWytepFNQdzQHGVWoipPHC652cjeVp5Q9QTKUQHZHQ91l
otChYbUrt1wio7Qpo4Vllkf18eoC6eMEq3I0XhjstEVNiyAoSMUQi79nhr6L5QWP
4Ew2siyPhxGEIAGFNHo/DKJ2FqWI8jeLKMaGlvxwtZ+LRULgC1+cu0SL9k/tcUbH
qGuZv9x/paIa1EaGOn4lko1nZBCMKH/EW6KF6k1e7rU7sgBpDCA=
=CNJe
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 31 Jan 2018 16:04
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 29678@debbugs.gnu.org)
87wozyoyqx.fsf@fastmail.com
Oleg Pykhalov <go.wigust@gmail.com> writes:

Toggle quote (18 lines)
>>> #:phases
>>> (modify-phases %standard-phases
>>> (replace 'configure
>>> @@ -166,6 +171,7 @@
>>> ("ncurses" ,ncurses)
>>> ;; ("pciutils" ,pciutils)
>>> ("pixman" ,pixman)
>>> + ("pulseaudio" ,pulseaudio)
>>
>> I see pulseaudio is already in Qemus closure,
>
> How do you see this?
>
> Is that what do you use?
> --8<---------------cut here---------------start------------->8---
> guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg
> --8<---------------cut here---------------end--------------->8---

I used `guix size qemu | grep pulseaudio`.

However "qemu-minimal" does not include pulseaudio, which increases the
size by about 25%. Can you drop the input from qemu-minimal at the same
time? Unfortunately we might have to override #:configure-flags as well.

[...]

Toggle quote (16 lines)
> @@ -96,10 +97,13 @@
> '(;; Running tests in parallel can occasionally lead to failures, like:
> ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> #:parallel-tests? #f
> - #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
> - (string-append "--smbd="
> - (assoc-ref %outputs "out")
> - "/libexec/samba-wrapper"))
> + #:configure-flags
> + (list "--enable-usb-redir"
> + "--enable-opengl"
> + (string-append "--smbd=" (assoc-ref %outputs "out")
> + "/libexec/samba-wrapper")
> + (string-append "--audio-drv-list="
> + (string-join (list "alsa" "pa" "sdl") ",")))

Nit-pick: I don't really see the benefit of using string-join here. But
no strong opinion. However: use '() instead of (list ...) when the
elements do not need to be evaluated.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlpx2xYACgkQoqBt8qM6
VPqXAQf+KkXekXL0/Kx/Mjb9cgJpEVQvivqlFvPW07cJKyeckZDy0iPxQp+6twE9
o59bFNhwhXF9TZEMpZIOvueQUn26pBzPzq3dwgYEYqF0kyJuCHeYrAjtcmkbNAPA
ieD2usOVd8x0oeEbYYjHGsMYW83qgVMZK91AWKNmcJTWjTkfzePnr9Ct63BqFpnN
ZVmQirLp6FqHqh8Y4g24+fQoCrme7umqs2AmOVLHSPYOMt8MCWiZwEXs0syrHefb
QBUrz10IR+1FoRbWCG3fSyODeMctiKOtzQ5yzm9yDQp4NFZtEn3MlIj5mdH6fQ+X
di2tz745dy+Em3rzCefghyuwj4pRJA==
=k701
-----END PGP SIGNATURE-----

O
O
Oleg Pykhalov wrote on 3 Feb 2018 11:40
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 29678@debbugs.gnu.org)
87a7wq9x0l.fsf@gmail.com
Toggle quote (2 lines)
>>>>> "Marius" == Marius Bakke <mbakke@fastmail.com> writes:

> I see pulseaudio is already in Qemus closure, I used `guix size
> qemu | grep pulseaudio`. However "qemu-minimal" does not include
> pulseaudio, which increases the size by about 25%. Can you drop
> the input from qemu-minimal at the same time?

For some unknown to me reason, “qemu-minimal” closure doesn't contain
“pulseaudio” according to my investigation:
Toggle snippet (24 lines)
$ ./pre-inst-env guix size qemu-minimal
store item total self
/gnu/store/30sahk57a45xx205n7mmv3xcpch51g08-qemu-minimal-2.10.2 185.3 66.6 35.9%
/gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25 38.5 37.1 20.0%
/gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib 68.6 30.1 16.2%
/gnu/store/azbfh3i72lbaqvhgg5m7p6ymmqq0ii6q-glib-2.52.3 111.9 13.8 7.5%
/gnu/store/zbywrj6klakskj0sppq56viqh9l56jl0-util-linux-2.30.1 87.7 12.1 6.5%
/gnu/store/09j7scnl3hahcmql986fsjpzj6gqsmzv-ncurses-6.0 74.3 5.7 3.1%
/gnu/store/b7y66db86k57vbb03nr4bfn9svmks4gf-bash-4.4.12 81.0 5.4 2.9%
/gnu/store/an52j0jrvd23qypbidd5f20k2wi75vh9-pcre-8.40 72.1 3.4 1.9%
/gnu/store/2p1ljs69x19v11r0rgqh7k3v6ggfqizq-libjpeg-turbo-1.5.3 72.0 3.4 1.8%
/gnu/store/w8kii3hjvmh50yxs52gkdywkq9jc7s19-pixman-0.34.0 70.2 1.6 0.9%
/gnu/store/zhrajv6qf2hzn9c3g2bb07559hyrz5xp-bash-static-4.4.12 1.4 1.4 0.8%
/gnu/store/mipizipnr4y2hly9b429j8id1albbgqi-readline-7.0 75.6 1.3 0.7%
/gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn-bash-minimal-4.4.12 39.5 1.0 0.5%
/gnu/store/vdqy6r4g7357nsjjh4d1gfqj9hhw1vk8-libseccomp-2.3.2 69.5 0.8 0.5%
/gnu/store/b9ww6qv1ii9v6n45kin7543vkf6jfnd3-libpng-1.6.29 70.8 0.8 0.4%
/gnu/store/sfx1wh27i6gsrk21p87rdyikc64v7d51-zlib-1.2.11 69.0 0.4 0.2%
/gnu/store/jnbb8ffxxvrw2b4z18zn0g08kqk9rsgl-libffi-3.2.1 68.8 0.1 0.1%
/gnu/store/hxn2viwl04nwswpjkfg0iyyhm815yaza-libcap-2.25 68.8 0.1 0.1%
/gnu/store/fq4zk6aqrgim67aiqri37vbbk4gdkfny-libaio-0.3.110 0.0 0.0 0.0%
total: 185.3 MiB

I could assume because “(package-arguments qemu-minimal)” shows a
totally different “#:configure-flags” than “(package-arguments qemu)”.
Particularly doesn't contain “--audio-drv-list=alsa,pa,sdl”.

> Unfortunately we might have to override #:configure-flags as well.

No (see above).

>> + (string-append "--audio-drv-list="
>> + (string-join (list "alsa" "pa" "sdl") ",")))

> Nit-pick: I don't really see the benefit of using string-join
> here.

Agree.

> But no strong opinion. However: use '() instead of (list
> ...) when the elements do not need to be evaluated.

Thanks, I will use a quote.

Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlp1kZoACgkQckbhHGm3
lWntjBAAspD49AObpZVlbYZ3cPVAyhBO0q0+Tg8ObCmiZeJ5fMCNH/UC9qL7kepB
TMKS4Gtn+MO2YdZbmXs7ZVeWCed7gVAr0DqbbJx5HD47ET+uK7E4C11zexkmCQ+3
T662Ndo1v2o/v8/pCnMRzTPB0YiW2eJQ0KDyAcwGDzs8P9rTj0G8BzlGxlXZ7691
YPFOxW30WcMeno6AMa6lCcfwzpWDirAdrglWRbsWtgsTnCHoIsJDatFmS5+IU4lT
9E0mFsfvxsBt0sfN9p0LVQJdcnJ9FPETk+3ZP/L30n56meSkNRPYWD+CfpdPWuL4
fg+bZPeuPZ6XWVp6/phJN7Cb/kWSCMpQuHp/PXkOXE08eUlTwl8ZDJLHjjZtGZr8
3NUB1pzwn9UVNRl+zi1FI9TTP0w0aX79zCeXe8xCu8kkxnsK4zLP/1dqt6k2QHgv
P8vmzus0q47LuyAcnCu3/7m7eFrEqo4sD4LxH0/zwe53J4tXqCFtKeXxt+YdCdan
b7ADPZYdO4c1Zs6YNfyTGvKfF/sUvqcbttG3poQ9KFE9tzfH9uAvF61XBiOmj+nx
xCdvdp2OXsVgTeeZnkWGRtRbR1FtjIYGsWF5Hz/DbUSjLPhDGq4s7Eg0w4QFNvOB
x02EyukpYVZEaSkgx08ZgZd83mDw72XkS7Zhz1sdguoMgRa39zg=
=FGse
-----END PGP SIGNATURE-----

M
M
Marius Bakke wrote on 8 Feb 2018 12:30
(name . Oleg Pykhalov)(address . go.wigust@gmail.com)(address . 29678@debbugs.gnu.org)
87h8qriur5.fsf@fastmail.com
Oleg Pykhalov <go.wigust@gmail.com> writes:

Toggle quote (38 lines)
>>>>>> "Marius" == Marius Bakke <mbakke@fastmail.com> writes:
>
> > I see pulseaudio is already in Qemus closure, I used `guix size
> > qemu | grep pulseaudio`. However "qemu-minimal" does not include
> > pulseaudio, which increases the size by about 25%. Can you drop
> > the input from qemu-minimal at the same time?
>
> For some unknown to me reason, “qemu-minimal” closure doesn't contain
> “pulseaudio” according to my investigation:
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix size qemu-minimal
> store item total self
> /gnu/store/30sahk57a45xx205n7mmv3xcpch51g08-qemu-minimal-2.10.2 185.3 66.6 35.9%
> /gnu/store/n6nvxlk2j8ysffjh3jphn1k5silnakh6-glibc-2.25 38.5 37.1 20.0%
> /gnu/store/3x53yv4v144c9xp02rs64z7j597kkqax-gcc-5.4.0-lib 68.6 30.1 16.2%
> /gnu/store/azbfh3i72lbaqvhgg5m7p6ymmqq0ii6q-glib-2.52.3 111.9 13.8 7.5%
> /gnu/store/zbywrj6klakskj0sppq56viqh9l56jl0-util-linux-2.30.1 87.7 12.1 6.5%
> /gnu/store/09j7scnl3hahcmql986fsjpzj6gqsmzv-ncurses-6.0 74.3 5.7 3.1%
> /gnu/store/b7y66db86k57vbb03nr4bfn9svmks4gf-bash-4.4.12 81.0 5.4 2.9%
> /gnu/store/an52j0jrvd23qypbidd5f20k2wi75vh9-pcre-8.40 72.1 3.4 1.9%
> /gnu/store/2p1ljs69x19v11r0rgqh7k3v6ggfqizq-libjpeg-turbo-1.5.3 72.0 3.4 1.8%
> /gnu/store/w8kii3hjvmh50yxs52gkdywkq9jc7s19-pixman-0.34.0 70.2 1.6 0.9%
> /gnu/store/zhrajv6qf2hzn9c3g2bb07559hyrz5xp-bash-static-4.4.12 1.4 1.4 0.8%
> /gnu/store/mipizipnr4y2hly9b429j8id1albbgqi-readline-7.0 75.6 1.3 0.7%
> /gnu/store/kpxi8h3669afr9r1bgvaf9ij3y4wdyyn-bash-minimal-4.4.12 39.5 1.0 0.5%
> /gnu/store/vdqy6r4g7357nsjjh4d1gfqj9hhw1vk8-libseccomp-2.3.2 69.5 0.8 0.5%
> /gnu/store/b9ww6qv1ii9v6n45kin7543vkf6jfnd3-libpng-1.6.29 70.8 0.8 0.4%
> /gnu/store/sfx1wh27i6gsrk21p87rdyikc64v7d51-zlib-1.2.11 69.0 0.4 0.2%
> /gnu/store/jnbb8ffxxvrw2b4z18zn0g08kqk9rsgl-libffi-3.2.1 68.8 0.1 0.1%
> /gnu/store/hxn2viwl04nwswpjkfg0iyyhm815yaza-libcap-2.25 68.8 0.1 0.1%
> /gnu/store/fq4zk6aqrgim67aiqri37vbbk4gdkfny-libaio-0.3.110 0.0 0.0 0.0%
> total: 185.3 MiB
> --8<---------------cut here---------------end--------------->8---
>
> I could assume because “(package-arguments qemu-minimal)” shows a
> totally different “#:configure-flags” than “(package-arguments qemu)”.
> Particularly doesn't contain “--audio-drv-list=alsa,pa,sdl”.

Oh, ok. That's great. Let's still drop it from the inputs of
qemu-minimal so it doesn't accidentally end up getting referenced in the
future. The patch LGTM with that change.

Sorry for the late reply, and thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlp8NM4ACgkQoqBt8qM6
VPq7Dwf/d5Gal4DeChaXv+XH6b4hYi4wE6Z/jkUYn0Sn6LCQJovcjWTLvlJ1vBef
E84KIwApiOqIyQwWcdXAWYzEItGGSnUPxggQ1mOAcRbIc5GmUp6327kSV3574DgD
NnvulT8tbRWKTM1q2M8xdlJfm5sOnz40V4ij+ziC7hH2fMeVFr7yN86SxI/8o9Oc
XNT8yDES1iXXMupMXwe4FwB1jEFisDD7uRsEzdEDFKG4CHe7mlYeKyNCaHVJpRh6
ktx34AG9KzESzDT5B01waTgVr91dJuLm60VMZzEimzmfD7pbdrk6oIGAdqlYPxTq
NGzjksZ037jvBHn4SMNgIn3UL/0/4w==
=iKyS
-----END PGP SIGNATURE-----

O
O
Oleg Pykhalov wrote on 9 Feb 2018 23:04
(name . Marius Bakke)(address . mbakke@fastmail.com)
87mv0h3jlu.fsf@gmail.com
Hello Marius,

Marius Bakke <mbakke@fastmail.com> writes:

> Oh, ok. That's great. Let's still drop it from the inputs of
> qemu-minimal so it doesn't accidentally end up getting referenced in the
> future.

OK.

> The patch LGTM with that change.

Pushed as 28e3569f1f2640f814b358cd934c386ddb65def1

I'll close the bug report.

Thanks,
Oleg.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlp+Gv0ACgkQckbhHGm3
lWkMxxAAibFTe3HoHQHgYThmmsYLRuF9y5b2pYyEp5eB+roaAbyGhTfXplAwZkgy
kaAeoZ04dG8VSValG3/5IJAEaklyR0jNBcRRhhFPGxL5bxXU3cGPuGrAPTNXKXfG
/WIKP1N0fWkUwSjYpnNb0OSelunemHxbvsghnz/X9/pqX3Wh3pdOvXHfsbziDTQX
e370UqT/+PHFnjt8TDh03YQbsvBWxtP+9K4iY9x9tI0wCw9Wt8YkPp93vLArAk8K
F2zTXx2Jpwc6KVtWacycepInAw3QCyCpRP7CZc0NWSZjQTSzRH5oW4qtMpEyUr7r
Y9OsQ6dwNCLe6RiqMMponDSrrVQOGM0s+I1XcNEp5/1VDBrFPUqxZ7O4Rf5ZjZmr
ZVjaEUfA0s4GH+OvqNnij2NcRBr8+j0E2rTwUnPxvjD2OkGfJjdSpK86hi3O//Rn
SMCgIRwi/l+0i0oCcs0saH59mVYV3BGzJxnW2qyZmjwI9Un4KW6ZJpOX5vVlkENa
tviyOCVWUBxll6b2ByEoH0rr/M8uFyGqWmvMLmFx4/qAOi8sk2d0DVT80M5Ch4Re
3lpid3Cz0Hp6gMo2KB4xz0dFG6jDxXMVaIfkNQ1ZrEEe9A7e504Uw/wQKEqa9P4o
/zIaJom06sRRWELoJ1wJf9vbCEyOss/Zy0LmLIwJH0UJRPbJpVA=
=8ATB
-----END PGP SIGNATURE-----

?