[PATCH] gnu: lua5.1-socket: Update to 3.0-rc1 (for IPv6 support).

DoneSubmitted by Clément Lassieur.
Details
2 participants
  • Clément Lassieur
  • Leo Famulari
Owner
unassigned
Severity
normal
C
C
Clément Lassieur wrote on 4 Dec 2017 16:14
(address . guix-patches@gnu.org)
20171204151448.26723-1-clement@lassieur.org
* gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.[source]: Change upstream URI.[arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHAREand INSTALL_TOP_LIB.--- gnu/packages/lua.scm | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
Toggle diff (34 lines)diff --git a/gnu/packages/lua.scm b/gnu/packages/lua.scmindex d5f55b963..3a528599f 100644--- a/gnu/packages/lua.scm+++ b/gnu/packages/lua.scm@@ -173,21 +173,20 @@ language.") (define-public lua5.1-socket (package (name "lua5.1-socket")- (version "2.0.2")+ (version "3.0-rc1") (source (origin (method url-fetch)- (uri (string-append "http://files.luaforge.net/releases/"- "luasocket/luasocket/luasocket-"- version "/luasocket-" version ".tar.gz"))+ (uri (string-append+ "https://github.com/diegonehab/luasocket/archive/v"+ version ".tar.gz")) (sha256 (base32- "19ichkbc4rxv00ggz8gyf29jibvc2wq9pqjik0ll326rrxswgnag"))))+ "0j8jx8bjicvp9khs26xjya8c495wrpb7parxfnabdqa5nnsxjrwb")))) (build-system gnu-build-system) (arguments `(#:make-flags (let ((out (assoc-ref %outputs "out")))- (list (string-append "INSTALL_TOP_SHARE=" out "/share/lua/5.1")- (string-append "INSTALL_TOP_LIB=" out "/lib/lua/5.1")))+ (list (string-append "INSTALL_TOP=" out))) #:phases (modify-phases %standard-phases (delete 'configure)-- 2.15.1
L
L
Leo Famulari wrote on 4 Dec 2017 20:24
(name . Clément Lassieur)(address . clement@lassieur.org)(address . 29562@debbugs.gnu.org)
20171204192455.GA30511@jasmine.lan
On Mon, Dec 04, 2017 at 04:14:48PM +0100, Clément Lassieur wrote:
Toggle quote (5 lines)> * gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.> [source]: Change upstream URI.> [arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHARE> and INSTALL_TOP_LIB.
Typically we don't package release candidates or beta software.Sometimes we do, if there are critical bugs fixed in the RC that wecan't backport, or if the upstream development seems to have stalledwithout issuing a final release.
Can you give more detail about this case?
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAloloQcACgkQJkb6MLrKfwjHoBAAyK+D82nr81AO839r9t2xyUNBKfKWBo6NQiVXWGD6ODSDGelJW/jOR5x6qE36UOL2ZJ1Q05AXk97TOtxppnqCl2PWAuSroK4I83jojvy19HeMnJjkcKmVc/+87w5IBQc3jWeFNIclGqYVKqZHJ9UU/KKJal3E+qXleG9TvqMv/OXVxoOFz5mVk04EptxJH4Qbyks0DbLZTeS8zf7zGPls3/h8CF8YP3932vhcsoleEUpnzcFnWCYVD2K+IGJdzdzmIggH3rcB//Tf3EAqdAkqY+lHVj7gjY7dAIZONy+loqwTwuoYTg0IC6MMjuReA1XPDx0j8Mf7LIxCPvhnYlo6x/GH2DnDlErT6o/EpGAj8yEUqKCp1Y3VQQfgmYEuaqTIXx8eKbzsLzBj4+BOmHdPK4dnzdp79xLv7R9qgG1b/+2qHi84Vp+npbdsaCjFkWe15nQ4NeNHkU/gND3mANmlugHPurdSN6eocQ/BZLqlW0Z9ICVsahDYbqJYXW+sEXLByhB7pyFqRyDE/foDx11gZ6UATUxFRAK3yeOHd1KD4loATIGoczP7UD/Et3dLfJv1JGriXEJyfRonxphZEihqbbPLdvn1xq7imwpn/fzHD8m/oLJmanxlXbBwLNV6txIb2Gdp4MzW741NBvmP8wap2Eq+chH3M9gQApVMlGYQt/M==xTAg-----END PGP SIGNATURE-----

C
C
Clément Lassieur wrote on 4 Dec 2017 23:08
(name . Leo Famulari)(address . leo@famulari.name)(address . 29562@debbugs.gnu.org)
87tvx6du3z.fsf@lassieur.org
Leo Famulari <leo@famulari.name> writes:
Toggle quote (13 lines)> On Mon, Dec 04, 2017 at 04:14:48PM +0100, Clément Lassieur wrote:>> * gnu/packages/lua.scm (lua5.1-socket): Update to 3.0-rc1.>> [source]: Change upstream URI.>> [arguments]: Set INSTALL_TOP environment variable instead of INSTALL_TOP_SHARE>> and INSTALL_TOP_LIB.>> Typically we don't package release candidates or beta software.> Sometimes we do, if there are critical bugs fixed in the RC that we> can't backport, or if the upstream development seems to have stalled> without issuing a final release.>> Can you give more detail about this case?
Sure. This patch adds support for IPv6 to Prosody. Seehttps://prosody.im/doc/ipv6andhttps://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.
Even though it's a release candidate, it's four years old, it'srecommended by Prosody, and I believe IPv6 is really important.
L
L
Leo Famulari wrote on 6 Dec 2017 03:19
(name . Clément Lassieur)(address . clement@lassieur.org)(address . 29562@debbugs.gnu.org)
20171206021909.GA28118@jasmine.lan
On Mon, Dec 04, 2017 at 11:08:16PM +0100, Clément Lassieur wrote:
Toggle quote (10 lines)> Leo Famulari <leo@famulari.name> writes:> > Can you give more detail about this case?> > Sure. This patch adds support for IPv6 to Prosody. See> https://prosody.im/doc/ipv6 and> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.> > Even though it's a release candidate, it's four years old, it's> recommended by Prosody, and I believe IPv6 is really important.
Given that this RC is 4 years old, implements a critical feature (IPv6),and is recommended by one of our major packages which is also its ownuser, LGTM :)
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlonU5kACgkQJkb6MLrKfwgw7A/+N9zwPM1DaO/oY0WCj1WS+bGriNnuvxJo9Jf+WizMVGNwKc7Y2wzwxFTDfHUzBojXe0vCUXcxDpd+TXZ7QhpESH2FE0PuD/KrumsbHhtmpMivGJamWBHwyJCQ7j3SdD09fOhZ/02P0kjY27KTAKBznKPeJgeJTA+PWmZe40/tyJB/b7gkT+thVROK+gY2Ti+GkwdARMY06S9iIu0y4GZZHN2uMIMIo+4sGAt3Z+gcGlpy52B+pnDYoI0uGmnBd8oQxclT8mj4caAUP0XA9D8wLWlKTvmYXXznNGL2QpHy5NEH2cwt+CS8eEieJzwmd1sJ9YhAl54PwFG9pEXvJESqmbhCOv2DTljFH5eh/NxduDFcJTjB4Bi1Tf0NzHRzHJgpspM3LSApRX5Nmsp9awM2o+AMMWz2PiSJ+rCUJNNJJRXbjjO1kMthjRiA6bvNRiWJEYRNpfaTBYvpCEKJWhsZFSZ8MYr3Wh744RosrLX5g7bScNphy7KV36lQ6YmTm+PalOgBqfjhxrxCeljjC7Rxqsi4QdTWZNVRZ2dq+eZ3MBJOvM2/yqSLiKilUkA+rejY5IwYQ4ViaWkhd14zfsVXeUehxgUxqV8f+mnHBhkxjeEIky2PGPlXeJ4wp2H/cOLw6qfkMxPdaACq9CPdrix5Jdvm+iOtET/0LJn7EoMaXZI==C+0X-----END PGP SIGNATURE-----

C
C
Clément Lassieur wrote on 6 Dec 2017 08:26
(name . Leo Famulari)(address . leo@famulari.name)(address . 29562@debbugs.gnu.org)
87r2s8e2py.fsf@lassieur.org
Leo Famulari <leo@famulari.name> writes:
Toggle quote (15 lines)> On Mon, Dec 04, 2017 at 11:08:16PM +0100, Clément Lassieur wrote:>> Leo Famulari <leo@famulari.name> writes:>> > Can you give more detail about this case?>> >> Sure. This patch adds support for IPv6 to Prosody. See>> https://prosody.im/doc/ipv6 and>> https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00050.html.>> >> Even though it's a release candidate, it's four years old, it's>> recommended by Prosody, and I believe IPv6 is really important.>> Given that this RC is 4 years old, implements a critical feature (IPv6),> and is recommended by one of our major packages which is also its own> user, LGTM :)
Haha, thank you for the review :-)
C
C
Clément Lassieur wrote on 6 Dec 2017 08:33
control message for bug #29562
(address . control@debbugs.gnu.org)
87po7se2ei.fsf@lassieur.org
tags 29562 fixedclose 29562
?
Your comment

This issue is archived.

To comment on this conversation send email to 29562@debbugs.gnu.org