[PATCH] Add es-dump-restore and dependencies

  • Done
  • quality assurance status badge
Details
2 participants
  • Ben Woodcroft
  • Christopher Baines
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal
C
C
Christopher Baines wrote on 24 Sep 2017 19:10
(address . guix-patches@gnu.org)
20170924181052.0219647c@cbaines.net
Add a useful utility for working with ElasticSearch indices.

Christopher Baines (7):
gnu: Add ruby-httpclient.
gnu: Add ruby-multi-json.
gnu: Add ruby-options.
gnu: Add ruby-highline.
gnu: Add ruby-progress_bar.
gnu: Add ruby-rubyzip.
gnu: Add es-dump-restore.

gnu/packages/databases.scm | 43 ++++++++++
gnu/packages/ruby.scm | 195 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 238 insertions(+)
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnH5xxfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xc8LA/9Fn8k7xDXYldIWQS/GSGXE2N5tw3BjmB6ja5zUiSregZATv8MzKt1H5JU
lzkuBtHLXW4BgekY+19kLHNFxmR0AnNEx8hiezSyhLNzhI1ADlkWTxKk8QDpz5+i
OcvRt3b30QN1KLL7lT6Av09AEPawYb0DGsOWoSw/0XvWxtTMnQzTAx1EnizB4/m3
tf/asSFAnXnhinouwsrGm4d1cKNTpnBKf4OrFQGgIFAMXZqSqPQ/3RjXDmIPIACn
YOzSMBgFwAgRYfkTLpEe4BZI3eAQ46fE0ufKydaNeP707+GeClDoAwilQpvzU/Ox
eW/f2kOOgvKiXfqZ+pUHxgXqmIPRxOiWA1RvSehuIEagA5ZTdN1LpvjHm8XTz3QB
G3wDdpXDQHOinZgUZXiFB4qOwHRCq5K7jrBSmdgFBVzlRKDEbV7lqhA3w59dXUWi
IvljuPQvU0bgZ8btervzX7xGTqqTNoDkMWqNoRdWFo/6b4GoxH2CwvI1vff6uOdt
daT3hjQ/t4hjrFe7KdZ1omGgcUbLEomTXov46bGNTbxHpVbk4B6lxP3B8VtnLIhS
feeTfngSZia0FmV/cLdEXTY/Iv2BS/LkCquPfPSKIMegP503jm3NL1jNv+imJoqa
JcNKni0Jg1J7q7cgP9x5pjIKjHaskCUN2wneta8pAfeMw4KFWNk=
=ry77
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 2/7] gnu: Add ruby-multi-json.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-2-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-multi-json): New variable.
---
gnu/packages/ruby.scm | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

Toggle diff (37 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ff6be875f..116db8c62 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1865,6 +1865,30 @@ net/http library.")
(home-page "https://github.com/nicksieger/multipart-post")
(license license:expat)))
+(define-public ruby-multi-json
+ (package
+ (name "ruby-multi-json")
+ (version "1.12.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "multi_json" version))
+ (sha256
+ (base32
+ "1raim9ddjh672m32psaa9niw67ywzjbxbdb8iijx3wv9k5b0pk2x"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f)) ;; No testsuite.
+ (synopsis
+ "Common interface to multiple JSON libraries for Ruby")
+ (description
+ "This package provides a common interface to multiple JSON libraries,
+including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem,
+NSJSONSerialization, gson.rb, JrJackson, and OkJson.")
+ (home-page
+ "http://github.com/intridea/multi_json")
+ (license license:expat)))
+
(define-public ruby-arel
(package
(name "ruby-arel")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 6/7] gnu: Add ruby-rubyzip.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-6-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-rubyzip): New variable.
---
gnu/packages/ruby.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

Toggle diff (47 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 5dde022c6..6f9589489 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1002,6 +1002,40 @@ Ruby Gems.")
(home-page "https://github.com/postmodern/rubygems-tasks")
(license license:expat)))
+(define-public ruby-rubyzip
+ (package
+ (name "ruby-rubyzip")
+ (version "1.2.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "rubyzip" version))
+ (sha256
+ (base32
+ "06js4gznzgh8ac2ldvmjcmg9v1vg9llm357yckkpylaj6z456zqz"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f ;; TODO: 265 runs, 2636 assertions, 5 failures, 0 errors, 0
+ ;; skips
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'patch-test/gentestfiles.rb
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "test/gentestfiles.rb"
+ (("/usr/bin/zip")
+ (string-append
+ (assoc-ref inputs "zip") "/bin/zip"))))))))
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-simplecov" ,ruby-simplecov)
+ ("zip" ,zip)))
+ (synopsis
+ "The rubyzip module is for reading and writing zip files")
+ (description
+ "The rubyzip module provides ways to read from and create zip files.")
+ (home-page "http://github.com/rubyzip/rubyzip")
+ (license license:bsd-2)))
+
(define-public ruby-ffi
(package
(name "ruby-ffi")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 7/7] gnu: Add es-dump-restore.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-7-mail@cbaines.net
* gnu/packages/databases.scm (es-dump-restore): New variable.
---
gnu/packages/databases.scm | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)

Toggle diff (70 lines)
diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 6ce58985e..2f64e61ab 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -68,6 +68,7 @@
#:use-module (gnu packages python)
#:use-module (gnu packages rdf)
#:use-module (gnu packages readline)
+ #:use-module (gnu packages ruby)
#:use-module (gnu packages tcl)
#:use-module (gnu packages tls)
#:use-module (gnu packages xml)
@@ -77,6 +78,7 @@
#:use-module (guix build-system gnu)
#:use-module (guix build-system perl)
#:use-module (guix build-system python)
+ #:use-module (guix build-system ruby)
#:use-module (guix build-system cmake)
#:use-module (guix utils)
#:use-module (srfi srfi-26)
@@ -256,6 +258,47 @@ SQL, Key/Value, XML/XQuery or Java Object storage for their data model.")
"--enable-cxx"))))
%standard-phases)))))
+(define-public es-dump-restore
+ (package
+ (name "es-dump-restore")
+ (version "2.1.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "es_dump_restore" version))
+ (sha256
+ (base32
+ "020yk7f1hw48clmf5501z3xv9shsdchyymcv0y2cci2c1xvr1mim"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'wrap-bin-es_dump_restore
+ (lambda* (#:key outputs #:allow-other-keys)
+ (wrap-program (string-append (assoc-ref outputs "out")
+ "/bin/es_dump_restore")
+ `("GEM_PATH" ":" prefix (,(string-append
+ (getenv "GEM_PATH")
+ ":"
+ (getenv "GEM_HOME")))))
+ #t)))))
+ (propagated-inputs
+ `(("ruby-httpclient" ,ruby-httpclient)
+ ("ruby-multi-json" ,ruby-multi-json)
+ ("ruby-progress_bar" ,ruby-progress_bar)
+ ("ruby-rubyzip" ,ruby-rubyzip)
+ ("ruby-thor" ,ruby-thor)))
+ (synopsis
+ "Utility for dumping and restoring ElasticSearch indexes")
+ (description
+ "This package provides a utility for dumping the contents of an
+ElasticSearch index to a compressed file and restoring the dumpfile back to an
+ElasticSearch server")
+ (home-page
+ "https://github.com/patientslikeme/es_dump_restore")
+ (license license:expat)))
+
(define-public leveldb
(package
(name "leveldb")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 3/7] gnu: Add ruby-options.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-3-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-options): New variable.
---
gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (41 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 116db8c62..1ee03e066 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -660,6 +660,34 @@ complexity.")
(home-page "https://github.com/ThoughtWorksStudios/saikuro_treemap")
(license license:expat)))
+(define-public ruby-options
+ (package
+ (name "ruby-options")
+ (version "2.3.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "options" version))
+ (sha256
+ (base32
+ "1s650nwnabx66w584m1cyw82icyym6hv5kzfsbp38cinkr5klh9j"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f ;; TODO: NameError: uninitialized constant Config
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'set-LIB
+ (lambda _
+ ;; This is used in the Rakefile, and setting it avoids an issue
+ ;; with running the tests.
+ (setenv "LIB" "options"))))))
+ (synopsis "Ruby library to parse options from *args cleanly")
+ (description
+ "The @code{options} library helps with parsing keyword options in Ruby
+functions.")
+ (home-page "https://github.com/ahoward/options")
+ (license license:ruby)))
+
(define-public ruby-orderedhash
(package
(name "ruby-orderedhash")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 4/7] gnu: Add ruby-highline.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-4-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-highline): New variable.
---
gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

Toggle diff (40 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 1ee03e066..9863d4b37 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
(("/bin/sh") (which "sh"))))
%standard-phases)))))
+(define-public ruby-highline
+ (package
+ (name "ruby-highline")
+ (version "1.7.8")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "highline" version))
+ (sha256
+ (base32
+ "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f)) ;; TODO: Requires code_statistics
+ (native-inputs
+ `(("bundler" ,bundler)))
+ (synopsis
+ "HighLine helps you build command-line interfaces")
+ (description
+ "HighLine provides a high-level IO library that provides validation,
+type conversion, and more for command-line interfaces.
+
+HighLine also includes a menu system for providing multiple options to the
+user.")
+ (home-page "https://github.com/JEG2/highline")
+ (license (list license:gpl2 license:ruby))))
+
(define-public ruby-hoe
(package
(name "ruby-hoe")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 1/7] gnu: Add ruby-httpclient.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-1-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-httpclient): New variable.
---
gnu/packages/ruby.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)

Toggle diff (64 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 80d3bffd8..ff6be875f 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -3579,6 +3579,57 @@ It has built-in support for the legacy @code{cookies.txt} and
(home-page "https://github.com/sparklemotion/http-cookie")
(license license:expat)))
+(define-public ruby-httpclient
+ (package
+ (name "ruby-httpclient")
+ (version "2.8.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "httpclient" version))
+ (sha256
+ (base32
+ "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(;; TODO: Some tests currently fail
+ ;; ------
+ ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0 pendings,
+ ;; 2 omissions, 0 notifications
+ ;; 91.866% passed
+ ;; ------
+ ;; 6.49 tests/s, 22.41 assertions/s
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (if tests?
+ (zero?
+ (system* "ruby"
+ "-Ilib"
+ "test/runner.rb"))
+ #t)))
+ (add-after 'install 'wrap-bin-httpclient
+ (lambda* (#:key outputs #:allow-other-keys)
+ (wrap-program (string-append (assoc-ref outputs "out")
+ "/bin/httpclient")
+ `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME"))))
+ #t)))))
+ (native-inputs
+ `(("ruby-rack" ,ruby-rack)))
+ (synopsis
+ "Make HTTP requests with support for HTTPS, Cookies, authentication and more")
+ (description
+ "The @code{httpclient} ruby library provides functionality related to
+HTTP. Compared to the @code{net/http} library, @{httpclient} also provides
+Cookie, multithreading and authentication (digest, NTLM) support.
+
+Also provided is a @command{httpclient} command, which can perform HTTP
+requests either using arguments or with an interactive prompt.")
+ (home-page "https://github.com/nahi/httpclient")
+ (license license:ruby)))
+
(define-public ruby-ansi
(package
(name "ruby-ansi")
--
2.14.1
C
C
Christopher Baines wrote on 24 Sep 2017 19:17
[PATCH 5/7] gnu: Add ruby-progress_bar.
(address . 28583@debbugs.gnu.org)
20170924171717.3855-5-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-progress_bar): New variable.
---
gnu/packages/ruby.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

Toggle diff (44 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 9863d4b37..5dde022c6 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -2114,6 +2114,37 @@ for select languages.")
(home-page "http://coderay.rubychan.de")
(license license:expat)))
+(define-public ruby-progress_bar
+ (package
+ (name "ruby-progress_bar")
+ (version "1.1.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "progress_bar" version))
+ (sha256
+ (base32
+ "1qc40mr6p1z9a3vlpnsg1zfgk1qswviql2a31y63wpv3vr6b5f48"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:test-target "spec"))
+ (propagated-inputs
+ `(("ruby-highline" ,ruby-highline)
+ ("ruby-options" ,ruby-options)))
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-rspec" ,ruby-rspec)
+ ("ruby-timecop" ,ruby-timecop)))
+ (synopsis
+ "Ruby library for displaying progress bars")
+ (description
+ "ProgressBar is a simple library for displaying progress bars. The
+maximum value is configurable, and additional information can be displayed
+like the percentage completion, estimated time remaining, elapsed time and
+rate.")
+ (home-page "https://github.com/paul/progress_bar")
+ (license license:wtfpl2)))
+
(define-public ruby-pry
(package
(name "ruby-pry")
--
2.14.1
B
B
Ben Woodcroft wrote on 27 Sep 2017 13:56
Re: [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient.
f2cf0b50-9c16-0b9e-4029-03c8d3f30970@uq.edu.au
Hi,

Thanks for the patches.


On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (44 lines)
> * gnu/packages/ruby.scm (ruby-httpclient): New variable.
> ---
> gnu/packages/ruby.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 80d3bffd8..ff6be875f 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3579,6 +3579,57 @@ It has built-in support for the legacy @code{cookies.txt} and
> (home-page "https://github.com/sparklemotion/http-cookie")
> (license license:expat)))
>
> +(define-public ruby-httpclient
> + (package
> + (name "ruby-httpclient")
> + (version "2.8.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "httpclient" version))
> + (sha256
> + (base32
> + "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99"))))
> + (build-system ruby-build-system)
> + (arguments
> + '(;; TODO: Some tests currently fail
> + ;; ------
> + ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0 pendings,
> + ;; 2 omissions, 0 notifications
> + ;; 91.866% passed
> + ;; ------
> + ;; 6.49 tests/s, 22.41 assertions/s
> + #:tests? #f
> + #:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + (lambda* (#:key tests? #:allow-other-keys)
> + (if tests?
> + (zero?
> + (system* "ruby"
> + "-Ilib"
> + "test/runner.rb"))
> + #t)))
Since tests? is #f, this is effectively dead code. But it could be
useful to someone continuing the tests, I'm not fussed.
Toggle quote (6 lines)
> + (add-after 'install 'wrap-bin-httpclient
> + (lambda* (#:key outputs #:allow-other-keys)
> + (wrap-program (string-append (assoc-ref outputs "out")
> + "/bin/httpclient")
> + `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME"))))
> + #t)))))
It would be preferable to move this to be part of the ruby-build-system
as is done in e.g. python-build-system, but OK.

Otherwise LGTM.
ben
B
B
Ben Woodcroft wrote on 27 Sep 2017 14:03
Re: [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json.
763dd635-3585-ed21-1823-2c0c3f285dbd@uq.edu.au
On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (1 lines)
> * gnu/packages/ruby.scm (ruby-multi-json): New variable.
[..]
Toggle quote (2 lines)
> + (arguments
> + '(#:tests? #f)) ;; No testsuite.
No testsuite included in distributed gem, rather.
Toggle quote (8 lines)
> + (synopsis
> + "Common interface to multiple JSON libraries for Ruby")
> + (description
> + "This package provides a common interface to multiple JSON libraries,
> +including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem,
> +NSJSONSerialization, gson.rb, JrJackson, and OkJson.")
> + (home-page
> + "http://github.com/intridea/multi_json")
Both home-page and synopsis could be moved to the line before.

Otherwise LGTM.
ben
B
B
Ben Woodcroft wrote on 27 Sep 2017 14:10
Re: [bug#28583] [PATCH 3/7] gnu: Add ruby-options.
d521360a-cccc-3850-6a27-999301dc5d36@uq.edu.au
On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (1 lines)
> * gnu/packages/ruby.scm (ruby-options): New variable.
LGTM.
B
B
Ben Woodcroft wrote on 27 Sep 2017 14:37
Re: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline.
6aeccdcc-1509-6440-7ee8-1ca4fc7615e8@uq.edu.au
On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (27 lines)
> * gnu/packages/ruby.scm (ruby-highline): New variable.
> ---
> gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 1ee03e066..9863d4b37 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
> (("/bin/sh") (which "sh"))))
> %standard-phases)))))
>
> +(define-public ruby-highline
> + (package
> + (name "ruby-highline")
> + (version "1.7.8")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "highline" version))
> + (sha256
> + (base32
> + "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
> + (build-system ruby-build-system)
> + (arguments
> + `(#:tests? #f)) ;; TODO: Requires code_statistics
I've attached a package for code_statistics, but adding it does not help
because there appears to be something amiss in the Rakefile. This has
been fixed in the not quite released 2.0.0 version, so the patch may be
useful in future.

Toggle quote (10 lines)
> + (native-inputs
> + `(("bundler" ,bundler)))
> + (synopsis
> + "HighLine helps you build command-line interfaces")
> + (description
> + "HighLine provides a high-level IO library that provides validation,
> +type conversion, and more for command-line interfaces.
> +
> +HighLine also includes a menu system for providing multiple options to the
> +user.")
I would combine the two sentences into one paragraph.

Otherwise LGTM.
From e2fb88306d527db0bbc53e980a071474d3b67100 Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <donttrustben@gmail.com>
Date: Wed, 27 Sep 2017 22:18:33 +1000
Subject: [PATCH] gnu: Add ruby-code-statistics.

* gnu/packages/ruby.scm (ruby-code-statistics): New variable.
---
gnu/packages/ruby.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 1ee03e066..c41c80569 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -4378,3 +4378,24 @@ really opens up the email messages you are parsing, if you know what you
are doing, you can fiddle with every last bit of your email directly.")
(home-page "https://github.com/mikel/mail")
(license license:expat)))
+
+(define-public ruby-code-statistics
+ (package
+ (name "ruby-code-statistics")
+ (version "0.2.13")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "code_statistics" version))
+ (sha256
+ (base32
+ "07rdpsbwbmh4vp8nxyh308cj7am2pbrfhv9v5xr2d5gq8hnnsm93"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f)) ; Not all test code is included in gem.
+ (synopsis "Port of the rails 'rake stats' method")
+ (description
+ "This gem is a port of the rails 'rake stats' method so it can be made
+more robust and work for non rails projects.")
+ (home-page "http://github.com/danmayer/code_statistics")
+ (license license:expat)))
--
2.14.1
B
B
Ben Woodcroft wrote on 27 Sep 2017 14:43
Re: [bug#28583] [PATCH 5/7] gnu: Add ruby-progress_bar.
8a1c5787-b9d2-c03a-aad6-51190de2a975@uq.edu.au
On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (16 lines)
> * gnu/packages/ruby.scm (ruby-progress_bar): New variable.
> ---
> gnu/packages/ruby.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 9863d4b37..5dde022c6 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -2114,6 +2114,37 @@ for select languages.")
> (home-page "http://coderay.rubychan.de")
> (license license:expat)))
>
> +(define-public ruby-progress_bar
> + (package
> + (name "ruby-progress_bar")
OK. Unfortunate that there is also a progress-bar gem.
LGTM.
B
B
Ben Woodcroft wrote on 28 Sep 2017 10:34
Re: [bug#28583] [PATCH 6/7] gnu: Add ruby-rubyzip.
188092b5-e618-47e9-bece-f6deb142a4bd@uq.edu.au
Hi,


On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (1 lines)
> * gnu/packages/ruby.scm (ruby-rubyzip): New variable.
I made a few changes, and got the tests to pass - patch attached. WDYT?
ben
From 8d7bcd94b011a326c3c42802589c7e326c5d09c1 Mon Sep 17 00:00:00 2001
From: Christopher Baines <mail@cbaines.net>
Date: Thu, 28 Sep 2017 18:31:03 +1000
Subject: [PATCH] gnu: Add ruby-rubyzip.

* gnu/packages/ruby.scm (ruby-rubyzip): New variable.

Co-authored by Ben Woodcroft <donttrustben@gmail.com>.
---
gnu/packages/ruby.scm | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)

Toggle diff (48 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 5dde022c6..4f2ba6ea7 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1002,6 +1002,41 @@ Ruby Gems.")
(home-page "https://github.com/postmodern/rubygems-tasks")
(license license:expat)))
+(define-public ruby-rubyzip
+ (package
+ (name "ruby-rubyzip")
+ (version "1.2.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "rubyzip" version))
+ (sha256
+ (base32
+ "06js4gznzgh8ac2ldvmjcmg9v1vg9llm357yckkpylaj6z456zqz"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'patch-tests
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "test/gentestfiles.rb"
+ (("/usr/bin/zip")
+ (string-append
+ (assoc-ref inputs "zip") "/bin/zip")))
+ (substitute* "test/input_stream_test.rb"
+ (("/usr/bin/env ruby") (which "ruby")))
+ #t)))))
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-simplecov" ,ruby-simplecov)
+ ("zip" ,zip)
+ ("unzip" ,unzip)))
+ (synopsis "Ruby module is for reading and writing zip files")
+ (description
+ "The rubyzip module provides ways to read from and create zip files.")
+ (home-page "http://github.com/rubyzip/rubyzip")
+ (license license:bsd-2)))
+
(define-public ruby-ffi
(package
(name "ruby-ffi")
--
2.14.1
B
B
Ben Woodcroft wrote on 28 Sep 2017 10:38
Re: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore.
5ee025a9-da9b-b178-8649-f72f532467b5@uq.edu.au
On 25/09/17 03:17, Christopher Baines wrote:
Toggle quote (1 lines)
> * gnu/packages/databases.scm (es-dump-restore): New variable.
[..]
Toggle quote (2 lines)
> + (arguments
> + '(#:tests? #f
Including a reason here would be good.

Toggle quote (11 lines)
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'wrap-bin-es_dump_restore
> + (lambda* (#:key outputs #:allow-other-keys)
> + (wrap-program (string-append (assoc-ref outputs "out")
> + "/bin/es_dump_restore")
> + `("GEM_PATH" ":" prefix (,(string-append
> + (getenv "GEM_PATH")
> + ":"
> + (getenv "GEM_HOME")))))
> + #t)))))
Again, it would be preferable to have this done as part of the build
system, but OK.

Toggle quote (8 lines)
> + (propagated-inputs
> + `(("ruby-httpclient" ,ruby-httpclient)
> + ("ruby-multi-json" ,ruby-multi-json)
> + ("ruby-progress_bar" ,ruby-progress_bar)
> + ("ruby-rubyzip" ,ruby-rubyzip)
> + ("ruby-thor" ,ruby-thor)))
> + (synopsis
> + "Utility for dumping and restoring ElasticSearch indexes")
This can be moved onto the previous line.

Toggle quote (6 lines)
> + (description
> + "This package provides a utility for dumping the contents of an
> +ElasticSearch index to a compressed file and restoring the dumpfile back to an
> +ElasticSearch server")
> + (home-page
> + "https://github.com/patientslikeme/es_dump_restore")
As can this. Otherwise LGTM - thanks for this series.
ben
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 2/8] gnu: Add ruby-multi-json.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-2-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-multi-json): New variable.
---
gnu/packages/ruby.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

Toggle diff (35 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ff6be875f..504eb60a9 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1865,6 +1865,28 @@ net/http library.")
(home-page "https://github.com/nicksieger/multipart-post")
(license license:expat)))
+(define-public ruby-multi-json
+ (package
+ (name "ruby-multi-json")
+ (version "1.12.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "multi_json" version))
+ (sha256
+ (base32
+ "1raim9ddjh672m32psaa9niw67ywzjbxbdb8iijx3wv9k5b0pk2x"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f)) ;; No testsuite included in the gem.
+ (synopsis "Common interface to multiple JSON libraries for Ruby")
+ (description
+ "This package provides a common interface to multiple JSON libraries,
+including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem,
+NSJSONSerialization, gson.rb, JrJackson, and OkJson.")
+ (home-page "http://github.com/intridea/multi_json")
+ (license license:expat)))
+
(define-public ruby-arel
(package
(name "ruby-arel")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 1/8] gnu: Add ruby-httpclient.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-1-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-httpclient): New variable.
---
gnu/packages/ruby.scm | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)

Toggle diff (64 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 80d3bffd8..ff6be875f 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -3579,6 +3579,57 @@ It has built-in support for the legacy @code{cookies.txt} and
(home-page "https://github.com/sparklemotion/http-cookie")
(license license:expat)))
+(define-public ruby-httpclient
+ (package
+ (name "ruby-httpclient")
+ (version "2.8.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "httpclient" version))
+ (sha256
+ (base32
+ "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(;; TODO: Some tests currently fail
+ ;; ------
+ ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0 pendings,
+ ;; 2 omissions, 0 notifications
+ ;; 91.866% passed
+ ;; ------
+ ;; 6.49 tests/s, 22.41 assertions/s
+ #:tests? #f
+ #:phases
+ (modify-phases %standard-phases
+ (replace 'check
+ (lambda* (#:key tests? #:allow-other-keys)
+ (if tests?
+ (zero?
+ (system* "ruby"
+ "-Ilib"
+ "test/runner.rb"))
+ #t)))
+ (add-after 'install 'wrap-bin-httpclient
+ (lambda* (#:key outputs #:allow-other-keys)
+ (wrap-program (string-append (assoc-ref outputs "out")
+ "/bin/httpclient")
+ `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME"))))
+ #t)))))
+ (native-inputs
+ `(("ruby-rack" ,ruby-rack)))
+ (synopsis
+ "Make HTTP requests with support for HTTPS, Cookies, authentication and more")
+ (description
+ "The @code{httpclient} ruby library provides functionality related to
+HTTP. Compared to the @code{net/http} library, @{httpclient} also provides
+Cookie, multithreading and authentication (digest, NTLM) support.
+
+Also provided is a @command{httpclient} command, which can perform HTTP
+requests either using arguments or with an interactive prompt.")
+ (home-page "https://github.com/nahi/httpclient")
+ (license license:ruby)))
+
(define-public ruby-ansi
(package
(name "ruby-ansi")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 3/8] gnu: Add ruby-options.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-3-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-options): New variable.
---
gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

Toggle diff (41 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 504eb60a9..ec4d33f40 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -660,6 +660,34 @@ complexity.")
(home-page "https://github.com/ThoughtWorksStudios/saikuro_treemap")
(license license:expat)))
+(define-public ruby-options
+ (package
+ (name "ruby-options")
+ (version "2.3.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "options" version))
+ (sha256
+ (base32
+ "1s650nwnabx66w584m1cyw82icyym6hv5kzfsbp38cinkr5klh9j"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f ;; TODO: NameError: uninitialized constant Config
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'set-LIB
+ (lambda _
+ ;; This is used in the Rakefile, and setting it avoids an issue
+ ;; with running the tests.
+ (setenv "LIB" "options"))))))
+ (synopsis "Ruby library to parse options from *args cleanly")
+ (description
+ "The @code{options} library helps with parsing keyword options in Ruby
+functions.")
+ (home-page "https://github.com/ahoward/options")
+ (license license:ruby)))
+
(define-public ruby-orderedhash
(package
(name "ruby-orderedhash")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 5/8] gnu: Add ruby-highline.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-5-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-highline): New variable.
---
gnu/packages/ruby.scm | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

Toggle diff (39 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 283f393b8..d6aa59099 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -216,6 +216,32 @@ a focus on simplicity and productivity.")
(("/bin/sh") (which "sh"))))
%standard-phases)))))
+(define-public ruby-highline
+ (package
+ (name "ruby-highline")
+ (version "1.7.8")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "highline" version))
+ (sha256
+ (base32
+ "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f)) ;; TODO: NameError: uninitialized constant SPEC
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-code-statistics" ,ruby-code-statistics)))
+ (synopsis
+ "HighLine helps you build command-line interfaces")
+ (description
+ "HighLine provides a high-level IO library that provides validation,
+type conversion, and more for command-line interfaces. HighLine also includes
+a menu system for providing multiple options to the user.")
+ (home-page "https://github.com/JEG2/highline")
+ (license (list license:gpl2 license:ruby))))
+
(define-public ruby-hoe
(package
(name "ruby-hoe")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 6/8] gnu: Add ruby-progress_bar.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-6-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-progress_bar): New variable.
---
gnu/packages/ruby.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)

Toggle diff (44 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index d6aa59099..3b0a67b9d 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -2111,6 +2111,37 @@ for select languages.")
(home-page "http://coderay.rubychan.de")
(license license:expat)))
+(define-public ruby-progress_bar
+ (package
+ (name "ruby-progress_bar")
+ (version "1.1.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "progress_bar" version))
+ (sha256
+ (base32
+ "1qc40mr6p1z9a3vlpnsg1zfgk1qswviql2a31y63wpv3vr6b5f48"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:test-target "spec"))
+ (propagated-inputs
+ `(("ruby-highline" ,ruby-highline)
+ ("ruby-options" ,ruby-options)))
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-rspec" ,ruby-rspec)
+ ("ruby-timecop" ,ruby-timecop)))
+ (synopsis
+ "Ruby library for displaying progress bars")
+ (description
+ "ProgressBar is a simple library for displaying progress bars. The
+maximum value is configurable, and additional information can be displayed
+like the percentage completion, estimated time remaining, elapsed time and
+rate.")
+ (home-page "https://github.com/paul/progress_bar")
+ (license license:wtfpl2)))
+
(define-public ruby-pry
(package
(name "ruby-pry")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 8/8] gnu: Add ruby-es-dump-restore.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-8-mail@cbaines.net
* gnu/packages/databases.scm (es-dump-restore): New variable.
---
gnu/packages/databases.scm | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)

Toggle diff (68 lines)
diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 6ce58985e..bd1c9e55e 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -68,6 +68,7 @@
#:use-module (gnu packages python)
#:use-module (gnu packages rdf)
#:use-module (gnu packages readline)
+ #:use-module (gnu packages ruby)
#:use-module (gnu packages tcl)
#:use-module (gnu packages tls)
#:use-module (gnu packages xml)
@@ -77,6 +78,7 @@
#:use-module (guix build-system gnu)
#:use-module (guix build-system perl)
#:use-module (guix build-system python)
+ #:use-module (guix build-system ruby)
#:use-module (guix build-system cmake)
#:use-module (guix utils)
#:use-module (srfi srfi-26)
@@ -256,6 +258,45 @@ SQL, Key/Value, XML/XQuery or Java Object storage for their data model.")
"--enable-cxx"))))
%standard-phases)))))
+(define-public es-dump-restore
+ (package
+ (name "es-dump-restore")
+ (version "2.1.0")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "es_dump_restore" version))
+ (sha256
+ (base32
+ "020yk7f1hw48clmf5501z3xv9shsdchyymcv0y2cci2c1xvr1mim"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:tests? #f ;; No testsuite.
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'install 'wrap-bin-es_dump_restore
+ (lambda* (#:key outputs #:allow-other-keys)
+ (wrap-program (string-append (assoc-ref outputs "out")
+ "/bin/es_dump_restore")
+ `("GEM_PATH" ":" prefix (,(string-append
+ (getenv "GEM_PATH")
+ ":"
+ (getenv "GEM_HOME")))))
+ #t)))))
+ (propagated-inputs
+ `(("ruby-httpclient" ,ruby-httpclient)
+ ("ruby-multi-json" ,ruby-multi-json)
+ ("ruby-progress_bar" ,ruby-progress_bar)
+ ("ruby-rubyzip" ,ruby-rubyzip)
+ ("ruby-thor" ,ruby-thor)))
+ (synopsis "Utility for dumping and restoring ElasticSearch indexes")
+ (description
+ "This package provides a utility for dumping the contents of an
+ElasticSearch index to a compressed file and restoring the dumpfile back to an
+ElasticSearch server")
+ (home-page "https://github.com/patientslikeme/es_dump_restore")
+ (license license:expat)))
+
(define-public leveldb
(package
(name "leveldb")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 4/8] gnu: Add ruby-code-statistics.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-4-mail@cbaines.net
From: Ben Woodcroft <donttrustben@gmail.com>

* gnu/packages/ruby.scm (ruby-code-statistics): New variable.
---
gnu/packages/ruby.scm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

Toggle diff (31 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index ec4d33f40..283f393b8 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -4376,3 +4376,24 @@ really opens up the email messages you are parsing, if you know what you
are doing, you can fiddle with every last bit of your email directly.")
(home-page "https://github.com/mikel/mail")
(license license:expat)))
+
+(define-public ruby-code-statistics
+ (package
+ (name "ruby-code-statistics")
+ (version "0.2.13")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "code_statistics" version))
+ (sha256
+ (base32
+ "07rdpsbwbmh4vp8nxyh308cj7am2pbrfhv9v5xr2d5gq8hnnsm93"))))
+ (build-system ruby-build-system)
+ (arguments
+ `(#:tests? #f)) ; Not all test code is included in gem.
+ (synopsis "Port of the rails 'rake stats' method")
+ (description
+ "This gem is a port of the rails 'rake stats' method so it can be made
+more robust and work for non rails projects.")
+ (home-page "http://github.com/danmayer/code_statistics")
+ (license license:expat)))
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:19
[PATCH 7/8] gnu: Add ruby-rubyzip.
(address . 28583@debbugs.gnu.org)
20170930081935.19671-7-mail@cbaines.net
* gnu/packages/ruby.scm (ruby-rubyzip): New variable.

Co-authored by Ben Woodcroft <donttrustben@gmail.com>.
---
gnu/packages/ruby.scm | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)

Toggle diff (48 lines)
diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 3b0a67b9d..019307629 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1001,6 +1001,41 @@ Ruby Gems.")
(home-page "https://github.com/postmodern/rubygems-tasks")
(license license:expat)))
+(define-public ruby-rubyzip
+ (package
+ (name "ruby-rubyzip")
+ (version "1.2.1")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (rubygems-uri "rubyzip" version))
+ (sha256
+ (base32
+ "06js4gznzgh8ac2ldvmjcmg9v1vg9llm357yckkpylaj6z456zqz"))))
+ (build-system ruby-build-system)
+ (arguments
+ '(#:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'patch-tests
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* "test/gentestfiles.rb"
+ (("/usr/bin/zip")
+ (string-append
+ (assoc-ref inputs "zip") "/bin/zip")))
+ (substitute* "test/input_stream_test.rb"
+ (("/usr/bin/env ruby") (which "ruby")))
+ #t)))))
+ (native-inputs
+ `(("bundler" ,bundler)
+ ("ruby-simplecov" ,ruby-simplecov)
+ ("zip" ,zip)
+ ("unzip" ,unzip)))
+ (synopsis "Ruby module is for reading and writing zip files")
+ (description
+ "The rubyzip module provides ways to read from and create zip files.")
+ (home-page "http://github.com/rubyzip/rubyzip")
+ (license license:bsd-2)))
+
(define-public ruby-ffi
(package
(name "ruby-ffi")
--
2.14.1
C
C
Christopher Baines wrote on 30 Sep 2017 10:21
Re: [bug#28583] [PATCH 1/7] gnu: Add ruby-httpclient.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092110.07a1e6dd@cbaines.net
On Wed, 27 Sep 2017 21:56:04 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (55 lines)
> Hi,
>
> Thanks for the patches.
>
>
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-httpclient): New variable.
> > ---
> > gnu/packages/ruby.scm | 51
> > +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
> > 51 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index 80d3bffd8..ff6be875f 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -3579,6 +3579,57 @@ It has built-in support for the legacy
> > @code{cookies.txt} and (home-page
> > "https://github.com/sparklemotion/http-cookie") (license
> > license:expat)))
> > +(define-public ruby-httpclient
> > + (package
> > + (name "ruby-httpclient")
> > + (version "2.8.3")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (rubygems-uri "httpclient" version))
> > + (sha256
> > + (base32
> > + "19mxmvghp7ki3klsxwrlwr431li7hm1lczhhj8z4qihl2acy8l99"))))
> > + (build-system ruby-build-system)
> > + (arguments
> > + '(;; TODO: Some tests currently fail
> > + ;; ------
> > + ;; 211 tests, 729 assertions, 13 failures, 4 errors, 0
> > pendings,
> > + ;; 2 omissions, 0 notifications
> > + ;; 91.866% passed
> > + ;; ------
> > + ;; 6.49 tests/s, 22.41 assertions/s
> > + #:tests? #f
> > + #:phases
> > + (modify-phases %standard-phases
> > + (replace 'check
> > + (lambda* (#:key tests? #:allow-other-keys)
> > + (if tests?
> > + (zero?
> > + (system* "ruby"
> > + "-Ilib"
> > + "test/runner.rb"))
> > + #t)))
> Since tests? is #f, this is effectively dead code. But it could be
> useful to someone continuing the tests, I'm not fussed.

I'm keen to keep it, as the #:tests? #f has a TODO comment, maybe the
tests can be made to pass in the future.

Toggle quote (9 lines)
> > + (add-after 'install 'wrap-bin-httpclient
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (wrap-program (string-append (assoc-ref outputs "out")
> > + "/bin/httpclient")
> > + `("GEM_HOME" ":" prefix (,(getenv "GEM_HOME"))))
> > + #t)))))
> It would be preferable to move this to be part of the
> ruby-build-system as is done in e.g. python-build-system, but OK.

Agreed, I'll try and make some time to look at this.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPU/ZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XekIA//ctS95Enk7cHMMNh7RpBtHAgrFQhK2gz7XFrQxxxUh1iz6a8y1e8Ovw7H
4yOdQXe+yu0K4G1AojPOIpEAm0uE4vhVawB1dBRpHq8q9HO+pvqfYaHq9s9AhpQm
drpIFEmhPDGRV2s3EYcBuPIW6tEcsmsVUC3Y7ZBu5fU/6h6z7iMoTEEKGGSBIglR
xEaovLtkfLSxrUQqpp+/3wSh1N8GgXEtZ9aun4Zolt5WGJglyJnRPTLIbLT9i0I3
KSgbR82tckzYPxP/esaxAITNo77U9Opsjnfc+U+HrcElGBLRDEKrj0pVfczLtABG
rSRqfSkLmKUVMxkP+iCZmesv1LW5wk0xk+LoyFpDVs8fXl3M8qgkuzv6HIMH2nxG
joskRYAyJWKm7nY9LVBWqCQ0ShTlMCT6yTNOdOv4ydHCa56kz4YIze2o8ol9tWtV
pW2wdxJ6H+IqnHOTJCaBDLq/rU4BCgNLsVNiM3uNTZ0otth15aza1HcgC/aGp4ba
rlV9+NqXg3eeKJnE95l3bF4+d+foYGFdoY0EYebH21sTPDCnUUmo7TNS57/Gqhxd
Tb4PK2JaUNBjgk6epz0eAEaq2DwaNQknE9mCYY+ORVXQEJpjpflgr75nQIitI5WY
X7Qk/d1NDtYo25bJ22+sNYiPE/HOoJ2JE9hKtDFlWIv6ZRdtPzY=
=XDCM
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 30 Sep 2017 10:21
Re: [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092144.008d49b7@cbaines.net
On Wed, 27 Sep 2017 22:03:32 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (7 lines)
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-multi-json): New variable.
> [..]
> > + (arguments
> > + '(#:tests? #f)) ;; No testsuite.
> No testsuite included in distributed gem, rather.

I've updated the comment.

Toggle quote (11 lines)
> > + (synopsis
> > + "Common interface to multiple JSON libraries for Ruby")
> > + (description
> > + "This package provides a common interface to multiple JSON
> > libraries, +including Oj, Yajl, the JSON gem (with C-extensions),
> > the pure-Ruby JSON gem, +NSJSONSerialization, gson.rb, JrJackson,
> > and OkJson.")
> > + (home-page
> > + "http://github.com/intridea/multi_json")
> Both home-page and synopsis could be moved to the line before.

And also updated the formatting.

Toggle quote (2 lines)
> Otherwise LGTM.
> ben
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVBhfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xcbtg/+JnRv/cPcnzFueDVN7oU4MGy7ATverEBLSmy3bp4u6MxDSJt0Ifw9HuLt
huPO3wMu9BFQaq0fGbm80eSXiZIhBp21T05yca7NwhUIDsI9cn8b1I4psnZ++Wgn
z6lOXCNVylXagu9d0VWM30mPeNiEe+NcYtGy5vvB15jb+fpRtCopZjkDkm5UC6AW
V6d4C6y4VFQN5dqp849Xjaa2IQGzUlThIgIov/hx2afbggophTwi/yKNCfYFaicu
/yaEP/cJSeVUSeeWGuPWkCUtCH9fij4/wkSLHh2l62kgzV4Q4n0cXwZdfnbIyG33
/+bbMAq8HSyE7EeVzycKMWh256CEMU3jjdGxeObbKwtVMh7TTQCo3XJFry97SV62
8vr196VgMemx8l6SzEH5ERA1oCbhGHJxWA7LsxlgUEn4JNAu2TMEqn0ipxCKxpKu
WiFMSxu1HNCTswk4ZwLBBYZMpzwmIof8gZYbsmmsiJwROuRn4qzfIyHDypm4V/7f
+RZjJH+ernKAL8SmgfYuaG4lIq7KbCh+GHoCNiHO30uQf9am7urXmW0Rt2wi1sV3
9Wodf0gfco86W3cJgoqWs8CgAKTyUYr0XvXjeLWvAt/cmqE9iDkEaCp0cTvApQGP
0tX0oIcT2fpG49P8e0SFPeW6lJkv2izRcLpvHB8mW5OlghGoBik=
=tbku
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 30 Sep 2017 10:23
Re: [bug#28583] [PATCH 4/7] gnu: Add ruby-highline.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092307.0b8e7858@cbaines.net
On Wed, 27 Sep 2017 22:37:39 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (33 lines)
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-highline): New variable.
> > ---
> > gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index 1ee03e066..9863d4b37 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -216,6 +216,33 @@ a focus on simplicity and productivity.")
> > (("/bin/sh") (which "sh"))))
> > %standard-phases)))))
> >
> > +(define-public ruby-highline
> > + (package
> > + (name "ruby-highline")
> > + (version "1.7.8")
> > + (source
> > + (origin
> > + (method url-fetch)
> > + (uri (rubygems-uri "highline" version))
> > + (sha256
> > + (base32
> > + "1nf5lgdn6ni2lpfdn4gk3gi47fmnca2bdirabbjbz1fk9w4p8lkr"))))
> > + (build-system ruby-build-system)
> > + (arguments
> > + `(#:tests? #f)) ;; TODO: Requires code_statistics
> I've attached a package for code_statistics, but adding it does not
> help because there appears to be something amiss in the Rakefile.
> This has been fixed in the not quite released 2.0.0 version, so the
> patch may be useful in future.

Awesome, thanks Ben. I've send an updated set of patches, including this
one now. It looks good to me.

Toggle quote (12 lines)
> > + (native-inputs
> > + `(("bundler" ,bundler)))
> > + (synopsis
> > + "HighLine helps you build command-line interfaces")
> > + (description
> > + "HighLine provides a high-level IO library that provides
> > validation, +type conversion, and more for command-line interfaces.
> > +
> > +HighLine also includes a menu system for providing multiple
> > options to the +user.")
> I would combine the two sentences into one paragraph.

I've made this change in the updated patches.

Toggle quote (2 lines)
> Otherwise LGTM.
>
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVGtfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xc0CQ/9EgzsYF3uNQzK29aN4der6WlvUhnuWxmBDeltymc/CinqgC+fYxsp5MIi
ALpIm9zkJkBSxtmVeNwhgPIf5hHLMCvVud3Az/YdoS2NsWV95z59mBNzsFrTy76i
zvRPwWgglDcJB8u0JbKZ0VDSnbj5hyQCBX9OapZdI9kXEXCNMr8F9DwBUkZoCmxW
97fQECjQjBcH8/pMaqxXMuJ7hMctGH1eGIGswBFxVvX1IV0ZpJ5SJGbwOq9YXDIZ
W8wZWMcoPf/DgHAb64Q83Kr0DS8IriVHSIQw7yK34odkG+rgStJWix34gFvnTZl9
EQ3IaREOjnyOkocjYTO2XodqfffrITHMtuk6T1wqjTdbINs2Gr8HjYCc1usfjDtC
KciE7/4IyaVmzW0MeoKsx/a3hGVrmisZSKw9LAM6Vaovy5nXcvD3p7Zy6N6qF3GQ
RyUYt1I+ZNp+p04Nyv4tFT/IH6n1ipLddxeS8W4yH9qn27uF4UB+fGaHbKUvaMOa
Pb1IZ4jigg/OzuuEt30MaXxsWSU9j2f3AZA9AA1A0PsjPoNYtIEg26N6myPT++WS
a+1TqG82qUrR6+CZ+B0OpfMbzHYjc9Thm35FNNTwzDV7kMiHmHNZMSLCHsT0Soyc
3HwYDey05TAiKfNzHb/SGs9endFwEodaTEN3kk/wmlQZL5MgUHI=
=36xi
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 30 Sep 2017 10:23
Re: [bug#28583] [PATCH 5/7] gnu: Add ruby-progress_bar.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092337.617f192c@cbaines.net
On Wed, 27 Sep 2017 22:43:31 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (19 lines)
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-progress_bar): New variable.
> > ---
> > gnu/packages/ruby.scm | 31 +++++++++++++++++++++++++++++++
> > 1 file changed, 31 insertions(+)
> >
> > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> > index 9863d4b37..5dde022c6 100644
> > --- a/gnu/packages/ruby.scm
> > +++ b/gnu/packages/ruby.scm
> > @@ -2114,6 +2114,37 @@ for select languages.")
> > (home-page "http://coderay.rubychan.de")
> > (license license:expat)))
> >
> > +(define-public ruby-progress_bar
> > + (package
> > + (name "ruby-progress_bar")
> OK. Unfortunate that there is also a progress-bar gem.

Indeed, I packaged the wrong one at first, and was wondering why things
were not working...

Toggle quote (1 lines)
> LGTM.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVIlfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XdNEQ/+PmcHFLrq7ZiseS2GPwBebDfdch5Qqcj92L3xnqtO62KUUYxRKPuBw/hT
kDzfHLFgMevP6Z2imo7qCVRD0WbQ6pRDn+ks9hpfFZ5Qv6PlaTKbwct7fOz8HTzt
h/KUMoePJ2EVuPt0T8oxb0Nog7v8LzZ9MlPB/wqpW80mC9o0SdUu3rFpnxMXauag
a/gH+CnyuOZOoZrxh8/tumh3T2pOSh2/ilvoiyhbTzRRGjsIT7dtWibXgmUkGb3h
3RoNjpP3D1atcr3PgIyb00uny4Fl2PUu73v+V9ZjY4XI4ILaWLZ08f8JB34Oweol
EuQ6kvIrT1apdbU7agzTjd/jMESNrogM+gemdZzTNHyiI79kdVZduC2mtyOxAj0N
/QXLOAJzUPkKza6C1LX0GFQDCoJDW+l3LZr9FzR2e7YUgjUJ9DhZDk0aeB7G77TB
MGOyJD7pNM/gDW4c1hXEdSdP+TLNFXGLcPEF3uaeKbYlofCyLukFXjn9+4i4Tyty
9a6m1wFOEiQyPoYZpXdCDjIA42gRm6TgfM58qB0B7bn9qKvwlqMqDHER7I5I1txO
gFjcgnJdt01JWEIJdGe4DPq85ctfJC34b61fSJNkd6fOJsg8A0jcfcvbPPQldQBf
4uJis3JTQTvusZ0p97oNd09ct8chvhMe6cMgYSBT8GgcUNklNx8=
=OozX
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 30 Sep 2017 10:24
Re: [bug#28583] [PATCH 6/7] gnu: Add ruby-rubyzip.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092401.36b9d8cf@cbaines.net
On Thu, 28 Sep 2017 18:34:30 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (8 lines)
> Hi,
>
>
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/ruby.scm (ruby-rubyzip): New variable.
> I made a few changes, and got the tests to pass - patch attached.
> WDYT? ben

Awesome, I've replaced the previous patch with the one you provided.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVKFfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XcEhg/+N02G3dXewOVlnN244CEGJGrRiB+prcd6zfU8LA2m01t5zJP8N0Cs/tj2
DLZp1O73FShUE3F8Svm62NUHBT6yyK+g2SwjgSQAyb5riVRZKuwViNwTQC+29Bgg
IwXh8DESWfzd4gqQjef/ZC3m3kAj1ubJUlzaIBxQ4Ax7ETgHVdCelYiHmD2QWwm+
MeL700nZ3KjWPLiXRTnWNaKWENErDmLfnMLhdY9YH5xAov2kTKwWJlWGJegQeoOI
/WXbwHdw3j2elZqNR5+EEgIjy5Ixh3eG3VKIQLmzFB4wrFMmy24Erik831cFDv88
KonPHyJuMqQArY9wIHyqmM844uVutnnQIt1k0Q4qmamJV9lt1H8W7iB6m4q9e8NE
f9p0uj2k7ipd6RQcXCK26aIT25T1i3jEUr/dSlVSWDrBKWAAl4SseUfG3+XdJlQw
OxZAxHSQQKHyvLOEdDimJyhlxnnr2XBHqvQ2U4nhpD6H9qFQfjiJC1B/NTFiWvFK
kI1143J2/iSWRekhMN5h6RKiKPfOKPH4CCw2s8C1SqArMxss1t/Ym+d46GyYVkVV
8DQgvGVMct5VXb/++zV3MivA2hohMUz6PXIyW1U1tmtJZOUrbOJG+S7floVtgPfJ
ll+OqBk4spDAXbQMDgTJI9rFG3hApiT03NiJ7H8qwYU8fosFnLo=
=+zNX
-----END PGP SIGNATURE-----


C
C
Christopher Baines wrote on 30 Sep 2017 10:25
Re: [bug#28583] [PATCH 7/7] gnu: Add es-dump-restore.
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583@debbugs.gnu.org)
20170930092523.4f4fcf34@cbaines.net
On Thu, 28 Sep 2017 18:38:19 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (7 lines)
> On 25/09/17 03:17, Christopher Baines wrote:
> > * gnu/packages/databases.scm (es-dump-restore): New variable.
> [..]
> > + (arguments
> > + '(#:tests? #f
> Including a reason here would be good.

Done, turns out the reason is that there is no testsuite.

Toggle quote (32 lines)
> > + #:phases
> > + (modify-phases %standard-phases
> > + (add-after 'install 'wrap-bin-es_dump_restore
> > + (lambda* (#:key outputs #:allow-other-keys)
> > + (wrap-program (string-append (assoc-ref outputs "out")
> > + "/bin/es_dump_restore")
> > + `("GEM_PATH" ":" prefix (,(string-append
> > + (getenv "GEM_PATH")
> > + ":"
> > + (getenv "GEM_HOME")))))
> > + #t)))))
> Again, it would be preferable to have this done as part of the build
> system, but OK.
>
> > + (propagated-inputs
> > + `(("ruby-httpclient" ,ruby-httpclient)
> > + ("ruby-multi-json" ,ruby-multi-json)
> > + ("ruby-progress_bar" ,ruby-progress_bar)
> > + ("ruby-rubyzip" ,ruby-rubyzip)
> > + ("ruby-thor" ,ruby-thor)))
> > + (synopsis
> > + "Utility for dumping and restoring ElasticSearch indexes")
> This can be moved onto the previous line.
>
> > + (description
> > + "This package provides a utility for dumping the contents of
> > an +ElasticSearch index to a compressed file and restoring the
> > dumpfile back to an +ElasticSearch server")
> > + (home-page
> > + "https://github.com/patientslikeme/es_dump_restore")
> As can this. Otherwise LGTM - thanks for this series.

These two formatting issues should be fixed now. Thanks for the review
and patches Ben. I've sent an updated set of patches.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPVPNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xfkcg//fsdyCJrvj13t5c1CKSmYnbTO719F12IKWlBD0Ms2D8lhICarZKulH8na
7aWZjkS8KlvN9pDQh/KZk4GbdvezNbzfbZFKmG22uq0yMf3vok+94brPaUvmdNY4
6OZPy67EQ94LF2Y1lE/FwtS+OXy3/IG/htHjIDohhXR3WIXuNULudzFRodVcq8eH
TyMU4sEz7qnTkWEwxxqNnEhkVnf8lmL3Pgtmfp2I7Svao4zdKcF0U8qOv6+C5uW9
qtCexyXOiySiAXiRWlKRop0TPT4Cz5ZB4og/T37+zEUVZBvCNVvql0FxTH8gNAqa
8yInKI8fC930GNoPLbTniEV46mt7TUnKmAAThKzPzMaoYTZmQ8pz1dz/4PaONt+1
RXWVZbh8qcbFoa0F82fotov1EntZXTG7tPuxcANLsbfNeQfw+CwJcbNx5fSOvOHQ
XBJ3bOKbg7f36u7hcSfytIYTf384e12xenFs5PvsUe2cBVEvEv59a7z+20qHYeKQ
rlpvU0njVjPBfvpws81kYO0f9QN4MimkBrdsLyzVHPOdkuBYiZUH10Ya9mzYECxd
iQ4ic0HkQew6SFC/telT1n7nAbmj/MplFL0KPFp16UIteMJGZ0N6t+3CWPzXwePd
TJoy7wYokr8oovMTRTfXiaGuEdJs888COdytDrfB9ynRTJlCwYI=
=y72y
-----END PGP SIGNATURE-----


B
B
Ben Woodcroft wrote on 30 Sep 2017 12:32
(name . Christopher Baines)(address . mail@cbaines.net)(address . 28583@debbugs.gnu.org)
851f07d9-4150-d9fa-9c7c-f51caa35e133@uq.edu.au
Hi Chris,


On 30/09/17 18:25, Christopher Baines wrote:
Toggle quote (4 lines)
>
> These two formatting issues should be fixed now. Thanks for the review
> and patches Ben. I've sent an updated set of patches.
>
Thanks. Feel free to push them - I am happy if you are.
ben
C
C
Christopher Baines wrote on 30 Sep 2017 12:52
(name . Ben Woodcroft)(address . b.woodcroft@uq.edu.au)(address . 28583-done@debbugs.gnu.org)
20170930115204.39e4a7f5@cbaines.net
On Sat, 30 Sep 2017 20:32:54 +1000
Ben Woodcroft <b.woodcroft@uq.edu.au> wrote:

Toggle quote (10 lines)
> Hi Chris,
>
>
> On 30/09/17 18:25, Christopher Baines wrote:
> >
> > These two formatting issues should be fixed now. Thanks for the
> > review and patches Ben. I've sent an updated set of patches.
> >
> Thanks. Feel free to push them - I am happy if you are.

Awesome. I've now pushed these patches. Thanks for your review.
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlnPd1RfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9XcBcxAAhQhBqUUXY7R6GnN/6Dntmb+beYZOY2dLq4H23wDvOSGmVx2uCATKLFaZ
oQZV2znDiPK5VYhlDq8pmKmDlZpLFscy8d54tQau8qLxUbL4n1rp8oXghlT2WQTi
ipUAYHsfUmNhiMyeElcHJMCASJrJ278muOgobpfL4ZSnYsUldfnPNouIDM8wlelJ
QmlcHutE9mkfbXae3u/Y87HILBPRJ1FdaZHCg/XU/hGo84yLndGXrdcheJtQKNgn
yqjziR0Ww+5rY+1xAhxLu0cYweH3jAohiprYl++PhWXZudC6sf4gSsYeLOtm5Lnv
iaTxiK9eJciQE9DgZRtBENQT1lzInfYNEdq5MNRQVi6nnVPtRlKH6JILAibrcKOv
JxReaHpe21htJfT+zJInWnnVZYw7ouCeSan4aoU51+IEYIcBDw9+cwmqyr/7KDTQ
YlG0gR9RIBHtzTnU4D5l2jm6L9o7HK5J/D8N2JOnrtptkTJhrfUE5b/JjnfDiBuj
tdL8IciKRo4uCDsmLf1hKGPOIwg65JK8Mw9Ed0NW6F9AZ3B0XxgjmFDannjhWmMK
b3toWjp92A6H9mMyWkSz8Q06W8DpI4CEodlZxq+WWUigOZNjUyd5mro2ec14WzT7
D+FZcU+quXixYmTS/UWHN8LjTEDH9+0+dr6CNUhJCWabnktnCWk=
=uDhl
-----END PGP SIGNATURE-----


Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 28583@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 28583
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch