[PATCH] gnu: Build the shared library for yaml-cpp.

  • Done
  • quality assurance status badge
Details
2 participants
  • Christopher Baines
  • Marius Bakke
Owner
unassigned
Submitted by
Christopher Baines
Severity
normal

Debbugs page

Christopher Baines wrote 8 years ago
(address . guix-patches@gnu.org)
20170822203645.4924-1-mail@cbaines.net
* gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
-DBUILD_SHARED_LIBS=ON to #:configure-flags.
---
gnu/packages/serialization.scm | 2 ++
1 file changed, 2 insertions(+)

Toggle diff (15 lines)
diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 3994191bd..8032e3181 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -249,6 +249,8 @@ that implements both the msgpack and msgpack-rpc specifications.")
(base32
"1vk6pjh0f5k6jwk2sszb9z5169whmiha9ainbdpa1arxlkq7v3b6"))))
(build-system cmake-build-system)
+ (arguments
+ '(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
(inputs
`(("boost" ,boost)))
(native-inputs
--
2.14.1
Marius Bakke wrote 8 years ago
87k21v2ubp.fsf@fastmail.com
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (3 lines)
> * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> -DBUILD_SHARED_LIBS=ON to #:configure-flags.

Does this disable building the static library too? If not, should we do
that while at it? LGTM, anyway.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmcmvsACgkQoqBt8qM6
VPpvnQf+N/Uizi9W7ye3KCfU+h8BoEON+w/FvoKg3h7e0S9hUMW5vu20brBfKRMH
+hP3gr8Hh/gsagQjX36Fog0QzWieU7VLHrpRTsd0Fp+LEmHonhYNs8R9gdRoiveo
lHlBzpVJKIxUmnwKgkgwGA26QPMBXsYq7LsVhzjTwr0nFtfc+jdXY66+fb3utG21
mVcc1bvtYa490WHsdOy7sW7mmUzyDTuwZi/JftsqY7g0UNQRHvkytBbKMPDbMz9i
LcdL+RPAQRiw5lBttOX4RtNVSq9MMdbds0NqYXyrYnT+3GG9E4/7iK+/pvXqtoyu
BEugkkuADk/51cA5SLxhL6ZoZF/qSQ==
=Bvi4
-----END PGP SIGNATURE-----

Christopher Baines wrote 8 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 28190@debbugs.gnu.org)
20170822220047.0821bdf7@cbaines.net
On Tue, 22 Aug 2017 22:58:34 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

Toggle quote (8 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> > -DBUILD_SHARED_LIBS=ON to #:configure-flags.
>
> Does this disable building the static library too? If not, should we
> do that while at it? LGTM, anyway.

I'm not quite sure, but I think so, these are the files in lib now, and
the .a file that was there before has disappeared.

└── lib
├── libyaml-cpp.so -> libyaml-cpp.so.0.5
├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
├── libyaml-cpp.so.0.5.3
└── pkgconfig
└── yaml-cpp.pc
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmcm39fFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xf+dRAAsyGg9oZJ29lvf26Y5QTnnPqRM9R8D1lhPdVbbsfvxLU+DAT7aN+ZWybT
Lf6448mO4uEdWe8SakyZep9X73wkMJOR1NtRtU8n27dEKjxiHufQDsMsa9UPRCUG
nvODd2Co7KJJNkMgj7L8U5gb6zd+mSr7zzVbShbyBFVXfQwQ9qe2ZuFtKpDQe04n
4HjAwEU40LKm/Ea1pivZmom04eb4HFMSNdMD+XSLi3g/7IZn+7PyLbleJrABzWGT
Z+piBr9eCM7tNjFeEmoWYgabwPiKof8GTUgf3//ex5NWzT5Y3GFMpPcKdbiy8oVt
ilRhPHdMNwFO076CP+C55gz0PmoZ5ofj0mbBmtQ3YfuASS85c+Ci6BnQeLh0I098
JhuduqA1+cPqNKp6btnKbMLI+ohlyQ3dwTkManQiVuiLja5g4gAJTb5Y/qWntpHU
2mtmZuYUdXK7u1Ko/KwV7+WtgvvGftToIe0C1BqkbdiTh/HtjpYxuvbqHtBsJtmV
njMt9AnjncMxjNJt2B6AO4Ylu5kKT4qdNhS0FbJgQ0cR5cHSxn6LGQrE0PhJe6tI
/nWi5L7gno5hqdP2I47ccFClzp4NCyQ796KGJDgVLCt7KFt/KYu2cVhZcVCi810L
wRf/bk34b6h1S+s6oyoGdRvY4KFiBgruo2O4Fd/23SEqrAXQT+o=
=Q13+
-----END PGP SIGNATURE-----


Marius Bakke wrote 8 years ago
(name . Christopher Baines)(address . mail@cbaines.net)(address . 28190@debbugs.gnu.org)
87h8wz2trl.fsf@fastmail.com
Christopher Baines <mail@cbaines.net> writes:

Toggle quote (21 lines)
> On Tue, 22 Aug 2017 22:58:34 +0200
> Marius Bakke <mbakke@fastmail.com> wrote:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
>> > -DBUILD_SHARED_LIBS=ON to #:configure-flags.
>>
>> Does this disable building the static library too? If not, should we
>> do that while at it? LGTM, anyway.
>
> I'm not quite sure, but I think so, these are the files in lib now, and
> the .a file that was there before has disappeared.
>
> └── lib
> ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
> ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
> ├── libyaml-cpp.so.0.5.3
> └── pkgconfig
> └── yaml-cpp.pc

Great! Static libraries cannot be reliably grafted, so it's good to
avoid them when we can. Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmcnc4ACgkQoqBt8qM6
VPqBUgf9G3Q4/NQ/TEv4t5099nZl2xO9ovBXC19fWiIlqS5evjPXXjTPbbsKrnBl
Kkf2vSbQ7w2J5idUdqNRBpNUmur1Byb2LUnQ4sxeNFTVFrNiKVjy2d3+gjdZDKgv
I0gNr0RWMLG8F3Zn9usA37/0GZLGPWDqXGk/jCW3om4BgA4kqp0ZTezc357dJTY4
/b8jWCyb+m3LobfMb1KhUkzwncvkWxZuQw7Yfti7LV6k8vyT6NjwXUonjiHbPxIy
NH2FuJDu/r3KqRVV+eBD0DSuhGVukSltp0Ow7BUzNnj4OgCNpgYqTH2ulXTB9LL1
FheysKxokv1rT2dxcH8rGe3QWJ08hQ==
=24fR
-----END PGP SIGNATURE-----

Christopher Baines wrote 8 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 28190-done@debbugs.gnu.org)
20170823101011.21ef8165@cbaines.net
On Tue, 22 Aug 2017 23:10:38 +0200
Marius Bakke <mbakke@fastmail.com> wrote:

Toggle quote (26 lines)
> Christopher Baines <mail@cbaines.net> writes:
>
> > On Tue, 22 Aug 2017 22:58:34 +0200
> > Marius Bakke <mbakke@fastmail.com> wrote:
> >
> >> Christopher Baines <mail@cbaines.net> writes:
> >>
> >> > * gnu/packages/serialization.scm (yaml-cpp)[arguments]: Add
> >> > -DBUILD_SHARED_LIBS=ON to #:configure-flags.
> >>
> >> Does this disable building the static library too? If not, should
> >> we do that while at it? LGTM, anyway.
> >
> > I'm not quite sure, but I think so, these are the files in lib now,
> > and the .a file that was there before has disappeared.
> >
> > └── lib
> > ├── libyaml-cpp.so -> libyaml-cpp.so.0.5
> > ├── libyaml-cpp.so.0.5 -> libyaml-cpp.so.0.5.3
> > ├── libyaml-cpp.so.0.5.3
> > └── pkgconfig
> > └── yaml-cpp.pc
>
> Great! Static libraries cannot be reliably grafted, so it's good to
> avoid them when we can. Thanks!

I've pushed this now, thanks for your review Marius :)
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmdRnNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE
9Xcviw//ZWYS/mnY2GVmBFuKxL8gxchHsSMnkw2YVAaOnw0/zuPOXwoqHej2SeEY
MB3H1trzw+ACGwop83v20k5qbDqgtylkhs4Z8M03F8c2YSDTWSYMcPvCR4cIn8Ou
MTgxTGuL9QGoxQ8qmNUYAuMVT2ZT5DkQ/w3PDSttOjDj7FnMUoEljo+6qT6BNi0X
pSVEPQjQcles6oyESrlcAxrZxe/1SMDADKJhqnYBufn7cYdQDrVqVMU4ppl2wj6l
6Q26n0kdY24qFif+/d2qk+WaXLC4kMGeP4JbW7/OlzDcBZpprUPfkFOB39sLMw+8
UhHuw9/Ate0FpEvQ7oiu831dftroIEO1tHNC2WGI7u9uN7XAWZl48m/ML7zUyLpV
ymBlVMGL0AykY5eWDrVwZCrKhGOvzF04ojzYZDmObenGuYvxaJAhRnXJ9SRlE11H
fr62LtrqFyJYBb4xPJW52j2mb/3kssKMh0+uMgJMPDIOCU8E4H6lXDEZrTj81/uG
qQrRk9Jd2bLJHV7NTeBlqSxHaKV0zOEKb3aKNgVnvvekCfNC9b268SeTvcyPLhQZ
tpbQpPWA5SrqWBCKeFrjQhKIlTsyCs4rAyojZZ/0U2WRnIT9bOwDY9FaNuiJ27l9
i8DQZwyfUfEwvLH94BetHYGlzrUapoynQ4gE/FRJtjyeiZXMEso=
=YZWR
-----END PGP SIGNATURE-----


Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 28190@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 28190
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help