gnu: red-eclipse: Add store "data" package path as default

  • Done
  • quality assurance status badge
Details
3 participants
  • Adonay Felipe Nogueira
  • Kei Kebreau
  • Ludovic Courtès
Owner
unassigned
Submitted by
Adonay Felipe Nogueira
Severity
normal
A
A
Adonay Felipe Nogueira wrote on 20 Aug 2017 20:28
(address . guix-patches@gnu.org)
871so63xh7.fsf@hyperbola.info
This is an attempt to fix bug#25034

--
- Palestrante e consultor sobre /software/ livre (não confundir com
gratis).
- "WhatsApp"? Ele não é livre. Por favor, use o GNU Ring ou o Tox.
- Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft
Office, MP3, MP4, WMA, WMV.
- Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU
GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF
(apenas sem DRM), PNG, TXT, WEBM.
K
K
Kei Kebreau wrote on 23 Sep 2017 17:30
(name . Adonay Felipe Nogueira)(address . adfeno@hyperbola.info)(address . 28164@debbugs.gnu.org)
87vak9sa94.fsf@posteo.net
Adonay Felipe Nogueira <adfeno@hyperbola.info> writes:

Toggle quote (4 lines)
> This is an attempt to fix bug#25034
> ([[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25034]]).
>

Nice catch!

Toggle quote (19 lines)
> --
> - [[https://libreplanet.org/wiki/User:Adfeno]]
> - Palestrante e consultor sobre /software/ livre (não confundir com
> gratis).
> - "WhatsApp"? Ele não é livre. Por favor, use o GNU Ring ou o Tox.
> - Contato: [[https://libreplanet.org/wiki/User:Adfeno#vCard]]
> - Arquivos comuns aceitos (apenas sem DRM): Corel Draw, Microsoft
> Office, MP3, MP4, WMA, WMV.
> - Arquivos comuns aceitos e enviados: CSV, GNU Dia, GNU Emacs Org, GNU
> GIMP, Inkscape SVG, JPG, LibreOffice (padrão ODF), OGG, OPUS, PDF
> (apenas sem DRM), PNG, TXT, WEBM.
>
>>From 6e1d96b5aeaca1a307d8fa42d12fc233e9cd831b Mon Sep 17 00:00:00 2001
> From: Adonay Felipe Nogueira <adfeno@hyperbola.info>
> Date: Sun, 20 Aug 2017 14:51:16 -0300
> Subject: [PATCH] gnu: red-eclipse: Add store "data" package path as default
>
> * gnu/packages/games.scm (red-eclipse): Remove "#t"s and extra spaces. Make version respect documentation.

This spacing is there to make the list more readable. I suppose the
spaces could be removed, but I'd prefer to keep them if we don't have to
get rid of them.

Also, the "#t"s were there to make sure that the phases returned true
like they're supposed to. They should probably stay unless that
convention has changed.

Toggle quote (4 lines)
> [arguments]: Add "prefix" to make-flags. Add
> "add-store-data-package-path-as-default" phase. Improve "copy-data"
> phase.

I tried removing "prefix" from the make-flags and everything still seems
to work fine. Am I missing what this is intended to do, or was it left
over from some earlier work on this patch?

Toggle quote (116 lines)
> ---
> gnu/packages/games.scm | 117 +++++++++++++++++++++++++++++--------------------
> 1 file changed, 69 insertions(+), 48 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 7932e84..f8243a6 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -24,7 +24,7 @@
> ;;; Copyright © 2016, 2017 Efraim Flashner <efraim@flashner.co.il>
> ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
> ;;; Copyright © 2016 Steve Webber <webber.sl@gmail.com>
> -;;; Copyright © 2017 Adonay "adfeno" Felipe Nogueira <https://libreplanet.org/wiki/User:Adfeno> <adfeno@openmailbox.org>
> +;;; Copyright © 2017 Adonay "adfeno" Felipe Nogueira <https://libreplanet.org/wiki/User:Adfeno> <adfeno@hyperbola.info>
> ;;; Copyright © 2017 Arun Isaac <arunisaac@systemreboot.net>
> ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
> ;;; Copyright © 2017 nee <nee-git@hidamari.blue>
> @@ -133,6 +133,7 @@
> #:use-module (gnu packages gnuzilla)
> #:use-module (gnu packages icu4c)
> #:use-module (gnu packages networking)
> + #:use-module (guix build utils)
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system haskell)
> #:use-module (guix build-system python)
> @@ -2716,50 +2717,55 @@ http://lavachat.symlynx.com/unix/")
> (license license:gpl2+)))
>
> (define-public red-eclipse
> - (let ((data-sources
> - '(("acerspyro" "0zmg78scrfdv33h7vszqvzylcqjwg7d5b0j2riav3rjfh326j8xx")
> - ("actors" "0l00rsvppqzdpsikm5qpj38jiygirszxlzay2nxp4g4n2qjq0m4a")
> - ("appleflap" "0jhfr7f13hk3nswwxqc4jajriipr6zz6j63v955nv4sgxs7lzbjd")
> - ("blendbrush" "1nk0zaisbqf2khrivq8ls6z2lnh6d51m133m2ppxk7k4c9gq1imq")
> - ("caustics" "1hq08k476wayi0kmk4ps8h6jr75yinq04f1r2p8r79xsdpxq9my5")
> - ("crosshairs" "1gmrmjm7i7n9py0qrzamk7ygi63yx1mr2pp6iwz2vwngprl03n8m")
> - ("dziq" "0gr36ydrv8syjxv7w9dw3ix8waaq201fzxr0klkqp260p8xp215s")
> - ("elyvisions" "05syxlpsap6nfwxnnd0ls7qj1p4vhw2jxi41pi5inwpfifapfphz")
> - ("fonts" "184syks602xc657q08973w5ji50x5zssvd4vp2q2ig8m68iyr51c")
> + (let ((release "1.5.8")
> + (revision 2)
> + (data-sources
> + '(("acerspyro" "0zmg78scrfdv33h7vszqvzylcqjwg7d5b0j2riav3rjfh326j8xx")
> + ("actors" "0l00rsvppqzdpsikm5qpj38jiygirszxlzay2nxp4g4n2qjq0m4a")
> + ("appleflap" "0jhfr7f13hk3nswwxqc4jajriipr6zz6j63v955nv4sgxs7lzbjd")
> + ("blendbrush" "1nk0zaisbqf2khrivq8ls6z2lnh6d51m133m2ppxk7k4c9gq1imq")
> + ("caustics" "1hq08k476wayi0kmk4ps8h6jr75yinq04f1r2p8r79xsdpxq9my5")
> + ("crosshairs" "1gmrmjm7i7n9py0qrzamk7ygi63yx1mr2pp6iwz2vwngprl03n8m")
> + ("dziq" "0gr36ydrv8syjxv7w9dw3ix8waaq201fzxr0klkqp260p8xp215s")
> + ("elyvisions" "05syxlpsap6nfwxnnd0ls7qj1p4vhw2jxi41pi5inwpfifapfphz")
> + ("fonts" "184syks602xc657q08973w5ji50x5zssvd4vp2q2ig8m68iyr51c")
> ("freezurbern" "020gpgcpy4rqjd9d18npfm96j8f02jcjnccbxcgzk1yb58y687ya")
> - ("john" "0hj5kwlb2gb0gsnl9bk7dkqlk8r7vxcw8gxpgrb3kfn8d9cwcb7k")
> - ("jojo" "0fij06040r7s5p7jksxm7wxi9jqwkhhm8iywys0dagk8j2wcbvsz")
> - ("jwin" "0ysfynjvypc8dszf7rsvk02jgw8fmsli49vy2xpm83zpkrqpddgf")
> + ("john" "0hj5kwlb2gb0gsnl9bk7dkqlk8r7vxcw8gxpgrb3kfn8d9cwcb7k")
> + ("jojo" "0fij06040r7s5p7jksxm7wxi9jqwkhhm8iywys0dagk8j2wcbvsz")
> + ("jwin" "0ysfynjvypc8dszf7rsvk02jgw8fmsli49vy2xpm83zpkrqpddgf")
> ("luckystrike" "1bm0xdqjv35ry5xwbzw3a3v1xf2gj1jwfg29nyl6w3ch0h6crr11")
> - ("maps" "0c9d1zxmpnngwhchzw6xb6cf84cx8xyycmdqcvyhamrd95d96qma")
> - ("mayhem" "133pdql7ari159skd9qdmw0p1m73x32d1v6jswkz0xwk8vgxmkil")
> - ("mikeplus64" "1d5npn9wlw0mviz9vhzzcsj98jvfh1wbvlh1nyqfj4ws5nfxhs7x")
> - ("misc" "19x2ps6yxnfrz0xdhqdwncaq25ds7i4w2l8sdfi95yh2r7c5k1qn")
> - ("nieb" "15029nipl92cb0jbh46z00k51hf3jk4v05pwx266b6b11bapdz0c")
> - ("nobiax" "0k9apim5z4ihd5ajmnbq4gyh24w872dv0mr5v8wqn31a8gxzahhp")
> - ("particles" "06827r9pnhzjil381xiwcbc93v9nxin7qlr59yrvk9gdzxmklk9m")
> - ("philipk" "1l6fhl6qz471vjn05hvk29bm8dhwnzqbmi2hdylpa9k998nzkfc1")
> + ("maps" "0c9d1zxmpnngwhchzw6xb6cf84cx8xyycmdqcvyhamrd95d96qma")
> + ("mayhem" "133pdql7ari159skd9qdmw0p1m73x32d1v6jswkz0xwk8vgxmkil")
> + ("mikeplus64" "1d5npn9wlw0mviz9vhzzcsj98jvfh1wbvlh1nyqfj4ws5nfxhs7x")
> + ("misc" "19x2ps6yxnfrz0xdhqdwncaq25ds7i4w2l8sdfi95yh2r7c5k1qn")
> + ("nieb" "15029nipl92cb0jbh46z00k51hf3jk4v05pwx266b6b11bapdz0c")
> + ("nobiax" "0k9apim5z4ihd5ajmnbq4gyh24w872dv0mr5v8wqn31a8gxzahhp")
> + ("particles" "06827r9pnhzjil381xiwcbc93v9nxin7qlr59yrvk9gdzxmklk9m")
> + ("philipk" "1l6fhl6qz471vjn05hvk29bm8dhwnzqbmi2hdylpa9k998nzkfc1")
> ("projectiles" "03ay8ik52n3vx723swqlnl5gpkzf1v1gadwj3zcnh43ch7nd2bqh")
> - ("props" "1yxz7gfmb79sqqrkyfdzp4ar9rf5f1kpfij4nrkk1l8vbw9liksc")
> - ("skyboxes" "1mm98mhb6yhb006p1hlic91jcwjxhq79mblxciwbqqa9c5g4yki6")
> - ("snipergoth" "1vlpmwlg71g6l5b706gp82bc07i5bbw2zphzynm2fx49za0zdi44")
> - ("sounds" "156g5wh8cvdh6zr33haqm566sd28ylnzdf2h4pqzpxbb2i19vbfg")
> - ("textures" "0wkhl5cgymr9kslzhksi83hs15rb0q01xvax5khi6b4dcl3mrmsh")
> - ("torley" "1xlag6ndjyqafl984n6d9zi96dv9aif7vrc2nvikc3iwgjwlbxav")
> - ("trak" "12x9ix8zkqn9svy56qmdgj4x2814qh25f4srplgq691lqn9qjhvd")
> - ("ulukai" "0gz1hd8hca2biskc85hw4jjacpsmqg9x4w6cwrka8x987xmc92k5")
> - ("unnamed" "09v8fjy6jqypm1i121kilg3z6zpw7dm0i4gxhd9b7ihprvzvy8r7")
> - ("vanities" "0m3vfq9l71pbb80qz4s3k8r5azmm158chqbw8snch09ymxm6h462")
> - ("vegetation" "07yzm9lbzr624j4i652ny5p762p83gadg40c1k8gwff4y7yk55gn")
> - ("weapons" "05fsp17gdrhjqdwia7rwdw9gcijaqwcnny8lf6krms43xmn8cj0x")
> - ("wicked" "0jjgwzdibr5my369gwvmvbklpjlwq939zgf643rv0168xc087xb2"))))
> + ("props" "1yxz7gfmb79sqqrkyfdzp4ar9rf5f1kpfij4nrkk1l8vbw9liksc")
> + ("skyboxes" "1mm98mhb6yhb006p1hlic91jcwjxhq79mblxciwbqqa9c5g4yki6")
> + ("snipergoth" "1vlpmwlg71g6l5b706gp82bc07i5bbw2zphzynm2fx49za0zdi44")
> + ("sounds" "156g5wh8cvdh6zr33haqm566sd28ylnzdf2h4pqzpxbb2i19vbfg")
> + ("textures" "0wkhl5cgymr9kslzhksi83hs15rb0q01xvax5khi6b4dcl3mrmsh")
> + ("torley" "1xlag6ndjyqafl984n6d9zi96dv9aif7vrc2nvikc3iwgjwlbxav")
> + ("trak" "12x9ix8zkqn9svy56qmdgj4x2814qh25f4srplgq691lqn9qjhvd")
> + ("ulukai" "0gz1hd8hca2biskc85hw4jjacpsmqg9x4w6cwrka8x987xmc92k5")
> + ("unnamed" "09v8fjy6jqypm1i121kilg3z6zpw7dm0i4gxhd9b7ihprvzvy8r7")
> + ("vanities" "0m3vfq9l71pbb80qz4s3k8r5azmm158chqbw8snch09ymxm6h462")
> + ("vegetation" "07yzm9lbzr624j4i652ny5p762p83gadg40c1k8gwff4y7yk55gn")
> + ("weapons" "05fsp17gdrhjqdwia7rwdw9gcijaqwcnny8lf6krms43xmn8cj0x")
> + ("wicked" "0jjgwzdibr5my369gwvmvbklpjlwq939zgf643rv0168xc087xb2"))))
> (package
> (name "red-eclipse")
> - (version "1.5.8")
> + (version (if (zero? revision)
> + release
> + (string-append release "-"
> + (number->string revision))))
> (source (origin
> (method url-fetch)
> (uri (string-append "https://github.com/red-eclipse/base"
> - "/archive/v" version ".tar.gz"))
> + "/archive/v" release ".tar.gz"))
> (file-name (string-append name "-" version ".tar.gz"))

The file-name now needs to use the upstream release number instead of the
Guix-specific version number.

Toggle quote (81 lines)
> (sha256
> (base32
> @@ -2769,7 +2775,9 @@ http://lavachat.symlynx.com/unix/")
> `(#:tests? #f ; no check target
> #:make-flags (list "CC=gcc" "-Csrc"
> (string-append "INSTDIR="
> - (assoc-ref %outputs "out") "/bin"))
> + (assoc-ref %outputs "out") "/bin")
> + (string-append "prefix="
> + (assoc-ref %outputs "out")))
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'unpack-data
> @@ -2782,17 +2790,29 @@ http://lavachat.symlynx.com/unix/")
> "-Cdata"
> "--transform"
> (string-append "s/"
> - name "-" ,version "/"
> + name "-" ,release "/"
> name "/")))
> - (list ,@(map car data-sources)))
> - #t))
> + (list ,@(map car data-sources)))))
> + (add-after 'unpack-data 'add-store-data-package-path-as-default
> + (lambda* (#:key outputs #:allow-other-keys)
> + (substitute* "src/engine/server.cpp"
> + (("(else[[:space:]]*)((addpackagedir\\()\"data\"(\\);))" _ else_part addpackagedir_original addpackagedir_open addpackagedir_close)
> + (string-append else_part
> + "{ "
> + addpackagedir_open
> + "\""
> + (assoc-ref outputs "out")
> + "/share/redeclipse/data\""
> + addpackagedir_close
> + " "
> + addpackagedir_original
> + " }")))))
> (delete 'configure) ; no configure script
> (add-after 'set-paths 'set-sdl-paths
> (lambda* (#:key inputs #:allow-other-keys)
> (setenv "CPATH"
> (string-append (assoc-ref inputs "sdl-union")
> - "/include/SDL2"))
> - #t))
> + "/include/SDL2"))))
> (add-after 'install 'copy-data
> (lambda* (#:key outputs #:allow-other-keys)
> (let ((out (assoc-ref outputs "out")))
> @@ -2801,8 +2821,10 @@ http://lavachat.symlynx.com/unix/")
> (copy-file "doc/examples/servinit.cfg"
> (string-append out "/config/servinit.cfg"))
> (copy-recursively "data"
> - (string-append out "/data")))
> - #t))
> + (string-append out "/share/redeclipse/data"))
> + (mkdir-p (string-append out "/lib/redeclipse"))
> + (symlink (string-append out "/share/redeclipse/data")
> + (string-append out "/lib/redeclipse/data")))))
> (add-after 'copy-data 'wrap-program
> (lambda* (#:key inputs outputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
> @@ -2831,8 +2853,7 @@ exec -a \"$0\" ~a/.redeclipse_server_linux-real~%"
> (string-append out)
> (string-append bin))))
> (chmod "redeclipse_linux" #o555)
> - (chmod "redeclipse_server_linux" #o555)))
> - #t)))))
> + (chmod "redeclipse_server_linux" #o555))))))))
> (native-inputs `(("pkg-config" ,pkg-config)))
> (inputs
> `(("curl" ,curl)
> @@ -2848,7 +2869,7 @@ exec -a \"$0\" ~a/.redeclipse_server_linux-real~%"
> (method url-fetch)
> (uri (string-append
> "https://github.com/red-eclipse/"
> - name "/archive/v" version ".tar.gz"))
> + name "/archive/v" release ".tar.gz"))
> (sha256 (base32 hash))
> (file-name (string-append name "-" version
> ".tar.gz"))))))

Thanks for your work!
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlnGfhcACgkQ5qXuPBlG
eg03eQ/+Jz2a+2+icvUCfbbXY1aTZRfzGgn9OArWnTDD/cLRl0gDGkCp9bOLGoxa
Ey6oy3bwa4AsccwhUhrzlInOkO5IQJtR4ja2/iKPGrQYMxHURDzCGWtqH5IHp0Av
/kkOCyJetugfR0KqJOeY0XykRHHyeChUUzwZt1U7bU6hVLPFVKHdStZasKzR8VEH
Sn0o1MaEpKBBvJUhL6BK5Nk/K52exRJfJiSFoVhLRgHxiKtBA4XPLHLgD1OAWzl2
l1Zas+8MpmdDuwfzlh+aPL3Q67TAEzIIqfruya+ljCmslidSQtpNe1ju6GKvTYp5
JQ54kYtyAvpY30w2E07cxFmpg9kGWEaGk0IQe3HbZfdRIrIFdyjqmuPubqxB1gOw
CVu0Xv9t34RXu5gmP4d8X60DLWIBWGRTsWyQKHkRx7EvjRDjxrYf2fYDqK2m5C9n
wJmanp89tM+FjObakE24AwONqP227+bWkl5ToYBdeehTfFQ3NFFIdJjzapa2DDCC
Fu8ThXWMix8fBOMHn6cEtKKCpHOwqRs4TDoqSFM+ydkF/hwQK8KtQZ/o9t3dLzQB
qLoNXfaaLOSr/clWkMH2XU2YUYUWGk9EWZ+8E2RiyPP3rn8jw/It+wPb584H5LrN
x3u5qAeIAF8ep4U3wTOUDtOFxyvOMYg5kIO2Rkh4UIOg+CUHBcM=
=rKwZ
-----END PGP SIGNATURE-----

L
L
Ludovic Courtès wrote on 7 Oct 2017 22:49
(name . Kei Kebreau)(address . kkebreau@posteo.net)
87bmliisyk.fsf@gnu.org
Kei Kebreau <kkebreau@posteo.net> skribis:

Toggle quote (8 lines)
> Adonay Felipe Nogueira <adfeno@hyperbola.info> writes:
>
>> This is an attempt to fix bug#25034
>> ([[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25034]]).
>>
>
> Nice catch!

Kei, Adonay: what's the status of this patch?


TIA,
Ludo'.
K
K
Kei Kebreau wrote on 9 Oct 2017 18:34
(name . Ludovic Courtès)(address . ludo@gnu.org)
87mv50b7q5.fsf@posteo.net
ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (17 lines)
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> Adonay Felipe Nogueira <adfeno@hyperbola.info> writes:
>>
>>> This is an attempt to fix bug#25034
>>> ([[https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25034]]).
>>>
>>
>> Nice catch!
>
> Kei, Adonay: what's the status of this patch?
>
> https://bugs.gnu.org/28164
>
> TIA,
> Ludo'.

I've attached the tentative patch, which differs a bit from Adonay's
patch. Namely, I've kept the #t's at the end of the phases, changed
from the version string ("1.5.8-2") to release ("1.5.8") in the URL so
the download works again and corrected the sha256 hash becuase of the
new file name based on the version string.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlnbpSIACgkQ5qXuPBlG
eg1WmA/+LM9oV5B3qoUtyyZxmqtswDAIEdKi3CoM2EOO+zPU4v2WHN999tmotCLE
RWTtXxJOCpc/50ILcQ5rzg2SOkG9nqU1aH7/DzZ9Fvg78+TuUZK/IRS73lQq5PK4
ZtBNFLMocPMEse54W/TpeXOWOuA/PKC6ej4uhMip7COSkwBaVKhF3xvFRmD8z18Y
LhZXp1egBC8TPziGxaqGskvdGWlJJ3SYIJJyPZv3b3D8e1xtlS8NDYWTlkBU4ByV
w1+ne0hy2jplcPC8iHOQAxGbZH/NTxNwF5nQT2SUBV/HU68TrNTQjS7Lu91WlZpw
+rTTLXgKXXXzKe8GWtcXkaGSn+NOxx28peoPB5IbQ1RYKOaxmDTuKL5yvAjMGFyp
Z0hxSXdIjqrpcTYLcxwsfVEKZQ2Xj8E3IlhrbLM8MeYU6kD6ClL9hIZKwt2Cuhbz
oQm0bbPrk/lFWa1uHZr7J2GDRxvqpMGittw9Z3BPxPxV9GyZvQf9u9wC7xXbdUs6
nRy07RTXdb1qWhz/mO3kwwGumIlHiDHDZZdxge8LjCVaz78HPVvopmKk8ACpvHDx
SMd9TdGstMmhiF06SeTe3Toxbr21icUfQ09DPg09cthbJ9nKMJMC7fPJawk8TOsq
4iODHU28tpJgT5G79+Zy5OjQSY+oHhtyyV3hsxUmhGrUYzHit/M=
=IC2z
-----END PGP SIGNATURE-----

A
A
Adonay Felipe Nogueira wrote on 9 Oct 2017 18:58
(address . 28164@debbugs.gnu.org)
87vajouul7.fsf@hyperbola.info
Looks good to me. ;)

Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (5 lines)
> I've attached the tentative patch, which differs a bit from Adonay's
> patch. Namely, I've kept the #t's at the end of the phases, changed
> from the version string ("1.5.8-2") to release ("1.5.8") in the URL so
> the download works again and corrected the sha256 hash becuase of the
> new file name based on the version string.
L
L
Ludovic Courtès wrote on 10 Oct 2017 09:20
(name . Kei Kebreau)(address . kkebreau@posteo.net)
87lgkjpiyu.fsf@gnu.org
Kei Kebreau <kkebreau@posteo.net> skribis:

Toggle quote (12 lines)
> From 59e71c1f353fc895318612e7cffe890e1caac029 Mon Sep 17 00:00:00 2001
> From: Adonay Felipe Nogueira <adfeno@hyperbola.info>
> Date: Sun, 20 Aug 2017 15:28:20 -0300
> Subject: [PATCH] gnu: red-eclipse: Add store "data" package path as default.
>
> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
> respect documentation.
> [arguments]: Add "prefix" to make-flags. Add
> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>
> Signed-off-by: Kei Kebreau <kkebreau@posteo.net>

At first sight, it LGTM. I think you can go ahead.

Thank you Adonay & Kei!

Ludo’.
K
K
Kei Kebreau wrote on 10 Oct 2017 14:27
(name . Ludovic Courtès)(address . ludo@gnu.org)
871smbdw7x.fsf@posteo.net
ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (20 lines)
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> From 59e71c1f353fc895318612e7cffe890e1caac029 Mon Sep 17 00:00:00 2001
>> From: Adonay Felipe Nogueira <adfeno@hyperbola.info>
>> Date: Sun, 20 Aug 2017 15:28:20 -0300
>> Subject: [PATCH] gnu: red-eclipse: Add store "data" package path as default.
>>
>> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
>> respect documentation.
>> [arguments]: Add "prefix" to make-flags. Add
>> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>>
>> Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
>
> At first sight, it LGTM. I think you can go ahead.
>
> Thank you Adonay & Kei!
>
> Ludo’.

Pushed to master as 42abb842f64f5dd7834cabd445a5f4d01f1e68a4.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlncvKMACgkQ5qXuPBlG
eg06ohAAnkSoQtWYrAfAUERD0Wh9T3zt15E+2irCz1XN0sayvSZGOAkLZbZV6Jw3
8x0QUeSQ2kDgshQpbJRb9HwwXUhwsF8veXQhH6/IrN2VW2Puf9vOnvFYp6J3W3Xh
p5Jt5Op223UQumLpZUuPyRcQUDiEhMgF70APBdbbKX5dXhFKWfXJbQo6jN+A1nBj
VV09cXsRIAH61DksaxhCpC2/1LVmMmoPcHMj7QWJ4E0MSEwDaVfWV10BGDSFsSWe
9O9TW7Hs/bBq4a1HvNKpLtbVIHFCEVlsbSL9liQn7/f+B9Vfb3S7MVtt4XzYYSH3
i2JJk5jYHFE+HYnrEk3rvNUDhN2bMzUKH8jO9b82FoiQKmwXj2gaE4CbyZh44O0O
mJa/1ITjR8XCyDKhoWtzS2GaGpICBdBDStxWSCu02pNV/5d7Co0eJ+/HWOh6IcYN
B/mXldEZQaey1fx+vXlJnPwkrn5Fv1WPoaIKElqiTVYj/0gTdYe6dvrS2fl8xbFH
ce2hvhcq7R1XLmkw8Ngsuk9voKQXye+xel/5wmrkGvUIEqtpvc9piaGx3pa0u365
Tlce2Z774L7BZsanvZdIyRtxcx/3ysfR3AJeXYKXEkHgP2v4OL1YWTRUPiQRsLcd
6+qpzD2EysbuTdtjsbeyoyIlyESj56bcoqKkKqZvq1rQjW1Irus=
=9jh6
-----END PGP SIGNATURE-----

Closed
A
A
Adonay Felipe Nogueira wrote on 12 Oct 2017 15:33
(address . 28164@debbugs.gnu.org)
87a80w5w4h.fsf@hyperbola.info
You're welcome! ;)

ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (6 lines)
> At first sight, it LGTM. I think you can go ahead.
>
> Thank you Adonay & Kei!
>
> Ludo’.
>
?
Your comment

This issue is archived.

To comment on this conversation send an email to 28164@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 28164
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch