Clean-up of package phases

  • Done
  • quality assurance status badge
Details
6 participants
  • Kei Kebreau
  • Kei Kebreau
  • Leo Famulari
  • Ludovic Courtès
  • Marius Bakke
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Kei Kebreau
Severity
normal

Debbugs page

Kei Kebreau wrote 8 years ago
(address . guix-patches@gnu.org)
871sov69jq.fsf@openmailbox.org
These patches address some issues with our package definitions, as
partially discussed with Mark on guix-devel. I believe I've corrected
all the cases that are fit for Guix's master branch.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmAKyoACgkQ5qXuPBlG
eg1g9xAApb3wN/yVqEkyPkS1sT9msastiDanIRj5+XISyijHp+tyx3r4bRQ0lVcd
i9mYWwLELfV+ZcFoq0jHx8pKEX7ljjPYxRhgoKDAaCOOiyf6Jjaqkap2mmjIHfs5
pgdCyKZ52s2FptwQTz5bi/VzZpxmuOo/RD91XVxs/hPG7GIRjojWVRhyeq9pQlYA
WkmjZ3dlCULPWorwMzuAt4WsrQBXdRrPcEY2U2FeJqgCR14bDvuUnjOxvJvWXYHM
mYxSlb8zcFCrzvfdwyslgrUQF9HPx5lGQliBmf3TaSkElJRVgutv47fhQXgDBuOG
emReFEl1KaLZ+IndWpKPtIt+ybmX4DJfykMxzaJRm+x2XZOSNiHX0oF+Wp8u/Z9i
PFQvllnCwFi4t4ywPb1GaPfuInHC1aOMkBQqqaW8kSp2MHFIJA98W7bBLX+kWrN2
/F7kCPwojlCeuB/rflouKZ9R5GPjdvojQtSBKrl7PW1RcHfRsFJrsiyjfH28LnZV
veDlCAwgkZVUzGXBNRZysZMKQnA3dSmKbVzOjA/+D3vMEa1ATZNqlHQz6myby70z
8Pzt02e1eARySNAKzNwncJWf4CcP2GDv/VlLfRXaF9oPrPJKFd/oh4L7FAIEtCkP
M458d2m12Yxq8eaH1k3+icuawD84AW7bw4ENxlmObxQWaR9KJDQ=
=zDWA
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
[PATCH 1/2] gnu: Use 'modify-phases' syntax.
(address . 27898@debbugs.gnu.org)(name . Kei Kebreau)(address . kei@openmailbox.org)
20170801072153.19077-1-kei@openmailbox.org
* gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
'modify-phases' syntax.
* gnu/packages/algebra.scm (arb)[arguments]: Likewise.
* gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
* gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
* gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
* gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
* gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
* gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
* gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
* gnu/packages/conky.scm (conky)[arguments]: Likewise.
* gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
* gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
* gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
* gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
* gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
* gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
* gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
* gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
* gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
* gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
* gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
* gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
* gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
* gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
* gnu/packages/gl.scm (glew)[arguments]: Likewise.
* gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
* gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
* gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
* gnu/packages/graphics.scm (agg)[arguments]: Likewise.
* gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
[arguments]: Likewise.
* gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
* gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
* gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
* gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
[arguments]: Likewise.
* gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
* gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
* gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
* gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
module-init-tools)[arguments]: Likewise.
* gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
* gnu/packages/lout.scm (lout)[arguments]: Likewise.
* gnu/packages/lua.scm (luajit)[arguments]: Likewise.
* gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
* gnu/packages/mail.scm (exim)[arguments]: Likewise.
* gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
* gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
suitesparse)[arguments]: Likewise.
* gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
* gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
* gnu/packages/music.scm (solfege)[arguments]: Likewise.
* gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
* gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
Likewise.
* gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
* gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
Likewise.
* gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
* gnu/packages/popt.scm (popt)[arguments]: Likewise.
* gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
Likewise.
* gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
* gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
python-sqlalchemy, python-docopt)[arguments]: Likewise.
* gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
* gnu/packages/regex.scm (tre)[arguments]: Likewise.
* gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
* gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
* gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
* gnu/packages/scheme.scm (racket)[arguments]: Likewise.
* gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
* gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
* gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
* gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
* gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
* gnu/packages/tcl.scm (expect)[arguments]: Likewise.
* gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
* gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
Likewise.
* gnu/packages/time.scm (time)[arguments]: Likewise.
* gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
* gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
* gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
* gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
* gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
* gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
* gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
* gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
* gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
* gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
* gnu/packages/xorg.scm (imake)[arguments]: Likewise.
---
gnu/packages/admin.scm | 294 ++++++++++++++---------------
gnu/packages/algebra.scm | 31 ++--
gnu/packages/apr.scm | 25 ++-
gnu/packages/audio.scm | 193 +++++++++----------
gnu/packages/backup.scm | 33 ++--
gnu/packages/bioinformatics.scm | 250 +++++++++++++------------
gnu/packages/bittorrent.scm | 33 ++--
gnu/packages/cdrom.scm | 2 +-
gnu/packages/compression.scm | 16 +-
gnu/packages/conky.scm | 31 ++--
gnu/packages/databases.scm | 102 +++++-----
gnu/packages/debug.scm | 70 +++----
gnu/packages/display-managers.scm | 22 +--
gnu/packages/dns.scm | 2 +-
gnu/packages/docbook.scm | 26 +--
gnu/packages/emacs.scm | 74 ++++----
gnu/packages/engineering.scm | 43 +++--
gnu/packages/firmware.scm | 48 ++---
gnu/packages/flashing-tools.scm | 21 +--
gnu/packages/fltk.scm | 42 ++---
gnu/packages/freedesktop.scm | 33 ++--
gnu/packages/gd.scm | 19 +-
gnu/packages/gimp.scm | 30 +--
gnu/packages/gkrellm.scm | 4 +-
gnu/packages/gl.scm | 2 +-
gnu/packages/glib.scm | 33 ++--
gnu/packages/gnome.scm | 145 +++++++--------
gnu/packages/gprolog.scm | 17 +-
gnu/packages/gps.scm | 19 +-
gnu/packages/graphics.scm | 13 +-
gnu/packages/gtk.scm | 80 ++++----
gnu/packages/guile-wm.scm | 81 ++++----
gnu/packages/guile.scm | 36 ++--
gnu/packages/hugs.scm | 61 +++---
gnu/packages/hurd.scm | 60 +++---
gnu/packages/image-viewers.scm | 14 +-
gnu/packages/libcanberra.scm | 18 +-
gnu/packages/libsigsegv.scm | 13 +-
gnu/packages/linux.scm | 379 +++++++++++++++++++-------------------
gnu/packages/lisp.scm | 61 +++---
gnu/packages/lout.scm | 142 +++++++-------
gnu/packages/lua.scm | 2 +-
gnu/packages/machine-learning.scm | 88 +++++----
gnu/packages/mail.scm | 90 ++++-----
gnu/packages/man.scm | 4 +-
gnu/packages/maths.scm | 119 ++++++------
gnu/packages/messaging.scm | 27 ++-
gnu/packages/mp3.scm | 87 ++++-----
gnu/packages/music.scm | 102 +++++-----
gnu/packages/noweb.scm | 79 ++++----
gnu/packages/patchutils.scm | 120 ++++++------
gnu/packages/pdf.scm | 69 +++----
gnu/packages/perl.scm | 31 ++--
gnu/packages/photo.scm | 15 +-
gnu/packages/popt.scm | 17 +-
gnu/packages/pretty-print.scm | 65 +++----
gnu/packages/pumpio.scm | 32 ++--
gnu/packages/python.scm | 47 +++--
gnu/packages/rdf.scm | 40 ++--
gnu/packages/regex.scm | 20 +-
gnu/packages/rrdtool.scm | 19 +-
gnu/packages/ruby.scm | 40 ++--
gnu/packages/sawfish.scm | 50 ++---
gnu/packages/scheme.scm | 134 +++++++-------
gnu/packages/sdl.scm | 46 ++---
gnu/packages/serveez.scm | 15 +-
gnu/packages/skribilo.scm | 29 +--
gnu/packages/smalltalk.scm | 17 +-
gnu/packages/suckless.scm | 4 +-
gnu/packages/tcl.scm | 15 +-
gnu/packages/telephony.scm | 12 +-
gnu/packages/textutils.scm | 25 ++-
gnu/packages/time.scm | 19 +-
gnu/packages/tor.scm | 14 +-
gnu/packages/uucp.scm | 24 +--
gnu/packages/video.scm | 9 +-
gnu/packages/web-browsers.scm | 10 +-
gnu/packages/web.scm | 15 +-
gnu/packages/wicd.scm | 214 +++++++++++----------
gnu/packages/wm.scm | 2 +-
gnu/packages/xdisorg.scm | 5 +-
gnu/packages/xfce.scm | 23 +--
gnu/packages/xfig.scm | 75 ++++----
gnu/packages/xorg.scm | 39 ++--
84 files changed, 2253 insertions(+), 2274 deletions(-)

Toggle diff (212 lines)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 9729a30fc..afcf9dcae 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -361,32 +361,33 @@ login, passwd, su, groupadd, and useradd.")
"05yxrp44ky2kg6qknk1ih0kvwkgbn9fbz77r3vci7agslh5wjm8g"))))
(build-system gnu-build-system)
(arguments
- `(#:phases (alist-replace 'configure
- (lambda* (#:key inputs outputs
- #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (man8 (string-append
- out "/share/man/man8"))
- (sbin (string-append out "/sbin"))
- (shadow (assoc-ref inputs "shadow"))
- (login (string-append shadow
- "/bin/login")))
- (substitute* "Makefile"
- (("^SBINDIR.*")
- (string-append "SBINDIR = " out
- "/sbin\n"))
- (("^MANDIR.*")
- (string-append "MANDIR = " out
- "/share/man/man8\n")))
-
- ;; Pick the right 'login' by default.
- (substitute* "mingetty.c"
- (("\"/bin/login\"")
- (string-append "\"" login "\"")))
-
- (mkdir-p sbin)
- (mkdir-p man8)))
- %standard-phases)
+ `(#:phases
+ (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let* ((out (assoc-ref outputs "out"))
+ (man8 (string-append
+ out "/share/man/man8"))
+ (sbin (string-append out "/sbin"))
+ (shadow (assoc-ref inputs "shadow"))
+ (login (string-append shadow
+ "/bin/login")))
+ (substitute* "Makefile"
+ (("^SBINDIR.*")
+ (string-append "SBINDIR = " out
+ "/sbin\n"))
+ (("^MANDIR.*")
+ (string-append "MANDIR = " out
+ "/share/man/man8\n")))
+
+ ;; Pick the right 'login' by default.
+ (substitute* "mingetty.c"
+ (("\"/bin/login\"")
+ (string-append "\"" login "\"")))
+
+ (mkdir-p sbin)
+ (mkdir-p man8))
+ #t)))
#:tests? #f)) ; no tests
(inputs `(("shadow" ,shadow)))
@@ -725,25 +726,25 @@ by bandwidth they use.")
("perl-x11-protocol" ,perl-x11-protocol)))
(arguments
`(#:phases
- (alist-cons-after
- 'install 'set-load-paths
- (lambda* (#:key inputs outputs #:allow-other-keys)
- ;; Put the perl-tk and perl-x11-protocol modules in the perl inc
- ;; path for PROG
- (let* ((out (assoc-ref outputs "out"))
- (prog (string-append out "/bin/cssh"))
- (perl-ver ,(package-version perl))
- (x11-inc (string-append
- (assoc-ref inputs "perl-x11-protocol")
- "/lib/perl5/site_perl/" perl-ver))
- (tk-inc (string-append
- (assoc-ref inputs "perl-tk")
- "/lib/perl5/site_perl/" perl-ver
- "/x86_64-linux")))
- (wrap-program
- prog
- `("PERL5LIB" ":" prefix (,x11-inc ,tk-inc)))))
- %standard-phases)))
+ (modify-phases %standard-phases
+ (add-after 'install 'set-load-paths
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ ;; Put the perl-tk and perl-x11-protocol modules in the perl inc
+ ;; path for PROG
+ (let* ((out (assoc-ref outputs "out"))
+ (prog (string-append out "/bin/cssh"))
+ (perl-ver ,(package-version perl))
+ (x11-inc (string-append
+ (assoc-ref inputs "perl-x11-protocol")
+ "/lib/perl5/site_perl/" perl-ver))
+ (tk-inc (string-append
+ (assoc-ref inputs "perl-tk")
+ "/lib/perl5/site_perl/" perl-ver
+ "/x86_64-linux")))
+ (wrap-program
+ prog
+ `("PERL5LIB" ":" prefix (,x11-inc ,tk-inc))))
+ #t)))))
;; The clusterssh.sourceforge.net address requires login to view
(home-page "https://sourceforge.net/projects/clusterssh/")
(synopsis "Secure concurrent multi-server terminal control")
@@ -849,29 +850,30 @@ system administrator.")
;; Avoid non-determinism; see <http://bugs.gnu.org/21918>.
#:parallel-build? #f
- #:phases (alist-cons-before
- 'configure 'pre-configure
- (lambda _
- (substitute* "src/sudo_usage.h.in"
- ;; Do not capture 'configure' arguments since we would
- ;; unduly retain references, and also because the
- ;; CPPFLAGS above would close the string literal
- ;; prematurely.
- (("@CONFIGURE_ARGS@") "\"\""))
- (substitute* (find-files "." "Makefile\\.in")
- (("-o [[:graph:]]+ -g [[:graph:]]+")
- ;; Allow installation as non-root.
- "")
- (("^install: (.*)install-sudoers(.*)" _ before after)
- ;; Don't try to create /etc/sudoers.
- (string-append "install: " before after "\n"))
- (("\\$\\(DESTDIR\\)\\$\\(rundir\\)")
- ;; Don't try to create /run/sudo.
- "$(TMPDIR)/dummy")
- (("\\$\\(DESTDIR\\)\\$\\(vardir\\)")
- ;; Don't try to create /var/db/sudo.
- "$(TMPDIR)/dummy")))
- %standard-phases)
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'configure 'pre-configure
+ (lambda _
+ (substitute* "src/sudo_usage.h.in"
+ ;; Do not capture 'configure' arguments since we would
+ ;; unduly retain references, and also because the
+ ;; CPPFLAGS above would close the string literal
+ ;; prematurely.
+ (("@CONFIGURE_ARGS@") "\"\""))
+ (substitute* (find-files "." "Makefile\\.in")
+ (("-o [[:graph:]]+ -g [[:graph:]]+")
+ ;; Allow installation as non-root.
+ "")
+ (("^install: (.*)install-sudoers(.*)" _ before after)
+ ;; Don't try to create /etc/sudoers.
+ (string-append "install: " before after "\n"))
+ (("\\$\\(DESTDIR\\)\\$\\(rundir\\)")
+ ;; Don't try to create /run/sudo.
+ "$(TMPDIR)/dummy")
+ (("\\$\\(DESTDIR\\)\\$\\(vardir\\)")
+ ;; Don't try to create /var/db/sudo.
+ "$(TMPDIR)/dummy"))
+ #t)))
;; XXX: The 'testsudoers' test series expects user 'root' to exist, but
;; the chroot's /etc/passwd doesn't have it. Turn off the tests.
@@ -907,13 +909,14 @@ commands and their arguments.")
"0l0l5gz3d5j9bqjsbjlfcv4w4jwndllp9fmyai4x9kg6qhs6v4xl"))))
(build-system gnu-build-system)
(arguments
- '(#:phases (alist-replace
- 'configure
- (lambda* (#:key outputs #:allow-other-keys)
- (chdir "wpa_supplicant")
- (copy-file "defconfig" ".config")
- (let ((port (open-file ".config" "al")))
- (display "
+ '(#:phases
+ (modify-phases %standard-phases
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (chdir "wpa_supplicant")
+ (copy-file "defconfig" ".config")
+ (let ((port (open-file ".config" "al")))
+ (display "
CONFIG_DEBUG_SYSLOG=y
# Choose GnuTLS (the default is OpenSSL.)
@@ -923,26 +926,24 @@ commands and their arguments.")
CFLAGS += $(shell pkg-config libnl-3.0 --cflags)
CONFIG_LIBNL32=y
CONFIG_READLINE=y\n" port)
- (close-port port)))
-
- (alist-cons-after
- 'install 'install-man-pages
- (lambda* (#:key outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
- (man (string-append out "/share/man"))
- (man5 (string-append man "/man5"))
- (man8 (string-append man "/man8")))
- (define (copy-man-page target)
- (lambda (file)
- (install-file file target)))
-
- (mkdir-p man5) (mkdir man8)
- (for-each (copy-man-page man5)
- (find-files "doc/docbook" "\\.5"))
- (for-each (copy-man-page man8)
- (find-files "doc/docbook" "\\.8"))
- #t))
- %standard-phases))
+ (close-port port))
+ #t))
+ (add-after 'install 'instal
This message was truncated. Download the full message here.
Kei Kebreau wrote 8 years ago
[PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(address . 27898@debbugs.gnu.org)(name . Kei Kebreau)(address . kei@openmailbox.org)
20170801072153.19077-2-kei@openmailbox.org
* gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases
accordingly.
* gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss,
htslib-for-sambamba)[arguments]: Likewise.
* gnu/packages/ci.scm (cuirass)[arguments]: Likewise.
* gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise.
* gnu/packages/cpp.scm (libzen)[arguments]: Likewise.
* gnu/packages/crypto.scm (opendht)[arguments]: Likewise.
* gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise.
* gnu/packages/debug.scm (stress-make)[arguments]: Likewise.
* gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]:
Likewise.
* gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise.
* gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise.
* gnu/packages/engineering.scm (gerbv)[arguments]: Likewise.
* gnu/packages/erlang.scm (erlang)[arguments]: Likewise.
* gnu/packages/ftp.scm (weex)[arguments]: Likewise.
* gnu/packages/gnome.scm (dia)[arguments]: Likewise.
* gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise.
* gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise.
* gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]:
Likewise.
* gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise.
* gnu/packages/irc.scm (weechat)[arguments]: Likewise.
* gnu/packages/java.scm (classpath-devel)[arguments]: Likewise.
* gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise.
* gnu/packages/libusb.scm (hidapi)[arguments]: Likewise.
* gnu/packages/linux.scm (gpm)[arguments]: Likewise.
* gnu/packages/logging.scm (glog)[arguments]: Likewise.
* gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise.
* gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp)
[arguments]: Likewise.
* gnu/packages/maths.scm (wxmaxima)[arguments]: Likewise.
* gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]:
Likewise.
* gnu/packages/microcom.scm (microcom)[arguments]: Likewise.
* gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise.
* gnu/packages/parallel.scm (slurm)[arguments]: Likewise.
* gnu/packages/pdf.scm (libharu)[arguments]: Likewise.
* gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise.
* gnu/packages/serialization.scm (msgpack)[arguments]: Likewise.
* gnu/packages/shells.scm (scsh)[arguments]: Likewise.
* gnu/packages/telephony.scm (libiax2)[arguments]: Likewise.
* gnu/packages/textutils.scm (dotconf)[arguments]: Likewise.
* gnu/packages/version-control.scm (findnewest)[arguments]: Likewise.
* gnu/packages/video.scm (vlc, libmediainfo, mediainfo)[arguments]: Likewise.
---
gnu/packages/audio.scm | 6 ++---
gnu/packages/bioinformatics.scm | 20 +++++++++-------
gnu/packages/ci.scm | 7 ++++--
gnu/packages/compression.scm | 4 ++--
gnu/packages/cpp.scm | 8 +++----
gnu/packages/crypto.scm | 2 +-
gnu/packages/databases.scm | 6 ++---
gnu/packages/debug.scm | 2 +-
gnu/packages/dns.scm | 4 ++--
gnu/packages/emacs.scm | 2 +-
gnu/packages/embedded.scm | 4 ++--
gnu/packages/engineering.scm | 2 +-
gnu/packages/erlang.scm | 8 +++++--
gnu/packages/ftp.scm | 2 +-
gnu/packages/gnome.scm | 2 +-
gnu/packages/gnunet.scm | 6 ++---
gnu/packages/gtk.scm | 6 ++---
gnu/packages/guile.scm | 16 ++++++-------
gnu/packages/ibus.scm | 4 ++--
gnu/packages/irc.scm | 6 +++--
gnu/packages/java.scm | 2 +-
gnu/packages/libreoffice.scm | 4 ++--
gnu/packages/libusb.scm | 2 +-
gnu/packages/linux.scm | 4 ++--
gnu/packages/logging.scm | 2 +-
gnu/packages/machine-learning.scm | 8 +++----
gnu/packages/mail.scm | 12 +++++-----
gnu/packages/maths.scm | 49 +++++++++++++++++++--------------------
gnu/packages/messaging.scm | 10 ++++----
gnu/packages/microcom.scm | 2 +-
gnu/packages/ocaml.scm | 4 ++--
gnu/packages/parallel.scm | 4 ++--
gnu/packages/pdf.scm | 2 +-
gnu/packages/samba.scm | 2 +-
gnu/packages/serialization.scm | 2 +-
gnu/packages/shells.scm | 2 +-
gnu/packages/telephony.scm | 2 +-
gnu/packages/textutils.scm | 2 +-
gnu/packages/version-control.scm | 2 +-
gnu/packages/video.scm | 18 ++++++--------
40 files changed, 128 insertions(+), 124 deletions(-)

Toggle diff (361 lines)
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index e756fbf7c..08095e16d 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -328,7 +328,7 @@ engineers, musicians, soundtrack editors and composers.")
#:phases
(modify-phases %standard-phases
;; FFmpeg is only detected if autoreconf runs.
- (add-before 'configure 'autoreconf
+ (add-after 'unpack 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi")))))
;; The test suite is not "well exercised" according to the developers,
@@ -1975,8 +1975,8 @@ tempo and pitch of an audio recording independently of one another.")
(arguments
`(#:tests? #f ;no "check" target
#:phases (modify-phases %standard-phases
- (add-before
- 'configure 'autoconf
+ (add-after
+ 'unpack 'autoconf
(lambda _ (zero? (system* "autoreconf" "-vfi"))))
(add-before
'build 'fix-makefile
diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 02250dfaf..d205e296f 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -3444,7 +3444,7 @@ sequences).")
(("^#include \"kseq\\.h\"")
"#include \"htslib/kseq.h\""))
#t))
- (add-before 'configure 'autoconf
+ (add-after 'unpack 'autoconf
(lambda _ (zero? (system* "autoconf")))))))
(native-inputs
`(("autoconf" ,autoconf)
@@ -4479,9 +4479,11 @@ distribution, coverage uniformity, strand specificity, etc.")
"Data2DB"
"PCL2Bin")))
(modify-phases %standard-phases
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
(lambda _
- (zero? (system* "bash" "gen_auto"))))
+ (substitute* "gen_tools_am"
+ (("/usr/bin/env perl") (which "perl")))
+ (zero? (system* "sh" "gen_auto"))))
(add-after 'build 'build-additional-tools
(lambda* (#:key make-flags #:allow-other-keys)
(every (lambda (dir)
@@ -6095,8 +6097,8 @@ track. The database is exposed as a @code{TxDb} object.")
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autogen
- (lambda _ (zero? (system* "autoreconf" "-vif")))))))
+ (add-after 'unpack 'autogen
+ (lambda _ (zero? (system* "autoreconf" "-vif")))))))
(inputs
`(("zlib" ,zlib)
("bzip2" ,bzip2)
@@ -8274,6 +8276,8 @@ the available RAM.")
(assoc-ref %build-inputs "libharu")))
#:phases
(modify-phases %standard-phases
+ (add-after 'unpack 'autogen
+ (lambda _ (zero? (system* "autoreconf" "-vif"))))
(add-after 'unpack 'fix-checks
(lambda _
;; The PNGDRIVER tests check for the presence of libgd, libpng
@@ -8291,9 +8295,7 @@ AM_CONDITIONAL(AMPNG, true)"))
;; looking for updates will not work.
(substitute* "Makefile.am"
(("\\$\\(bindir\\)/embossupdate") ""))
- #t))
- (add-before 'configure 'autogen
- (lambda _ (zero? (system* "autoreconf" "-vif")))))))
+ #t)))))
(inputs
`(("perl" ,perl)
("libpng" ,libpng)
@@ -9191,7 +9193,7 @@ global-scaling and full-quantile normalization.")
(substitute-keyword-arguments (package-arguments htslib)
((#:phases phases)
`(modify-phases ,phases
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
(lambda _
(zero? (system* "autoreconf" "-vif"))))))))
(native-inputs
diff --git a/gnu/packages/ci.scm b/gnu/packages/ci.scm
index e2cb712bf..32e7e6e16 100644
--- a/gnu/packages/ci.scm
+++ b/gnu/packages/ci.scm
@@ -215,8 +215,11 @@ their dependencies.")
(substitute* "Makefile.am"
(("tests/repo.scm \\\\") "\\"))
#t))
- (add-before 'configure 'bootstrap
- (lambda _ (zero? (system* "sh" "bootstrap"))))
+ (add-after 'disable-repo-tests 'bootstrap
+ (lambda _
+ (substitute* "build-aux/git-version-gen"
+ (("/bin/sh") (which "sh")))
+ (zero? (system* "sh" "bootstrap"))))
(add-after 'install 'wrap-program
(lambda* (#:key inputs outputs #:allow-other-keys)
;; Wrap the 'cuirass' command to refer to the right modules.
diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 2a9ccd167..a28a31572 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -114,7 +114,7 @@ in compression.")
(modify-phases %standard-phases
(add-after 'unpack 'enter-source
(lambda _ (chdir "contrib/minizip") #t))
- (add-before 'configure 'autoreconf
+ (add-after 'enter-source 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vif")))))))
(native-inputs
@@ -960,7 +960,7 @@ respectively, based on the reference implementation from Google.")
(modify-phases %standard-phases
(add-after 'unpack 'enter-build-directory
(lambda _ (chdir "xdelta3")))
- (add-before 'configure 'autoconf
+ (add-after 'enter-build-directory 'autoconf
(lambda _ (zero? (system* "autoreconf" "-vfi")))))))
(home-page "http://xdelta.com")
(synopsis "Delta encoder for binary files")
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index da192553a..a1289ec21 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -45,12 +45,10 @@
'(#:phases
;; build scripts not in root of archive
(modify-phases %standard-phases
- (add-before 'configure 'pre-configure
+ (add-after 'unpack 'autogen
(lambda _
- (chdir "Project/GNU/Library")))
- (add-before 'configure 'autogen
- (lambda _
- (zero? (system* "./autogen.sh")))))))
+ (chdir "Project/GNU/Library")
+ (zero? (system* "sh" "autogen.sh")))))))
(home-page "https://github.com/MediaArea/ZenLib")
(synopsis "C++ utility library")
(description "ZenLib is a C++ utility library. It includes classes for handling
diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm
index d02bc20f2..fa8ecf831 100644
--- a/gnu/packages/crypto.scm
+++ b/gnu/packages/crypto.scm
@@ -160,7 +160,7 @@ OpenBSD tool of the same name.")
(arguments
`(#:configure-flags '("--disable-tools" "--disable-python")
#:phases (modify-phases %standard-phases
- (add-before 'configure 'autoconf
+ (add-after 'unpack 'autoconf
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(home-page "https://github.com/savoirfairelinux/opendht/")
diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 655c6db18..4d231a045 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -114,9 +114,9 @@
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'generate-configure
+ (add-after 'unpack 'autogen
(lambda _
- (zero? (system* "./autogen.sh")))))))
+ (zero? (system* "sh" "autogen.sh")))))))
;; http://www.4store.org has been down for a while now.
(home-page "https://github.com/garlik/4store")
(synopsis "Clustered RDF storage and query engine")
@@ -1559,7 +1559,7 @@ for ODBC.")
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autoreconf
+ (add-after 'unpack 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(home-page "http://mdbtools.sourceforge.net/")
diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 1dab0085c..017e81656 100644
--- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -300,7 +300,7 @@ down the road.")
(zero? (system* "tar" "cJf" "./make.tar.xz"
(string-append "make-"
,(package-version gnu-make))))))
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(home-page "https://github.com/losalamos/stress-make")
diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 64fdc9c3e..ce2f4d81b 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -181,7 +181,7 @@ high-volume and high-reliability applications. The name BIND stands for
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autoreconf
+ (add-after 'unpack 'autoreconf
(lambda _
;; Re-generate build files due to unbundling ltdl.
;; TODO: Prevent generating new libltdl and building it.
@@ -229,7 +229,7 @@ servers is included, and an up-to-date version is available at
#:tests? #f
#:phases
(modify-phases %standard-phases
- (add-before 'configure 'create-configure
+ (add-after 'unpack 'create-configure
(lambda _
(zero? (system* "make" "configure")))))))
(native-inputs
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index b77abc778..11eebc063 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1274,7 +1274,7 @@ single buffer.")
;; Build server side using 'gnu-build-system'.
(add-after 'unpack 'enter-server-dir
(lambda _ (chdir "server") #t))
- (add-before 'configure 'autogen
+ (add-after 'enter-server-dir 'autogen
(lambda _
(zero? (system* "bash" "autogen.sh"))))
diff --git a/gnu/packages/embedded.scm b/gnu/packages/embedded.scm
index e509647ea..d3bd99274 100644
--- a/gnu/packages/embedded.scm
+++ b/gnu/packages/embedded.scm
@@ -316,7 +316,7 @@ languages are C and C++.")
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autoreconf
+ (add-after 'unpack 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(home-page "http://repo.or.cz/w/libjaylink.git")
@@ -400,7 +400,7 @@ language.")
"presto" "openjtag")))
#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autoreconf
+ (add-after 'unpack 'autoreconf
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(home-page "http://openocd.org")
diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 28d9a718e..1d133b966 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -483,7 +483,7 @@ ready for production.")
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'autoconf
+ (add-after 'unpack 'autoconf
(lambda _
;; Build rules contain references to Russian translation, but the
;; needed files are missing; see
diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
index a400e712d..519100849 100644
--- a/gnu/packages/erlang.scm
+++ b/gnu/packages/erlang.scm
@@ -124,6 +124,12 @@
(("\\{H,Mi,S\\} = time\\(\\),")
(date->string source-date-epoch
"{H,Mi,S} = {~H,~M,~S},"))))))
+ (add-after 'unpack 'autoconf
+ (lambda _
+ (substitute* '("erts/autoconf/config.guess"
+ "erts/autoconf/install-sh")
+ (("/bin/sh") (which "sh")))
+ (zero? (system* "sh" "otp_build" "autoconf"))))
(add-after 'patch-source-shebangs 'patch-source-env
(lambda _
(let ((escripts
@@ -143,8 +149,6 @@
(add-before 'configure 'set-erl-top
(lambda _
(setenv "ERL_TOP" (getcwd))))
- (add-before 'configure 'autoconf
- (lambda _ (zero? (system* "./otp_build" "autoconf"))))
(add-after 'install 'patch-erl
;; This only works after install.
(lambda _
diff --git a/gnu/packages/ftp.scm b/gnu/packages/ftp.scm
index 49e721499..5563b6473 100644
--- a/gnu/packages/ftp.scm
+++ b/gnu/packages/ftp.scm
@@ -159,7 +159,7 @@ FTP browser, as well as non-interactive commands such as 'ncftpput' and
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
(lambda _ (zero? (system* "autoreconf" "-vfi")))))))
(home-page "http://weex.sourceforge.net/")
(synopsis "Non-interactive client for FTP synchronization")
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index f40381498..7f5fadb79 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -310,7 +310,7 @@ either on a local, or remote machine via a number of methods.")
(arguments
`(#:phases
(modify-phases %standard-phases
- (add-before 'configure 'run-autogen
+ (add-after 'unpack 'run-autogen
(lambda _
(system* "sh" "autogen.sh"))))))
(home-page "https://wiki.gnome.org/Apps/Dia")
diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 9ca2d9502..6902461e4 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -234,10 +234,10 @@ and support for SSL3 and TLS.")
(rename-file (string-append out "/share/man/man3")
(string-append doc "/share/man/man3"))
#t)))
- (add-before 'configure 'autoconf
+ (add-after 'unpack 'autoconf
;; Clear artifacts left (shebangs) from release preparation.
(lambda _
- (zero? (system* "./buildconf"))))
+ (zero? (system* "sh" "buildconf"))))
(replace 'check
(lambda _
;; It is unclear why test1026 fails, however the content of it
@@ -345,7 +345,7 @@ kinds of basic applications for the foundation of a GNU internet.")
(build-system gnu-build-system)
(arguments
'(#:phases (modify-phases %standard-phases
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
(lambda _
(zero? (system* "autoreconf" "-vfi")))))))
(native-inputs `(("pkg-config" ,pkg-config)
diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 11e2ace98..12319ac76 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -839,7 +839,7 @@ exceptions, macros, and a dynamic programming environment.")
(build-system gnu-build-system)
(arguments
`(#:phases (modify-phases %standard-phases
- (add-before 'configure 'bootstrap
+ (add-after 'unpack 'bootstrap
This message was truncated. Download the full message here.
Marius Bakke wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(name . Kei Kebreau)(address . kei@openmailbox.org)
87mv7hwzqu.fsf@fastmail.com
Kei Kebreau <kei@openmailbox.org> writes:

Toggle quote (187 lines)
> * gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
> 'modify-phases' syntax.
> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
> [arguments]: Likewise.
> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
> [arguments]: Likewise.
> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
> module-init-tools)[arguments]: Likewise.
> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
> suitesparse)[arguments]: Likewise.
> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
> Likewise.
> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
> Likewise.
> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
> Likewise.
> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
> python-sqlalchemy, python-docopt)[arguments]: Likewise.
> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
> Likewise.
> * gnu/packages/time.scm (time)[arguments]: Likewise.
> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
> ---
> gnu/packages/admin.scm | 294 ++++++++++++++---------------
> gnu/packages/algebra.scm | 31 ++--
> gnu/packages/apr.scm | 25 ++-
> gnu/packages/audio.scm | 193 +++++++++----------
> gnu/packages/backup.scm | 33 ++--
> gnu/packages/bioinformatics.scm | 250 +++++++++++++------------
> gnu/packages/bittorrent.scm | 33 ++--
> gnu/packages/cdrom.scm | 2 +-
> gnu/packages/compression.scm | 16 +-
> gnu/packages/conky.scm | 31 ++--
> gnu/packages/databases.scm | 102 +++++-----
> gnu/packages/debug.scm | 70 +++----
> gnu/packages/display-managers.scm | 22 +--
> gnu/packages/dns.scm | 2 +-
> gnu/packages/docbook.scm | 26 +--
> gnu/packages/emacs.scm | 74 ++++----
> gnu/packages/engineering.scm | 43 +++--
> gnu/packages/firmware.scm | 48 ++---
> gnu/packages/flashing-tools.scm | 21 +--
> gnu/packages/fltk.scm | 42 ++---
> gnu/packages/freedesktop.scm | 33 ++--
> gnu/packages/gd.scm | 19 +-
> gnu/packages/gimp.scm | 30 +--
> gnu/packages/gkrellm.scm | 4 +-
> gnu/packages/gl.scm | 2 +-
> gnu/packages/glib.scm | 33 ++--
> gnu/packages/gnome.scm | 145 +++++++--------
> gnu/packages/gprolog.scm | 17 +-
> gnu/packages/gps.scm | 19 +-
> gnu/packages/graphics.scm | 13 +-
> gnu/packages/gtk.scm | 80 ++++----
> gnu/packages/guile-wm.scm | 81 ++++----
> gnu/packages/guile.scm | 36 ++--
> gnu/packages/hugs.scm | 61 +++---
> gnu/packages/hurd.scm | 60 +++---
> gnu/packages/image-viewers.scm | 14 +-
> gnu/packages/libcanberra.scm | 18 +-
> gnu/packages/libsigsegv.scm | 13 +-
> gnu/packages/linux.scm | 379 +++++++++++++++++++-------------------
> gnu/packages/lisp.scm | 61 +++---
> gnu/packages/lout.scm | 142 +++++++-------
> gnu/packages/lua.scm | 2 +-
> gnu/packages/machine-learning.scm | 88 +++++----
> gnu/packages/mail.scm | 90 ++++-----
> gnu/packages/man.scm | 4 +-
> gnu/packages/maths.scm | 119 ++++++------
> gnu/packages/messaging.scm | 27 ++-
> gnu/packages/mp3.scm | 87 ++++-----
> gnu/packages/music.scm | 102 +++++-----
> gnu/packages/noweb.scm | 79 ++++----
> gnu/packages/patchutils.scm | 120 ++++++------
> gnu/packages/pdf.scm | 69 +++----
> gnu/packages/perl.scm | 31 ++--
> gnu/packages/photo.scm | 15 +-
> gnu/packages/popt.scm | 17 +-
> gnu/packages/pretty-print.scm | 65 +++----
> gnu/packages/pumpio.scm | 32 ++--
> gnu/packages/python.scm | 47 +++--
> gnu/packages/rdf.scm | 40 ++--
> gnu/packages/regex.scm | 20 +-
> gnu/packages/rrdtool.scm | 19 +-
> gnu/packages/ruby.scm | 40 ++--
> gnu/packages/sawfish.scm | 50 ++---
> gnu/packages/scheme.scm | 134 +++++++-------
> gnu/packages/sdl.scm | 46 ++---
> gnu/packages/serveez.scm | 15 +-
> gnu/packages/skribilo.scm | 29 +--
> gnu/packages/smalltalk.scm | 17 +-
> gnu/packages/suckless.scm | 4 +-
> gnu/packages/tcl.scm | 15 +-
> gnu/packages/telephony.scm | 12 +-
> gnu/packages/textutils.scm | 25 ++-
> gnu/packages/time.scm | 19 +-
> gnu/packages/tor.scm | 14 +-
> gnu/packages/uucp.scm | 24 +--
> gnu/packages/video.scm | 9 +-
> gnu/packages/web-browsers.scm | 10 +-
> gnu/packages/web.scm | 15 +-
> gnu/packages/wicd.scm | 214 +++++++++++----------
> gnu/packages/wm.scm | 2 +-
> gnu/packages/xdisorg.scm | 5 +-
> gnu/packages/xfce.scm | 23 +--
> gnu/packages/xfig.scm | 75 ++++----
> gnu/packages/xorg.scm | 39 ++--
> 84 files changed, 2253 insertions(+), 2274 deletions(-)

Wow! That is a lot of code to review at once. Can you split this into
maybe one patch per file? I guess some can be consolidated, but we
should try to make each patch easily digestible both for current and
future code reviewers. Hopefully we can alternate on the LGTMs.

It would be good to have this as a "slow-rolling" change on 'master' as
well since it will likely cause a lot of rebuilds.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmCJAoACgkQoqBt8qM6
VPorQgf+IHey/KNBijy2p2CUlWGG/LsRNIPlwW+/CrksMopf28a6wTTmvb47ZB5M
HajvQgWIc8zpkmBEc7yfF/0PX5M5nCquHifTCVDfQp6956PVfdnx3GwMDPe/JuBV
rz0fkiALoIhHNGQtnXVZipXMEFxpnnreSQTFRCvJw95adwL31EosOVYCpyNWjybQ
zPgUO8rzNiIK61QzbWogiLQjs1vO7YUMYRuhuxQk0QRUlcpEhnfegc9sYJfRhhBQ
Mz89ZscGfBGgtanF2XZvmL3Oa455o7ApWDRs+Cgs8ziMF5Pnn/3CMdi2s1FYgeG1
WbFSDQ2JkKDl6QX6hpyVE96ZkJs5Qw==
=63LA
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
Re: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(name . Kei Kebreau)(address . kei@openmailbox.org)
87k22lwys2.fsf@fastmail.com
Kei Kebreau <kei@openmailbox.org> writes:

Toggle quote (47 lines)
> * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases
> accordingly.
> * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss,
> htslib-for-sambamba)[arguments]: Likewise.
> * gnu/packages/ci.scm (cuirass)[arguments]: Likewise.
> * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise.
> * gnu/packages/cpp.scm (libzen)[arguments]: Likewise.
> * gnu/packages/crypto.scm (opendht)[arguments]: Likewise.
> * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise.
> * gnu/packages/debug.scm (stress-make)[arguments]: Likewise.
> * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]:
> Likewise.
> * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise.
> * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise.
> * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise.
> * gnu/packages/erlang.scm (erlang)[arguments]: Likewise.
> * gnu/packages/ftp.scm (weex)[arguments]: Likewise.
> * gnu/packages/gnome.scm (dia)[arguments]: Likewise.
> * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise.
> * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise.
> * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]:
> Likewise.
> * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise.
> * gnu/packages/irc.scm (weechat)[arguments]: Likewise.
> * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise.
> * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise.
> * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise.
> * gnu/packages/linux.scm (gpm)[arguments]: Likewise.
> * gnu/packages/logging.scm (glog)[arguments]: Likewise.
> * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise.
> * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp)
> [arguments]: Likewise.
> * gnu/packages/maths.scm (wxmaxima)[arguments]: Likewise.
> * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]:
> Likewise.
> * gnu/packages/microcom.scm (microcom)[arguments]: Likewise.
> * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise.
> * gnu/packages/parallel.scm (slurm)[arguments]: Likewise.
> * gnu/packages/pdf.scm (libharu)[arguments]: Likewise.
> * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise.
> * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise.
> * gnu/packages/shells.scm (scsh)[arguments]: Likewise.
> * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise.
> * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise.
> * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise.
> * gnu/packages/video.scm (vlc, libmediainfo, mediainfo)[arguments]: Likewise.

Phew! This too will cause a lot of rebuilds, but I guess we could put it
on 'staging'. It would have to be committed just before starting it to
reduce the amount of merge conflicts.

That said, I'm not sure how necessary this change is, but I don't have a
strong argument against it. Other opinions welcome!

Maybe we could add an '#:autoreconf?' parameter to gnu-build-system,
which runs `autoreconf -vif` in a phase and automatically pulls in
automake and autoconf (and probably also libtool). Thoughts?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmCKO4ACgkQoqBt8qM6
VPqc+wgAui46n+dW54eu4RjT+XAsX7CO22KUvOqyxQ9bwMcJNnTAx5u7yN1mQViC
XY/WYIqhPFTYd37LDeYxxCmqffh77oIa2cV2/E3iM7/8f9DoAjj9cFsYmGGz2EV1
9X5IbDvgN7oaingWPFwjVVhn84otX4/37ZRud0T1GfVQGtDzmTfauZwXptoRIcM+
lfFQ89kkmSyN5a1pJ5qrGJA4HE8IbbD8mA+fuMGAE+VU1hqKVhVIRIj1sS9o71tZ
YPLXvisaQzf6uDLbicDeBhNVNLSaP0qoefBtwOHKN/e1wjl6/9hEWVNHRj4DiM/S
OoFooYim5xZ7bdADbG7fJLx4bYCV1g==
=ajo3
-----END PGP SIGNATURE-----

Leo Famulari wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(name . Marius Bakke)(address . mbakke@fastmail.com)
20170802194148.GB13105@jasmine.lan
Attachment: file
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmCKvkACgkQJkb6MLrK
fwj/ug//aWw/PgctQqH4BV7J1vhi0Loil81wWuI1MVVXpXxfg6Pfx+OiYbz49vxH
3lBOr4SMq5IFJws6SEl+oJjzyPRckMSI3CN584LOWFZ2ygXp5ebmt6eOLODtmV/b
Cl9u4zOFeqqcHmsW8JRKAPMo25OXrR/qLEHmOQgd8IM0mzrX01kSs02Nnop9C6T7
3WjDBdKlmNvImuuz0zMdWyr0gfYmZ9ME5WUpLI+YCCz/GVotz+vLGrtDKKvBkrHp
ImCMJvsfAmS18OCMsnLNWEyxJ9+YR4/HcRmC36xVlp3JK89NKgjesf0XyyzMD/Dw
dUu/zuQ+oTSxle+7ME9VlrVq7N/h/g/BrbiCEvyg7lhfqVKjWGuwj5O99PdA2z9P
3+3mbz9anhQJlBOfIkYRSvjAwO/OhYYvcQZaUjDS1irU+O/DOZJR/bkkqJNjoJDv
8T2miBTZCXqRlmvFf8pcEwUNexiUKeYUgYGIA1IG2cl7SSpt0y7z2JpL8T696ckt
QUAOrE9z7SWNnyyy5Pg/8DgPLXErU9BXpc+Vv0jYljWLGFhcIUUeMi4/2GK11JqM
Zkw78EWk894f7IQ8AGyoXvy60kgXeY+hO8f/Chf5Ef2DgApj4U3ChKdm45p2dAU1
IwrwTSDY2hUSs3IHxYaAz7BySs/iAUdNt+vynuDREz9Nck9yc1U=
=GPnN
-----END PGP SIGNATURE-----


Leo Famulari wrote 8 years ago
Re: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(name . Marius Bakke)(address . mbakke@fastmail.com)
20170802194515.GC13105@jasmine.lan
On Wed, Aug 02, 2017 at 09:33:01PM +0200, Marius Bakke wrote:
Toggle quote (2 lines)
> Kei Kebreau <kei@openmailbox.org> writes:

[... move autoconf phases ...]

Toggle quote (4 lines)
> Phew! This too will cause a lot of rebuilds, but I guess we could put it
> on 'staging'. It would have to be committed just before starting it to
> reduce the amount of merge conflicts.

Agreed

Toggle quote (3 lines)
> That said, I'm not sure how necessary this change is, but I don't have a
> strong argument against it. Other opinions welcome!

I guess there is a correct ordering and an incorrect ordering, depending
on whether or not these phases should happen before or after the shebang
patching phases. Does it work if it happens before the shebangs are
patched?

Toggle quote (4 lines)
> Maybe we could add an '#:autoreconf?' parameter to gnu-build-system,
> which runs `autoreconf -vif` in a phase and automatically pulls in
> automake and autoconf (and probably also libtool). Thoughts?

Interesting!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmCK8sACgkQJkb6MLrK
fwihpg//dTXp/80wCpsaM3gjZ39Ak+rFPIKyPe0eC5DhhrH64/Q9pdpfngS6y9Xw
bNPR1+vEGmK+NAE0TQb3g4cWfntdi1iTnucPJs1kzZ8YwVG+vb1+BvOLfol+QeVg
wtATnNbof1gXL3DsadCp52SYPQBniJSwLEX7+er+u1UpyamZBQG1Ez65wN4fDZmA
k2XaXcQ9FB/ZuTJ0HvbqbmUujJ2MBLAOiozShUsCCysjcAJ2eW+dAc9j+2mFlaLz
7HKgHoogqYVXC/EcrH7JMYP7PqYpw3FARY9nJcGhwNiH3tYAKzyG2hwgcd9CgU3T
YE7GrHy844dRFOHqyWiYey6DcQO9iupfW1s88hs/0Df03pqMhQILC48drPZCz+m8
rtLHYO3frwCnmRT5K3QZE78lJvqtmsw7UMUBAZnpeuBiGUgLG4AqLVIfTIf08Mbl
tKDz6hphaMSe2mIeDJ8JB1dMyhF44L6n08ObmSlGVRDLnuDyCSKjDES8gFq9MCJw
IbTY2tmQJY2MRJX0vqTzcmbx+fezG0S1p12jne2LSccUEdnqBr6Qap5l1P9zAXXD
oSml4jP72v+4E9MUbU4smk1VsdosddapeiwMbra+yqBfXaOYNtMzDxIm4mXAUoYG
pY1Z9BFWjkSTT4c4FZ9QspuZPNO1bCiv5M79GbPFp/6UKxfk/NE=
=w0hW
-----END PGP SIGNATURE-----


Marius Bakke wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(name . Leo Famulari)(address . leo@famulari.name)
87fud9wx59.fsf@fastmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (207 lines)
> On Wed, Aug 02, 2017 at 09:12:09PM +0200, Marius Bakke wrote:
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>> > * gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
>> > wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>> > 'modify-phases' syntax.
>> > * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>> > * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>> > * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>> > lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>> > zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>> > * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>> > * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>> > flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>> > * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>> > * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>> > * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>> > * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>> > * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>> > * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>> > * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>> > * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>> > * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>> > * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>> > * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>> > * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>> > * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>> > * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>> > * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>> > * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>> > * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>> > * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>> > * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>> > * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>> > libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>> > * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>> > * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>> > * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>> > * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
>> > [arguments]: Likewise.
>> > * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>> > * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>> > * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>> > * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>> > [arguments]: Likewise.
>> > * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>> > * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>> > * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>> > * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>> > unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>> > module-init-tools)[arguments]: Likewise.
>> > * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>> > * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>> > * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>> > * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>> > * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>> > * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>> > * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>> > suitesparse)[arguments]: Likewise.
>> > * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>> > * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>> > * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>> > * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>> > * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>> > Likewise.
>> > * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>> > zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>> > * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>> > Likewise.
>> > * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>> > * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>> > * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>> > Likewise.
>> > * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>> > * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>> > python-sqlalchemy, python-docopt)[arguments]: Likewise.
>> > * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>> > * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>> > * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>> > * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>> > * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>> > * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>> > * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>> > * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>> > * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>> > * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>> > * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>> > * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>> > * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>> > * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>> > Likewise.
>> > * gnu/packages/time.scm (time)[arguments]: Likewise.
>> > * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>> > * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>> > * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>> > * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>> > * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>> > * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>> > * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>> > * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>> > * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>> > * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>> > * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>> > ---
>> > gnu/packages/admin.scm | 294 ++++++++++++++---------------
>> > gnu/packages/algebra.scm | 31 ++--
>> > gnu/packages/apr.scm | 25 ++-
>> > gnu/packages/audio.scm | 193 +++++++++----------
>> > gnu/packages/backup.scm | 33 ++--
>> > gnu/packages/bioinformatics.scm | 250 +++++++++++++------------
>> > gnu/packages/bittorrent.scm | 33 ++--
>> > gnu/packages/cdrom.scm | 2 +-
>> > gnu/packages/compression.scm | 16 +-
>> > gnu/packages/conky.scm | 31 ++--
>> > gnu/packages/databases.scm | 102 +++++-----
>> > gnu/packages/debug.scm | 70 +++----
>> > gnu/packages/display-managers.scm | 22 +--
>> > gnu/packages/dns.scm | 2 +-
>> > gnu/packages/docbook.scm | 26 +--
>> > gnu/packages/emacs.scm | 74 ++++----
>> > gnu/packages/engineering.scm | 43 +++--
>> > gnu/packages/firmware.scm | 48 ++---
>> > gnu/packages/flashing-tools.scm | 21 +--
>> > gnu/packages/fltk.scm | 42 ++---
>> > gnu/packages/freedesktop.scm | 33 ++--
>> > gnu/packages/gd.scm | 19 +-
>> > gnu/packages/gimp.scm | 30 +--
>> > gnu/packages/gkrellm.scm | 4 +-
>> > gnu/packages/gl.scm | 2 +-
>> > gnu/packages/glib.scm | 33 ++--
>> > gnu/packages/gnome.scm | 145 +++++++--------
>> > gnu/packages/gprolog.scm | 17 +-
>> > gnu/packages/gps.scm | 19 +-
>> > gnu/packages/graphics.scm | 13 +-
>> > gnu/packages/gtk.scm | 80 ++++----
>> > gnu/packages/guile-wm.scm | 81 ++++----
>> > gnu/packages/guile.scm | 36 ++--
>> > gnu/packages/hugs.scm | 61 +++---
>> > gnu/packages/hurd.scm | 60 +++---
>> > gnu/packages/image-viewers.scm | 14 +-
>> > gnu/packages/libcanberra.scm | 18 +-
>> > gnu/packages/libsigsegv.scm | 13 +-
>> > gnu/packages/linux.scm | 379 +++++++++++++++++++-------------------
>> > gnu/packages/lisp.scm | 61 +++---
>> > gnu/packages/lout.scm | 142 +++++++-------
>> > gnu/packages/lua.scm | 2 +-
>> > gnu/packages/machine-learning.scm | 88 +++++----
>> > gnu/packages/mail.scm | 90 ++++-----
>> > gnu/packages/man.scm | 4 +-
>> > gnu/packages/maths.scm | 119 ++++++------
>> > gnu/packages/messaging.scm | 27 ++-
>> > gnu/packages/mp3.scm | 87 ++++-----
>> > gnu/packages/music.scm | 102 +++++-----
>> > gnu/packages/noweb.scm | 79 ++++----
>> > gnu/packages/patchutils.scm | 120 ++++++------
>> > gnu/packages/pdf.scm | 69 +++----
>> > gnu/packages/perl.scm | 31 ++--
>> > gnu/packages/photo.scm | 15 +-
>> > gnu/packages/popt.scm | 17 +-
>> > gnu/packages/pretty-print.scm | 65 +++----
>> > gnu/packages/pumpio.scm | 32 ++--
>> > gnu/packages/python.scm | 47 +++--
>> > gnu/packages/rdf.scm | 40 ++--
>> > gnu/packages/regex.scm | 20 +-
>> > gnu/packages/rrdtool.scm | 19 +-
>> > gnu/packages/ruby.scm | 40 ++--
>> > gnu/packages/sawfish.scm | 50 ++---
>> > gnu/packages/scheme.scm | 134 +++++++-------
>> > gnu/packages/sdl.scm | 46 ++---
>> > gnu/packages/serveez.scm | 15 +-
>> > gnu/packages/skribilo.scm | 29 +--
>> > gnu/packages/smalltalk.scm | 17 +-
>> > gnu/packages/suckless.scm | 4 +-
>> > gnu/packages/tcl.scm | 15 +-
>> > gnu/packages/telephony.scm | 12 +-
>> > gnu/packages/textutils.scm | 25 ++-
>> > gnu/packages/time.scm | 19 +-
>> > gnu/packages/tor.scm | 14 +-
>> > gnu/packages/uucp.scm | 24 +--
>> > gnu/packages/video.scm | 9 +-
>> > gnu/packages/web-browsers.scm | 10 +-
>> > gnu/packages/web.scm | 15 +-
>> > gnu/packages/wicd.scm | 214 +++++++++++----------
>> > gnu/packages/wm.scm | 2 +-
>> > gnu/packages/xdisorg.scm | 5 +-
>> > gnu/packages/xfce.scm | 23 +--
>> > gnu/packages/xfig.scm | 75 ++++----
>> > gnu/packages/xorg.scm | 39 ++--
>> > 84 files changed, 2253 insertions(+), 2274 deletions(-)
>>
>> Wow! That is a lot of code to review at once. Can you split this into
>> maybe one patch per file? I guess some can be consolidated, but we
>> should try to make each patch easily digestible both for current and
>> future code reviewers. Hopefully we can alternate on the LGTMs.
>
> I agree, wow! Thanks for this. It should help new Schemers to feel more
> comfortable editing packages.
>
> This might be annoying but it should wait until after the core-updates
> branch is done and merged into the master branch. I want to minimize the
> number of merge conflicts because they are 1) annoying and 2) relatively
> opaque when reading the Git history. Marius's suggestion is another good
> one, and would help with issues like that.
>
> But if we were to wait until after core-updates and push it as one
> commit, I wouldn't mind. It's up to the two of you and everyone else :)

Yeah I guess the squashed patch is okay. If we delay the patches until
after 'staging' and 'python-updates' as well, no merge will be
necessary. But it won't be a pretty cherry-pick either, by then.

I don't really have a strong opinion either way. But I'd hate to the one
resolving potentially 100s of merge conflicts at once ;-) Cherry-picking
at least restricts the set of conflicts to these changes.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmCMTIACgkQoqBt8qM6
VPqiBQf9HX4C2mgla8D4T/5+qRev8Jdb9VsZiZNoCKPgAt45QmbBP0PENR6pyi5a
Atflq3DMlInlfU7LZTjx8fjXqsbb+cszanpaBtFdOjBFziDP8CXU/xeCUD/LGrSv
oufPDu4+uAvWkB6pVYXrbyG8PIZOQoJEGFL9iigZv9tISkWIrrewMT+5X3NVV957
6zLMoQlTjcPklHkhxtZr8c3UXEOYsT0OeqXhtzIIqQX5ihqvBPMdAW0FmAi3arQ9
QnTgeLvzSm4zKC9O/hPrO8sVgmmxtL+z5hR+tA78qGLL2DGIswjmxABOpTo3FyHh
ZeNQEB9ToXuSqGfDtpP8+z5QIXf9Pw==
=RaoE
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
Re: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(name . Leo Famulari)(address . leo@famulari.name)
87k22l4sqb.fsf@openmailbox.org
Leo Famulari <leo@famulari.name> writes:

Toggle quote (20 lines)
> On Wed, Aug 02, 2017 at 09:33:01PM +0200, Marius Bakke wrote:
>> Kei Kebreau <kei@openmailbox.org> writes:
>
> [... move autoconf phases ...]
>
>> Phew! This too will cause a lot of rebuilds, but I guess we could put it
>> on 'staging'. It would have to be committed just before starting it to
>> reduce the amount of merge conflicts.
>
> Agreed
>
>> That said, I'm not sure how necessary this change is, but I don't have a
>> strong argument against it. Other opinions welcome!
>
> I guess there is a correct ordering and an incorrect ordering, depending
> on whether or not these phases should happen before or after the shebang
> patching phases. Does it work if it happens before the shebangs are
> patched?
>

What does the "it" in "does it work" mean here? If you mean the
builds themselves, then no. Success isn't guaranteed because the
configure scripts might not be patched, as the patching phases are
finished before the "build" phases. This change ensures that the
"patch-usr-bin-file" phase can operate on generated configure scripts if
necessary:


Toggle quote (6 lines)
>> Maybe we could add an '#:autoreconf?' parameter to gnu-build-system,
>> which runs `autoreconf -vif` in a phase and automatically pulls in
>> automake and autoconf (and probably also libtool). Thoughts?
>
> Interesting!

I agree. It would cut down on repetitive, common code and potential for
"autoreconf-ing" incorrectly.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmCNowACgkQ5qXuPBlG
eg2QOw/9Hf6PV2ZIZa+r2fzbhx4xFKEyJAPG21/YtL6rEsLze3Mdm+AFFHQ+6Lkr
96mdBi3Xqz68aINITUiCtqwmx4kf428E0ntz4k2U2eAXzDnfswQxLVjKxjRaxJl8
zfG3TAklZdJr4dhm5oatJK6Lp+4SG+/5/T041vPRNWGkHoW4Qek8KARltkILxpAr
FfJwHwhikId8749f7Gnz54h1o4W+/waPg1st+AcHf7y9XVI/fHJxccJUcGfWne2S
nIFFs08yy7krqE89oWauH3xD0Ya3JHZjFlBCoJs5FOSupyY2eXB7lv4HlSeRMjH+
3ZxXUIcv4lGqdoP23G7mxVe+cNxWFnimp5GJbwIpWsSF5nuuHrzaAcV2sAPS5m3T
YNSvO7r9OCIoezvC4O7ICuWYRnGgsA2C0dHcCEAq12lHEQheItFvDSOemN6EbkzL
omjEWKX3da4AzHS4Fy444wvwdcYdkKQm2JVBrmgoc+Rrj25xt2uk8+Q967f3hsd0
2vbh6/HlcH6YkSHrXvw0sAc8SeiC0HHaiJ2BiQ3JzgzsVtvbwTmasoL1i9tlBeR4
Bi7iPpAGb16oe65K196oiEFXL6INvkiEMvtIokGwda67vWoc0WAehcj7acAKx9uh
gpjxRe2TJx7Et94Kotb2TdwkQXcRDTm74D02fDe8qWJAjxNL4mE=
=tmXp
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(name . Marius Bakke)(address . mbakke@fastmail.com)
87h8xp4sdv.fsf@openmailbox.org
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (200 lines)
> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Aug 02, 2017 at 09:12:09PM +0200, Marius Bakke wrote:
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>> > * gnu/packages/admin.scm (mingetty, clusterssh, sudo,
>>> > wpa-supplicant-minimal,
>>> > wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>>> > 'modify-phases' syntax.
>>> > * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>>> > * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>>> > * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>>> > lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>>> > zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>>> > * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>>> > * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>>> > flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>>> > * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>>> > * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>>> > * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>>> > * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>>> > * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>>> > * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>>> > * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>>> > * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>>> > * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>>> > * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>>> > * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>>> > * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>>> > * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>>> > * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>>> > * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>>> > * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>>> > * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>>> > * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>>> > * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>>> > * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>>> > libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>>> > * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>>> > * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>>> > * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>>> > * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present,
>>> > python2-pycairo)
>>> > [arguments]: Likewise.
>>> > * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>>> > * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>>> > * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>>> > * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>>> > [arguments]: Likewise.
>>> > * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>>> > * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>>> > * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>>> > * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>>> > unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>>> > module-init-tools)[arguments]: Likewise.
>>> > * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>>> > * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>>> > * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>>> > * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>>> > * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>>> > * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>>> > * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>>> > suitesparse)[arguments]: Likewise.
>>> > * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>>> > * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>>> > * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>>> > * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>>> > * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>>> > Likewise.
>>> > * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>>> > zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>>> > * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>>> > Likewise.
>>> > * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>>> > * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>>> > * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>>> > Likewise.
>>> > * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>>> > * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>>> > python-sqlalchemy, python-docopt)[arguments]: Likewise.
>>> > * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>>> > * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>>> > * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>>> > * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>>> > * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>>> > * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>>> > * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>>> > * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>>> > * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>>> > * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>>> > * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>>> > * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>>> > * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>>> > * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>>> > Likewise.
>>> > * gnu/packages/time.scm (time)[arguments]: Likewise.
>>> > * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>>> > * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>>> > * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>>> > * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>>> > * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>>> > * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>>> > * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>>> > * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>>> > * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>>> > * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>>> > * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>>> > ---
>>> > gnu/packages/admin.scm | 294 ++++++++++++++---------------
>>> > gnu/packages/algebra.scm | 31 ++--
>>> > gnu/packages/apr.scm | 25 ++-
>>> > gnu/packages/audio.scm | 193 +++++++++----------
>>> > gnu/packages/backup.scm | 33 ++--
>>> > gnu/packages/bioinformatics.scm | 250 +++++++++++++------------
>>> > gnu/packages/bittorrent.scm | 33 ++--
>>> > gnu/packages/cdrom.scm | 2 +-
>>> > gnu/packages/compression.scm | 16 +-
>>> > gnu/packages/conky.scm | 31 ++--
>>> > gnu/packages/databases.scm | 102 +++++-----
>>> > gnu/packages/debug.scm | 70 +++----
>>> > gnu/packages/display-managers.scm | 22 +--
>>> > gnu/packages/dns.scm | 2 +-
>>> > gnu/packages/docbook.scm | 26 +--
>>> > gnu/packages/emacs.scm | 74 ++++----
>>> > gnu/packages/engineering.scm | 43 +++--
>>> > gnu/packages/firmware.scm | 48 ++---
>>> > gnu/packages/flashing-tools.scm | 21 +--
>>> > gnu/packages/fltk.scm | 42 ++---
>>> > gnu/packages/freedesktop.scm | 33 ++--
>>> > gnu/packages/gd.scm | 19 +-
>>> > gnu/packages/gimp.scm | 30 +--
>>> > gnu/packages/gkrellm.scm | 4 +-
>>> > gnu/packages/gl.scm | 2 +-
>>> > gnu/packages/glib.scm | 33 ++--
>>> > gnu/packages/gnome.scm | 145 +++++++--------
>>> > gnu/packages/gprolog.scm | 17 +-
>>> > gnu/packages/gps.scm | 19 +-
>>> > gnu/packages/graphics.scm | 13 +-
>>> > gnu/packages/gtk.scm | 80 ++++----
>>> > gnu/packages/guile-wm.scm | 81 ++++----
>>> > gnu/packages/guile.scm | 36 ++--
>>> > gnu/packages/hugs.scm | 61 +++---
>>> > gnu/packages/hurd.scm | 60 +++---
>>> > gnu/packages/image-viewers.scm | 14 +-
>>> > gnu/packages/libcanberra.scm | 18 +-
>>> > gnu/packages/libsigsegv.scm | 13 +-
>>> > gnu/packages/linux.scm | 379
>>> > +++++++++++++++++++-------------------
>>> > gnu/packages/lisp.scm | 61 +++---
>>> > gnu/packages/lout.scm | 142 +++++++-------
>>> > gnu/packages/lua.scm | 2 +-
>>> > gnu/packages/machine-learning.scm | 88 +++++----
>>> > gnu/packages/mail.scm | 90 ++++-----
>>> > gnu/packages/man.scm | 4 +-
>>> > gnu/packages/maths.scm | 119 ++++++------
>>> > gnu/packages/messaging.scm | 27 ++-
>>> > gnu/packages/mp3.scm | 87 ++++-----
>>> > gnu/packages/music.scm | 102 +++++-----
>>> > gnu/packages/noweb.scm | 79 ++++----
>>> > gnu/packages/patchutils.scm | 120 ++++++------
>>> > gnu/packages/pdf.scm | 69 +++----
>>> > gnu/packages/perl.scm | 31 ++--
>>> > gnu/packages/photo.scm | 15 +-
>>> > gnu/packages/popt.scm | 17 +-
>>> > gnu/packages/pretty-print.scm | 65 +++----
>>> > gnu/packages/pumpio.scm | 32 ++--
>>> > gnu/packages/python.scm | 47 +++--
>>> > gnu/packages/rdf.scm | 40 ++--
>>> > gnu/packages/regex.scm | 20 +-
>>> > gnu/packages/rrdtool.scm | 19 +-
>>> > gnu/packages/ruby.scm | 40 ++--
>>> > gnu/packages/sawfish.scm | 50 ++---
>>> > gnu/packages/scheme.scm | 134 +++++++-------
>>> > gnu/packages/sdl.scm | 46 ++---
>>> > gnu/packages/serveez.scm | 15 +-
>>> > gnu/packages/skribilo.scm | 29 +--
>>> > gnu/packages/smalltalk.scm | 17 +-
>>> > gnu/packages/suckless.scm | 4 +-
>>> > gnu/packages/tcl.scm | 15 +-
>>> > gnu/packages/telephony.scm | 12 +-
>>> > gnu/packages/textutils.scm | 25 ++-
>>> > gnu/packages/time.scm | 19 +-
>>> > gnu/packages/tor.scm | 14 +-
>>> > gnu/packages/uucp.scm | 24 +--
>>> > gnu/packages/video.scm | 9 +-
>>> > gnu/packages/web-browsers.scm | 10 +-
>>> > gnu/packages/web.scm | 15 +-
>>> > gnu/packages/wicd.scm | 214 +++++++++++----------
>>> > gnu/packages/wm.scm | 2 +-
>>> > gnu/packages/xdisorg.scm | 5 +-
>>> > gnu/packages/xfce.scm | 23 +--
>>> > gnu/packages/xfig.scm | 75 ++++----
>>> > gnu/packages/xorg.scm | 39 ++--
>>> > 84 files changed, 2253 insertions(+), 2274 deletions(-)
>>>
>>> Wow! That is a lot of code to review at once. Can you split this into
>>> maybe one patch per file? I guess some can be consolidated, but we
>>> should try to make each patch easily digestible both for current and
>>> future code reviewers. Hopefully we can alternate on the LGTMs.

One patch per file seems reasonable.

Toggle quote (21 lines)
>>
>> I agree, wow! Thanks for this. It should help new Schemers to feel more
>> comfortable editing packages.
>>
>> This might be annoying but it should wait until after the core-updates
>> branch is done and merged into the master branch. I want to minimize the
>> number of merge conflicts because they are 1) annoying and 2) relatively
>> opaque when reading the Git history. Marius's suggestion is another good
>> one, and would help with issues like that.
>>
>> But if we were to wait until after core-updates and push it as one
>> commit, I wouldn't mind. It's up to the two of you and everyone else :)
>
> Yeah I guess the squashed patch is okay. If we delay the patches until
> after 'staging' and 'python-updates' as well, no merge will be
> necessary. But it won't be a pretty cherry-pick either, by then.
>
> I don't really have a strong opinion either way. But I'd hate to the one
> resolving potentially 100s of merge conflicts at once ;-) Cherry-picking
> at least restricts the set of conflicts to these changes.

Delaying the packages is fine as long as necessary to get bigger and
more difficult updates done first. It's a relatively simple change for
most packages, so coming back to it after a while shouldn't be too bad
(in theory).
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmCOEwACgkQ5qXuPBlG
eg2GOg//YDUE5tCtwvyiym3bC0HI/41b1QTuu/Y2UCc6DafOO5y4tccbb6tVly/u
RkEDZ/oQtwRIfNpJZsgfMcXHnMBDTwxnTqWNfBI4zestPfgBZwMA43m+h9frLfe4
PoJa5C7hoxYD6to20kbuddGh4xOql6SiDyroF58xXX4JD2QQe9O+iCi1QZp4cuQV
m/KIR7hNwXAN7ZKySB8LLNwSrt6G0/74Kw+jiOHk8xSVaLsnpJoSfW01NMup5O2l
9KakCjT4htavQl8KpdDWAEOt9t194cGYMBEMKrhZfGdfEtYXM8xk0Gud/uI/ZKV1
WF3xsx8o3I/891JqB6F8Vn2dK7fx4BexBxzxJUoU5YRm+QhEMoC25uxRh6xozoiH
SzjN1aVqnMqDOegB1dGwmYSvXceCZCuA7yvdjrNHrKA9CXvBadI8md0QLTnhfxuO
2ZX6a6sB6KGkx3NthakBpCzksqNC87BBzg1P6TStdwjr7UHge6IUoKFR7P/qYiBQ
zHgUorg1RPiia0eYbZjT1S8/p9mSUxhtQtC/2TrvTw3DziLgSbvsogRNVICUZXBy
2HuILz7vcBALE7BJvAC9Xi5CpNJcxMo4j8RxkP5BihPMgJp4IiVSRuRfbREebpP8
ADsrWyy8MOUGm1reXfEs3zs/x9Qh42PJHY1aKDtsJrofTrYrENY=
=+ZOl
-----END PGP SIGNATURE-----

Leo Famulari wrote 8 years ago
Re: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(name . Kei Kebreau)(address . kei@openmailbox.org)
20170802224416.GB14798@jasmine.lan
On Wed, Aug 02, 2017 at 04:31:08PM -0400, Kei Kebreau wrote:
Toggle quote (15 lines)
> Leo Famulari <leo@famulari.name> writes:
> > I guess there is a correct ordering and an incorrect ordering, depending
> > on whether or not these phases should happen before or after the shebang
> > patching phases. Does it work if it happens before the shebangs are
> > patched?
>
> What does the "it" in "does it work" mean here? If you mean the
> builds themselves, then no. Success isn't guaranteed because the
> configure scripts might not be patched, as the patching phases are
> finished before the "build" phases. This change ensures that the
> "patch-usr-bin-file" phase can operate on generated configure scripts if
> necessary:
>
> https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00124.html

I'm sorry for sending that confusing sentence! You interpreted it
correctly. Thank for the clarification!
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmCVb8ACgkQJkb6MLrK
fwgGSxAArHhdae/7yFB1Imz6NlI9iiLh0+9bLzTYwRTSs+bC3JaAN7VVm/uybzlz
Uowgi4n7Gz/strtSFVtNc5hKfiW46Xin5nI0BNHYYc/KB8TnA2DgqFoTV/UJN290
j2KUVzYf8SAxhGOTaKNGm8sDJFtOnATNmf9whQEwLrFgmi6x2/alDMQ1O33RyLAw
z7AhZnSjkBcnRnNHp677DjafOW5zVR3UJIeYn90IWbEV/BgEvt6DxzexEf1XrFJQ
9IVVKHZefNbwXb9b9g8eXLPE4lSpsrXHN3yqxqeR/RKPqpDAss7W8psmOps3n9oz
mhjuIzs0gecV/cwvMZQVWQtgbdLyze4etN4zAgEU4GlWRSqB8/MezJhkE9hgdvsG
KwUkOg2n3xx1AUBjMrRbERlR3UDnOoANeA4aH1YskAmDfJEa2jN0/Ju34QTq4JML
MMpVFY+UaE07qKFOcPIhshGgIgqALrT6L+0SdClE/NuxeeJWDnPrb2d0dmNeqOrY
nhAN9Ad4DpDriNSmEazUnFaSgEfuSgGADOcg6RuwW4pWhMN6E0KqijLDdcjyZHPj
0q+XLku/Pr65NzRPWxbX2z5GyvttNatTsYWfEkWJMRkFCzhf8K664pmO4OVgTWu1
deMZWzo8I/N4HTTjXqJNWmGaKX/HYo+R/+TZDbr3aM/No3eQafM=
=2b3u
-----END PGP SIGNATURE-----


Leo Famulari wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(name . Marius Bakke)(address . mbakke@fastmail.com)
20170802224614.GC14798@jasmine.lan
On Wed, Aug 02, 2017 at 10:08:18PM +0200, Marius Bakke wrote:
Toggle quote (17 lines)
> Leo Famulari <leo@famulari.name> writes:
> > I agree, wow! Thanks for this. It should help new Schemers to feel more
> > comfortable editing packages.
> >
> > This might be annoying but it should wait until after the core-updates
> > branch is done and merged into the master branch. I want to minimize the
> > number of merge conflicts because they are 1) annoying and 2) relatively
> > opaque when reading the Git history. Marius's suggestion is another good
> > one, and would help with issues like that.
> >
> > But if we were to wait until after core-updates and push it as one
> > commit, I wouldn't mind. It's up to the two of you and everyone else :)
>
> Yeah I guess the squashed patch is okay. If we delay the patches until
> after 'staging' and 'python-updates' as well, no merge will be
> necessary. But it won't be a pretty cherry-pick either, by then.

True, we should not wait *too* long. I think that doing it after
core-updates and before staging and python-updates could be good
compromise, because those branches touch a relatively small number of
modules. WDYT?

Toggle quote (4 lines)
> I don't really have a strong opinion either way. But I'd hate to the one
> resolving potentially 100s of merge conflicts at once ;-) Cherry-picking
> at least restricts the set of conflicts to these changes.

OTOH, if Kei doesn't have an unsquashed version of this patch, it will
be annoying to split it up :)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmCVjYACgkQJkb6MLrK
fwghZA//SJ1poCCy9h0YgxDzAsJbDQJEltUX079JbqwB34EZRRFImAWVVnsaE6OQ
L/mZU3ZOTrxaJGqPAmhneVZCp4B8SuPa/ouXTQ1LGdMFK2+Y0IBOJSsLAVUo06/D
I5LqQR2A63fVnyhiTNhvigVeBW+aFAs5lNMenBSsk1vorqaD7724UXp9stKH5LWL
z9hM2CpDx4A1EQKFr+WbY9ugxfxw9DnpIJCTUUSFvxdzlt4E1SG0ElL4k50yWls3
oYqT4gs5RQgfnOQpCDr090EvnbA03HwRiuU4NwGn5XoToJaeGp0m4RIYqeDOPUjI
8EIjrnr0th9gfYvV/mreo1FvtLH7BmOP719+kVbxb+5l6LvkLF6roKSymAR2x7ON
4AxxDJbTIuBLULSM5V+oFjX7oo7YDh73crQcKRHClCzBEYFE7/CDMOFiVIhW10h9
Ta6dKyY47c6SRo43RKLC13HPj06G73F1+qexRUzYnT7pJuicJmZrlE4nZ1AiI98T
B8UlsO+6IEv1Y5aXQAdwwuAMnWr9V9aKKLzx4Q3Qe0+Z4vMCmRA7ZgTtuXr2PPbf
xE+t96Pgz/6jE370sjKghyu6MOlJaNw5nChnQN6mHmoEoFI4LnDYjpIuS3GaquRa
clPxHN32JaR6ztIg1MZXpGfLAuZkYidw4LiGWCs7nAXK6dcbi1Y=
=rICT
-----END PGP SIGNATURE-----


Marius Bakke wrote 8 years ago
(name . Leo Famulari)(address . leo@famulari.name)
8760e5wpgq.fsf@fastmail.com
Leo Famulari <leo@famulari.name> writes:

Toggle quote (23 lines)
> On Wed, Aug 02, 2017 at 10:08:18PM +0200, Marius Bakke wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > I agree, wow! Thanks for this. It should help new Schemers to feel more
>> > comfortable editing packages.
>> >
>> > This might be annoying but it should wait until after the core-updates
>> > branch is done and merged into the master branch. I want to minimize the
>> > number of merge conflicts because they are 1) annoying and 2) relatively
>> > opaque when reading the Git history. Marius's suggestion is another good
>> > one, and would help with issues like that.
>> >
>> > But if we were to wait until after core-updates and push it as one
>> > commit, I wouldn't mind. It's up to the two of you and everyone else :)
>>
>> Yeah I guess the squashed patch is okay. If we delay the patches until
>> after 'staging' and 'python-updates' as well, no merge will be
>> necessary. But it won't be a pretty cherry-pick either, by then.
>
> True, we should not wait *too* long. I think that doing it after
> core-updates and before staging and python-updates could be good
> compromise, because those branches touch a relatively small number of
> modules. WDYT?

I think the least painful path is:

* Merge 'core-updates'.
* Merge to 'staging'.
* <apply these commits>
* Branch 'python-updates' from staging.
* Build staging.

Sounds good? :-)

Toggle quote (7 lines)
>> I don't really have a strong opinion either way. But I'd hate to the one
>> resolving potentially 100s of merge conflicts at once ;-) Cherry-picking
>> at least restricts the set of conflicts to these changes.
>
> OTOH, if Kei doesn't have an unsquashed version of this patch, it will
> be annoying to split it up :)

Yeah.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmCWBUACgkQoqBt8qM6
VPpWQAgAoTDcY3ShHoN7RuhNz+HFv6zrWo/UlDdU4FhrbHq/RMt3jUWbPOtJhCTg
RTAaPOFEtaRkwpvm+seMmpPOOxbsCONDZ1Id3BXB/otXXWYcB9GA7rMCrNOPqbu+
6BtF8DPT0at9PHd/2afBNMSmWj1uVwteGSwi34PtxNvW3WV5w4SWp7NITOEDPukt
c9+ujdIuaQgsZHhmXxIkhzfkwjMCBoRYCAwqV48oHjtOig15k/oyGbqBL1SZ3p2D
yWpySyGH2Amw4YCKZsQQffqOCVISIfncRZwP57tai1x3gNuvyI+73NBojKhyFemp
cGQiyg/F4CAIiWVfVO6MXsDhCWvnxw==
=NrMo
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
(name . Leo Famulari)(address . leo@famulari.name)
871sotwowy.fsf@fastmail.com
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (35 lines)
> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Aug 02, 2017 at 10:08:18PM +0200, Marius Bakke wrote:
>>> Leo Famulari <leo@famulari.name> writes:
>>> > I agree, wow! Thanks for this. It should help new Schemers to feel more
>>> > comfortable editing packages.
>>> >
>>> > This might be annoying but it should wait until after the core-updates
>>> > branch is done and merged into the master branch. I want to minimize the
>>> > number of merge conflicts because they are 1) annoying and 2) relatively
>>> > opaque when reading the Git history. Marius's suggestion is another good
>>> > one, and would help with issues like that.
>>> >
>>> > But if we were to wait until after core-updates and push it as one
>>> > commit, I wouldn't mind. It's up to the two of you and everyone else :)
>>>
>>> Yeah I guess the squashed patch is okay. If we delay the patches until
>>> after 'staging' and 'python-updates' as well, no merge will be
>>> necessary. But it won't be a pretty cherry-pick either, by then.
>>
>> True, we should not wait *too* long. I think that doing it after
>> core-updates and before staging and python-updates could be good
>> compromise, because those branches touch a relatively small number of
>> modules. WDYT?
>
> I think the least painful path is:
>
> * Merge 'core-updates'.
> * Merge to 'staging'.
> * <apply these commits>
> * Branch 'python-updates' from staging.
> * Build staging.
>
> Sounds good? :-)

Actually we probably should swap 2 and 3 if we can take the rebuild hit
on 'master'. I don't know how many rebuilds this will cause, but I guess
as long as it's in the three-digit range it should not take too long.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmCWt4ACgkQoqBt8qM6
VPpEaAgAqkCGnipI68l5jyqj4hcn7SLV7qPTH2C+146afi5gEb0zZ+pvEN8WdxLW
uTwmR/FY7E2gJkxN4WrPerPQ+0k4MCJuE9ZlMnfXuUt7acI8J9qOzOEctaeA/OIC
ngKQcQUZ+9FUwAVvMMCFkZflNpbzMBX811UaV+1e2/Comd3urbmX8obBmEWYIeb5
ld1LJcXY9SVv4b+x8R7mvoIXyxJE16ms8iHqIX7BZYtkSNii9TXN6MTZVth51zhj
4EmcyqUawg6FLmoSE0twgWT52O2vlj3CJ+50EMUOrefwAURKaf+/kDaHfv6lWzMs
7gn358tkQnEjNX+s9QqAmjKDiNk5QQ==
=xaqA
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
(name . Kei Kebreau)(address . kei@openmailbox.org)
87pobhz3vg.fsf@fastmail.com
Kei Kebreau <kei@openmailbox.org> writes:

Toggle quote (101 lines)
> * gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
> 'modify-phases' syntax.
> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
> [arguments]: Likewise.
> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
> [arguments]: Likewise.
> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
> module-init-tools)[arguments]: Likewise.
> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
> suitesparse)[arguments]: Likewise.
> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
> Likewise.
> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
> Likewise.
> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
> Likewise.
> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
> python-sqlalchemy, python-docopt)[arguments]: Likewise.
> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
> Likewise.
> * gnu/packages/time.scm (time)[arguments]: Likewise.
> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.

Hello Kei!

'core-updates' is now merged. Let's try to get this patch in.

I've read through the changed variables and think we can handle it on
'master', except 'bdb-5.3' which will have to wait until the next
'core-updates' cycle. Can you double check that this won't cause more
than a few hundred rebuilds?

Thanks!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmioqQACgkQoqBt8qM6
VPoYWAf/QgA917pJl/wEUenKRy8uloYJ20DvqOJsoQm4PU/wytEdqkem+rm62Cx9
my9bp7XSQffRizObGwQZawesFtGaBX+AR9ZwxoLDEN0nJhP2pNk70//nHLe2g1s1
/hwnsCj2EJBNy9sTzYgbszSm2G1XT47NFF53KRa47zVHNZpHEunIOjBalpsQFN88
PYaCdGtAwZiL3KYrzdu0k6GPFCrcVZGJcgKDQZx9mgN70AV3DoYOoAPk8rEPYt6P
wqVS787XcNkTurf3OZC8LkA7t1V7DbLA7hNJg3EDcfXoElN1K+1WtuDMAUpVFL1L
tIa8FXr3JE+SC8X4OQyVcAYk1Bhy7w==
=Fce7
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
Re: [bug#27898] [PATCH 2/2] gnu: Put autoconf-related phases immediately after the 'unpack phase.
(name . Kei Kebreau)(address . kei@openmailbox.org)
87mv6lz3pl.fsf@fastmail.com
Kei Kebreau <kei@openmailbox.org> writes:

Toggle quote (47 lines)
> * gnu/packages/audio.scm (audacity, rtmidi)[arguments]: Correct phases
> accordingly.
> * gnu/packages/bioinformatics.scm (mash, seek, vsearch, emboss,
> htslib-for-sambamba)[arguments]: Likewise.
> * gnu/packages/ci.scm (cuirass)[arguments]: Likewise.
> * gnu/packages/compression.scm (minizip, xdelta)[arguments]: Likewise.
> * gnu/packages/cpp.scm (libzen)[arguments]: Likewise.
> * gnu/packages/crypto.scm (opendht)[arguments]: Likewise.
> * gnu/packages/databases.scm (4store, mdbtools)[arguments]: Likewise.
> * gnu/packages/debug.scm (stress-make)[arguments]: Likewise.
> * gnu/packages/dns.scm (dnscrypt-proxy, dnscrypt-wrapper)[arguments]:
> Likewise.
> * gnu/packages/emacs.scm (emacs-pdf-tools)[arguments]: Likewise.
> * gnu/packages/embedded.scm (libjaylink, openocd)[arguments]: Likewise.
> * gnu/packages/engineering.scm (gerbv)[arguments]: Likewise.
> * gnu/packages/erlang.scm (erlang)[arguments]: Likewise.
> * gnu/packages/ftp.scm (weex)[arguments]: Likewise.
> * gnu/packages/gnome.scm (dia)[arguments]: Likewise.
> * gnu/packages/gnunet.scm (gnurl, guile-gnunet)[arguments]: Likewise.
> * gnu/packages/gtk.scm (guile-rsvg, graphene)[arguments]: Likewise.
> * gnu/packages/guile.scm (guildhall, guile-ics, guile-sqlite3)[arguments]:
> Likewise.
> * gnu/packages/ibus.scm (ibus-libpinyin)[arguments]: Likewise.
> * gnu/packages/irc.scm (weechat)[arguments]: Likewise.
> * gnu/packages/java.scm (classpath-devel)[arguments]: Likewise.
> * gnu/packages/libreoffice.scm (libetonyek)[arguments]: Likewise.
> * gnu/packages/libusb.scm (hidapi)[arguments]: Likewise.
> * gnu/packages/linux.scm (gpm)[arguments]: Likewise.
> * gnu/packages/logging.scm (glog)[arguments]: Likewise.
> * gnu/packages/machine-learning.scm (ghmm)[arguments]: Likewise.
> * gnu/packages/mail.scm (dovecot-trees, dovecot-libsodium-plugin, esmtp)
> [arguments]: Likewise.
> * gnu/packages/maths.scm (wxmaxima)[arguments]: Likewise.
> * gnu/packages/messaging.scm (freetalk, libmesode, libstrophe)[arguments]:
> Likewise.
> * gnu/packages/microcom.scm (microcom)[arguments]: Likewise.
> * gnu/packages/ocaml.scm (ocaml-ssl)[arguments]: Likewise.
> * gnu/packages/parallel.scm (slurm)[arguments]: Likewise.
> * gnu/packages/pdf.scm (libharu)[arguments]: Likewise.
> * gnu/packages/samba.scm (cifs-utils)[arguments]: Likewise.
> * gnu/packages/serialization.scm (msgpack)[arguments]: Likewise.
> * gnu/packages/shells.scm (scsh)[arguments]: Likewise.
> * gnu/packages/telephony.scm (libiax2)[arguments]: Likewise.
> * gnu/packages/textutils.scm (dotconf)[arguments]: Likewise.
> * gnu/packages/version-control.scm (findnewest)[arguments]: Likewise.
> * gnu/packages/video.scm (vlc, libmediainfo, mediainfo)[arguments]: Likewise.

Same with this. Looks okay for 'master', but please double check before
pushing. TIA!
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmio3cACgkQoqBt8qM6
VPoVhwf/fK+ugNvhbo5A2gZjFhz5ph1YThiBuHK45lKZ4fESgaeuvAxFRbpntlYe
ePg3HIC7rXEy5dTbz49vsuphE2yJPmgKs4jfhQoEQztsNGjRIsTS6rmYnCSP4OKf
HDjG2pdSkgCLlPVRp/dYVS7PXFX7RWjVe4Vv2r28n/WIi6eSWnkjPYW25Tb3Bt6v
/RmmvA4uUgQIYjI0zFeh5YRVX40BHXpzXdHQcxLiKjJEHtHtiZ0FIKDp8EhqgcZb
Ee2IeaOhlxuC16xMuGPKLKBEeNKIzUUy7gC5A/zkZ3L/QeSMEyNbJC9bVqMQKss7
BGb7pZK7v0UQb0EOv4Ow2Y/nARY0ZA==
=Gi+5
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
(address . 27898@debbugs.gnu.org)(address . mbakke@fastmail.com)
87a82jzhwg.fsf@posteo.net
Toggle quote (114 lines)
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> * gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
>> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>> 'modify-phases' syntax.
>> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
>> [arguments]: Likewise.
>> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>> [arguments]: Likewise.
>> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>> module-init-tools)[arguments]: Likewise.
>> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>> suitesparse)[arguments]: Likewise.
>> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>> Likewise.
>> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>> Likewise.
>> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>> Likewise.
>> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>> python-sqlalchemy, python-docopt)[arguments]: Likewise.
>> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>> Likewise.
>> * gnu/packages/time.scm (time)[arguments]: Likewise.
>> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>
> Hello Kei!
>
> 'core-updates' is now merged. Let's try to get this patch in.
>
> I've read through the changed variables and think we can handle it on
> 'master', except 'bdb-5.3' which will have to wait until the next
> 'core-updates' cycle. Can you double check that this won't cause more
> than a few hundred rebuilds?
>
> Thanks!

How does 1301 rebuilds sound?

P.S. It seems that I have to type the patch a second time, so it may be
a while until I am able to push to master.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmkW6AACgkQ5qXuPBlG
eg3a/Q//d1fIkllk/tacLCMEUtDUjHfj2wTybj2LGmu2Mg4Et4zDdSHwqsqBNZWj
VQAr8GRLF3Gq+vtlpjZVJVZA0hH4gbCZsmpDLqZ7FzhFXmBn3t8JjxOA6ZFSeKLu
7HM2q7X+09kBRCYhgwifasx2gO320tgHibWUjoeSovxhCiL89xrJW4oVhGXcbp5w
05NjGsfnwwekA6F7BUkPa94QAs3zUtoWznrSnsUy7Vgub0IUVlCR6VKESm/S/KR1
dycB+H87H9RQLkxsOItZKtJcHVaHY5nmThZqP+jFV8AXSu7gKu2jhWI6L/oQ6myl
kwzglWZhKbWgLrTiu0O5LqkETIvUCBFc7mCsq8T1Adw0kM+uVXKzRUr9C0abNuCB
OA9IAv39bbwydjXwrHZyZMeG7kzLlgpXFXjjAXQbILaFi6SwajwYMEQwxVVP27Tk
nr3M8flmtYGE6AJL1vr3TF8T/Ld+K643/SHpLL6BGcFbx1JBIy/m275r2AlxYcB9
rZ8qSorxJpTSJ6Xlpeal+w2JIgHN18pb69tbMmWqdTST/4gH0wF6fT5QStBaLdnJ
kif5y1MO+PmfL9bEPJ5qEHVgxqk7t0+mA57DQRDJRI4D6HFxwiv1TcjHMHJDEGnR
6ZWgOjMt+3YrtyuJiqkFmUOhT2Trkee4Dhn1SJMTq5ASwoPI9eU=
=0p1l
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
878ti3zade.fsf@fastmail.com
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (116 lines)
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> * gnu/packages/admin.scm (mingetty, clusterssh, sudo, wpa-supplicant-minimal,
>>> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>>> 'modify-phases' syntax.
>>> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>>> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>>> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>>> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>>> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>>> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>>> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>>> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>>> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>>> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>>> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>>> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>>> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>>> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>>> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>>> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>>> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>>> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>>> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>>> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>>> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>>> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>>> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>>> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>>> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>>> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>>> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>>> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>>> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>>> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>>> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>>> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>>> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present, python2-pycairo)
>>> [arguments]: Likewise.
>>> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>>> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>>> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>>> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>>> [arguments]: Likewise.
>>> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>>> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>>> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>>> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>>> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>>> module-init-tools)[arguments]: Likewise.
>>> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>>> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>>> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>>> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>>> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>>> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>>> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>>> suitesparse)[arguments]: Likewise.
>>> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>>> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>>> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>>> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>>> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>>> Likewise.
>>> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>>> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>>> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>>> Likewise.
>>> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>>> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>>> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>>> Likewise.
>>> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>>> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>>> python-sqlalchemy, python-docopt)[arguments]: Likewise.
>>> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>>> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>>> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>>> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>>> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>>> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>>> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>>> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>>> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>>> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>>> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>>> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>>> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>>> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>>> Likewise.
>>> * gnu/packages/time.scm (time)[arguments]: Likewise.
>>> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>>> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>>> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>>> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>>> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>>> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>>> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>>> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>>> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>>> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>>> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>>
>> Hello Kei!
>>
>> 'core-updates' is now merged. Let's try to get this patch in.
>>
>> I've read through the changed variables and think we can handle it on
>> 'master', except 'bdb-5.3' which will have to wait until the next
>> 'core-updates' cycle. Can you double check that this won't cause more
>> than a few hundred rebuilds?
>>
>> Thanks!
>
> How does 1301 rebuilds sound?

I think that will take several days (~week?) to complete, so it should
be done on 'staging' so that users are not left without binary
substitutes for very long.

But then, we are probably facing a weeks worth of merge conflicts.

Toggle quote (3 lines)
> P.S. It seems that I have to type the patch a second time, so it may be
> a while until I am able to push to master.

I would assume `git cherry-pick` could resolve most hunks, no? Files
with many conflicts may be easier to reset to their original state and
redo.

If you do have to redo large parts of it, maybe we could do it in 3-4
batches and keep an eye on Hydra in between? It would cause some extra
rebuilds, but I suspect it's the least painful option.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmkgb0ACgkQoqBt8qM6
VPrVnAf/Ue/6yBypahZPNtEyxl7MBUWEE3mzT3WWjqGwK9s9Oa+A/aoWFOx8mJTq
GRq0StMBxxVsjQiuWeq9NMki8x5MlQu1Un5GCJ0iFibzdUUbsAgNXHyPUJHOExWe
j1bHQaAyVWlpJLTNWBNB/7ZlLoDOkr+8MUa0H+fZgYVqTyVMzfq5iWmI1Fku9TAL
XVuXZvzklmUCZdaM6QxUdHHuir9gVPuscfe+4Nt066GoiKqNzHk+nonjCoRhbwiV
bMoYmpz1UgUf2mhnE12DJKrFs1UmDTg130L2cvsJehQ2c9wD0B4AMUUUDC7+GpxG
4J0DVPX1+TXqm3WLpGpyPz6T5RKNuQ==
=7kUw
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 27898@debbugs.gnu.org)
8760d7z49r.fsf@posteo.net
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (134 lines)
> Kei Kebreau <kkebreau@posteo.net> writes:
>
>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>
>>>> * gnu/packages/admin.scm (mingetty, clusterssh, sudo,
>>>> wpa-supplicant-minimal,
>>>> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>>>> 'modify-phases' syntax.
>>>> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>>>> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>>>> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>>>> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>>>> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>>>> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>>>> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>>>> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>>>> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>>>> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>>>> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>>>> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>>>> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>>>> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>>>> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>>>> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>>>> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>>>> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>>>> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>>>> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>>>> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>>>> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>>>> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>>>> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>>>> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>>>> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>>>> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>>>> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>>>> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>>>> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>>>> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>>>> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>>>> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present,
>>>> python2-pycairo)
>>>> [arguments]: Likewise.
>>>> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>>>> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>>>> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>>>> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>>>> [arguments]: Likewise.
>>>> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>>>> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>>>> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>>>> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>>>> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>>>> module-init-tools)[arguments]: Likewise.
>>>> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>>>> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>>>> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>>>> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>>>> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>>>> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>>>> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>>>> suitesparse)[arguments]: Likewise.
>>>> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>>>> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>>>> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>>>> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>>>> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>>>> Likewise.
>>>> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>>>> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>>>> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>>>> Likewise.
>>>> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>>>> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>>>> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>>>> Likewise.
>>>> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>>>> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>>>> python-sqlalchemy, python-docopt)[arguments]: Likewise.
>>>> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>>>> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>>>> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>>>> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>>>> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>>>> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>>>> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>>>> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>>>> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>>>> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>>>> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>>>> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>>>> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>>>> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>>>> Likewise.
>>>> * gnu/packages/time.scm (time)[arguments]: Likewise.
>>>> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>>>> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>>>> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>>>> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>>>> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>>>> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>>>> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>>>> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>>>> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>>>> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>>>> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>>>
>>> Hello Kei!
>>>
>>> 'core-updates' is now merged. Let's try to get this patch in.
>>>
>>> I've read through the changed variables and think we can handle it on
>>> 'master', except 'bdb-5.3' which will have to wait until the next
>>> 'core-updates' cycle. Can you double check that this won't cause more
>>> than a few hundred rebuilds?
>>>
>>> Thanks!
>>
>> How does 1301 rebuilds sound?
>
> I think that will take several days (~week?) to complete, so it should
> be done on 'staging' so that users are not left without binary
> substitutes for very long.
>
> But then, we are probably facing a weeks worth of merge conflicts.
>
>> P.S. It seems that I have to type the patch a second time, so it may be
>> a while until I am able to push to master.
>
> I would assume `git cherry-pick` could resolve most hunks, no? Files
> with many conflicts may be easier to reset to their original state and
> redo.
>

Maybe if my commits were split up? I have to read about
`git cherry-pick`.

Toggle quote (4 lines)
> If you do have to redo large parts of it, maybe we could do it in 3-4
> batches and keep an eye on Hydra in between? It would cause some extra
> rebuilds, but I suspect it's the least painful option.

That could work. I'll see if I can have things sorted by tomorrow and
we'll go from there.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmkoKAACgkQ5qXuPBlG
eg3snQ/9FrocD6E8N8jUoJDQiN+5tgnqvDMBhxXJ/zCzcO6maMyapwE+jJFnj9L+
9YwFcQsg2KfDyXDFnCVR4V1rDbd2+IRHA+v2PkVocoR3Zy3f0X8vU1fvTDf6bKAz
3sznDmBylDzXBua1XDwdpMlfP3uRDpC/mQJYiPjy1QnNtDys5TJenOWESrdsT66G
niJBRhsd6Wen8Hl/ntgug3P2gDKVImY+lKnQHsFzANX40uwud/rVxDR1ZeaCnUVq
+Xt2wtUIPNv0zgzjJPjWudX96A0BvibM5dGg+sumANTgMjN+ZzRLwZg7TTe8LRcq
gTf5B4Abe894CUnSgwCDhor8QEMy9O9Rv8flLk0Om4So+QmumBmtV5jOb14HVGFR
lTPffZKmn+sBhtQBKXGDnavozQb6EIGxCZLfrRm+qBo4Q5WKtG8FgYazdozDuClg
iTQ4bK+f0KnFZiM2St+c0wzVlZhnt91erpa80oGaCM+7dchUKjFSB72S+0qapb8I
PeT5VP0n7tv4eBBLxfvORG9TM1GkATydn3A+ABu1wx5HMxzyjHlN03aLIowkohuk
l0h9XZ0kMH+UXFIZu0gKqd+MSMwIsp2ugF6DY+LdO2ThbPQmaDy5V6mJn+7I/ZCK
snJwcnubtd6H6v+Yo1IbhRDgEfPc17W4nEOQz+kCvtiaizNPzpw=
=Vkid
-----END PGP SIGNATURE-----

Kei Kebreau wrote 8 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 27898@debbugs.gnu.org)
87shg7yjti.fsf@posteo.net
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (146 lines)
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Kei Kebreau <kkebreau@posteo.net> writes:
>>
>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>
>>>>> * gnu/packages/admin.scm (mingetty, clusterssh, sudo,
>>>>> wpa-supplicant-minimal,
>>>>> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>>>>> 'modify-phases' syntax.
>>>>> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>>>>> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>>>>> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>>>>> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>>>>> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>>>>> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>>>>> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>>>>> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>>>>> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>>>>> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>>>>> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>>>>> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>>>>> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>>>>> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>>>>> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>>>>> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>>>>> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>>>>> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>>>>> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>>>>> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>>>>> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>>>>> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>>>>> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>>>>> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>>>>> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>>>>> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>>>>> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>>>>> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>>>>> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>>>>> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>>>>> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>>>>> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>>>>> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present,
>>>>> python2-pycairo)
>>>>> [arguments]: Likewise.
>>>>> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>>>>> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>>>>> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>>>>> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>>>>> [arguments]: Likewise.
>>>>> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>>>>> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>>>>> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>>>>> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>>>>> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>>>>> module-init-tools)[arguments]: Likewise.
>>>>> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>>>>> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>>>>> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>>>>> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>>>>> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>>>>> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>>>>> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>>>>> suitesparse)[arguments]: Likewise.
>>>>> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>>>>> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>>>>> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>>>>> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>>>>> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>>>>> Likewise.
>>>>> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>>>>> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>>>>> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>>>>> Likewise.
>>>>> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>>>>> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>>>>> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>>>>> Likewise.
>>>>> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>>>>> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>>>>> python-sqlalchemy, python-docopt)[arguments]: Likewise.
>>>>> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>>>>> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>>>>> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>>>>> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>>>>> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>>>>> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>>>>> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>>>>> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>>>>> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>>>>> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>>>>> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>>>>> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>>>>> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>>>>> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>>>>> Likewise.
>>>>> * gnu/packages/time.scm (time)[arguments]: Likewise.
>>>>> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>>>>> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>>>>> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>>>>> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>>>>> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>>>>> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>>>>> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>>>>> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>>>>> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>>>>> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>>>>> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>>>>
>>>> Hello Kei!
>>>>
>>>> 'core-updates' is now merged. Let's try to get this patch in.
>>>>
>>>> I've read through the changed variables and think we can handle it on
>>>> 'master', except 'bdb-5.3' which will have to wait until the next
>>>> 'core-updates' cycle. Can you double check that this won't cause more
>>>> than a few hundred rebuilds?
>>>>
>>>> Thanks!
>>>
>>> How does 1301 rebuilds sound?
>>
>> I think that will take several days (~week?) to complete, so it should
>> be done on 'staging' so that users are not left without binary
>> substitutes for very long.
>>
>> But then, we are probably facing a weeks worth of merge conflicts.
>>
>>> P.S. It seems that I have to type the patch a second time, so it may be
>>> a while until I am able to push to master.
>>
>> I would assume `git cherry-pick` could resolve most hunks, no? Files
>> with many conflicts may be easier to reset to their original state and
>> redo.
>>
>
> Maybe if my commits were split up? I have to read about
> `git cherry-pick`.
>
>> If you do have to redo large parts of it, maybe we could do it in 3-4
>> batches and keep an eye on Hydra in between? It would cause some extra
>> rebuilds, but I suspect it's the least painful option.
>
> That could work. I'll see if I can have things sorted by tomorrow and
> we'll go from there.

The patches are in working order. The first patch would cause 1200
rebuilds, but the second would only cause 128 rebuilds. Should I work on
splitting up the first patch into pieces that Hydra can handle under its
current load?
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlmoCCoACgkQ5qXuPBlG
eg2jPRAAkhN1JhfNljTSSnOUeOm5DSQ43Fj+JqXyO797JjuK8bRuQt+VWncbABj2
s/jxeX7f4/iv60lw1Yyhw9FksWE3uqB6XMiCrKxw6NGwSGJfXBFCNPjgPtYXXy8l
OL0dWPb0HzUY+VW4V8TSc8pvuOhr/87wa+3Pri+i65127WCnPoycpagYxMZBFXpz
4qXyBmLrdo46rb29muhg64EQzc2Fflx5UmEWLNXzXJMPix1Bj6UDndxpSdN6r9Qg
Lf9QuslFlkmKhlM/+qd/txCoey6V+MhAwj8DhmwHOKiiyF/DuMVVBfOAG4etCJ0s
0Q3YYW1EmPCb5NvpOCXmQrg6+GbJJq8TsNFS6gehRZwN8Yh0cR8MZTieRcEMOoeo
SgmUmZZKYDH3I1mGVfb076ZCa1Nh71/RS67go7Eg/szrdelhw1DehERSlEvTHguj
fRgbLyjm+CRC+rUzAtalWPmWVD9rOsgjMvPmBcoac/5p7cX3mq4P1sFjKe+JKATp
vUrL93epb1w+uLaw1+qrX7oRP/5rzv19AuTPOXuBskOBc+Tw3zzHjyTrzFst/wrZ
fTr5wuhIaFvsW8nkRx0WyMcqS/Nt1myqD9VzsQgRpAiwZwU61avMnGKACpSaAsi3
Hm0oNh14pvZ+ezYAeIOWu4uJvED1ShWhU344gR5xjV0uZl59aI4=
=GoXv
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
(name . Kei Kebreau)(address . kkebreau@posteo.net)
87r2vrk70f.fsf@fastmail.com
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (153 lines)
> Kei Kebreau <kkebreau@posteo.net> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>> Kei Kebreau <kkebreau@posteo.net> writes:
>>>
>>>>> Kei Kebreau <kei@openmailbox.org> writes:
>>>>>
>>>>>> * gnu/packages/admin.scm (mingetty, clusterssh, sudo,
>>>>>> wpa-supplicant-minimal,
>>>>>> wpa-supplicant, wakelan, acpica, tree, direvent, dstat)[arguments]: Use
>>>>>> 'modify-phases' syntax.
>>>>>> * gnu/packages/algebra.scm (arb)[arguments]: Likewise.
>>>>>> * gnu/packages/apr.scm (apr-util)[arguments]: Likewise.
>>>>>> * gnu/packages/audio.scm (clalsadrv, fluidsynth, faad2, lv2-mda-piano,
>>>>>> lv2-mda-epiano, timidity++, vamp, soundtouch, portaudio, rsound,
>>>>>> zita-convolver, zita-alsa-pcmi)[arguments]: Likewise.
>>>>>> * gnu/packages/backup.scm (rdup, btar)[arguments]: Likewise.
>>>>>> * gnu/packages/bioinformatics.scm (bedops, bwa, crossmap, express,
>>>>>> flexbar, grit, hisat, ngs-sdk, subread)[arguments]: Likewise.
>>>>>> * gnu/packages/bittorrent.scm (transmission)[arguments]: Likewise.
>>>>>> * gnu/packages/cdrom.scm (cd-discid)[arguments]: Likewise.
>>>>>> * gnu/packages/compression.scm (sharutils)[arguments]: Likewise.
>>>>>> * gnu/packages/conky.scm (conky)[arguments]: Likewise.
>>>>>> * gnu/packages/databases.scm (bdb, bdb-5.3)[arguments]: Likewise.
>>>>>> * gnu/packages/debug.scm (delta, c-reduce)[arguments]: Likewise.
>>>>>> * gnu/packages/display-managers.scm (slim)[arguments]: Likewise.
>>>>>> * gnu/packages/dns.scm (dnsmasq)[arguments]: Likewise.
>>>>>> * gnu/packages/emacs.scm (geiser, emacs-wget, bbdb)[arguments]: Likewise.
>>>>>> * gnu/packages/engineering.scm (pcb)[arguments]: Likewise.
>>>>>> * gnu/packages/firmware.scm (ath9k-htc-firmware)[arguments]: Likewise.
>>>>>> * gnu/packages/flashing-tools.scm (flashrom)[arguments]: Likewise.
>>>>>> * gnu/packages/fltk.scm (fltk)[arguments]: Likewise.
>>>>>> * gnu/packages/freedesktop.scm (python-pyxdg)[arguments]: Likewise.
>>>>>> * gnu/packages/gd.scm (perl-gd)[arguments]: Likewise.
>>>>>> * gnu/packages/gimp.scm (gegl)[arguments]: Likewise.
>>>>>> * gnu/packages/gkrellm.scm (gkrellm)[arguments]: Likewise.
>>>>>> * gnu/packages/glib.scm (glibmm)[arguments]: Likewise.
>>>>>> * gnu/packages/gl.scm (glew)[arguments]: Likewise.
>>>>>> * gnu/packages/gnome.scm (icon-naming-utils, orbit2, libbonobo, gnome-vfs,
>>>>>> libgnome, libbonoboui, goffice-0.8, dconf)[arguments]: Likewise.
>>>>>> * gnu/packages/gprolog.scm (gprolog)[arguments]: Likewise.
>>>>>> * gnu/packages/gps.scm (gpscorrelate)[arguments]: Likewise.
>>>>>> * gnu/packages/graphics.scm (agg)[arguments]: Likewise.
>>>>>> * gnu/packages/gtk.scm (ganv, gtksourceview-2, guile-present,
>>>>>> python2-pycairo)
>>>>>> [arguments]: Likewise.
>>>>>> * gnu/packages/guile.scm (guile-1.8)[arguments]: Likewise.
>>>>>> * gnu/packages/guile-wm.scm (guile-wm)[arguments]: Likewise.
>>>>>> * gnu/packages/hugs.scm (hugs)[arguments]: Likewise.
>>>>>> * gnu/packages/hurd.scm (gnumach-headers, hurd-headers, hurd-minimal)
>>>>>> [arguments]: Likewise.
>>>>>> * gnu/packages/image-viewers.scm (feh, sxiv)[arguments]: Likewise.
>>>>>> * gnu/packages/libcanberra.scm (libcanberra)[arguments]: Likewise.
>>>>>> * gnu/packages/libsigsegv.scm (libsigsegv)[arguments]: Likewise.
>>>>>> * gnu/packages/linux.scm (zerofree, net-tools, bridge-utils, iw, fuse,
>>>>>> unionfs-fuse/static, lm-sensors, i2c-tools, xsensors, perf, mdadm, libaio,
>>>>>> module-init-tools)[arguments]: Likewise.
>>>>>> * gnu/packages/lisp.scm (ccl)[arguments]: Likewise.
>>>>>> * gnu/packages/lout.scm (lout)[arguments]: Likewise.
>>>>>> * gnu/packages/lua.scm (luajit)[arguments]: Likewise.
>>>>>> * gnu/packages/machine-learning.scm (shogun)[arguments]: Likewise.
>>>>>> * gnu/packages/mail.scm (exim)[arguments]: Likewise.
>>>>>> * gnu/packages/man.scm (man-pages, txt2man)[arguments]: Likewise.
>>>>>> * gnu/packages/maths.scm (lapack, superlu-dist, openlibm, openspecfun,
>>>>>> suitesparse)[arguments]: Likewise.
>>>>>> * gnu/packages/messaging.scm (bitlbee)[arguments]: Likewise.
>>>>>> * gnu/packages/mp3.scm (libmad, id3lib, mp3info)[arguments]: Likewise.
>>>>>> * gnu/packages/music.scm (solfege)[arguments]: Likewise.
>>>>>> * gnu/packages/noweb.scm (noweb)[arguments]: Likewise.
>>>>>> * gnu/packages/patchutils.scm (patchutils, quilt, colordiff)[arguments]:
>>>>>> Likewise.
>>>>>> * gnu/packages/pdf.scm (xpdf, zathura-cb, zathura-ps, zathura-djvu,
>>>>>> zathura-pdf-poppler, zathura, podofo, fbidag)[arguments]: Likewise.
>>>>>> * gnu/packages/perl.scm (perl-file-list, perl-test-harness)[arguments]:
>>>>>> Likewise.
>>>>>> * gnu/packages/photo.scm (gphoto2)[arguments]: Likewise.
>>>>>> * gnu/packages/popt.scm (popt)[arguments]: Likewise.
>>>>>> * gnu/packages/pretty-print.scm (source-highlight, astyle)[arguments]:
>>>>>> Likewise.
>>>>>> * gnu/packages/pumpio.scm (pumpa)[arguments]: Likewise.
>>>>>> * gnu/packages/python.scm (python-passlib, python-pycrypto, python2-empy,
>>>>>> python-sqlalchemy, python-docopt)[arguments]: Likewise.
>>>>>> * gnu/packages/rdf.scm (lrdf)[arguments]: Likewise.
>>>>>> * gnu/packages/regex.scm (tre)[arguments]: Likewise.
>>>>>> * gnu/packages/rrdtool.scm (rrdtool)[arguments]: Likewise.
>>>>>> * gnu/packages/ruby.scm (ruby-2.1, ruby-1.8)[arguments]: Likewise.
>>>>>> * gnu/packages/sawfish.scm (sawfish)[arguments]: Likewise.
>>>>>> * gnu/packages/scheme.scm (racket)[arguments]: Likewise.
>>>>>> * gnu/packages/sdl.scm (guile-sdl)[arguments]: Likewise.
>>>>>> * gnu/packages/serveez.scm (serveez)[arguments]: Likewise.
>>>>>> * gnu/packages/skribilo.scm (skribilo)[arguments]: Likewise.
>>>>>> * gnu/packages/smalltalk.scm (smalltalk)[arguments]: Likewise.
>>>>>> * gnu/packages/suckless.scm (dmenu, slock)[arguments]: Likewise.
>>>>>> * gnu/packages/tcl.scm (expect)[arguments]: Likewise.
>>>>>> * gnu/packages/telephony.scm (commoncpp)[arguments]: Likewise.
>>>>>> * gnu/packages/textutils.scm (recode, libgtextutils)[arguments]:
>>>>>> Likewise.
>>>>>> * gnu/packages/time.scm (time)[arguments]: Likewise.
>>>>>> * gnu/packages/tor.scm (privoxy)[arguments]: Likewise.
>>>>>> * gnu/packages/uucp.scm (uucp)[arguments]: Likewise.
>>>>>> * gnu/packages/video.scm (libdvdnav-4)[arguments]: Likewise.
>>>>>> * gnu/packages/web-browsers.scm (lynx)[arguments]: Likewise.
>>>>>> * gnu/packages/web.scm (tinyproxy)[arguments]: Likewise.
>>>>>> * gnu/packages/wicd.scm (wicd)[arguments]: Likewise.
>>>>>> * gnu/packages/wm.scm (bspwm)[arguments]: Likewise.
>>>>>> * gnu/packages/xdisorg.scm (sxhkd, xcape)[arguments]: Likewise.
>>>>>> * gnu/packages/xfce.scm (xfconf)[arguments]: Likewise.
>>>>>> * gnu/packages/xfig.scm (transfig)[arguments]: Likewise.
>>>>>> * gnu/packages/xorg.scm (imake)[arguments]: Likewise.
>>>>>
>>>>> Hello Kei!
>>>>>
>>>>> 'core-updates' is now merged. Let's try to get this patch in.
>>>>>
>>>>> I've read through the changed variables and think we can handle it on
>>>>> 'master', except 'bdb-5.3' which will have to wait until the next
>>>>> 'core-updates' cycle. Can you double check that this won't cause more
>>>>> than a few hundred rebuilds?
>>>>>
>>>>> Thanks!
>>>>
>>>> How does 1301 rebuilds sound?
>>>
>>> I think that will take several days (~week?) to complete, so it should
>>> be done on 'staging' so that users are not left without binary
>>> substitutes for very long.
>>>
>>> But then, we are probably facing a weeks worth of merge conflicts.
>>>
>>>> P.S. It seems that I have to type the patch a second time, so it may be
>>>> a while until I am able to push to master.
>>>
>>> I would assume `git cherry-pick` could resolve most hunks, no? Files
>>> with many conflicts may be easier to reset to their original state and
>>> redo.
>>>
>>
>> Maybe if my commits were split up? I have to read about
>> `git cherry-pick`.
>>
>>> If you do have to redo large parts of it, maybe we could do it in 3-4
>>> batches and keep an eye on Hydra in between? It would cause some extra
>>> rebuilds, but I suspect it's the least painful option.
>>
>> That could work. I'll see if I can have things sorted by tomorrow and
>> we'll go from there.
>
> The patches are in working order. The first patch would cause 1200
> rebuilds, but the second would only cause 128 rebuilds. Should I work on
> splitting up the first patch into pieces that Hydra can handle under its
> current load?

I'm not actually sure what's best here. It may be easiest to just throw
them both at 'staging' and accept the (hopefully few) merge conflicts.

Ludo, any preference?

If we're going staging, let's try to coordinate it so that we can start
it shortly after adding them. Maybe midnight tomorrow or Saturday UTC?
I have a few other updates in my queue that haven't been pushed yet.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmoQIAACgkQoqBt8qM6
VPpkJAgA0kNLvNF4wKIeCRtFqWrh/BzDMwKrydVDp7elCSDMuk/UBmw+6GQwgQTM
wyw5p6ajs5s+54hS+ZMOMQ+TNnDZzZJYXBMV81HfRvlGTBt4ARvv5+0gc2aiPt7C
6cMVKQGaZNPi+JhRqC4cCa3VjbCzGyfou0GnsYcEVJ+2JxX794aVQ+3llROeiOu2
/BffK90CVOXVEDVm4BICGx5rXhZ5cRfQQSWST9OdQEaaTV8io+lfqsNc/8zd3gzv
64FyqSqm5qCL0x5lV7Hz+2v9Wnr+QxLyQc/D+6i5Rr75bcJDqqT70Pv+fGyvkzAI
leJPAlr4IWSt7N8k0qhEJVMRa859ig==
=TF8v
-----END PGP SIGNATURE-----

Ludovic Courtès wrote 8 years ago
(name . Marius Bakke)(address . mbakke@fastmail.com)
87tw0m7ryl.fsf@gnu.org
Hello,

Marius Bakke <mbakke@fastmail.com> skribis:

Toggle quote (2 lines)
> Kei Kebreau <kkebreau@posteo.net> writes:

[...]

Toggle quote (10 lines)
>> The patches are in working order. The first patch would cause 1200
>> rebuilds, but the second would only cause 128 rebuilds. Should I work on
>> splitting up the first patch into pieces that Hydra can handle under its
>> current load?
>
> I'm not actually sure what's best here. It may be easiest to just throw
> them both at 'staging' and accept the (hopefully few) merge conflicts.
>
> Ludo, any preference?

The one that causes 128 rebuilds could go to ‘master’ (which is a good
thing: we won’t have conflicts with this part of the changes.)

The rest could go to ‘staging’ I suppose.

Toggle quote (4 lines)
> If we're going staging, let's try to coordinate it so that we can start
> it shortly after adding them. Maybe midnight tomorrow or Saturday UTC?
> I have a few other updates in my queue that haven't been pushed yet.

Sounds reasonable to me. I’ll let you coordinate. :-)

Thanks for taking care of this!

Ludo’.
Kei Kebreau wrote 8 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)
87bmmrdrtf.fsf@posteo.net
ludo@gnu.org (Ludovic Courtès) writes:

Toggle quote (21 lines)
> Hello,
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Kei Kebreau <kkebreau@posteo.net> writes:
>
> [...]
>
>>> The patches are in working order. The first patch would cause 1200
>>> rebuilds, but the second would only cause 128 rebuilds. Should I work on
>>> splitting up the first patch into pieces that Hydra can handle under its
>>> current load?
>>
>> I'm not actually sure what's best here. It may be easiest to just throw
>> them both at 'staging' and accept the (hopefully few) merge conflicts.
>>
>> Ludo, any preference?
>
> The one that causes 128 rebuilds could go to ‘master’ (which is a good
> thing: we won’t have conflicts with this part of the changes.)

I've committed the 128-rebuild patch to the master branch.

Toggle quote (10 lines)
>
> The rest could go to ‘staging’ I suppose.
>
>> If we're going staging, let's try to coordinate it so that we can start
>> it shortly after adding them. Maybe midnight tomorrow or Saturday UTC?
>> I have a few other updates in my queue that haven't been pushed yet.
>
> Sounds reasonable to me. I’ll let you coordinate. :-)
>

Marius, send me an email when you're ready!

Toggle quote (3 lines)
> Thanks for taking care of this!
>

:-)

Toggle quote (1 lines)
> Ludo’.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlms0u0ACgkQ5qXuPBlG
eg0olw//fA43pWXY8luJiToFU7szEpjdPocX4kMEBIXs+LnAnb0cLTN0+xzi4TNc
KlRvMYS8KC33St2DYKCMhqt2QDQ9ZDjIKkytYxxwn0GoDTcOMlZc4/IdWW8k/uNN
Xpk/lh80s5X2AtBJNIx6DTVNn87qBdyFcSWBktNt811dbdW8N8uPWxN8W8Sc+UK4
XbAvcv/AMKsgKKQM16U09HnaEK3tuL78zUA6dkX4nsbpIQjzPb3ZFxtfD9Qji2nX
BxGmps5o6uz38+s/GTG/FAkLu/3qFR7SpHXXiAxHQVydhqS9RLNghLFtNzp/PGJi
AmE2EIXcTaBa4Uc0SqZWeRuxwwwV9DbI6m7OTlVqYndEvkIs+jUQfJZx5F9Fl/QY
76NxFpvumxdJH+u99pbxaQzkgjAkWvr5OLDkVAYQATtxhej2e1VLdgqMuSBDYYa+
LfLbeTRmIQZrFo9btdwszVAGiH1XbZl4lgWv62Is/dRMbdBSo7C3NANWV5Rhenwz
+pACMvVzHOrPyql3VYfiGs91c0kpy2ejYT5MoIXr/L+RXDEpU6dxG1luRFt2+BCO
0EIfvg6EHPFA8sBN+fzFfS2ZTSYnvzLOlvJSIhbhiU0f/YI5g7Ihn2Rz+fyqeoS+
ob9lKRwkSGVwk/tmSZeEWzsVnw9Ar17SROF+OPWN9e8Rr26/Tpc=
=Cdaj
-----END PGP SIGNATURE-----

Marius Bakke wrote 8 years ago
(address . 27898@debbugs.gnu.org)
87k21ejj39.fsf@fastmail.com
Kei Kebreau <kkebreau@posteo.net> writes:

Toggle quote (11 lines)
>> The rest could go to ‘staging’ I suppose.
>>
>>> If we're going staging, let's try to coordinate it so that we can start
>>> it shortly after adding them. Maybe midnight tomorrow or Saturday UTC?
>>> I have a few other updates in my queue that haven't been pushed yet.
>>
>> Sounds reasonable to me. I’ll let you coordinate. :-)
>>
>
> Marius, send me an email when you're ready!

Ready when you are! I just merged in 'master' so it should be good to
go. I'll have a look at the rebuild count of the patch and see if
there's a lot of overlap with dbus and/or util-linux and possibly revert
those before starting Hydra.
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmtuZoACgkQoqBt8qM6
VPrcbgf8DzGVk6+0nXzWtzhdyEtvr9cMOik+BYKM4XDg+00fgDf1fH/r4fXPSKDC
VutIk1k2q0IUgGLF5kLuoFQuNLr6Ke8VV6AYLSKxuvhLi3o4PRAjieju9BprmIOg
HzjFeAvGub/+eVfi8OVrUHjFxDQ6+gP0yYvRSrCN/U1snn+PJEWO1/g25SPI3sCH
4jTGkgJjSM7ozVY1Ck5f+OIpOBWs2/9XBxL0dpKV5GBtmlL45M7zHQy1+7PvXVBs
vuqDXvuLbFQC0wsClUCzrIsB4pX3fTIddKnKyOhraCc6I+CFJtqf/NHDCZ58y3RC
21NOj5U+4IaKHJqzBpQWPf2QkoTuQw==
=sdfw
-----END PGP SIGNATURE-----

Ricardo Wurmus wrote 7 years ago
Re: [bug#27898] Clean-up of package phases
(name . Kei Kebreau)(address . kei@openmailbox.org)(address . 27898-done@debbugs.gnu.org)
87sheg2fxw.fsf@elephly.net
Kei Kebreau <kei@openmailbox.org> writes:

Toggle quote (4 lines)
> These patches address some issues with our package definitions, as
> partially discussed with Mark on guix-devel. I believe I've corrected
> all the cases that are fit for Guix's master branch.

Looks like this has already been pushed to the repository, so I’m
closing this now.

Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
Closed
?
Your comment

This issue is archived.

To comment on this conversation send an email to 27898@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 27898
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help