Danny Milosavljevic wrote 8 years ago
(address . bug-guix@gnu.org)
20170703210458.349d2dd5@scratchpost.org
netpbm is not reproducible
- Done
Details
- 2 participants
- Danny Milosavljevic
- Leo Famulari
- Owner
- unassigned
- Submitted by
- Danny Milosavljevic
- Severity
- normal
Danny Milosavljevic wrote 8 years ago
[PATCH] gnu: netpbm: Add "patch-timestamps" phase.
(address . 27567@debbugs.gnu.org)(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
20170703190801.13831-1-dannym@scratchpost.org
* gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
---
gnu/packages/netpbm.scm | 5 +++++
1 file changed, 5 insertions(+)
Toggle diff (16 lines)
diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..6b97d7e06 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -109,6 +109,11 @@
(arguments
`(#:phases
(modify-phases %standard-phases
+ (add-after 'unpack 'patch-timestamps
+ (lambda _
+ (substitute* "buildtools/makepointerman"
+ (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
+ #t))
(replace 'configure
(lambda* (#:key inputs outputs #:allow-other-keys)
(copy-file "config.mk.in" "config.mk")
Danny Milosavljevic wrote 8 years ago
[PATCH v2] gnu: netpbm: Remove timestamps.
(address . 27567@debbugs.gnu.org)(name . Danny Milosavljevic)(address . dannym@scratchpost.org)
20170703191638.26462-1-dannym@scratchpost.org
* gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
---
gnu/packages/netpbm.scm | 3 +++
1 file changed, 3 insertions(+)
Toggle diff (14 lines)
diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
index cd0c3d950..652c23aed 100644
--- a/gnu/packages/netpbm.scm
+++ b/gnu/packages/netpbm.scm
@@ -87,6 +87,9 @@
(drop "ppmtopjxl" in "converter/ppm")
;; Remove timestamps from the generated code.
+ (substitute* "buildtools/makepointerman"
+ (("gmctime[(][)]")
+ "\"Thu Jan 1 00:00:00 1970\""))
(substitute* "buildtools/stamp-date"
(("^DATE=.*")
"DATE=\"Thu Jan 01 00:00:00+0000 1970\"\n")
Leo Famulari wrote 8 years ago
Re: bug#27567: [PATCH] gnu: netpbm: Add "patch-timestamps" phase.
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 27567@debbugs.gnu.org)
20170704190156.GA30345@jasmine.lan
On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
Toggle quote (19 lines)
> * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> ---
> gnu/packages/netpbm.scm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..6b97d7e06 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -109,6 +109,11 @@
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'patch-timestamps
> + (lambda _
> + (substitute* "buildtools/makepointerman"
> + (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> + #t))
Why this particular date instead of the Unix epoch?
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllb5iEACgkQJkb6MLrK
fwgDmRAA3zfY+pFaw8bDTQl3SXWLnnqZCHtFslgVirFvcjiEwynFgFWbcFUh4t96
J0/C+I0iXayNuAa5oOBahIYOKomP/aP9J+sph7bS6A5u/iDLJFZkHA7zOD7g2HcB
WO8t5uvPg83yjRFJQTMfUwc2MzVwOPU4U9F04vib8/nb/++khgVvwAqCjgcT13iW
LkjpO4SsK+IlWyiQ8cgpvgcOlKs2saZFpUejz1ibwFYRm0/XrSHuIBtATUGezdxS
UoqvLDdMffvvQhSSlEyBePh7jFPCIYMcE/xVuL4WlUGH/aEjcQbezwRuBe1mXkjx
zOCJLSSC3ReRKfDavrDGQManfasQxcwQZmeshKyh7kSBspS3NWncx4MO17n266ia
CnQp4Nd6fMCgQ+8ni8r5LT0PVlx8o9ku6h3qfGmxUcLdfBt3OCMQxE7rJNArkyyk
soc+ud9l83mn403gymBeKL9wD4QZYbzUJNPwEclgnOwv9c9X6iqlh27FWJlqh/A7
HsQanbAcGX9xXEk0FuY3gU+TGzPkJmLk5lyldYNhK/i0jB+4lX5MhNf+SMa+bpae
5DRLd9u0XTp7PtrowG3e63eUP56mYve+Rk1+nkcoqAQCykibd/cGrQlOwXD5Fl7Y
ZEYCN/IqTNBys+/PVp/D68XFo3jZT33DQHXW6SYT3TnnSODif4I=
=4n73
-----END PGP SIGNATURE-----
Danny Milosavljevic wrote 8 years ago
(name . Leo Famulari)(address . leo@famulari.name)(address . 27567@debbugs.gnu.org)
20170704210400.78070e01@scratchpost.org
Hi Leo,
On Tue, 4 Jul 2017 15:01:56 -0400
Leo Famulari <leo@famulari.name> wrote:
Toggle quote (8 lines)
> On Mon, Jul 03, 2017 at 09:08:01PM +0200, Danny Milosavljevic wrote:
> > * gnu/packages/netpbm.scm (netpbm): Add "patch-timestamps" phase.
> > ---
> > + (("gmctime\\(\\)\\)") "Thu Apr 9 18:15:06 1998")
> > + #t))
>
> Why this particular date instead of the Unix epoch?
Copy & paste from example. We can use the Unix epoch as well :)
Leo Famulari wrote 8 years ago
Re: bug#27567: [PATCH v2] gnu: netpbm: Remove timestamps.
(name . Danny Milosavljevic)(address . dannym@scratchpost.org)(address . 27567@debbugs.gnu.org)
20170704190442.GB30345@jasmine.lan
On Mon, Jul 03, 2017 at 09:16:38PM +0200, Danny Milosavljevic wrote:
Toggle quote (17 lines)
> * gnu/packages/netpbm.scm (netpbm)[source]: Remove timestamps.
> ---
> gnu/packages/netpbm.scm | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/netpbm.scm b/gnu/packages/netpbm.scm
> index cd0c3d950..652c23aed 100644
> --- a/gnu/packages/netpbm.scm
> +++ b/gnu/packages/netpbm.scm
> @@ -87,6 +87,9 @@
> (drop "ppmtopjxl" in "converter/ppm")
>
> ;; Remove timestamps from the generated code.
> + (substitute* "buildtools/makepointerman"
> + (("gmctime[(][)]")
> + "\"Thu Jan 1 00:00:00 1970\""))
I'm not sure what's going on with core-updates: the last evaluation was
aborted.
So, assuming that you can build groff on core-updates with this change
before Hydra builds netpbm on core-updates, LGTM. Once we build
core-updates to that point, we should wait for the next core-updates
cycle.
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllb5soACgkQJkb6MLrK
fwjcgxAAl02hGB5KIsQuGozFGrURs26lczwWTTImdIeI4O1AV8zPKMkUB64Uu4lK
7dB4O6Cr8K9qNSFPEKA0l0jgIeLgDaOxqg7NcZtuCA5+Sh8NdeCkW8DniV7qQY9A
JvnTrzkMEIIzWzl2jz26qvix3BjL2ghnoht7EAMNyZgdOa5ItVKrsYAfB5bh+n5D
QB8zcZPKBcXYiHX7QqBKuiSmmVBrZe2m7k0v6CqiCxV89JzmL8JliLpcaThj2BXi
xYEK3yuDr0RJww8FK79+gq2RrhqL6fLqPk8+0wf3BKp9sMU82ZXAinlHkyjpiaQI
zq6xNWa8CzEOFb0BoogHfpjm88QhzHJeTYlc0UPfbxF7DPkxJEtipAsnjFAJz8w+
sIZQU/1QmnDyUAlb3B4dGxG8OkiThgZcAIqhjBk+GqF+Qds1Y8SUjttI+ofD4vaT
SPc+n/r0u39L/LL4gwP0JVQIWInbvDzj+1kssr9Gwy8WjjKTr3DtZVkMnLSBJ1N2
v/Kosu3s4ERGga/eyr1q82br641K2T/E1Qc3q8KcB7IOVMF9UZpg76xu7bOCyx0d
oLL1Gx8yQ25z74d0k623sWpgtUAk3Vykef0v0GteA0rLsb6q9jlGw6AkT0P5MiqJ
ovNWver1skIB9ECrW0nCQ8ySQxJGk3bGxka1qXWYE3vl+QrVx4E=
=fAej
-----END PGP SIGNATURE-----
Danny Milosavljevic wrote 8 years ago
(no subject)
(address . control@debbugs.gnu.org)
20170706024707.070a4cd7@scratchpost.org
close 27567
close 27563
?