[PATCH] maint: Mention the Signed-off-by line in 'HACKING'.

  • Done
  • quality assurance status badge
Details
3 participants
  • Clément Lassieur
  • ng0
  • Marius Bakke
Owner
unassigned
Submitted by
Clément Lassieur
Severity
normal
C
C
Clément Lassieur wrote on 21 Mar 2017 22:20
(address . guix-patches@gnu.org)(address . leo@famulari.name)
20170321212017.15176-1-clement@lassieur.org
* HACKING: Mention the Signed-off-by line.
---
HACKING | 4 ++++
1 file changed, 4 insertions(+)

Toggle diff (17 lines)
diff --git a/HACKING b/HACKING
index 46a724961..26f828bd6 100644
--- a/HACKING
+++ b/HACKING
@@ -50,6 +50,10 @@ You can prevent yourself from accidentally pushing unsigned commits to Savannah
by using the pre-push Git hook called 'pre-push'. It's located at
'etc/git/pre-push'.
+When pushing a commit on behalf of somebody else, you should add a
+Signed-off-by line at the end of the commit log message (e.g. with ‘git am
+--signoff’). This improves tracking of who did what.
+
For anything else, please post to guix-patches@gnu.org and leave time for a
review, without committing anything. If you didn’t receive any reply
after two weeks, and if you’re confident, it’s OK to commit.
--
2.12.0
M
M
Marius Bakke wrote on 23 Mar 2017 18:57
874lyj6flk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me
Clément Lassieur <clement@lassieur.org> writes:

Toggle quote (17 lines)
> * HACKING: Mention the Signed-off-by line.
> ---
> HACKING | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/HACKING b/HACKING
> index 46a724961..26f828bd6 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -50,6 +50,10 @@ You can prevent yourself from accidentally pushing unsigned commits to Savannah
> by using the pre-push Git hook called 'pre-push'. It's located at
> 'etc/git/pre-push'.
>
> +When pushing a commit on behalf of somebody else, you should add a
> +Signed-off-by line at the end of the commit log message (e.g. with ‘git am
> +--signoff’). This improves tracking of who did what.

s/you should/please. Otherwise LGTM.
Toggle quote (6 lines)
> +
> For anything else, please post to guix-patches@gnu.org and leave time for a
> review, without committing anything. If you didn’t receive any reply
> after two weeks, and if you’re confident, it’s OK to commit.
> --
> 2.12.0
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAljUDIgACgkQoqBt8qM6
VPoQtQf+LDTxvpfjtAE7Pjoiyr+vgPa5H+0z9KGttJ9WK76hpmxq4th+/wyzmz7+
ijvqA3rExc7JbGcxz3LdkBPABhBEo6Oi29rV5lLdbFsm2zRWT4O2e0vu9yMbyCJr
tBjiQKILY8/+39v7J/F2EuSeRVQbqli5Da01rGNN532bb4zRcK9E4skWWDrCTzVj
RcJUcSi8tVEiEoVy97qLICDBkod2xG6XhLKMady3VvqtKRPTYzTiS3rjKdz7GnoL
QGmEA7FrqugUw3sfS9UfQbLQt+YsGJqhm8Ev5/OmxpVigoCnd3vuxTKaDKOdc/FA
n2CGzH68uUCUPU/3CylajbV+KYN06g==
=7jn+
-----END PGP SIGNATURE-----

C
C
Clément Lassieur wrote on 24 Mar 2017 13:58
(name . Marius Bakke)(address . mbakke@fastmail.com)(address . 26213@debbugs.gnu.org)
87shm2q1a5.fsf@lassieur.org
Marius Bakke <mbakke@fastmail.com> writes:

Toggle quote (21 lines)
> Clément Lassieur <clement@lassieur.org> writes:
>
>> * HACKING: Mention the Signed-off-by line.
>> ---
>> HACKING | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/HACKING b/HACKING
>> index 46a724961..26f828bd6 100644
>> --- a/HACKING
>> +++ b/HACKING
>> @@ -50,6 +50,10 @@ You can prevent yourself from accidentally pushing unsigned commits to Savannah
>> by using the pre-push Git hook called 'pre-push'. It's located at
>> 'etc/git/pre-push'.
>>
>> +When pushing a commit on behalf of somebody else, you should add a
>> +Signed-off-by line at the end of the commit log message (e.g. with ‘git am
>> +--signoff’). This improves tracking of who did what.
>
> s/you should/please. Otherwise LGTM.

Thank you for reviewing! Pushed.

Toggle quote (5 lines)
>> For anything else, please post to guix-patches@gnu.org and leave time for a
>> review, without committing anything. If you didn’t receive any reply
>> after two weeks, and if you’re confident, it’s OK to commit.
>> --
>> 2.12.0
C
C
Clément Lassieur wrote on 24 Mar 2017 13:59
control message for bug #26213
(address . control@debbugs.gnu.org)
87r31mq19c.fsf@lassieur.org
tags 26213 fixed
close 26213
N
Re: bug#26213: [PATCH] maint: Mention the Signed-off-by line in 'HACKING'.
(name . Clément Lassieur)(address . clement@lassieur.org)
20170324164800.lttfhbrsidqe6nem@abyayala
Clément Lassieur transcribed 1.0K bytes:
Toggle quote (25 lines)
> Marius Bakke <mbakke@fastmail.com> writes:
>
> > Clément Lassieur <clement@lassieur.org> writes:
> >
> >> * HACKING: Mention the Signed-off-by line.
> >> ---
> >> HACKING | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/HACKING b/HACKING
> >> index 46a724961..26f828bd6 100644
> >> --- a/HACKING
> >> +++ b/HACKING
> >> @@ -50,6 +50,10 @@ You can prevent yourself from accidentally pushing unsigned commits to Savannah
> >> by using the pre-push Git hook called 'pre-push'. It's located at
> >> 'etc/git/pre-push'.
> >>
> >> +When pushing a commit on behalf of somebody else, you should add a
> >> +Signed-off-by line at the end of the commit log message (e.g. with ‘git am
> >> +--signoff’). This improves tracking of who did what.
> >
> > s/you should/please. Otherwise LGTM.
>
> Thank you for reviewing! Pushed.

Okay, closed.
Toggle quote (9 lines)
> >> For anything else, please post to guix-patches@gnu.org and leave time for a
> >> review, without committing anything. If you didn’t receive any reply
> >> after two weeks, and if you’re confident, it’s OK to commit.
> >> --
> >> 2.12.0
>
>
>
>
Closed
?