I'm not very familiar with ant-build-system, but isn't ant available inPATH here (so you can simply (system* "ant"))? It should probably alsobe wrapped in a (zero? (system* ..)) so that the return value is checked.
"install-file" (or actually "copy-file" from reading (guix build utils)has an unspecified return value, so this phase should end with anexplicit #t.
Toggle quote (10 lines)> + (home-page "https://xmlgraphics.apache.org/fop/")> + (synopsis "Formatting objects processor")> + (description "Apache FOP is a print formatter driven by XSL formatting> +objects (XSL-FO) and an output independent formatter. It is a Java application> +that reads a formatting object (FO) tree and renders the resulting pages to a> +specified output. Output formats currently supported include PDF, PS, PCL,> +AFP, XML (area tree representation), Print, AWT and PNG, and to a lesser> +extent, RTF and TXT. The primary output target is PDF.")> + (license license:asl2.0)))
I did not do a license audit of this package, but please double checkthat all bundled software also carries this license (or mention theirshere). The rest LGTM.
Hi Roel, as Marius already mentioned, Java people have the tendency to just put abunch of (binary) jar files in a lib folder. In GuixSD, we want alldependencies be built and brought in by Guix. That has two advantages: 1. We can be sure that the dependencies are really what they claimto be, built from the available sources.2. If there are (security) updates in the dependencies they will beupdated automatically. Building the dependencies can be quite annoying, because they requireother dependencies to be available, and so on ... That's one of thereasons why Java support in GuixSD is yet very limited. There is a patch-series by Hartmut Goebel not yet applied, containingconnons-lang and commons-io: https://lists.gnu.org/archive/html/guix-devel/2016-09/threads.html#00774 Maybe you can start with these? Björn
(name . Björn Höfling)(address . firstname.lastname@example.org)
Björn Höfling <email@example.com> writes:
Toggle quote (7 lines)> There is a patch-series by Hartmut Goebel not yet applied, containing> connons-lang and commons-io:>> https://lists.gnu.org/archive/html/guix-devel/2016-09/threads.html#00774>> Maybe you can start with these?
I have taken the patches from Hartmut, cleaned them up, added a coupleof more dependencies to run tests … and then got stuck at some pointagain. I have a big WIP branch for that and I think before someone elsestarts from scratch I should share the branch. I’ll try to get something ready for merging/sharing/collaborating thisweekend. (Feel free to ping me if you don’t hear from me about this.) --Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAChttps://elephly.net