307 "Temporary Redirect" is not handled

DoneSubmitted by Alex Kost.
Details
2 participants
  • Alex Kost
  • Ludovic Courtès
Owner
unassigned
Severity
normal
A
A
Alex Kost wrote on 12 Apr 2016 10:23
(address . bug-guix@gnu.org)
87a8kzz15a.fsf@gmail.com
As discovered by Albin Söderqvist (see the commentary in his 'openttd'patch [1]), the following command fails:
guix download http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz
with the following error:
Toggle snippet (7 lines)Starting download of /tmp/guix-file.sYMDJZFrom http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz...ERROR: download failed "http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz" 307 "Temporary Redirect"failed to download "/tmp/guix-file.sYMDJZ" from "http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz"guix download: error: http://binaries.openttd.org/releases/1.6.0/openttd-1.6.0-source.tar.xz: download failed
This happens because 'http-fetch' procedure from (guix build download)module handles only 301 and 302 codes, while here we have 307 [2] [3].
The attached patch fixes this problem.
[1] http://lists.gnu.org/archive/html/guix-devel/2016-04/msg00445.html[2] https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_Redirection[3] https://tools.ietf.org/html/rfc2616#section-10.3.8
From d0ee21dd4e8c34e7d3f23eb69943026706d24d37 Mon Sep 17 00:00:00 2001From: Alex Kost <alezost@gmail.com>Date: Tue, 12 Apr 2016 11:14:59 +0300Subject: [PATCH] download: Follow HTTP 307 "Temporary Redirection".MIME-Version: 1.0Content-Type: text/plain; charset=UTF-8Content-Transfer-Encoding: 8bit
Reported by Albin Söderqvist <albin@fripost.org>.
* guix/build/download.scm (http-fetch): Follow redirections upon 307. This is what 'binaries.openttd.org' does.--- guix/build/download.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Toggle diff (16 lines)diff --git a/guix/build/download.scm b/guix/build/download.scmindex 0568800..fb236d3 100644--- a/guix/build/download.scm+++ b/guix/build/download.scm@@ -530,7 +530,8 @@ Return the resulting target URI." (put-bytevector p bv-or-port)))) file)) ((301 ; moved permanently- 302) ; found (redirection)+ 302 ; found (redirection)+ 307) ; temporary redirection (let ((uri (resolve-uri-reference (response-location resp) uri))) (format #t "following redirection to `~a'...~%" (uri->string uri))-- 2.7.3
L
L
Ludovic Courtès wrote on 13 Apr 2016 22:35
(name . Alex Kost)(address . alezost@gmail.com)(address . 23275@debbugs.gnu.org)
87lh4hfds4.fsf@gnu.org
Alex Kost <alezost@gmail.com> skribis:
Toggle quote (13 lines)> From d0ee21dd4e8c34e7d3f23eb69943026706d24d37 Mon Sep 17 00:00:00 2001> From: Alex Kost <alezost@gmail.com>> Date: Tue, 12 Apr 2016 11:14:59 +0300> Subject: [PATCH] download: Follow HTTP 307 "Temporary Redirection".> MIME-Version: 1.0> Content-Type: text/plain; charset=UTF-8> Content-Transfer-Encoding: 8bit>> Reported by Albin Söderqvist <albin@fripost.org>.>> * guix/build/download.scm (http-fetch): Follow redirections upon 307.> This is what 'binaries.openttd.org' does.
Sure, please push!
(Please add “Fixes …” in the commit log.)
Thanks!
Ludo’.
A
A
Alex Kost wrote on 14 Apr 2016 10:07
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 23275@debbugs.gnu.org)
87zisw1ump.fsf@gmail.com
Ludovic Courtès (2016-04-13 23:35 +0300) wrote:
Toggle quote (19 lines)> Alex Kost <alezost@gmail.com> skribis:>>> From d0ee21dd4e8c34e7d3f23eb69943026706d24d37 Mon Sep 17 00:00:00 2001>> From: Alex Kost <alezost@gmail.com>>> Date: Tue, 12 Apr 2016 11:14:59 +0300>> Subject: [PATCH] download: Follow HTTP 307 "Temporary Redirection".>> MIME-Version: 1.0>> Content-Type: text/plain; charset=UTF-8>> Content-Transfer-Encoding: 8bit>>>> Reported by Albin Söderqvist <albin@fripost.org>.>>>> * guix/build/download.scm (http-fetch): Follow redirections upon 307.>> This is what 'binaries.openttd.org' does.>> Sure, please push!>> (Please add “Fixes …” in the commit log.)
Done and committed as 82fd23b.
-- Alex
A
A
Alex Kost wrote on 14 Apr 2016 10:08
control message for bug #23275
(address . control@debbugs.gnu.org)
87wpo01ukn.fsf@gmail.com
tags 23275 fixedclose 23275
?
Your comment

This issue is archived.

To comment on this conversation send email to 23275@debbugs.gnu.org