Freshness check blocks upgrading

  • Done
  • quality assurance status badge
Details
5 participants
  • Alex Kost
  • Andreas Enge
  • Leo Famulari
  • Ludovic Courtès
  • Ricardo Wurmus
Owner
unassigned
Submitted by
Andreas Enge
Severity
normal

Debbugs page

Andreas Enge wrote 9 years ago
(address . bug-guix@gnu.org)
20160219171209.GA530@solar
Hello,

when upgrading packages, there is a check for new GNU releases.
In the presence of network problems preventing to reach the corresponding
servers, the command "guix package -u" hangs indefinitely.

It would be nice to add a (short) time-out to the procedure looking
for updates, or better yet, to add a command line flag to turn it off:
Even when the servers are reachable, checking for new versions takes
a considerable amount of time that can be saved in many circumstances.

Personally, I would not even mind turning this feature off completely;
I think we update packages sufficiently often and the message is rather
distracting.

Andreas
Leo Famulari wrote 9 years ago
(name . Andreas Enge)(address . andreas@enge.fr)(address . 22740@debbugs.gnu.org)
20160220062505.GA14544@jasmine
On Fri, Feb 19, 2016 at 06:12:09PM +0100, Andreas Enge wrote:
Toggle quote (15 lines)
> Hello,
>
> when upgrading packages, there is a check for new GNU releases.
> In the presence of network problems preventing to reach the corresponding
> servers, the command "guix package -u" hangs indefinitely.
>
> It would be nice to add a (short) time-out to the procedure looking
> for updates, or better yet, to add a command line flag to turn it off:
> Even when the servers are reachable, checking for new versions takes
> a considerable amount of time that can be saved in many circumstances.
>
> Personally, I would not even mind turning this feature off completely;
> I think we update packages sufficiently often and the message is rather
> distracting.

It does seem out of place while upgrading. It could be considered
extraneous to the features of `guix refresh`.

Toggle quote (6 lines)
>
> Andreas
>
>
>
>
Alex Kost wrote 9 years ago
(name . Andreas Enge)(address . andreas@enge.fr)(address . 22740@debbugs.gnu.org)
87mvqv943a.fsf@gmail.com
Andreas Enge (2016-02-19 20:12 +0300) wrote:

Toggle quote (13 lines)
> Hello,
>
> when upgrading packages, there is a check for new GNU releases.
> In the presence of network problems preventing to reach the corresponding
> servers, the command "guix package -u" hangs indefinitely.
>
> It would be nice to add a (short) time-out to the procedure looking
> for updates, or better yet, to add a command line flag to turn it off:
> Even when the servers are reachable, checking for new versions takes
> a considerable amount of time that can be saved in many circumstances.
>
> Personally, I would not even mind turning this feature off completely;

I totally agree with this! I didn't like it since the very beginning.

Toggle quote (3 lines)
> I think we update packages sufficiently often and the message is rather
> distracting.

--
Alex
Ricardo Wurmus wrote 9 years ago
(name . Leo Famulari)(address . leo@famulari.name)
87y4af4udx.fsf@mdc-berlin.de
Leo Famulari <leo@famulari.name> writes:

Toggle quote (19 lines)
> On Fri, Feb 19, 2016 at 06:12:09PM +0100, Andreas Enge wrote:
>> Hello,
>>
>> when upgrading packages, there is a check for new GNU releases.
>> In the presence of network problems preventing to reach the corresponding
>> servers, the command "guix package -u" hangs indefinitely.
>>
>> It would be nice to add a (short) time-out to the procedure looking
>> for updates, or better yet, to add a command line flag to turn it off:
>> Even when the servers are reachable, checking for new versions takes
>> a considerable amount of time that can be saved in many circumstances.
>>
>> Personally, I would not even mind turning this feature off completely;
>> I think we update packages sufficiently often and the message is rather
>> distracting.
>
> It does seem out of place while upgrading. It could be considered
> extraneous to the features of `guix refresh`.

I agree. It seems to better fit with “guix refresh”.
Ludovic Courtès wrote 9 years ago
(name . Alex Kost)(address . alezost@gmail.com)
874md0moo2.fsf@gnu.org
Alex Kost <alezost@gmail.com> skribis:

Toggle quote (17 lines)
> Andreas Enge (2016-02-19 20:12 +0300) wrote:
>
>> Hello,
>>
>> when upgrading packages, there is a check for new GNU releases.
>> In the presence of network problems preventing to reach the corresponding
>> servers, the command "guix package -u" hangs indefinitely.
>>
>> It would be nice to add a (short) time-out to the procedure looking
>> for updates, or better yet, to add a command line flag to turn it off:
>> Even when the servers are reachable, checking for new versions takes
>> a considerable amount of time that can be saved in many circumstances.
>>
>> Personally, I would not even mind turning this feature off completely;
>
> I totally agree with this! I didn't like it since the very beginning.

I agree. I implemented it mostly for the fun of it and to demonstrate
that we could possibly do “clever” things with access to high-level
package objects (the command could automatically offer to use the new
source instead of the old one), but in practice it’s been largely
annoying.

Ludo’, waiting for the patch that removes it. :-)
Alex Kost wrote 9 years ago
(name . Ludovic Courtès)(address . ludo@gnu.org)(address . 22740@debbugs.gnu.org)
87k2lvolh5.fsf@gmail.com
Ludovic Courtès (2016-02-23 00:16 +0300) wrote:

Toggle quote (27 lines)
> Alex Kost <alezost@gmail.com> skribis:
>
>> Andreas Enge (2016-02-19 20:12 +0300) wrote:
>>
>>> Hello,
>>>
>>> when upgrading packages, there is a check for new GNU releases.
>>> In the presence of network problems preventing to reach the corresponding
>>> servers, the command "guix package -u" hangs indefinitely.
>>>
>>> It would be nice to add a (short) time-out to the procedure looking
>>> for updates, or better yet, to add a command line flag to turn it off:
>>> Even when the servers are reachable, checking for new versions takes
>>> a considerable amount of time that can be saved in many circumstances.
>>>
>>> Personally, I would not even mind turning this feature off completely;
>>
>> I totally agree with this! I didn't like it since the very beginning.
>
> I agree. I implemented it mostly for the fun of it and to demonstrate
> that we could possibly do “clever” things with access to high-level
> package objects (the command could automatically offer to use the new
> source instead of the old one), but in practice it’s been largely
> annoying.
>
> Ludo’, waiting for the patch that removes it. :-)

Attached. I also removed 'check-package-freshness' from (gnu packages)
as it is not used anywhere else, or should it be left?
Attachment: 0001-Do-not-check-package-freshness-during-upgrade.patch
Andreas Enge wrote 9 years ago
(name . Alex Kost)(address . alezost@gmail.com)
20160223091824.GD19217@solar
On Tue, Feb 23, 2016 at 11:54:30AM +0300, Alex Kost wrote:
Toggle quote (3 lines)
> Attached. I also removed 'check-package-freshness' from (gnu packages)
> as it is not used anywhere else, or should it be left?

I think it is good, please push. (Assuming that "guix refresh" still
works and none of the procedures you remove are still used.)

One of the procedures has the comment: "This has a noticeable impact when
doing "guix upgrade -u"." It looks like we are going way back into the
history of guix!

Andreas
Ludovic Courtès wrote 9 years ago
(name . Alex Kost)(address . alezost@gmail.com)(address . 22740@debbugs.gnu.org)
87bn77gxu3.fsf@gnu.org
Alex Kost <alezost@gmail.com> skribis:

Toggle quote (3 lines)
> Attached. I also removed 'check-package-freshness' from (gnu packages)
> as it is not used anywhere else, or should it be left?

It’s fine to remove it.

Toggle quote (12 lines)
> From 1d6d4d0864672b0676f09eb6c8285684e5b8785c Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Tue, 23 Feb 2016 11:38:00 +0300
> Subject: [PATCH] Do not check package freshness during upgrade.
>
> Fixes <http://bugs.gnu.org/22740>.
> Reported by Andreas Enge <andreas@enge.fr>.
>
> * gnu/packages.scm (waiting, ftp-open*, check-package-freshness): Remove.
> * guix/scripts/package.scm (options->installable): Adjust accordingly.
> * emacs/guix-main.scm (package->manifest-entry*): Likewise.

OK, thanks!

Ludo’.
Alex Kost wrote 9 years ago
(address . 22740@debbugs.gnu.org)
87k2lucd5l.fsf@gmail.com
Andreas Enge (2016-02-23 12:18 +0300) wrote:

Toggle quote (7 lines)
> On Tue, Feb 23, 2016 at 11:54:30AM +0300, Alex Kost wrote:
>> Attached. I also removed 'check-package-freshness' from (gnu packages)
>> as it is not used anywhere else, or should it be left?
>
> I think it is good, please push. (Assuming that "guix refresh" still
> works and none of the procedures you remove are still used.)

Ludovic Courtès (2016-02-23 20:07 +0300) wrote:

Toggle quote (7 lines)
> Alex Kost <alezost@gmail.com> skribis:
>
>> Attached. I also removed 'check-package-freshness' from (gnu packages)
>> as it is not used anywhere else, or should it be left?
>
> It’s fine to remove it.

The patch committed, thanks.

--
Alex
Ludovic Courtès wrote 9 years ago
control message for bug #22740
(address . control@debbugs.gnu.org)
87fuwcvc22.fsf@gnu.org
close 22740 0.9.1
?
Your comment

This issue is archived.

To comment on this conversation send an email to 22740@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it
mumi current 22740
Then, you may apply the latest patchset in this issue (with sign off)
mumi am -- -s
Or, compose a reply to this issue
mumi compose
Or, send patches to this issue
mumi send-email *.patch
You may also tag this issue. See list of standard tags. For example, to set the confirmed and easy tags
mumi command -t +confirmed -t +easy
Or, remove the moreinfo tag and set the help tag
mumi command -t -moreinfo -t +help