ilmbase test fails on i686-linux

  • Done
  • quality assurance status badge
Details
4 participants
  • Leo Famulari
  • Ludovic Courtès
  • Mark H Weaver
  • rennes
Owner
unassigned
Submitted by
rennes
Severity
normal
R
R
rennes wrote on 29 Nov 2015 04:42
libreoffice compile error
(address . bug-guix@gnu.org)
21c1059e083d3df68b981cb1a83b3a7c@openmailbox.org
hi,

i try install libreoffice in guixsd (guix package -i libreoffice) and
return error:

can you help me please.

...


ImathTest: testBoxAlgo.cpp:892: void {anonymous}::boxMatrixTransform():
Assertion `b21 == b2' failed.
/gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line
5: 4297 Aborted ${dir}$tst
FAIL: ImathTest
==================
1 of 1 test failed
==================
Makefile:403: recipe for target 'check-TESTS' failed
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory
'/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'
Makefile:525: recipe for target 'check-am' failed
make[1]: *** [check-am] Error 2
make[1]: Leaving directory
'/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'
Makefile:356: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
phase `check' failed after 39.8 seconds
builder for
`/gnu/store/ihwc1rm9ka080x223bf3ajp4d2n1sgnz-ilmbase-2.2.0.drv' failed
with exit code 1
cannot build derivation
`/gnu/store/970sjpar4z0yy99if7p6nm7a4k4nx9zp-vigra-1.10.0.drv': 1
dependencies couldn't be built
cannot build derivation
`/gnu/store/vhbikp9n9kzzjrl9dg2x5aq9xhr38294-libreoffice-5.0.0.2.drv': 1
dependencies couldn't be built
cannot build derivation
`/gnu/store/l7gvchzisln5q0dr4l9px6ikpqp1y9m2-profile.drv': 1
dependencies couldn't be built
guix package: error: build failed: build of
`/gnu/store/l7gvchzisln5q0dr4l9px6ikpqp1y9m2-profile.drv' failed
L
L
Ludovic Courtès wrote on 29 Nov 2015 16:02
(address . rennes@openmailbox.org)(address . 22049@debbugs.gnu.org)
877fl0lugc.fsf@gnu.org
rennes@openmailbox.org skribis:

Toggle quote (3 lines)
> i try install libreoffice in guixsd (guix package -i libreoffice) and
> return error:

[...]

Toggle quote (13 lines)
> ImathTest: testBoxAlgo.cpp:892: void
> {anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.
> /gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line
> 5: 4297 Aborted ${dir}$tst
> FAIL: ImathTest
> ==================
> 1 of 1 test failed
> ==================
> Makefile:403: recipe for target 'check-TESTS' failed
> make[2]: *** [check-TESTS] Error 1
> make[2]: Leaving directory
> '/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'

What platform is this on? i686, x86_64, armhf, or mips64el?

Thanks for your report!

Ludo’.
R
R
rennes wrote on 29 Nov 2015 17:50
(address . ludo@gnu.org)(address . 22049@debbugs.gnu.org)
931b1698a0a6d10913db88e944622dc4@openmailbox.org
On 2015-11-29 09:02, ludo@gnu.org wrote:
Toggle quote (28 lines)
> rennes@openmailbox.org skribis:
>
>> i try install libreoffice in guixsd (guix package -i libreoffice) and
>> return error:
>
> [...]
>
>> ImathTest: testBoxAlgo.cpp:892: void
>> {anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.
>> /gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line
>> 5: 4297 Aborted ${dir}$tst
>> FAIL: ImathTest
>> ==================
>> 1 of 1 test failed
>> ==================
>> Makefile:403: recipe for target 'check-TESTS' failed
>> make[2]: *** [check-TESTS] Error 1
>> make[2]: Leaving directory
>> '/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'
>
> What platform is this on? i686, x86_64, armhf, or mips64el?
>
> Thanks for your report!
>
> Ludo’.



Hi Ludo,

i use i686 in virtualbox.

and thanks.
L
L
Ludovic Courtès wrote on 29 Nov 2015 21:25
retitle
(address . request@debbugs.gnu.org)
87si3oimdn.fsf@gnu.org
retitle 22049 ilmbase test fails on i686-linux
thanks
L
L
Leo Famulari wrote on 30 Nov 2015 20:56
Re: bug#22049: libreoffice compile error
(address . rennes@openmailbox.org)
20151130195654.GA32198@jasmine
On Sun, Nov 29, 2015 at 10:50:22AM -0600, rennes@openmailbox.org wrote:
Toggle quote (35 lines)
> On 2015-11-29 09:02, ludo@gnu.org wrote:
> >rennes@openmailbox.org skribis:
> >
> >>i try install libreoffice in guixsd (guix package -i libreoffice) and
> >>return error:
> >
> >[...]
> >
> >>ImathTest: testBoxAlgo.cpp:892: void
> >>{anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.
> >>/gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line
> >>5: 4297 Aborted ${dir}$tst
> >>FAIL: ImathTest
> >>==================
> >>1 of 1 test failed
> >>==================
> >>Makefile:403: recipe for target 'check-TESTS' failed
> >>make[2]: *** [check-TESTS] Error 1
> >>make[2]: Leaving directory
> >>'/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'
> >
> >What platform is this on? i686, x86_64, armhf, or mips64el?
> >
> >Thanks for your report!
> >
> >Ludo’.
>
>
>
> Hi Ludo,
>
> i use i686 in virtualbox.
>
> and thanks.

It looks like the problem is with a libreoffice dependency, ilmbase.
Looking at the build history on hydra.gnu.org, it hasn't built
successfully since at least 2015-02-25:

Here is how to view the most recent build log from the command line:
$ guix build --system=i686-linux --log-file ilmbase

And here it can be viewed in a browser:
L
L
Ludovic Courtès wrote on 30 Nov 2015 21:14
(name . Leo Famulari)(address . leo@famulari.name)
8737vn453a.fsf@gnu.org
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (5 lines)
> It looks like the problem is with a libreoffice dependency, ilmbase.
> Looking at the build history on hydra.gnu.org, it hasn't built
> successfully since at least 2015-02-25:
> http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux

Right. This sounds very much like a rounding issue, whereby the epsilon
in floating-point number comparisons is to strict for 32-bit machines.

We should report it upstream, but I don’t see any clear way to report
bugs, neither in README, nor on openexr.com. Am I overlooking it?

Ludo’.
L
L
Leo Famulari wrote on 1 Dec 2015 06:58
(name . Ludovic Courtès)(address . ludo@gnu.org)
20151201055827.GB6294@jasmine
On Mon, Nov 30, 2015 at 10:14:49PM +0200, Ludovic Courtès wrote:
Toggle quote (13 lines)
> Leo Famulari <leo@famulari.name> skribis:
>
> > It looks like the problem is with a libreoffice dependency, ilmbase.
> > Looking at the build history on hydra.gnu.org, it hasn't built
> > successfully since at least 2015-02-25:
> > http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux
>
> Right. This sounds very much like a rounding issue, whereby the epsilon
> in floating-point number comparisons is to strict for 32-bit machines.
>
> We should report it upstream, but I don’t see any clear way to report
> bugs, neither in README, nor on openexr.com. Am I overlooking it?

openexr-devel appears to be the main list:
L
L
Leo Famulari wrote on 3 Dec 2015 21:01
(name . Ludovic Courtès)(address . ludo@gnu.org)
20151203200129.GA22924@jasmine
On Tue, Dec 01, 2015 at 12:58:27AM -0500, Leo Famulari wrote:
Toggle quote (17 lines)
> On Mon, Nov 30, 2015 at 10:14:49PM +0200, Ludovic Courtès wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> >
> > > It looks like the problem is with a libreoffice dependency, ilmbase.
> > > Looking at the build history on hydra.gnu.org, it hasn't built
> > > successfully since at least 2015-02-25:
> > > http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux
> >
> > Right. This sounds very much like a rounding issue, whereby the epsilon
> > in floating-point number comparisons is to strict for 32-bit machines.
> >
> > We should report it upstream, but I don’t see any clear way to report
> > bugs, neither in README, nor on openexr.com. Am I overlooking it?
>
> openexr-devel appears to be the main list:
> https://lists.gnu.org/mailman/listinfo/openexr-devel

I'm happy to send a bug report to openexr-devel but I don't understand
the issue well enough to write a decent report. Would it be sufficient to
just copy your message, Ludovic? Along with information about the
platform, of course.
L
L
Ludovic Courtès wrote on 4 Dec 2015 12:59
(name . Leo Famulari)(address . leo@famulari.name)
87io4eo24p.fsf@gnu.org
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (23 lines)
> On Tue, Dec 01, 2015 at 12:58:27AM -0500, Leo Famulari wrote:
>> On Mon, Nov 30, 2015 at 10:14:49PM +0200, Ludovic Courtès wrote:
>> > Leo Famulari <leo@famulari.name> skribis:
>> >
>> > > It looks like the problem is with a libreoffice dependency, ilmbase.
>> > > Looking at the build history on hydra.gnu.org, it hasn't built
>> > > successfully since at least 2015-02-25:
>> > > http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux
>> >
>> > Right. This sounds very much like a rounding issue, whereby the epsilon
>> > in floating-point number comparisons is to strict for 32-bit machines.
>> >
>> > We should report it upstream, but I don’t see any clear way to report
>> > bugs, neither in README, nor on openexr.com. Am I overlooking it?
>>
>> openexr-devel appears to be the main list:
>> https://lists.gnu.org/mailman/listinfo/openexr-devel
>
> I'm happy to send a bug report to openexr-devel but I don't understand
> the issue well enough to write a decent report. Would it be sufficient to
> just copy your message, Ludovic? Along with information about the
> platform, of course.

I would suggest giving them as much information as possible about the
platform, including versions of dependencies, and an excerpt from the
build log (probably with a link to the full log on hydra.gnu.org.)

So, thanks in advance! :-)

Ludo’.
M
M
Mark H Weaver wrote on 8 Dec 2015 21:36
Re: Test failure of ilmbase-2.2.0 on i686-linux (testBoxAlgo.cpp)
(name . Leo Famulari)(address . leo@famulari.name)
87si3cy8xy.fsf@netris.org
[added 22049@debbugs.gnu.org to the CC list]

Leo Famulari <leo@famulari.name> writes:

Toggle quote (18 lines)
> Greetings from Guix! [0]
>
> We're having trouble building ilmbase-2.2.0 for the i686 architecture on
> Linux, with gcc-4.9.3.
>
> The build process fails during testing. Specifically, it fails
> testBoxAlgo, like this:
>
> ImathTest: testBoxAlgo.cpp:892: void {anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.
> /gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line 5: 4565 Aborted ${dir}$tst
>
> On our mailing list, this was suggested as the nature of the problem
> [1]:
> On Mon, Nov 30, 2015 at 10:14:49PM +0200, Ludovic Courtès wrote:
>> Right. This sounds very much like a rounding issue, whereby the
>> epsilon in floating-point number comparisons is to strict for 32-bit
>> machines.

Given that ilmbase builds successfully in Guix on x86_64, mips64el, and
armhf, and only fails on i686, I believe that Ludovic's suggestion is
right on the mark.

The issue is that the x87 instruction set (used on 32-bit Intel systems
without SSE) uses 80-bit double-extended precision internally. When
these 80-bit results are later converted to 64-bit doubles, they are
rounded a second time. This "double rounding" results in larger
round-off errors than would occur when rounding only once to 64-bit
doubles, as is done when using x86_64, SSE2, or other architectures.
For more on this, see:


Quoting from that page:

Some computer languages and the IEEE 754-2008 standard dictate that in
straightforward calculations the result should not be rounded twice.
This has been a particular problem with Java as it is designed to be
run identically on different machines, special programming tricks have
had to be used to achieve this with x87 floating point.[1][2]

[1] Samuel A. Figueroa (July 1995). "When is double rounding
innocuous?". ACM SIGNUM Newsletter (ACM) 30 (3):
21–25. doi:10.1145/221332.221334.

[2] Roger Golliver (October 1998). "Efficiently producing default
orthogonal IEEE double results using extended IEEE
hardware". Intel.

Hope this helps,

Mark
L
L
Ludovic Courtès wrote on 28 Feb 2016 19:06
Re: bug#22049: libreoffice compile error
(name . Leo Famulari)(address . leo@famulari.name)
87h9gsvhep.fsf@gnu.org
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (41 lines)
> On Sun, Nov 29, 2015 at 10:50:22AM -0600, rennes@openmailbox.org wrote:
>> On 2015-11-29 09:02, ludo@gnu.org wrote:
>> >rennes@openmailbox.org skribis:
>> >
>> >>i try install libreoffice in guixsd (guix package -i libreoffice) and
>> >>return error:
>> >
>> >[...]
>> >
>> >>ImathTest: testBoxAlgo.cpp:892: void
>> >>{anonymous}::boxMatrixTransform(): Assertion `b21 == b2' failed.
>> >>/gnu/store/isxqjfaglyfsbcv75y8qbqbph8v28ykr-bash-4.3.39/bin/bash: line
>> >>5: 4297 Aborted ${dir}$tst
>> >>FAIL: ImathTest
>> >>==================
>> >>1 of 1 test failed
>> >>==================
>> >>Makefile:403: recipe for target 'check-TESTS' failed
>> >>make[2]: *** [check-TESTS] Error 1
>> >>make[2]: Leaving directory
>> >>'/tmp/nix-build-ilmbase-2.2.0.drv-0/ilmbase-2.2.0/ImathTest'
>> >
>> >What platform is this on? i686, x86_64, armhf, or mips64el?
>> >
>> >Thanks for your report!
>> >
>> >Ludo’.
>>
>>
>>
>> Hi Ludo,
>>
>> i use i686 in virtualbox.
>>
>> and thanks.
>
> It looks like the problem is with a libreoffice dependency, ilmbase.
> Looking at the build history on hydra.gnu.org, it hasn't built
> successfully since at least 2015-02-25:
> http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux

The problem appears to be fixed in IlmBase 2.0.1:


Would you like to try?

Thanks,
Ludo’.
L
L
Leo Famulari wrote on 29 Feb 2016 09:35
(name . Ludovic Courtès)(address . ludo@gnu.org)
20160229083540.GA18295@jasmine
On Sun, Feb 28, 2016 at 07:06:22PM +0100, Ludovic Court�s wrote:
Toggle quote (12 lines)
> Leo Famulari <leo@famulari.name> skribis:
> > It looks like the problem is with a libreoffice dependency, ilmbase.
> > Looking at the build history on hydra.gnu.org, it hasn't built
> > successfully since at least 2015-02-25:
> > http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux
>
> The problem appears to be fixed in IlmBase 2.0.1:
>
> https://github.com/openexr/openexr/issues/3
>
> Would you like to try?

We currently package 2.2.0. I did read that bug report, and then kept
reading, until I came to the Debian bug report [0], where Steven
Chamberlain linked to our bug report with OpenEXR and produced two
patches that Debian has merged into their "unstable" branch.

I've attached my (working) attempt at conditionally applying these
patches on i686-* architectures. Please feel free to criticize or modify
this patch :)

I copied the patches from [1].

Thanks for the reminder!

[0]

[1]

[2]

Relevant commit in Debian ilmbase packaging repo:
L
L
Leo Famulari wrote on 29 Feb 2016 09:37
(name . Ludovic Courtès)(address . ludo@gnu.org)
20160229083723.GA18766@jasmine
On Mon, Feb 29, 2016 at 03:35:40AM -0500, Leo Famulari wrote:
Toggle quote (22 lines)
> On Sun, Feb 28, 2016 at 07:06:22PM +0100, Ludovic Court�s wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> > > It looks like the problem is with a libreoffice dependency, ilmbase.
> > > Looking at the build history on hydra.gnu.org, it hasn't built
> > > successfully since at least 2015-02-25:
> > > http://hydra.gnu.org/job/gnu/master/ilmbase-2.2.0.i686-linux
> >
> > The problem appears to be fixed in IlmBase 2.0.1:
> >
> > https://github.com/openexr/openexr/issues/3
> >
> > Would you like to try?
>
> We currently package 2.2.0. I did read that bug report, and then kept
> reading, until I came to the Debian bug report [0], where Steven
> Chamberlain linked to our bug report with OpenEXR and produced two
> patches that Debian has merged into their "unstable" branch.
>
> I've attached my (working) attempt at conditionally applying these
> patches on i686-* architectures. Please feel free to criticize or modify
> this patch :)

I forgot the attachment. Here it is!

Toggle quote (19 lines)
>
> I copied the patches from [1].
>
> Thanks for the reminder!
>
> [0]
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815712
>
> [1]
> https://sources.debian.net/src/ilmbase/2.2.0-11/debian/patches/
>
> [2]
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815712#194
>
> Relevant commit in Debian ilmbase packaging repo:
> https://anonscm.debian.org/cgit/pkg-phototools/ilmbase.git/commit/?id=ab28bb45cdad8adc32e345b777ab8e692b1d9a9c
>
>
>
Attachment: 0001-gnu-ilmbase-Add-patches-to-fix-build-on-i686.patch
L
L
Ludovic Courtès wrote on 1 Mar 2016 14:36
(name . Leo Famulari)(address . leo@famulari.name)
878u22pbfr.fsf@gnu.org
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (15 lines)
> From bf1f2a1c3621ba93ec99711ec78a79663acb6e82 Mon Sep 17 00:00:00 2001
> Message-Id: <bf1f2a1c3621ba93ec99711ec78a79663acb6e82.1456734966.git.leo@famulari.name>
> From: Leo Famulari <leo@famulari.name>
> Date: Mon, 29 Feb 2016 02:23:43 -0500
> Subject: [PATCH 1/1] gnu: ilmbase: Add patches to fix build on i686.
>
> Fixes <http://bugs.gnu.org/22049>.
>
> * gnu/packages/patches/ilmbase-testBox.patch,
> gnu/packages/patches/ilmbase-testBoxAlgo.patch: New files.
> * gnu-system.am (dist_patch_DATA): Add them.
> * gnu/packages/graphics.scm (ilmbase)[native-inputs]: Add patch/testBox
> and patch/testBoxAlgo.
> [arguments]: Add 'patch-for-i686' phase.

Cool!

I think it’d be reasonable to squash both patches in one file, and to
apply it unconditionally. WDYT?

So I gather upgrading to IlmBase 2.0.1 is not an option?

Thanks,
Ludo’.
L
L
Leo Famulari wrote on 1 Mar 2016 18:24
(name . Ludovic Courtès)(address . ludo@gnu.org)
20160301172445.GB6052@jasmine
On Tue, Mar 01, 2016 at 02:36:24PM +0100, Ludovic Courtès wrote:
Toggle quote (22 lines)
> Leo Famulari <leo@famulari.name> skribis:
>
> > From bf1f2a1c3621ba93ec99711ec78a79663acb6e82 Mon Sep 17 00:00:00 2001
> > Message-Id: <bf1f2a1c3621ba93ec99711ec78a79663acb6e82.1456734966.git.leo@famulari.name>
> > From: Leo Famulari <leo@famulari.name>
> > Date: Mon, 29 Feb 2016 02:23:43 -0500
> > Subject: [PATCH 1/1] gnu: ilmbase: Add patches to fix build on i686.
> >
> > Fixes <http://bugs.gnu.org/22049>.
> >
> > * gnu/packages/patches/ilmbase-testBox.patch,
> > gnu/packages/patches/ilmbase-testBoxAlgo.patch: New files.
> > * gnu-system.am (dist_patch_DATA): Add them.
> > * gnu/packages/graphics.scm (ilmbase)[native-inputs]: Add patch/testBox
> > and patch/testBoxAlgo.
> > [arguments]: Add 'patch-for-i686' phase.
>
> Cool!
>
> I think it’d be reasonable to squash both patches in one file, and to
> apply it unconditionally. WDYT?

Sure, I'll send an updated patch.

I'm wondering — does the current patch handle the conditional
application of the patch properly? Just looking for some feedback on the
approach...

Toggle quote (3 lines)
>
> So I gather upgrading to IlmBase 2.0.1 is not an option?

2.0.1 would be a downgrade for us; we are on 2.2.0. I did try it without
success.

Toggle quote (3 lines)
>
> Thanks,
> Ludo’.
L
L
Leo Famulari wrote on 1 Mar 2016 19:01
(name . Ludovic Courtès)(address . ludo@gnu.org)
20160301180148.GB5055@jasmine
On Tue, Mar 01, 2016 at 12:24:45PM -0500, Leo Famulari wrote:
Toggle quote (25 lines)
> On Tue, Mar 01, 2016 at 02:36:24PM +0100, Ludovic Courtès wrote:
> > Leo Famulari <leo@famulari.name> skribis:
> >
> > > From bf1f2a1c3621ba93ec99711ec78a79663acb6e82 Mon Sep 17 00:00:00 2001
> > > Message-Id: <bf1f2a1c3621ba93ec99711ec78a79663acb6e82.1456734966.git.leo@famulari.name>
> > > From: Leo Famulari <leo@famulari.name>
> > > Date: Mon, 29 Feb 2016 02:23:43 -0500
> > > Subject: [PATCH 1/1] gnu: ilmbase: Add patches to fix build on i686.
> > >
> > > Fixes <http://bugs.gnu.org/22049>.
> > >
> > > * gnu/packages/patches/ilmbase-testBox.patch,
> > > gnu/packages/patches/ilmbase-testBoxAlgo.patch: New files.
> > > * gnu-system.am (dist_patch_DATA): Add them.
> > > * gnu/packages/graphics.scm (ilmbase)[native-inputs]: Add patch/testBox
> > > and patch/testBoxAlgo.
> > > [arguments]: Add 'patch-for-i686' phase.
> >
> > Cool!
> >
> > I think it’d be reasonable to squash both patches in one file, and to
> > apply it unconditionally. WDYT?
>
> Sure, I'll send an updated patch.

Attached.

Toggle quote (17 lines)
>
> I'm wondering — does the current patch handle the conditional
> application of the patch properly? Just looking for some feedback on the
> approach...
>
> >
> > So I gather upgrading to IlmBase 2.0.1 is not an option?
>
> 2.0.1 would be a downgrade for us; we are on 2.2.0. I did try it without
> success.
>
> >
> > Thanks,
> > Ludo’.
>
>
>
Attachment: 0001-gnu-ilmbase-Add-patch-to-fix-build-on-i686.patch
L
L
Ludovic Courtès wrote on 1 Mar 2016 21:36
(name . Leo Famulari)(address . leo@famulari.name)
87r3fuoryy.fsf@gnu.org
Leo Famulari <leo@famulari.name> skribis:

Toggle quote (29 lines)
> On Tue, Mar 01, 2016 at 12:24:45PM -0500, Leo Famulari wrote:
>> On Tue, Mar 01, 2016 at 02:36:24PM +0100, Ludovic Courtès wrote:
>> > Leo Famulari <leo@famulari.name> skribis:
>> >
>> > > From bf1f2a1c3621ba93ec99711ec78a79663acb6e82 Mon Sep 17 00:00:00 2001
>> > > Message-Id: <bf1f2a1c3621ba93ec99711ec78a79663acb6e82.1456734966.git.leo@famulari.name>
>> > > From: Leo Famulari <leo@famulari.name>
>> > > Date: Mon, 29 Feb 2016 02:23:43 -0500
>> > > Subject: [PATCH 1/1] gnu: ilmbase: Add patches to fix build on i686.
>> > >
>> > > Fixes <http://bugs.gnu.org/22049>.
>> > >
>> > > * gnu/packages/patches/ilmbase-testBox.patch,
>> > > gnu/packages/patches/ilmbase-testBoxAlgo.patch: New files.
>> > > * gnu-system.am (dist_patch_DATA): Add them.
>> > > * gnu/packages/graphics.scm (ilmbase)[native-inputs]: Add patch/testBox
>> > > and patch/testBoxAlgo.
>> > > [arguments]: Add 'patch-for-i686' phase.
>> >
>> > Cool!
>> >
>> > I think it’d be reasonable to squash both patches in one file, and to
>> > apply it unconditionally. WDYT?
>>
>> Sure, I'll send an updated patch.
>
> Attached.
>

[...]

Toggle quote (5 lines)
>> > So I gather upgrading to IlmBase 2.0.1 is not an option?
>>
>> 2.0.1 would be a downgrade for us; we are on 2.2.0. I did try it without
>> success.

Oops, sorry. :-)

Toggle quote (11 lines)
> From 2f895108a3f476038b82e03645ee7f51e4ee1675 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@famulari.name>
> Date: Mon, 29 Feb 2016 02:23:43 -0500
> Subject: [PATCH] gnu: ilmbase: Add patch to fix build on i686.
>
> Fixes <http://bugs.gnu.org/22049>.
>
> * gnu/packages/patches/ilmbase-fix-tests.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
> * gnu/packages/graphics.scm (ilmbase)[source]: Add patch.

Perfect, thanks again!

Ludo’.
L
L
Leo Famulari wrote on 2 Mar 2016 01:20
(name . Ludovic Courtès)(address . ludo@gnu.org)
20160302002046.GA18810@jasmine
On Tue, Mar 01, 2016 at 09:36:53PM +0100, Ludovic Courtès wrote:
Toggle quote (53 lines)
> Leo Famulari <leo@famulari.name> skribis:
>
> > On Tue, Mar 01, 2016 at 12:24:45PM -0500, Leo Famulari wrote:
> >> On Tue, Mar 01, 2016 at 02:36:24PM +0100, Ludovic Courtès wrote:
> >> > Leo Famulari <leo@famulari.name> skribis:
> >> >
> >> > > From bf1f2a1c3621ba93ec99711ec78a79663acb6e82 Mon Sep 17 00:00:00 2001
> >> > > Message-Id: <bf1f2a1c3621ba93ec99711ec78a79663acb6e82.1456734966.git.leo@famulari.name>
> >> > > From: Leo Famulari <leo@famulari.name>
> >> > > Date: Mon, 29 Feb 2016 02:23:43 -0500
> >> > > Subject: [PATCH 1/1] gnu: ilmbase: Add patches to fix build on i686.
> >> > >
> >> > > Fixes <http://bugs.gnu.org/22049>.
> >> > >
> >> > > * gnu/packages/patches/ilmbase-testBox.patch,
> >> > > gnu/packages/patches/ilmbase-testBoxAlgo.patch: New files.
> >> > > * gnu-system.am (dist_patch_DATA): Add them.
> >> > > * gnu/packages/graphics.scm (ilmbase)[native-inputs]: Add patch/testBox
> >> > > and patch/testBoxAlgo.
> >> > > [arguments]: Add 'patch-for-i686' phase.
> >> >
> >> > Cool!
> >> >
> >> > I think it’d be reasonable to squash both patches in one file, and to
> >> > apply it unconditionally. WDYT?
> >>
> >> Sure, I'll send an updated patch.
> >
> > Attached.
> >
>
> [...]
>
> >> > So I gather upgrading to IlmBase 2.0.1 is not an option?
> >>
> >> 2.0.1 would be a downgrade for us; we are on 2.2.0. I did try it without
> >> success.
>
> Oops, sorry. :-)
>
> > From 2f895108a3f476038b82e03645ee7f51e4ee1675 Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <leo@famulari.name>
> > Date: Mon, 29 Feb 2016 02:23:43 -0500
> > Subject: [PATCH] gnu: ilmbase: Add patch to fix build on i686.
> >
> > Fixes <http://bugs.gnu.org/22049>.
> >
> > * gnu/packages/patches/ilmbase-fix-tests.patch: New file.
> > * gnu-system.am (dist_patch_DATA): Add it.
> > * gnu/packages/graphics.scm (ilmbase)[source]: Add patch.
>
> Perfect, thanks again!

Pushed as 5e8276dcf4e3a, and closing.

Toggle quote (2 lines)
>
> Ludo’.
Closed
?