[PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Done

Details

2 participants

Arun Isaac
BonfaceKilz

Owner: unassigned

Submitted by: BonfaceKilz

Severity: normal

BonfaceKilz wrote on 19 Aug 2021 09:17

Recipients:(address . guix-patches@gnu.org)

Message-ID:20210819071709.90126-1-me@bonfacemunyoki.com

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

Toggle snippet (9 lines)

Typically end-user Go packages will want inputs/native-inputs rather

than propagated inputs unless the input provides a binary used at

runtime, so user profiles are not cluttered (go-build-system needs

source from all transitive dependencies). Also, a more friendly name

("csvdiff" is available) might be better for end-user packages like

this.

BonfaceKilz (2):

gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".

gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

gnu/packages/golang.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

2.31.1

BonfaceKilz wrote on 19 Aug 2021 09:21

Recipients:(address . 50117@debbugs.gnu.org)

Message-ID:20210819072156.90545-1-me@bonfacemunyoki.com

Hi all. Find attached the updated package definition of csv diff which addresses the following issues that were kindly pointed out by Sarah:

Toggle snippet (9 lines)

Typically end-user Go packages will want inputs/native-inputs rather

than propagated inputs unless the input provides a binary used at

runtime, so user profiles are not cluttered (go-build-system needs

source from all transitive dependencies). Also, a more friendly name

("csvdiff" is available) might be better for end-user packages like

this.

BonfaceKilz (2):

gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".

gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

gnu/packages/golang.scm | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

2.31.1

BonfaceKilz wrote on 19 Aug 2021 09:21

[PATCH 1/2] gnu: go-github-com-aswinkarthik-csvdiff: Rename name to "csvdiff".

Recipients:(address . 50117@debbugs.gnu.org)

Message-ID:20210819072156.90545-2-me@bonfacemunyoki.com

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)[name]: Rename
to "csvdiff" which is more user-friendly.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 72579d6bd2..8a8830a6f6 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8424,7 +8424,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
 
 (define-public go-github-com-aswinkarthik-csvdiff
   (package
-    (name "go-github-com-aswinkarthik-csvdiff")
+    (name "csvdiff")
     (version "1.4.0")
     (source
       (origin
-- 
2.31.1

BonfaceKilz wrote on 19 Aug 2021 09:21

[PATCH 2/2] gnu: go-github-com-aswinkarthik-csvdiff: Make inputs native.

Recipients:(address . 50117@debbugs.gnu.org)

Message-ID:20210819072156.90545-3-me@bonfacemunyoki.com

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff)
[propagated-inputs]: Make these inputs native. Typically end-user Go packages
will want inputs/native-inputs rather than propagated inputs unless the input
provides a binary used at runtime, so user profiles are not
cluttered (go-build-system needs source from all transitive dependencies).
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Toggle diff (15 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 8a8830a6f6..7b151a03e3 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8439,7 +8439,7 @@ non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (build-system go-build-system)
     (arguments
      '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
+    (native-inputs
      `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
        ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
        ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-- 
2.31.1

Arun Isaac wrote on 19 Aug 2021 21:47

Re: [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Recipients:

Message-ID:87wnohrzc4.fsf@systemreboot.net

Hi Bonface,

Thanks for the patches! Some feedback follows.

1. I think we can combine the two commits into one since this is

logically just a single change.

2. We should retain the old package as a deprecated package. We should

add something like the snippet below.

Toggle snippet (4 lines)

(define-public go-github-com-aswinkarthik-csvdiff

(deprecated-package "go-github-com-aswinkarthik-csvdiff" csvdiff))

Toggle quote (2 lines)

> (define-public go-github-com-aswinkarthik-csvdiff

3. We should rename the variable name as well.

Toggle quote (4 lines)

> (package

> - (name "go-github-com-aswinkarthik-csvdiff")

> + (name "csvdiff")

3. We should also move the package to some file other than

golang.scm. How about textutils.scm?

Thank you for your patience! :-)

Arun

Arun Isaac wrote on 9 Dec 2021 11:35

Re: [bug#50117] [PATCH 0/2] go-github-com-aswinkarthik-csvdiff package updates

Recipients:(address . iskarian@mgsn.dev)

Message-ID:87o85qhxqf.fsf@systemreboot.net

Hi Bonface,

Any progress on this? Just a gentle ping.

Thanks,

Arun

Bonface M. K wrote on 9 Dec 2021 15:02

Recipients:(address . iskarian@mgsn.dev)

Message-ID:86o85pho6e.fsf@bonfacemunyoki.com

Arun Isaac <arunisaac@systemreboot.net> anaandika:

Toggle quote (7 lines)

> Hi Bonface,

> Any progress on this? Just a gentle ping.

> Thanks,

> Arun

Hi!  Lemme have a look at this once my classes are
done.  Somehow this got lost in my To-Do tasks!
Thanks for the reminder.

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: https://upbookclub.com | Twitter: @BonfaceKilz

Arun Isaac wrote on 10 Dec 2021 04:30

Recipients:(address . iskarian@mgsn.dev)

Message-ID:87bl1pi1bo.fsf@systemreboot.net

Toggle quote (3 lines)

> Hi! Lemme have a look at this once my classes are done. Somehow this

> got lost in my To-Do tasks! Thanks for the reminder.

Sure, Bonface, thanks!

BonfaceKilz wrote on 10 Dec 2021 12:17

[PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates

Recipients:(address . 50117@debbugs.gnu.org)

Message-ID:20211210111752.20147-1-me@bonfacemunyoki.com

Hi all! Find below updated patches from a review from a while back. @Arun, I

have moved csvdiff to textutils(it makes more semantic sense). I see no need

of defining it as a deprecated-package since there's no package dependent on

it ATM. Let me know if I need to change anything. Thanks for being patient

with this!

BonfaceKilz (1):

gnu: Move csvdiff to (gnu packages textutils).

gnu/packages/golang.scm | 44 ------------------------------------

gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++

2 files changed, 46 insertions(+), 44 deletions(-)

2.31.1

BonfaceKilz wrote on 10 Dec 2021 12:17

[PATCH 1/1] gnu: Move csvdiff to (gnu packages textutils).

Recipients:(address . 50117@debbugs.gnu.org)

Message-ID:20211210111752.20147-2-me@bonfacemunyoki.com

See http://issues.guix.gnu.org/50117.

* gnu/packages/golang.scm (go-github-com-aswinkarthik-csvdiff): Move from here

* gnu/packages/textutils (go-github-com-aswinkarthik-csvdiff): to here.

---

gnu/packages/golang.scm | 44 ------------------------------------

gnu/packages/textutils.scm | 46 ++++++++++++++++++++++++++++++++++++++

2 files changed, 46 insertions(+), 44 deletions(-)

Toggle diff (125 lines)diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d555a92579..49c124a415 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8788,50 +8788,6 @@ zero round-trip encryption, and other advanced features.")
 non-cryptographic hash algorithm, working at speeds close to RAM limits.")
     (license license:asl2.0)))
 
-(define-public go-github-com-aswinkarthik-csvdiff
-  (package
-    (name "go-github-com-aswinkarthik-csvdiff")
-    (version "1.4.0")
-    (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/aswinkarthik/csvdiff")
-               (commit (string-append "v" version))))
-        (file-name (git-file-name name version))
-        (sha256
-         (base32
-          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
-    (build-system go-build-system)
-    (arguments
-     '(#:import-path "github.com/aswinkarthik/csvdiff"))
-    (propagated-inputs
-     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
-       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
-       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
-       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
-       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
-       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
-       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
-       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
-       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
-    (home-page "https://github.com/aswinkarthik/csvdiff")
-    (synopsis "Fast diff tool for comparing CSV files")
-    (description "@code{csvdiff} is a diff tool to compute changes between two
-CSV files.  It can compare CSV files with a million records in under 2
-seconds.  It is specifically suited for comparing CSV files dumped from
-database tables.  GNU Diff is orders of magnitude faster for comparing line by
-line.  @code{csvdiff} supports
-
-@itemize
-@item Selective comparison of fields in a row
-@item Specifying group of columns as primary-key to uniquely identify a row
-@item Ignoring columns
-@item Several output formats including colored git style output or
-JSON for post-processing
-@end itemize")
-    (license license:expat)))
-
 (define-public go-gopkg-in-djherbis-times-v1
   (package
     (name "go-gopkg-in-djherbis-times-v1")
diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
index 7e7293ac16..9a8b9ae1e8 100644
--- a/gnu/packages/textutils.scm
+++ b/gnu/packages/textutils.scm
@@ -22,6 +22,7 @@
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;; Copyright © 2021 Jean-Baptiste Volatier <jbv@pm.me>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
+;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -64,6 +65,7 @@
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-build)
   #:use-module (gnu packages python-xyz)
+  #:use-module (gnu packages syncthing)
   #:use-module (gnu packages readline)
   #:use-module (gnu packages ruby)
   #:use-module (gnu packages slang)
@@ -1347,3 +1349,47 @@ languages such as HTML, Markdown, Asciidoc, and reStructuredText.  The community
 around it also has a list of style guides implemented with Vale in
 @url{https://github.com/errata-ai/styles, their styles repo}.")
     (license license:expat)))
+
+(define-public go-github-com-aswinkarthik-csvdiff
+  (package
+    (name "csvdiff")
+    (version "1.4.0")
+    (source
+      (origin
+        (method git-fetch)
+        (uri (git-reference
+               (url "https://github.com/aswinkarthik/csvdiff")
+               (commit (string-append "v" version))))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32
+          "0cd1ikxsypjqisfnmr7zix3g7x8p892w77086465chyd39gpk97b"))))
+    (build-system go-build-system)
+    (arguments
+     '(#:import-path "github.com/aswinkarthik/csvdiff"))
+    (propagated-inputs
+     `(("go-golang-org-x-sys" ,go-golang-org-x-sys)
+       ("go-github-com-stretchr-testify" ,go-github-com-stretchr-testify)
+       ("go-github-com-spf13-cobra" ,go-github-com-spf13-cobra)
+       ("go-github-com-spf13-afero" ,go-github-com-spf13-afero)
+       ("go-github-com-spaolacci-murmur3" ,go-github-com-spaolacci-murmur3)
+       ("go-github-com-mattn-go-colorable" ,go-github-com-mattn-go-colorable)
+       ("go-github-com-fatih-color" ,go-github-com-fatih-color)
+       ("go-github-com-cespare-xxhash" ,go-github-com-cespare-xxhash)
+       ("go-github-com-oneofone-xxhash" ,go-github-com-oneofone-xxhash)))
+    (home-page "https://github.com/aswinkarthik/csvdiff")
+    (synopsis "Fast diff tool for comparing CSV files")
+    (description "@code{csvdiff} is a diff tool to compute changes between two
+CSV files.  It can compare CSV files with a million records in under 2
+seconds.  It is specifically suited for comparing CSV files dumped from
+database tables.  GNU Diff is orders of magnitude faster for comparing line by
+line.  @code{csvdiff} supports
+
+@itemize
+@item Selective comparison of fields in a row
+@item Specifying group of columns as primary-key to uniquely identify a row
+@item Ignoring columns
+@item Several output formats including colored git style output or
+JSON for post-processing
+@end itemize")
+    (license license:expat)))
-- 
2.31.1

Arun Isaac wrote on 13 Dec 2021 07:08

Re: [PATCH 0/1] go-github-com-aswinkarthik-csvdiff package updates

Recipients:(name . BonfaceKilz)(address . me@bonfacemunyoki.com)(address . 50117@debbugs.gnu.org)

Message-ID:87r1ahf35q.fsf@systemreboot.net

Hi Bonface,

Toggle quote (3 lines)

> Hi all! Find below updated patches from a review from a while back. @Arun, I

> have moved csvdiff to textutils(it makes more semantic sense).

Sounds good.

Toggle quote (3 lines)

> I see no need of defining it as a deprecated-package since there's no

> package dependent on it ATM.

Users might have installed csvdiff into their profiles. So, I think we
still need to define a deprecated-package. Could you send an updated
patchset?

Thanks!
Arun

Bonface M. K wrote on 13 Dec 2021 07:50

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 50117@debbugs.gnu.org)

Message-ID:86bl1lxali.fsf@bonfacemunyoki.com

Arun Isaac <arunisaac@systemreboot.net> anaandika:

Toggle quote (15 lines)> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?
>

Sure. Let me do that later during the day...

Toggle quote (3 lines)

> Thanks!

> Arun

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: https://upbookclub.com | Twitter: @BonfaceKilz

Bonface M. K wrote on 13 Dec 2021 21:51

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 50117@debbugs.gnu.org)

Message-ID:868rwo44a2.fsf@bonfacemunyoki.com

Arun Isaac <arunisaac@systemreboot.net> anaandika:

Toggle quote (14 lines)> Hi Bonface,
>
>> Hi all!  Find below updated patches from a review from a while back.  @Arun, I
>> have moved csvdiff to textutils(it makes more semantic sense).
>
> Sounds good.
>
>> I see no need of defining it as a deprecated-package since there's no
>> package dependent on it ATM.
>
> Users might have installed csvdiff into their profiles. So, I think we
> still need to define a deprecated-package. Could you send an updated
> patchset?

Yup.  This makes sense.  Find attached a new patch
that adds an alias for the deprecated package.
Let me know if this is okay :)

Attachment: 0001-gnu-Move-csvdiff-to-gnu-packages-textutils.patch

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: https://upbookclub.com | Twitter: @BonfaceKilz

Arun Isaac wrote on 20 Dec 2021 06:35

Recipients:(name . Bonface M. K)(address . me@bonfacemunyoki.com)(address . 50117-done@debbugs.gnu.org)

Message-ID:87ee6796ug.fsf@systemreboot.net

Hi Bonface,

I have applied the patch on master with a few changes. Most

significantly, I moved the deprecated alias from

gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm

is where the original package was.

Thanks,

Arun

Closed

Bonface M. K wrote on 21 Dec 2021 13:29

Recipients:(name . Arun Isaac)(address . arunisaac@systemreboot.net)(address . 50117-done@debbugs.gnu.org)

Message-ID:86wnjydtuv.fsf@bonfacemunyoki.com

Arun Isaac <arunisaac@systemreboot.net> anaandika:

Toggle quote (7 lines)

> Hi Bonface,

> I have applied the patch on master with a few changes. Most

> significantly, I moved the deprecated alias from

> gnu/packages/textutils.scm to gnu/packages/golang.scm since golang.scm

> is where the original package was.

Thanks!

-- 
Bonface M. K.
D4F09EB110177E03C28E2FE1F5BBAE1E0392253F (hkp://keys.gnupg.net)
Free Software Activist
Humble GNU Emacs User | Bearer of scheme-y parens
Curator: https://upbookclub.com | Twitter: @BonfaceKilz

Closed

Your comment

This issue is archived.

To comment on this conversation send an email to 50117@debbugs.gnu.org

To respond to this issue using the mumi CLI, first switch to it

mumi current 50117

Then, you may apply the latest patchset in this issue (with sign off)

mumi am -- -s

Or, compose a reply to this issue

mumi compose

Or, send patches to this issue

mumi send-email *.patch

is:open	open issues
is:done	closed issues
submitter:<who>	search issue submitter
author:<who>	search by message author
date:yesterday..now	search by issue date
mdate:3m..2d	search by message date