Subject: Re: [bug#74180] [PATCH] gnu: add bash-preexec

From: Nicolas Graves <[email-masked]>
Date: Sun, 03 Nov 2024 21:07:11 +0100

On 2024-11-02 21:14, Javier Olaechea wrote:

> * gnu/packages/bash.scm: (bash-preexec): New variable.

> +
> +(define-public bash-preexec
> +  (package
> +    (name "bash-preexec")
> +    (version "0.5.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/rcaloras/bash-preexec")
> +             (commit "da64ad4b7bb965d19dbeb5bb7447f1a63e3de2e3")))

You can use version here.

> +
> +       (sha256
> +        (base32 "0nx0m1bhm4f4v033ngi2m9zq3vppimsmn8kmwqbvyqr4n6gkjmgq"))))
> +    (build-system gnu-build-system)

Looks like you can simply use the copy-build-system here, no?

> +    (arguments
> +     (list
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (delete 'build)
> +                   (delete 'check)
> +                   (replace 'install
> +                     (lambda _
> +                       (install-file "bash-preexec.sh"
> +                                     (string-append #$output "/bin")))))))
> +    (home-page "https://github.com/rcaloras/bash-preexec")
> +    (synopsis "preexec and precmd functions for Bash just like Zsh")
> +    (description
> +     "preexec and precmd hook functions for Bash 3.1+ in the style of
> Zsh.")

The description should be more descriptive. You can describe the two
functions like they do in the README.  Use @command{bash/zsh}.  Prefix
with "This package provides".

> +    (license license:expat)))
>
> base-commit: ea11d3608566174c4bae70faa4f9d0c67748d2db

-- 
Best regards,
Nicolas Graves