From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 06:34:13 2023 Received: (at 62584) by debbugs.gnu.org; 1 Apr 2023 10:34:13 +0000 Received: from localhost ([127.0.0.1]:35587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piYYn-0002Jy-4K for submit@debbugs.gnu.org; Sat, 01 Apr 2023 06:34:13 -0400 Received: from mail.envs.net ([5.199.136.28]:44390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piYYl-0002Jq-Es for 62584@debbugs.gnu.org; Sat, 01 Apr 2023 06:34:12 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id DC56438A008E; Sat, 1 Apr 2023 10:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1680345249; bh=VHu9ck+4p0c99gKJyi6g6+dkx+liKU/zEo9i0y9XiYM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XhDRK1zdvsLd2q7vEzJ1W89PV2N1piddxQFD2algSoU896S7A6HOBxXRM0Iw5V1pW 3DCkUPvEU+v5mfM1nKJtgVNHwqDvrPoAdzKNoBgCZXEvwlPFkMi3Y7JX+Mz2WV0lf1 KaH7xmoObzfGViD0gMfyK9sQ2ezKETC/lPzX5xbkNzkIuBkqfEiOEAjFbdfxcNkGpT shsPSLHuObB5G9UaXHEGVrZk1mjPvxt5QeEGUyKBc6Iybzz/B+oQRjTAdvzuPT3nU8 uFPEknybNaioEDh+vohxKENgcNzYq+XPIj4ekdaV58iSPXC1arFIia6toIT8JC3qjz NL3pIKcVdEhePuvuYWute9NgoXqCQIEekVgErdC497fUfEqqaau/FKgNSZZ1yMGoij uNrHkOZkCCv+7Tg8W2EMh8ji/qr58HzERszB3zHSuSrNxcSD57TJxD4+Sd7lgb+meS 5VqCBDrdMy1SqdYPILco0DzQu/oJ52Ok4S4cQT8QKGQOp9RHKJtnhFPzgQKsA8Y4+N eMNjX3lz1ViDOun6Tn0qfz7Pd2k6+RGxM2Tzd6n4jzWC27GbDM3h1KLicHfiKrcrz8 NHgdeXUCZWvO6gK/43AWF7CuiLKabVjWVrVFWjpQqT/PKXmS4bhBQyR4pMnZjLkOH9 Ay733kpNXp6NpPkCDyWOry5I= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 88rQHi1fCzA8; Sat, 1 Apr 2023 10:34:06 +0000 (UTC) Received: from localhost (unknown [36.170.59.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sat, 1 Apr 2023 10:34:05 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id f8f2529b; Sat, 1 Apr 2023 10:34:54 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#62584: [PATCH] services: Add error/success service type. References: <20230401072842.13315-1-ludo@gnu.org> Date: Sat, 01 Apr 2023 18:34:54 +0800 In-Reply-To: <20230401072842.13315-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Sat, 1 Apr 2023 09:28:42 +0200") Message-ID: <87y1nbevqp.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62584 Cc: 62584@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > I think it=E2=80=99s good to have it by default, but that=E2=80=99s somet= hing we can > discuss. Okay, I don't think so... > +(define (error/success-boot-gexp _) > + #~(begin > + (display "error in finalization thread: Success\n" > + (current-error-port)) > + (sleep 2))) ;let the user notice--all this hasn't been i= n vain How about make the message and delay customable? I prefer "No error in finalization thread: Success", and 2 seconds may not be enough for a slow reader like me! > + > +(define error/success-service-type > + (service-type > + (name 'error/success) > + (extensions > + (list (service-extension boot-service-type > + error/success-boot-gexp))) > + (default-value 42) What are this 42 is for? Otherwise look good to me, thank you!