From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 09:43:23 2023 Received: (at 62324) by debbugs.gnu.org; 21 Mar 2023 13:43:23 +0000 Received: from localhost ([127.0.0.1]:57976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecGo-0001G6-Of for submit@debbugs.gnu.org; Tue, 21 Mar 2023 09:43:22 -0400 Received: from smtpm3.myservices.hosting ([185.26.105.234]:46914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecGm-0001Fw-O3 for 62324@debbugs.gnu.org; Tue, 21 Mar 2023 09:43:21 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id C558820F41; Tue, 21 Mar 2023 14:43:15 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 6CBBC800A3; Tue, 21 Mar 2023 14:43:15 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sof2ud39V7da; Tue, 21 Mar 2023 14:43:15 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 05BD1800A0; Tue, 21 Mar 2023 14:43:14 +0100 (CET) Message-ID: <6ad8a739-992c-e578-ea8f-76e762f70c42@makinata.eu> Date: Tue, 21 Mar 2023 13:43:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [bug#62324] gnu: Add emu8051 Content-Language: en-US To: c4droid References: From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62324 Cc: 62324@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi, On 2023-03-21 07:20, c4droid wrote: > > + (arguments > + `(#:tests? #f ;No test suite > + #:make-flags (list (string-append "CC=" > + ,(cc-for-target))) > + #:phases (modify-phases %standard-phases > + (delete 'configure) ;No ./configure script > + (add-before 'build 'patch-ncurses > + ;; Replace LDFLAGS -lcurses to -lncurses > + (lambda* _ > + (substitute* "Makefile" > + (("-lcurses") > + "-lncurses")))) How about turning this 'patch-ncurses phase into a patch snippet instead? i.e. (source (origin (method ...) ... (modules '((guix build utils))) (snippet #~(begin ;; Replace LDFLAGS -lcurses to -lncurses (substitute* "Makefile" (("-lcurses") "-lncurses")))))) [...] > + (replace 'install > + ;; No installation procedure > + (lambda _ > + (install-file "emu" > + (string-append (assoc-ref %outputs "out") > + "/bin"))))))) Use G-Expressions here, i.e. (arguments (list #:tests? #f ;No test suite #:make-flags #~(list ...) #:phases #~(modify-phases ... ... (replace 'install (lambda _ (install-file "emu" (string-append #$output "/bin"))))))) Cheers, Bruno