From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 22 07:05:13 2023 Received: (at 62306) by debbugs.gnu.org; 22 Mar 2023 11:05:13 +0000 Received: from localhost ([127.0.0.1]:33645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pewHI-0003dx-Ig for submit@debbugs.gnu.org; Wed, 22 Mar 2023 07:05:13 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:43620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pewHG-0003dh-PJ for 62306@debbugs.gnu.org; Wed, 22 Mar 2023 07:05:11 -0400 Received: by mail-qt1-f179.google.com with SMTP id c10so10840276qtj.10 for <62306@debbugs.gnu.org>; Wed, 22 Mar 2023 04:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679483105; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=shjvF9WHt0hRbZOpLSWrEiZlwGenpBoOQQuiZVVDVPg=; b=HiRPequ4sx+QXAbYSEPVxXH8Xeno0RXpT1XKI2xsJzR/AzcgqHms1CvpDPaSCH/UbK zWUrgCk2hyHNaBapBFkrMyoA0kRqskcktO2OazEmX9ep86y4MvRJ5r3ZoXCa3YwJESjT +bmOg/VPYg1mjTfj9+e3BsV772w9sar75KSxs7DHHEnepM7rMruizrNHkCNy9pX8uX4d IbKJhx3779gCPZ2WRuyLmkpVVcaIXtgGrjMuYG+d8UXlJUtKssZjWExqEB7jZbKKpAP3 9MBgo8sFRuWjKx/zVpsyw2iH9U2yu+P5f/oaZ3MXvRxSmzNN7L+aDt+HdB8KdQIQGNpG O+HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679483105; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=shjvF9WHt0hRbZOpLSWrEiZlwGenpBoOQQuiZVVDVPg=; b=FoPxccZJ8K8rTLGe0kgCTPiHz8Ui+bZHCcsGTVwA1PmwQMmS+q/xJpZNXPA9K64Dvp VQmCcIMv+dH7oupiFF6oXt9d+l5oi1oJnLUX3zGc+DQsF+IxHvSJNigdmAWwDdLpc+pT PNzBoULFsyckP4wJ07TU0Aq1PbtRR9KiKbJaEqA5RCWiOzhnMss6xwTZJbZ0DJK/Kuv7 EsHyemMEkcJ/hLDcOeNFiymcKfBUgLHuJl8mslWWgc4khagXBRLq753W3B6Pwu1CMZh1 in5vziFr/05LqXLBcOil87LIAUH9sI2scSk3J4AbVRdYHc6gvwVB4JoQiWbNovTeOx4d 4w7A== X-Gm-Message-State: AO0yUKXuRsTIk68nWADwAt2bcKrqgS0YSTxEBfCm6GfYICWHcBI79NWB pGVo8kkRtTPIjojW9K6JQvUx5ETfutQ4gA56aMs= X-Google-Smtp-Source: AK7set8JNht1Bvf9gdj2fkRpfOMu5c/6c7KRxuZ/VbyStFt4GqK1cDMyqQd50xHQmJ45jauJbOw83mr8F4yAGxDcq5g= X-Received: by 2002:a05:622a:19a2:b0:3dd:7bdc:2975 with SMTP id u34-20020a05622a19a200b003dd7bdc2975mr1174295qtc.7.1679483105044; Wed, 22 Mar 2023 04:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20230320215028.26102-1-sharlatanus@gmail.com> <87lejpnc17.fsf@gmail.com> In-Reply-To: <87lejpnc17.fsf@gmail.com> From: Sharlatan Hellseher Date: Wed, 22 Mar 2023 11:04:54 +0000 Message-ID: Subject: Re: bug#62306: [PATCH] gnu: Add phd2 To: Maxim Cournoyer Content-Type: multipart/alternative; boundary="000000000000e1ea9705f77b21f3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62306 Cc: 62306@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e1ea9705f77b21f3 Content-Type: text/plain; charset="UTF-8" Hi Maxim, Thank you for the review. I'll check that procedure and prepare simplified v2 patch. Oleg On Tue, 21 Mar 2023, 19:24 Maxim Cournoyer, wrote: > Hi, > > Sharlatan Hellseher writes: > > > * gnu/packages/astronomy.scm (phd2): New variable. > > --- > > gnu/packages/astronomy.scm | 71 ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > > index 46839c802f..66040ad5f5 100644 > > --- a/gnu/packages/astronomy.scm > > +++ b/gnu/packages/astronomy.scm > > @@ -678,6 +678,77 @@ (define-public gnuastro > > programs for the manipulation and analysis of astronomical data.") > > (license license:gpl3+))) > > > > +(define-public phd2 > > + (package > > + (name "phd2") > > + (version "2.6.11") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/OpenPHDGuiding/phd2") > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 "0n87xsv9gzrwk1ygws4vw397ffq40xybp5b3c3bd5kcmff0avaw9")) > > + (modules '((guix build utils))) > > + (snippet > > + '(begin > > + ;; NOTE: Keep eye on the thirdparty directory as the bundled > names > > + ;; change from relase to release. > > + ;; > > + ;; Remove bundles. > > + (with-directory-excursion "thirdparty" > > + (for-each delete-file-recursively > > + '("HID_Utilities" > > + "MallincamGuider-OSX-dylib-source.zip" > > + "VidCapture" > > + "cfitsio-3.47-patched.tar.gz" > > + "cfitsio-README-PHD2.txt" > > + "cfitsio-snprintf.patch" > > + "eigen-eigen-67e894c6cd8f.tar.bz2" > > + "gettext-0.14.4-bin.zip" > > + "gettext-0.14.4-dep.zip" > > + "gtest-1.7.0.zip" > > + "indiclient-44aaf5d3-win32.zip" > > + "libcurl-7.54.0-win32.zip" > > + "libdc1394-2.2.2.tar.gz" > > + > "libindi-58b26c584049e1b9ecd55aa5f4a225677a417898.tar.gz" > > + "libusb-1.0.21.tar.bz2" > > + "openssag"))))))) > > To make maintenance easier, perhaps you could reuse the 'delete-all-but' > procedure from turbovnc or similar? This has the benefit of listing > what is kept (more transparent), and if the things we do care for change > names, we will know. > > Could you please send a v2 with this suggestion implemented? > > -- > Thanks, > Maxim > --000000000000e1ea9705f77b21f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Maxim,

Th= ank you for the review. I'll check that procedure and prepare simplifie= d v2 patch.

Oleg

On= Tue, 21 Mar 2023, 19:24 Maxim Cournoyer, <maxim.cournoyer@gmail.com> wrote:
Hi,

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

> * gnu/packages/astronomy.scm (phd2): New variable.
> ---
>=C2=A0 gnu/packages/astronomy.scm | 71 ++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 1 file changed, 71 insertions(+)
>
> diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > index 46839c802f..66040ad5f5 100644
> --- a/gnu/packages/astronomy.scm
> +++ b/gnu/packages/astronomy.scm
> @@ -678,6 +678,77 @@ (define-public gnuastro
>=C2=A0 programs for the manipulation and analysis of astronomical data.= ")
>=C2=A0 =C2=A0 =C2=A0 (license license:gpl3+)))
>=C2=A0
> +(define-public phd2
> +=C2=A0 (package
> +=C2=A0 =C2=A0 (name "phd2")
> +=C2=A0 =C2=A0 (version "2.6.11")
> +=C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/OpenPHDGuiding/phd2")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit (string-appen= d "v" version))))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name version)) > +=C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32 "0n87xsv9gzrwk1ygws4vw397ffq= 40xybp5b3c3bd5kcmff0avaw9"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(modules '((guix build utils)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(snippet
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 '(begin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; NOTE: Keep eye on the thi= rdparty directory as the bundled names
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; change from relase to rel= ease.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; Remove bundles.
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(with-directory-excursion &q= uot;thirdparty"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(for-each delete-file= -recursively
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0'("HID_Utilities"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"MallincamGuider-OSX-dylib-source.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"VidCapture"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"cfitsio-3.47-patched.tar.gz"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"cfitsio-README-PHD2.txt"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"cfitsio-snprintf.patch"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"eigen-eigen-67e894c6cd8f.tar.bz2"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"gettext-0.14.4-bin.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"gettext-0.14.4-dep.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"gtest-1.7.0.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"indiclient-44aaf5d3-win32.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"libcurl-7.54.0-win32.zip"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"libdc1394-2.2.2.tar.gz"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"libindi-58b26c584049e1b9ecd55aa5f4a225677a417898= .tar.gz"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"libusb-1.0.21.tar.bz2"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0"openssag")))))))

To make maintenance easier, perhaps you could reuse the 'delete-all-but= '
procedure from turbovnc or similar?=C2=A0 This has the benefit of listing what is kept (more transparent), and if the things we do care for change names, we will know.

Could you please send a v2 with this suggestion implemented?

--
Thanks,
Maxim
--000000000000e1ea9705f77b21f3--