From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 10:54:01 2023 Received: (at 62298) by debbugs.gnu.org; 24 Mar 2023 14:54:01 +0000 Received: from localhost ([127.0.0.1]:41131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfino-00041X-MG for submit@debbugs.gnu.org; Fri, 24 Mar 2023 10:54:00 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:36856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfinn-00041L-Ln for 62298@debbugs.gnu.org; Fri, 24 Mar 2023 10:54:00 -0400 Received: by mail-qt1-f178.google.com with SMTP id hf2so1688731qtb.3 for <62298@debbugs.gnu.org>; Fri, 24 Mar 2023 07:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679669634; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=vOinnVx3zB2t+MHwvsAUejMJHNWbx/lBruAHwRyr+3I=; b=Ndcmk2RjZVPZxRbaSZRa/fUs/2p34L+mgbLLlzQTmlEp+JosBVwUP/Pa1jNJkQ8lnV r1NOK3wC6Mwr/N2gcGTHcO3SndsKp1Ch0eP6Ricl6Uz3ioTl2V7Tp7dw8CdZAjaJaZ6M o5i/mjXNSz1du7OEVgBG8aV3WyLWEuV4LzkJpPunT16a+IQaxJdFahrSmihRkEEcILkw mi/N4tOSiVUfStpURYykSAXJLlWpTQnquVtANMGVW7fr/CpIIUqUTLNIq5HkOjobN+a7 jAujZQh1yPGEtlPG8Q2JAeg/D33O6x49VVSj9MKKPaK+xE6w5NjZSWhV6Av4fBVlzeQ0 0ZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679669634; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vOinnVx3zB2t+MHwvsAUejMJHNWbx/lBruAHwRyr+3I=; b=oyNnWStmG9EvlfS4tZvp9ig8m3eXLqZQO/YARlspT1c7Ntr+hgS075NddNvUGM7V88 82vyn04B0mbQhUyuqPU9uUup2dcdUHzwk1Cyia6gIeuQ1pPf5hM/bAFfBgOWcKXyWWjb oto6Fyx3paf5MllulicC2LTupFdiclmBkCwOJ02WAyuDqOnqjFS2DnnJc0TfXc7cwqMX vm+1iCRYZN4WOPZyPTstZt6R1AZpX214XacgvRy/q2mWUXeypEHSfXMOWC2Zu2+LJM8l rBGPZQEjYI0huZDPoQ42hzo7Bi8jJy6fIF8ZUtrhk/31X4pxUB1ANJaYLrQtDN5oqaeD XJ8A== X-Gm-Message-State: AO0yUKVeiDbsWi929aKOCbUc733Z/aBXwvMwxQw8SNpJG315uPSZEKZE cA4MbUTjunkHfd4MQZEbREvlY26KF8Gd4A== X-Google-Smtp-Source: AK7set/rqIZLehZcOZDsxme4t4fwMQvjv9yuOK0TVL2tNrTyrTlOxaCJ5NE0cnWhnBFJksNhkjbqmg== X-Received: by 2002:a05:622a:1d0:b0:3e3:7c94:7270 with SMTP id t16-20020a05622a01d000b003e37c947270mr5646101qtw.59.1679668339370; Fri, 24 Mar 2023 07:32:19 -0700 (PDT) Received: from hurd (dsl-155-54.b2b2c.ca. [66.158.155.54]) by smtp.gmail.com with ESMTPSA id s16-20020ac85290000000b003e38c9a2a22sm3380107qtn.92.2023.03.24.07.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 07:32:18 -0700 (PDT) From: Maxim Cournoyer To: Bruno Victal Subject: Re: [PATCH v2 4/8] services: mympd: Require 'syslog service when configured to log to syslog. References: <96e6404d84211c766924d2fcd4f88d33c11cacfe.1679583701.git.mirai@makinata.eu> Date: Fri, 24 Mar 2023 10:32:17 -0400 In-Reply-To: <96e6404d84211c766924d2fcd4f88d33c11cacfe.1679583701.git.mirai@makinata.eu> (Bruno Victal's message of "Thu, 23 Mar 2023 15:02:14 +0000") Message-ID: <87ileqz0cu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62298 Cc: 62298@debbugs.gnu.org, ludo@gnu.org, liliana.prikler@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Bruno Victal writes: > * gnu/services/audio.scm (mympd-shepherd-service): Depend on 'syslog when > configured to log to syslog. > --- > gnu/services/audio.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm > index e9ecccd614..e5b065a479 100644 > --- a/gnu/services/audio.scm > +++ b/gnu/services/audio.scm > @@ -749,7 +749,9 @@ (define (mympd-shepherd-service config) > (let ((log-level* (format #f "MYMPD_LOGLEVEL=~a" log-level))) > (shepherd-service > (documentation "Run the myMPD daemon.") > - (requirement `(loopback user-processes ,@shepherd-requirement)) > + (requirement `(loopback user-processes > + ,@(if (eqv? log-to 'syslog) '(syslog) '()) eq? is sufficient to compare symbols. Otherwise, LGTM. -- Thanks, Maxim