From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 20 14:44:59 2023 Received: (at 62293) by debbugs.gnu.org; 20 Mar 2023 18:44:59 +0000 Received: from localhost ([127.0.0.1]:56805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKV8-00022w-SJ for submit@debbugs.gnu.org; Mon, 20 Mar 2023 14:44:59 -0400 Received: from smtpm3.myservices.hosting ([185.26.105.234]:58694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peKV6-00022o-T6 for 62293@debbugs.gnu.org; Mon, 20 Mar 2023 14:44:58 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm3.myservices.hosting (Postfix) with ESMTP id 69FB220EB8; Mon, 20 Mar 2023 19:44:54 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 2109D80098; Mon, 20 Mar 2023 19:44:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SNiFKyzkZYjL; Mon, 20 Mar 2023 19:44:53 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id CB1C18009B; Mon, 20 Mar 2023 19:44:52 +0100 (CET) Message-ID: <581f51f5-aecc-13db-a499-af8a9e485d39@makinata.eu> Date: Mon, 20 Mar 2023 18:44:48 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [bug#62293] [PATCH] gnu: add pcsc-cyberjack Content-Language: en-US To: Arvid Krein References: From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62293 Cc: 62293@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi Arvid, On 2023-03-20 10:28, Arvid Krein wrote: > +(define-public pcsc-cyberjack > +  (package > +    (name "pcsc-cyberjack") > +    (version "3.99.5final.sp15") > +    (synopsis "PC/SC driver for cyberJack chipcard readers") > +    (home-page "http://www.reiner-sct.com/") > +    (description > +     "REINER SCT cyberJack USB chipcard reader user space driver > + This package includes the IFD driver for the cyberJack contactless > + (RFID) and contact USB chipcard reader.") How about “This package includes the IFD driver for the cyberJack contactless (RFID) and contact USB chipcard readers.” > +    (source (origin > +              (method url-fetch) > +              (uri > + "https://support.reiner-sct.de/downloads/LINUX/V3.99.5_SP15/pcsc-cyberjack_3.99.5final.SP15.tar.bz2")> +              (sha256 > +               (base32 > + "0yj6plgb245r218v6lgdabb3422hxyrw8rrpf5b8fwah4j1w5dxc")))) How about indenting this as: (source (origin (method url-fetch) (uri ...) (sha256 (base32 ...)))) > +    (arguments > +     (list #:configure-flags #~(list (string-append "--with-usbdropdir=" > +                                                    (ungexp output "out") > + "/pcsc/drivers") > +                                     (string-append "--bindir=" > +                                                    (ungexp output "tools") > +                                                    "/bin")) > +           #:phases '(modify-phases %standard-phases > +                       (add-after 'install 'install-tools > +                         (lambda _ > +                           (invoke "make" "-C" "tools/cjflash" "install")))))))) Do this: (arguments (list #:configure-flags #~(list (string-append "--with-usbdropdir=" #$output "/pcsc/drivers") (string-append "--bindir=" #$output:tools "/bin")) #:phases #~(modify-phases %standard-phases ... ))) Also, please reorder the package fields into something like: (define-public ... (package (name ...) (version ...) (source ...) (build-system ...) (arguments ...) (native-inputs ...) (inputs ...) (outputs ...) (synopsis ...) (description ...) (home-page ...) (license ...))) Cheers, Bruno