From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 18:08:04 2023 Received: (at 62202) by debbugs.gnu.org; 8 Apr 2023 22:08:04 +0000 Received: from localhost ([127.0.0.1]:59773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plGj5-0000nx-Qz for submit@debbugs.gnu.org; Sat, 08 Apr 2023 18:08:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plGj3-0000nU-LN for 62202@debbugs.gnu.org; Sat, 08 Apr 2023 18:08:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plGiv-0004xt-RO; Sat, 08 Apr 2023 18:07:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=TajsiM4QO16mND9oKQAKLa6N77xN8GXdGT/ZdjmuUJc=; b=d5oe4ax+cwVdThRubfwg LrWJae9Y9wbR7FMfkoyMINceshDYIVf4LDgs8ReQYuQSz0+dJV48u1hUMdSpoVjYCyDL40QdcmMBA m6cnGgroYSm40+SOQQl6xmDrxmS9xKApJUkTzjctiQeL4ZXg9uk3FR5O1n/Cr95qDpzi2+DBEwFqj jFZQJH8Z92xfx0RUeLSVs+byRwPrp+brfnKOwIMRAvBXREnZVKy7/AS0R6xFVCwPMleqa0Ud5NoTh TYUSJi3NwwwLKbtrExwPMr43VgZAHUm+YiFAd9/+TxMPQWPfQUwO0cMj9I3HE0RVASS8x1isypQzt Vn6ISEfMPJAHdw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plGiv-0008Cu-7w; Sat, 08 Apr 2023 18:07:53 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Nicolas Graves Subject: Re: bug#62202: [PATCH 0/21] Juliahub import script. References: <871qlq89kz.fsf@ngraves.fr> Date: Sun, 09 Apr 2023 00:07:50 +0200 In-Reply-To: <871qlq89kz.fsf@ngraves.fr> (Nicolas Graves's message of "Wed, 15 Mar 2023 13:47:56 +0100") Message-ID: <87ile69geh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62202 Cc: 62202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Nicolas Graves skribis: > Took me quite more time than I would've liked, but I have a usable > juliahub scheme import script! > > It seems there's still one edge case that isn't covered and revolves > around when Julia packagers don't properly tag their git repos (I've > only seen the case with SnoopPrecompile). There's the possibility to > rely on tree commit hashes from the General repository (since this is a > valid way to identify/store a git repo), but that needs some major > changes in the way latest-repository-commit works. Otherwise, it needs > to be done by hand. It might also not work for subpackages in > directories that are up-to-date on juliahub but not yet on github, I > haven't met this case yet. > > I'm sending a patch series in the coming minutes. > > It's detailed since I haven't swauased all commits, for readability, but > I can squash it further if necessary. I=E2=80=99ll let Simon comment on the actual code since I=E2=80=99m not a J= ulia person. :-) Some more general comments: =E2=80=A2 Please make sure to document it in =E2=80=98doc/guix.texi=E2=80= =99 under =E2=80=9CInvoking guix import=E2=80=9D, following the same template as the others there. =E2=80=A2 Please write =E2=80=98tests/juliahub.scm=E2=80=99. I recommend= the same strategy as =E2=80=98tests/cpan.scm=E2=80=99, which is to mock the upstream HTTP se= rver. =E2=80=A2 Prefer (srfi srfi-41) over (ice-9 streams) (see rationale at ). =E2=80=A2 Prefer (srfi srfi-71) over (srfi srfi-11) for multiple-value bindings. Thanks, Ludo=E2=80=99.