From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 17 04:52:05 2023 Received: (at 62123) by debbugs.gnu.org; 17 Mar 2023 08:52:05 +0000 Received: from localhost ([127.0.0.1]:43639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5oj-0008Ta-FT for submit@debbugs.gnu.org; Fri, 17 Mar 2023 04:52:05 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:51501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pd5oh-0008T3-Ay for 62123@debbugs.gnu.org; Fri, 17 Mar 2023 04:52:04 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 5AA7624000F; Fri, 17 Mar 2023 08:51:55 +0000 (UTC) From: Nicolas Goaziou To: Rostislav Svoboda Subject: Re: [bug#62123] [PATCH 3/4] gnu: Add emacs-pippel. References: <20230311144938.765-1-Rostislav.Svoboda@gmail.com> <20230311144938.765-3-Rostislav.Svoboda@gmail.com> Date: Fri, 17 Mar 2023 09:51:54 +0100 In-Reply-To: (Rostislav Svoboda's message of "Mon, 13 Mar 2023 14:01:52 +0100") Message-ID: <871qlndal1.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62123 Cc: 62123@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Rostislav Svoboda writes: > Oh, the patch is broken, ignore it. sorry. Here's a correction. Thanks. Some comments follow. > Please have a look at the 'python2 vs. python3' comment. Is it OK to > make it work just for python3? Guix does not support Python 2 anymore. Note, however, that you can provide `python-wrapper' as input instead of `python', and use "python" executable. Anyway sticking to "python3" is OK. > + (inputs (list python)) > + (propagated-inputs (list emacs-dash emacs-s)) Nitpick: usually, inputs and propagated inputs are located after arguments. > + (arguments > + (list #:phases #~(modify-phases %standard-phases You can add a newline characther after `list' and another one after `#:phases'. > + (add-after 'unpack 'substitute-python-path > + (lambda* (#:key inputs #:allow-other-keys) > + (emacs-substitute-variables "pippel.el" > + > ("pippel-python-command" > + (search-input= -file > + inputs > +;;; For 'python2 vs. python3' see the choice: > +;;; https://github.com/arifer612/pippel/blob/cb194952ee150e77601d3233dab= db521b976ee79/pippel.el#L65 > + > "/bin/python3")))))))) > + (home-page "https://github.com/arifer612/pippel") > + (synopsis "Emacs frontend to Python package manager pip") pip -> Pip > + (description > + "Emacs frontend for the Python package manager pip. As pippel al= so uses > +@code{tabulated-list-mode}, it provides a similar package menu like > +@code{package-list-packages}.") The first sentence is not complete : "Pippel is an Emacs=E2=80=A6" Also, pip -> Pip, pippel -> Pippel, @code{tabulated-list-mode} -> Tabulated List mode. > + (license license:gpl3+)))) I think you also need to include "pippel.py" file through #:include keyword and possibly configure `pippel-package-path'. Regards, --=20 Nicolas Goaziou