From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 05:55:42 2023 Received: (at 61959) by debbugs.gnu.org; 5 Mar 2023 10:55:42 +0000 Received: from localhost ([127.0.0.1]:38603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm1m-0002K6-Df for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:55:42 -0500 Received: from mail-ed1-f50.google.com ([209.85.208.50]:38512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYm1j-0002Js-3p for 61959@debbugs.gnu.org; Sun, 05 Mar 2023 05:55:41 -0500 Received: by mail-ed1-f50.google.com with SMTP id cw28so27337994edb.5 for <61959@debbugs.gnu.org>; Sun, 05 Mar 2023 02:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=burningswell-com.20210112.gappssmtp.com; s=20210112; t=1678013733; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=UG1Zi0iWfqwXkWezinE7GR/AOhZapyPTIfTmvJJ+TCk=; b=QwX7EzAtp79KIu8zRPwyWmkczKm/yzss6+KajIT3jJ06FFFZDADuUrM0LdQJerfDMD gLfM5jlQE+qfOiJ90zsVmECIczeeG2XRQbUQrGPPcMzBm9OGuFpjH+cRobyGKXYhk5n6 p2putH7N3n+Dn6uDJ7L+0o1avKxfNRXl/SYnJAqQVIBF9ykSI7bbL6WZxajtz0sjIXqD GESH6PZc0KHM4JUudttmfVuO04ElxlVMjhmyICR0YRvk8KZIjJuD2BTuad1sndIA5aIT Zfucpg9hEiaCb/ybFccGY5clM+7Rx2AX0c4yzxL0QrmWzE6cwrLAH12qQTMHALVz1FBw jkBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678013733; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UG1Zi0iWfqwXkWezinE7GR/AOhZapyPTIfTmvJJ+TCk=; b=HJl1qz3F+Wz+I7ReHfwtvvQD5Z/v9CLZX6NDUGJ+NMEjqGZ92xCM9HnT965NfQBAop UsaLR/6SPPF35myhzhZeLA6NBXcdlvkROk7nAdF03lb3JcEaA3FcDZxayr2YxfYmNeoj m+9F/3uR7BI55XfDLbmOeMTkdpPKXjztwO72fW3MpNQBlJ2Hdt4t48my95QJgKERozZW eHKfv84rtGnEHYmsb/iZphowEOvqWW0syyru1cOcTbi+OA3uD+cHKtvSn2DGtGJvzGov G3y0uh2TZCUdTQ0/GvQsSzJZzp2yJjtgHJOHbBUt6BYh4YrppC3gFIaAed5FJEyiA9Py rFOw== X-Gm-Message-State: AO0yUKUH2kRAxZXGPqLZpGy6kAQljiOBIN9mkHcsaYas5tA/kEpeu2lc 6OHBxDdGht7BwoOtik+ldZWJxzz0kTpvL8R1rwc= X-Google-Smtp-Source: AK7set/CNVeNk/kwRS1CMz7XcZ9oa+PMrs0e8jczpFrhny+UvdqH2ypULownZtDhko/Byu9+ckOsNQ== X-Received: by 2002:a17:906:a14:b0:8b1:7de3:cfb3 with SMTP id w20-20020a1709060a1400b008b17de3cfb3mr6924026ejf.1.1678013733163; Sun, 05 Mar 2023 02:55:33 -0800 (PST) Received: from bombaclaat ([2a01:598:b1ad:1fff:8e8b:b210:246d:cd7a]) by smtp.gmail.com with ESMTPSA id s26-20020a50ab1a000000b004bf999f8e57sm3477835edc.19.2023.03.05.02.55.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Mar 2023 02:55:32 -0800 (PST) References: <87mt4sl88u.fsf@elephly.net> User-agent: mu4e 1.8.13; emacs 29.0.60 From: Roman Scherer To: Ricardo Wurmus Subject: Re: [PATCH 0/7] Add some Asahi Linux packages Date: Sun, 05 Mar 2023 11:53:46 +0100 In-reply-to: <87mt4sl88u.fsf@elephly.net> Message-ID: <86zg8rlb6k.fsf@burningswell.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61959 Cc: 61959@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ricardo, I updated the patch series and sent v2 of it. Thanks for your review! Roman Ricardo Wurmus writes: > Thank you for the patches. > > Here a couple of comments: > > * Please do not use Github archive URLs like > "https://github.com/AsahiLinux/m1n1/archive/v=E2=80=A6.tar.gz". These = are > automatically generated and have changed in the past, leading to > different hashes. In the interest of reproducibility please use > =E2=80=9Cgit-fetch=E2=80=9D with plain commit hashes instead. > > * Please use G-expressions instead of simple quoting with (assoc-ref > outputs "out"). Instead of this: > > --8<---------------cut here---------------start------------->8--- > (arguments > `(#:phases > (modify-phases %standard-phases > (replace 'configure > (lambda _ > (setenv "RELEASE" "1"))) > (replace 'install > (lambda* (#:key outputs #:allow-other-keys) > (let ((dir (string-append (assoc-ref outputs "out") "/libexe= c/"))) > (mkdir-p dir) > (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")= )))) > ;; There are no tests > (delete 'check)))) > --8<---------------cut here---------------end--------------->8--- > > > Please do this: > > --8<---------------cut here---------------start------------->8--- > (arguments > (list > ;; There are no tests > #:tests? #false > #:phases > #~(modify-phases %standard-phases > (replace 'configure > (lambda _ > (setenv "RELEASE" "1"))) > (replace 'install > (lambda _ > (let ((dir (string-append #$output "/libexec/"))) > (mkdir-p dir) > (copy-file "build/m1n1.bin" (string-append dir "m1n1.bin")= ))))))) > --8<---------------cut here---------------end--------------->8--- > > This also applies to =E2=80=9Casahi-fwextract=E2=80=9D. > > * The string labels for inputs are a deprecated style. Please use plain > lists of package variables. If you want to modify an inherited list > of inputs such as in =E2=80=9Casahi-mesa=E2=80=9D please use =E2=80=9Cm= odify-inputs=E2=80=9D. > > * In =E2=80=9Casahi-fwextract=E2=80=9D the build phase =E2=80=9C'remove-v= endor=E2=80=9D should be a > source snippet instead. > > * Please use pyproject-build-system instead of python-build-system. The > pyproject-build-system is going to be the default in the future, and > it would be good to use it already to address any incompatibilities > early. > > Could you please send a new version of this patch set? Thanks again! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFTBAEBCAA9FiEE0iajOdjfRIFd3gygPdpSUn0qwZkFAmQEdSMfHHJvbWFuLnNj aGVyZXJAYnVybmluZ3N3ZWxsLmNvbQAKCRA92lJSfSrBmaPXB/0cp+M44KDxUvEb 9PlAgCaK4bDngwY6NugzwPsOeSIWVYsWJnEX7RuMux89uZuKL6TAe42H0kQbLOLb 6bFumyHOEIBjs9IDg+vQszlbMGDHSqsPo/vxeVvqNtMp9U4kJc/qQU7idocyY7gA FnAMxakQUm6a8YjfGzfaXvQGJ3HfiUYnfLqm01gtfpGKM4alILr3izGQKEp6ENEV PP2GLFPIdjUnpshLddARa5axdQY9ACWi4SkL3fOcv8cDx697R45qh+g1jelbYhhY OhTU9WZxHXSzil6jafTJWLfRr+g4mDYQRWhuJSIYg5jOkYN/WQLPek6IAAjimyZT r6Ns/W5G =RjWj -----END PGP SIGNATURE----- --=-=-=--