From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 04 08:20:16 2023 Received: (at 61865) by debbugs.gnu.org; 4 Jun 2023 12:20:16 +0000 Received: from localhost ([127.0.0.1]:45235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5miU-0007ef-EA for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:20:16 -0400 Received: from mail-ed1-f49.google.com ([209.85.208.49]:47213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5miQ-0007eD-EK for 61865@debbugs.gnu.org; Sun, 04 Jun 2023 08:20:12 -0400 Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-51496f57e59so5112826a12.2 for <61865@debbugs.gnu.org>; Sun, 04 Jun 2023 05:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685881205; x=1688473205; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=4LZvqDAUIGH5qUhP7Ha07fZ2zirNze0dBB5b2mG5QFA=; b=TqlozXNOKP8IEIbj9CwcB07u0ZKg0owH5tfFinu7ysHPbGBk4WSCYtCG+glUOFGmMT +W8cPqxyLn7BYn7x9iNwL+LDO0f/dHjAQU2fcRd8/91wylQWv0Qh/ilns5KCsfL7H5fA LYDg84Om/fJivRZM8LIeoLLIy5h2ClCGmZinbwGLO92J9l9NQiHDyUb7pZSofNrR37J9 QfOdA4MweFeBjdLCwXXtkKEj7pI6yGupkqSUyzGHFR7ZC5l2ZbzlTTrfgm00PRRIwuiq KuWKdD6PzQk3koLl1pykX+NcHv8WqfjdRg+GDWMiRf0rFi7+LBbzqcIqtCSZRtgbEODH tLBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685881205; x=1688473205; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4LZvqDAUIGH5qUhP7Ha07fZ2zirNze0dBB5b2mG5QFA=; b=LfL1WyZXOTDDIW3EjjIpkppK4adOI+EcCDsbpWDrWtAIQHnagTs0+DpVI1L6RR+DgP 1F6+xkLCOyIgZ4SXtAC8es9e/0dn3CDLZDboi116WlkP7vgpYil15P8nWWuRG6TA8khD GFlk4WV2fj7yHriauxtMEwT2sscBKrCqgi64DfDUZKGX3xOmf0K6sR1n8O/L7AWWapul rHqkfQiH5OAr7uggWTkERp2IH5uAaR+a7Ovcil93MRpcwVxB/jnraRIjODobj7PpTVq5 otrOHtTcAJOjgFnb51otFabkWU5Yi9mPkwrDr3NsuHrQ8ugshIZ5fDgklwUWZtSdZhkM oq3Q== X-Gm-Message-State: AC+VfDzxVYtZIGRDExRNyL4TrwWO6De4ARYLOTl+hOY5YsOaPJlY6roA bRmLkSKHZtABOtLYSdc1E4k= X-Google-Smtp-Source: ACHHUZ41+1QMIGnu6vN6AYuwfiJEoeXkQFX+dnd0+yrvXIUuDJxaf9E88T9agX8R10jgXQBxHWZv5A== X-Received: by 2002:a05:6402:184d:b0:510:d0bc:e130 with SMTP id v13-20020a056402184d00b00510d0bce130mr5159304edy.33.1685881204447; Sun, 04 Jun 2023 05:20:04 -0700 (PDT) Received: from localhost ([2a02:ed3:913:500:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id m18-20020aa7d352000000b00511aea132b9sm2745877edr.3.2023.06.04.05.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 05:20:04 -0700 (PDT) Date: Sun, 4 Jun 2023 15:19:59 +0300 From: Efraim Flashner To: Z572 <873216071@qq.com> Subject: Re: [bug#61865] [PATCH 7/8] gnu: libotf: fix cross-compile. Message-ID: Mail-Followup-To: Efraim Flashner , Z572 <873216071@qq.com>, 61865@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jsi3bvkcNsOToxsG" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61865 Cc: 61865@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --Jsi3bvkcNsOToxsG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable This one I didn't apply. I don't believe adding freetype as a native-input is correct but I could see adding it as an input. In the end libotf links to freetype, and we don't want it to link to the one in native-inputs. I don't think the phase is the correct way to do this. I didn't see any error related to it when I was building it before applying the patch, and I made it pretty far after overriding the location of freetype-config. On Tue, Feb 28, 2023 at 04:33:39PM +0800, Z572 via Guix-patches via wrote: > * gnu/packages/fontutils.scm(libotf): fix cross-compile. > [native-inputs]: > add freetype, when cross-compile, add libtool, autoconf automake. > [arguments]: when cross-compile, add phase to fix rpl_malloc undefined re= ference > --- > gnu/packages/fontutils.scm | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/fontutils.scm b/gnu/packages/fontutils.scm > index 72621cc006..d451f5e504 100644 > --- a/gnu/packages/fontutils.scm > +++ b/gnu/packages/fontutils.scm > @@ -1392,7 +1392,22 @@ (define-public libotf > (base32 "0sq6g3xaxw388akws6qrllp3kp2sxgk2dv4j79k6mm52rnih= rnv8")))) > (build-system gnu-build-system) > (native-inputs > - (list pkg-config)) > + (append (if (%current-target-system) > + (list libtool > + autoconf automake) > + '()) > + (list pkg-config freetype))) > + (arguments (if (%current-target-system) > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-rpl_malloc > + (lambda _ > + (substitute* "configure.ac" > + (("AC_FUNC_MALLOC") > + "")) > + (invoke "sh" "autogen.sh"))))) > + '())) > (propagated-inputs > (list freetype)) > (home-page "https://www.nongnu.org/m17n/") > --=20 > 2.39.1 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Jsi3bvkcNsOToxsG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmR8gW8ACgkQQarn3Mo9 g1H0pQ//aIcDPNn7ETK8LQHu2/LboJOSAJbdoPYMW9WrYusIc4NRzKzseniSPezu vHhI4H4Cglmm7T7JH2rMtfCNeXHlr2Cpe2oZ2XzGQX851OwFdM5ZWbJKBQskztfV Xj87o03mtrifiWSqJ41gesI9gDG98+5tWCjW8NOeXBRPaWt1FPUYQsDMHoQ7f2Am No969qhohMz4+5mcBbJEOjWkOkBhjLYH+mFDboiN5xKjOhYczvZGPMiCSjty3go0 B7MJRVw0OnrGfhxFbKXHj0rM28cbGR072fttNJbW2ZIZkELTrvrc/ffzKPgYrpdd kZIGj2lS+ganzH1QNp1uwx+/pjdo+mmJGGRO+TSIQ4wUm/+b8PnOl/BeslQ5OT9P 1o7aNSGV4jJBL7gMCQ7987bd5aFz3kbkdn6zjyk+aH7XNb/mZjpyD0hryqOUxzlr uY6jPB6gppCjj3hsmSIgeOItD6HB7akfNlefBX6k+uOL21YFF/WFT47crpOT//GI CvvtHjD/YPacDs7xnt9zq0LH3SoEmqIR4/p/P/ofDNA7yZaEjswJjLYQ8Zlr/mA5 J+MSoBERx55r1t/Rp4v0vSQUeYmieeUYj6Z8UorkaWz9LEbGhnqayGega44aE77r uLLPGc+wrP5HY80MC7FXTfC0W6CN7r0AimMnERdElNGRpPEgrO4= =JCkm -----END PGP SIGNATURE----- --Jsi3bvkcNsOToxsG--