From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 02:51:08 2023 Received: (at 61010) by debbugs.gnu.org; 25 Jan 2023 07:51:08 +0000 Received: from localhost ([127.0.0.1]:58161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKaYl-0007xY-PA for submit@debbugs.gnu.org; Wed, 25 Jan 2023 02:51:08 -0500 Received: from mail-qt1-f175.google.com ([209.85.160.175]:45826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKaYj-0007x2-Sx for 61010@debbugs.gnu.org; Wed, 25 Jan 2023 02:51:06 -0500 Received: by mail-qt1-f175.google.com with SMTP id h24so11370086qta.12 for <61010@debbugs.gnu.org>; Tue, 24 Jan 2023 23:51:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atai-org.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+WUM8n2F94moCavRYlNzzHiGs+R1hqZewH2WJ35l50w=; b=C9Ab92io90sXGX3ZAk53ZR1cACbq+ePMMtWNoXLEcTNCtER6ij74qO8JCxZMREau0J kKRHQu5UBMiLMMQsFAg0Ptl9JSXVULp7H1Rc8fFWuXNhfuG8OlSxO8FHP/f95847NG7F Tam0mwb9nADiKbK3tNRxpaciPKt2tH3dlIbm9OBUfBz9wv4FlHHOqu4tdmeQzxB1X2bY XpYpCxlLPezMGlTF803T2cx8bzBDpOmAov6WVi/PvK856FCH6iNZgQi4h81FKYR8ZaFP 6jmDn9CVejO5X58A5BPc8btmOUPAfH1/L3ssruyn5zN/6DE5eAxBYhDNdo4nX03ysBgw prHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+WUM8n2F94moCavRYlNzzHiGs+R1hqZewH2WJ35l50w=; b=nAha7YoRxxmUJ9nEZEL1ehhvdoBtVvrPyApxWjLC+MqDJlC9Yy0pHQZaRmgwdf0C/H 5ioKXDqKlj6suA2lOLFxGe78FjGVo7NoZQxxHw2+rb8G/oltrIYK4WrE0l5wYq7MA8Mf 1rSZruvPJeeHhEYBsyn/VBh/dvAvAk9Rdx8pGVFKhsEaVUnShH5z+TMnfMEyp6KvBgk0 4NojQKTSLwawiHLf5+g0fM4yQpQ2n+2qLFqhu95n+f/zFGuHh7+QkwUq6Z9jeZisLP6u yFA+4sv8QgpI470YqHi8gT7CrHetMl/92zbT+m+k3EAKrEsfUxFOYHxiL3LMLVheGXF2 r+DQ== X-Gm-Message-State: AFqh2kq9uB3bADR7nSBmPvRUd3U2iWUbXg1uNeENwelF8u5T5alavtlv C8l/IccM3tuebMo308EpA8HRaI7V8mbRfk+7kRY= X-Google-Smtp-Source: AMrXdXs5ouwcOVwirgB3ib49VX4eYMOus7dtLRRSH+8t/KEFmOlC0l0TgxkHiwRW7XP2PiLyd0CU2WEu9VlITFbfD9w= X-Received: by 2002:a05:622a:28c:b0:3b6:36a0:adc2 with SMTP id z12-20020a05622a028c00b003b636a0adc2mr1404314qtw.107.1674633059961; Tue, 24 Jan 2023 23:50:59 -0800 (PST) MIME-Version: 1.0 References: <87k01cp195.fsf@gmail.com> In-Reply-To: From: Andy Tai Date: Tue, 24 Jan 2023 23:50:23 -0800 Message-ID: Subject: Re: [bug#61010] [PATCH] gnu: Add icewm To: Simon Tournier Content-Type: multipart/mixed; boundary="000000000000ab493d05f311e405" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61010 Cc: 61010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000ab493d05f311e405 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable same patch with only difference of label as "v2" not sure how to make Guix QA rebuild with the new patch On Tue, Jan 24, 2023 at 11:37 PM Andy Tai wrote: > > updated patch attached > > > On Tue, Jan 24, 2023 at 4:35 AM Simon Tournier = wrote: > > > > The patch builds fine and it LTGM except one minor point. > > > > On dim., 22 janv. 2023 at 12:37, Andy Tai wrote: > > > > This archive contains generated .gmo which are not in the source code > > [1] and I do not know what is the usual Guix policy about that. Do we > > re-generate them? > > > > Other said, these files are in the archive tar.gz [2]. > > > > 1: > > 2: > > > > This I did not address in the revision because the second .tar.gz is > available on the net, satisfying GPL's source requirement... but will > revise if Guix policy demands otherwise > > > > > \ No newline at end of file > > > > This patch does not apply to current master. From my point of view, it > > is worth to provide the base-commit (see --base option of > > git-format-patch or git-send-email). > > > > And it helps if the new package is not added to the end of the file. > > For instance, I would put it between i3lock-fancy and xmonad-next. > > > > addressed as suggested > > > > Cheers, > > simon --=20 Andy Tai, atai@atai.org, Skype: licheng.tai, Line: andy_tai, WeChat: andyta= i1010 Year 2023 =E6=B0=91=E5=9C=8B112=E5=B9=B4 =E8=87=AA=E5=8B=95=E7=9A=84=E7=B2=BE=E7=A5=9E=E5=8A=9B=E6=98=AF=E4=BF=A1=E4= =BB=B0=E8=88=87=E8=A6=BA=E6=82=9F =E8=87=AA=E5=8B=95=E7=9A=84=E8=A1=8C=E7=82=BA=E5=8A=9B=E6=98=AF=E5=8B=9E=E5= =8B=95=E8=88=87=E6=8A=80=E8=83=BD --000000000000ab493d05f311e405 Content-Type: text/x-patch; charset="UTF-8"; name="v2-0001-gnu-Add-icewm.patch" Content-Disposition: attachment; filename="v2-0001-gnu-Add-icewm.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ldbd7qn20 RnJvbSA1OGFmOTQ5YmU2ZDQzYzQxOTRjNTE3ODc0YTAyMWI0M2NiZWExNTQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmR5IFRhaSA8YXRhaUBhdGFpLm9yZz4KRGF0ZTogVHVlLCAy NCBKYW4gMjAyMyAyMzoyNTowNyAtMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjJdIGdudTogQWRkIGlj ZXdtCgoqIGdudS9wYWNrYWdlcy93bS5zY20gKGljZXdtKTogTmV3IHZhcmlhYmxlCi0tLQogZ251 L3BhY2thZ2VzL3dtLnNjbSB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQg YS9nbnUvcGFja2FnZXMvd20uc2NtIGIvZ251L3BhY2thZ2VzL3dtLnNjbQppbmRleCBhODYwZWQx ZjkzLi5mMmQzZjZmMWIzIDEwMDY0NAotLS0gYS9nbnUvcGFja2FnZXMvd20uc2NtCisrKyBiL2du dS9wYWNrYWdlcy93bS5zY20KQEAgLTEwMCw2ICsxMDAsNyBAQCAoZGVmaW5lLW1vZHVsZSAoZ251 IHBhY2thZ2VzIHdtKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBiaXNvbikKICAgIzp1 c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgYnVpbGQtdG9vbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251 IHBhY2thZ2VzIGNhbGVuZGFyKQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBjb21wcmVz c2lvbikKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgY2hlY2spCiAgICM6dXNlLW1vZHVs ZSAoZ251IHBhY2thZ2VzIGRhdGFzdHJ1Y3R1cmVzKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBkb2Nib29rKQpAQCAtNzYzLDYgKzc2NCw2NCBAQCAoZGVmaW5lLXB1YmxpYyBpM2xvY2st ZmFuY3kKIGRlc2t0b3AgZW52aXJvbm1lbnQuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmV4cGF0 KSkpCiAKKyhkZWZpbmUtcHVibGljIGljZXdtCisgIChwYWNrYWdlCisgICAgKG5hbWUgImljZXdt IikKKyAgICAodmVyc2lvbiAiMy4zLjAiKQorICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAg ICAgICAobWV0aG9kIHVybC1mZXRjaCkKKyAgICAgICAgICAgICAgKHVyaSAoc3RyaW5nLWFwcGVu ZAorICAgICAgICAgICAgICAgICAgICAiaHR0cHM6Ly9naXRodWIuY29tL2ljZS13bS9pY2V3bS9y ZWxlYXNlcy9kb3dubG9hZC8iCisgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi9pY2V3bS0i IHZlcnNpb24gIi50YXIubHoiKSkKKyAgICAgICAgICAgICAgKHNoYTI1NgorICAgICAgICAgICAg ICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICIxNHZrdjVyOXJ2d2ZqOGdtZHNya2txN3Z4dmsy ajd6N3dmeWJ6Yzh5d2o0Njl5eWE1cHBxIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGdudS1idWls ZC1zeXN0ZW0pCisgICAgKG5hdGl2ZS1pbnB1dHMgKGxpc3QgcGtnLWNvbmZpZykpCisgICAgKGlu cHV0cyAobGlzdCBmb250Y29uZmlnCisgICAgICAgICAgICAgICAgICBmcmliaWRpCisgICAgICAg ICAgICAgICAgICBpbWxpYjIKKyAgICAgICAgICAgICAgICAgIGxpYmljZQorICAgICAgICAgICAg ICAgICAgbGlianBlZy10dXJibworICAgICAgICAgICAgICAgICAgbGlic20KKyAgICAgICAgICAg ICAgICAgIGxpYnhjb21wb3NpdGUKKyAgICAgICAgICAgICAgICAgIGxpYnhkYW1hZ2UKKyAgICAg ICAgICAgICAgICAgIGxpYnhleHQKKyAgICAgICAgICAgICAgICAgIGxpYnhmaXhlcworICAgICAg ICAgICAgICAgICAgbGlieGZ0CisgICAgICAgICAgICAgICAgICBsaWJ4aW5lcmFtYQorICAgICAg ICAgICAgICAgICAgbGlieHBtCisgICAgICAgICAgICAgICAgICBsaWJ4cmFuZHIKKyAgICAgICAg ICAgICAgICAgIGxpYnhyZW5kZXIKKyAgICAgICAgICAgICAgICAgIGxpYngxMQorICAgICAgICAg ICAgICAgICAgbHppcAorICAgICAgICAgICAgICAgICAgcGVybCkpCisgICAgKGFyZ3VtZW50cwor ICAgICBgKCM6cGhhc2VzIChtb2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAg ICAgICAgICAgIChhZGQtYWZ0ZXIgJ3VucGFjayAnc2tpcC1mYWlsaW5nLXRlc3QKKyAgICAgICAg ICAgICAgICAgICAgOzsgc3RydGVzdC5jYyB0ZXN0cyBmYWlsaW5nIGR1ZSB0byAkSE9NRSBhbmQg L2V0YyBzZXR1cAorICAgICAgICAgICAgICAgICAgICA7OyBkaWZmZXJlbmNlIHVuZGVyIGd1aXgK KyAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSBfCisgICAgICAgICAgICAgICAgICAgICAgKHN1 YnN0aXR1dGUqICJzcmMvTWFrZWZpbGUuaW4iCisgICAgICAgICAgICAgICAgICAgICAgICAoKCJU RVNUUyA9IHN0cnRlc3RcXCRcXChFWEVFWFRcXCkiKQorICAgICAgICAgICAgICAgICAgICAgICAg ICJURVNUUyA9ICIpKSAjdCkpKSkpCisgICAgKGhvbWUtcGFnZSAiaHR0cHM6Ly9pY2Utd20ub3Jn LyIpCisgICAgKHN5bm9wc2lzICJXaW5kb3cgbWFuYWdlciBmb3IgdGhlIFggV2luZG93IFN5c3Rl bSIpCisgICAgKGRlc2NyaXB0aW9uCisgICAgICJJY2VXTSBpcyBhIHdpbmRvdyBtYW5hZ2VyIGZv ciB0aGUgWCBXaW5kb3cgU3lzdGVtLiAgVGhlIGdvYWwgb2YKK0ljZVdNIGlzIHNwZWVkLCBzaW1w bGljaXR5LCBhbmQgbm90IGdldHRpbmcgaW4gdGhlIHVzZXLigJlzIHdheS4gIEl0IGNvbWVzIHdp dGggYQordGFza2JhciB3aXRoIHBhZ2VyLCBnbG9iYWwgYW5kIHBlci13aW5kb3cga2V5YmluZGlu Z3MgYW5kIGEgZHluYW1pYyBtZW51IHN5c3RlbS4KK0FwcGxpY2F0aW9uIHdpbmRvd3MgY2FuIGJl IG1hbmFnZWQgYnkga2V5Ym9hcmQgYW5kIG1vdXNlLiAgV2luZG93cworY2FuIGJlIGljb25pZmll ZCB0byB0aGUgdGFza2JhciwgdG8gdGhlIHRyYXksIHRvIHRoZSBkZXNrdG9wIG9yIGJlIG1hZGUK K2hpZGRlbi4gIFRoZXkgYXJlIGNvbnRyb2xsYWJsZSBieSBhIHF1aWNrIHN3aXRjaCB3aW5kb3cg KEFsdCtUYWIpIGFuZCBpbiBhCit3aW5kb3cgbGlzdC4gIEEgaGFuZGZ1bCBvZiBjb25maWd1cmFi bGUgZm9jdXMgbW9kZWxzIGFyZQorbWVudS1zZWxlY3RhYmxlLiAgU2V0dXBzIHdpdGggbXVsdGlw bGUgbW9uaXRvcnMgYXJlIHN1cHBvcnRlZCBieSBSYW5kUiBhbmQKK1hpbmVyYW1hLiAgSWNlV00g aXMgdmVyeSBjb25maWd1cmFibGUsIHRoZW1lYWJsZSBhbmQgd2VsbCBkb2N1bWVudGVkLiAgSXQK K2luY2x1ZGVzIGFuIG9wdGlvbmFsIGV4dGVybmFsIGJhY2tncm91bmQgd2FsbHBhcGVyIG1hbmFn ZXIgd2l0aCB0cmFuc3BhcmVuY3kKK3N1cHBvcnQsIGEgc2ltcGxlIHNlc3Npb24gbWFuYWdlciBh bmQgYSBzeXN0ZW0gdHJheS4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMikpKQorCisKIChk ZWZpbmUtcHVibGljIHhtb25hZC1uZXh0CiAgIChwYWNrYWdlCiAgICAgKG5hbWUgInhtb25hZC1u ZXh0IikKCmJhc2UtY29tbWl0OiA3MTgyMjNjNThjMjBmYTA2NjUyN2ZiMzBkYTJiNWRjY2NhODI5 MTNmCi0tIAoyLjM5LjEKCg== --000000000000ab493d05f311e405--