From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 22:35:03 2023 Received: (at 60788) by debbugs.gnu.org; 9 Feb 2023 03:35:03 +0000 Received: from localhost ([127.0.0.1]:57103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxiB-00060B-9L for submit@debbugs.gnu.org; Wed, 08 Feb 2023 22:35:03 -0500 Received: from mail-qv1-f49.google.com ([209.85.219.49]:46938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxi6-0005zc-E2 for 60788@debbugs.gnu.org; Wed, 08 Feb 2023 22:35:02 -0500 Received: by mail-qv1-f49.google.com with SMTP id l6so178567qvl.13 for <60788@debbugs.gnu.org>; Wed, 08 Feb 2023 19:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zM64E3OtC+1XlCBdr5msDSAmX58h1+QOjhm7HXRdcjE=; b=Eb3Wz6Cl5HYUs9J3pVnh3CSWKS5lLSLTOdunAv7HwlngNJOWx4EPLBwfWP2Yz5eKpz f92ztD5Uxz1l0iRj6wyyKYRsC86wcgEZ0tRWNLUHpLXp4kPqQhX9EicGWHJoZrvmhW8D /hAFoZDoJubmBLJBE8OJ7iIQ8kPe8ecwPQm0toV91FHq0WCLKXKHQxTEE4VS/OMauX+0 Ldi7Lcukibzk3LjtMlkcEnEj3OAHiicSlSULfeC2tBALDRqF4KSqfOs+uJzBEiuCnkiL yrrQF7RZGgVkqL/iXYkyanDezA0noC/xwl18Ds2k7KFl1fS5QHDB6Bpp/Fwk7gKJ9OJD zHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zM64E3OtC+1XlCBdr5msDSAmX58h1+QOjhm7HXRdcjE=; b=ePX+Y5urZGPW7pkorf7bbh/foAyrhaeLOvw0BUPMAHINcQOctwQ2jKyGLGYc5WzsD1 bxCx5k1unEuZEErXgmb4m0035sLFB2fJaG4xdrgEJNRbnRXNBszU5CEmDaEcjstX0UwT RHHf1c0bg5MbSVnoVL7ItqX3mQO8UKhZDGlaUhu/PxtCAz2mRX8DMFW9kpSAGyZidbXp INm4EEKQBz3MYYhje3KlzXS1xMYpsNq+dOfgRLznFjx8bqaG9Tf5knuMFVpSN4H5L0xM g3AB3V1nt4roQh+ukCtTIGhQLQh/XV6dM0jje7GpwjHVtSkHEL5vN3JKgdF/EXtTBTCp 0lTg== X-Gm-Message-State: AO0yUKUtC24pjcLePAIS4J7Gbj0bbk9QocWumUVDydu4wN0AzXMhbhR3 LQpjN3Q29M3janvc/DIMrIqxgVE6kW++1w== X-Google-Smtp-Source: AK7set8QiBAyaMyhWB3Mxv6fSs73zUKHoWeMh9scBL+2Xdqi/9cw7ATG0fwRS3eIPHtd0W2QrAH8Rg== X-Received: by 2002:a05:6214:e85:b0:567:d345:1019 with SMTP id hf5-20020a0562140e8500b00567d3451019mr16722780qvb.42.1675913692808; Wed, 08 Feb 2023 19:34:52 -0800 (PST) Received: from hurd (dsl-151-105.b2b2c.ca. [66.158.151.105]) by smtp.gmail.com with ESMTPSA id 2-20020a05620a040200b006fbb4b98a25sm484501qkp.109.2023.02.08.19.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Feb 2023 19:34:52 -0800 (PST) From: Maxim Cournoyer To: Bruno Victal Subject: Re: bug#60788: [PATCH] services: Add vnstat-service-type. References: <95b646eb6b23dec213cba43b6e4e7ddc4a601d0f.1673640404.git.mirai@makinata.eu> <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> Date: Wed, 08 Feb 2023 22:34:51 -0500 In-Reply-To: <8b62c1b5643a09163b53af4bf03bb12862770b50.1675779899.git.mirai@makinata.eu> (Bruno Victal's message of "Tue, 7 Feb 2023 14:25:23 +0000") Message-ID: <87357fjyuc.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60788 Cc: 60788@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Bruno, Bruno Victal writes: > * gnu/services/monitoring.scm (vnstat-service-type): New variable. > * doc/guix.texi (Monitoring Services): Document it. > --- > doc/guix.texi | 240 ++++++++++++++++++- > gnu/services/monitoring.scm | 451 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 689 insertions(+), 2 deletions(-) Two remaining comments from me: 1. I'd normalize all the configuration field names to lowercase, so max-BW and use-UTC? would become max-bw and use-utc?, for example. 2. I'd add a simple example vnstat usage example to the manual. With this done, I think it should be good to go! -- Thanks, Maxim