From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 04 00:25:09 2023 Received: (at 60341) by debbugs.gnu.org; 4 Jan 2023 05:25:09 +0000 Received: from localhost ([127.0.0.1]:47308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCwGz-0000Vf-0w for submit@debbugs.gnu.org; Wed, 04 Jan 2023 00:25:09 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pCwGv-0000V4-OM for 60341@debbugs.gnu.org; Wed, 04 Jan 2023 00:25:07 -0500 Received: (Authenticated sender: andrew@trop.in) by mail.gandi.net (Postfix) with ESMTPSA id E4BB860005; Wed, 4 Jan 2023 05:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=gm1; t=1672809899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pY0oCrK69kqhHBfNg/cRJ1TEJC+INQYaALc5lz+HDwg=; b=Ox8ZOgIeXanibNt2Sv3RpRtoHj887yh1UO3KoypvF7cI1e0an3OJO3GZZUIZ8PJw4DPaU0 6+gVk6QjZVefNJ2jehMkn2FIS9lovAGOreWMLssXpsOjQT69qnugxzhkwoviYamEV8UQuG ycmYLI0TIhO9G2YRTCMAo6ikr/pZmvp+unRIXsnglMz2Bfqj4ueei8RT9U+Bh+e22HWxTB 67rezwBdDb6Xgt/SZjGW61P0xO7Ip7RdCmIO+AgniQ8CJQsPytqRmqkGJb6gK0eHn/9FHp Gs/UPhRiX9x3yAKZye7+wlBuWdZFRH+4n3+DLopYP1fvLb8Gob5fH1MsKwqePQ== From: Andrew Tropin To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60341: [PATCH Home] home: services: environment-variables: Add support for literal strings. In-Reply-To: <871qob6xj7.fsf_-_@gnu.org> References: <20221226181938.30003-1-ludo@gnu.org> <87o7rpa6rk.fsf@trop.in> <871qob6xj7.fsf_-_@gnu.org> Date: Wed, 04 Jan 2023 09:24:55 +0400 Message-ID: <874jt6c1nc.fsf@trop.in> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 60341 Cc: 60341@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2023-01-03 23:52, Ludovic Court=C3=A8s wrote: > Hi, > > Andrew Tropin skribis: > >> On 2022-12-26 19:19, Ludovic Court=C3=A8s wrote: > > [...] > >>> I found that it=E2=80=99s occasionally useful to be able to define shel= l variables >>> with a value that is to be taken literally, without shell expansion. T= his >>> is what this patch implements. >>> >>> Thoughts? >> >> Hi Ludo, >> >> the code looks good. >> >> I'm a little conserned that one need to learn a new abstraction to >> properly quote the expression instead of just using " or ' inside value >> string, but we already have af4c103595a725194318f40fc5aba110772ff417 and >> with the current state of the code this change looks rational and >> idiomatic. Also, it makes the interface more high-level, which can be >> good in some circumstances. > > Yeah, the shell/Scheme mixture is a bit weird; it=E2=80=99s sort of in-be= tween > because you can=E2=80=99t completely ignore that it=E2=80=99s shell code = under the hood. > > Looking at , I think we should strive > to not generate non-working shell snippets. Automatic quoting and this > =E2=80=98literal-string=E2=80=99 construct are a way to achieve that. Yep, I think this is a way to go. =2D-=20 Best regards, Andrew Tropin --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEKEGaxlA4dEDH6S/6IgjSCVjB3rAFAmO1DacACgkQIgjSCVjB 3rAtaA/+OyZlFHlMBE/anUfmGxS+nbwAA+DbnS4iZF0d4cOPBEbKE0fXF+mg8sxG cicet9x8W3H5PY7017sku1PczQ0Z/EYmrEkN1vMXxCLtZwGWzGW20w1fV0QFBUuU yedFt9YhO/v81BvX5B+nT6ySJXQgmvkEGlB4nE9+k7zc5mN+0SedXnXLz7+7yeJr OL4OCoxLRzaeR+7Wk2pVtNBg06RftCWcFED7MQCSLFpwskVRhcZy+JDssWBGGaXc Wh6ANnKxiN14UGT6L2bslKMCubanfTXcfccZeL4KKMt2V+B4fvTTiAsAmSecvagg pAoxaXwm0s6S7Wqpd+YkWoWHfzItrDMFWdmQlcMrJ/fiSz2cucgF7feQD4m8v0HC w6LCkyu93enHpLBoLOIVBjNvu214rxc43DODKAJzjfil5JttIm0SfUwtK7Zw/Rs9 90jBdZu8c1LycxUqLKUTqWRoDpsw66wKK4cFGAiOpMs5moFN66idrW4tBtQe/WiE 6xtaghFs4z0LkM+A+FCLKLUNZboOvxQUKagLQ8sB0OOoehhi/OwqWlfc1XAmhTk1 0YF1KK3C6kF5bWiGikPN+8/VxWz52JF6GrS5cvcanZVFRJTaxr9LmmhWt3LnDBD8 FJ6JX7BSBKUHNrkD5ICMyDdlnytTRrMCxPYM5arSTBZIHUrEP1g= =GoBM -----END PGP SIGNATURE----- --=-=-=--