From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 16:12:35 2022 Received: (at 60120-done) by debbugs.gnu.org; 21 Dec 2022 21:12:35 +0000 Received: from localhost ([127.0.0.1]:53963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p86OA-00054a-Qf for submit@debbugs.gnu.org; Wed, 21 Dec 2022 16:12:35 -0500 Received: from lepiller.eu ([89.234.186.109]:46918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p86O7-00054U-72 for 60120-done@debbugs.gnu.org; Wed, 21 Dec 2022 16:12:33 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 98985d8e; Wed, 21 Dec 2022 21:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=fQmO9tJoQoa7 U85S3weqRDouvU+7afwFS8DaUwHXnj4=; b=CnY0s8Vcn5zZ6HV/fPZNSc2fHPKb mcZ6+FIwcqy7J7Hp7Hfd6wBPKrz1YAzn5dLifacH9rrU3WELxIkWK0zcsi5uLOpE /+ww3PuQGogQjfbntt5EzBEP+ymnFNG+6kJEJfhhVtP8MIXUiW+MIR76jjkQ91F5 OgNRNtT8yn6B6RO9eeWs+31gGa9hfNgRQvOq7Us5itx0Bkl+LTBeo/G43m54e9I9 edV3cCx5R2Or1YLHpO8zHOtGEWlGTbA3ljj7Iyao8RCpVWBO7Joe7eNlcQsnYNws 0yhoSx/+ugezeMT12/CwFv0QKHmYGlYvSIYg5z9uQRtMT2WgebK3kARrXA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 5eab4aa3 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 21 Dec 2022 21:12:12 +0000 (UTC) Date: Wed, 21 Dec 2022 22:11:53 +0100 From: Julien Lepiller To: pukkamustard Subject: Re: [bug#60120] [PATCH 01/28] gnu: Add ocaml-5.0. Message-ID: <20221221221153.7915a496@sybil.lepiller.eu> In-Reply-To: <20221216132527.2539-1-pukkamustard@posteo.net> References: <20221216132224.2229-1-pukkamustard@posteo.net> <20221216132527.2539-1-pukkamustard@posteo.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60120-done Cc: 60120-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! Thanks for the patch series. Pushed to master with the following fixes: [01/28] > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ocaml/ocaml") > + (commit version))) is missing a file-name field (guix lint complains about it), like this: (file-name (git-file-name name version)) [04/28] > +(define-public ocaml5.0-result but this was not added to the properties of ocaml-result. [06/28] 0.2.1 is the latest version. [07/28] > "https://gitlab.inria.fr/fpottier/monolith/-/archive/20210525/archive.tar.gz" I think this might not be a stable archive, and guix lint complains about the name, so I used git-fetch instead. [08/28] 0.3.0 is the latest version. [09/28] There was a space at the end of description, and it contained typos. You should use https instead of http when available. There was a tab in the patch. [20/28] Description does not match our usual style. It seems you didn't define ocaml-eio as public, because it fails to build. Would be great to fix, wdyt? [21/28] Missing synopsis and description. [22/28] Description does not match our usual style. [23/28] Missing synopsis and description. [24/28] Missing synopsis and description.