From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 11:36:53 2022 Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 16:36:53 +0000 Received: from localhost ([127.0.0.1]:40260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5UkX-00050b-B0 for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:36:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5UkS-00050O-8D for submit@debbugs.gnu.org; Wed, 14 Dec 2022 11:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5UkR-0001JY-Ba for guix-patches@gnu.org; Wed, 14 Dec 2022 11:36:48 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5UkP-0006EP-Ft for guix-patches@gnu.org; Wed, 14 Dec 2022 11:36:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=HQWdtX9z4rVL9 4fA4/3z189dhAr7Swfr5EOHsgR9Ykg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=kFkeeUlSn2xtEB1SxFpG0iYtdG3MDeAsDw0QRn vsp5E4N4hHfnUceXYurzrSmrU/BTsy2hzWtChCYEh4smppEkDnaN+rpfHnvUC+EFGu/IzS fbddBpkLbYkVfYSg0LNCxFuc8RWu+GdROA6WnSv0tD2MnWqiI2CNyO7oj6SyG35WbMZEJE 8VoU3DkT6XqS4xRWNZvR5nr7IaqqI1rpRL/RCNbQEzYklXmUCFw776i0NHhnLIUqv7ELuL sY0yt+mwlZgdVlF52ZBrTQ6uajX8GaG9uiJXzUk6z/Wluio2cuZBSwBlZK8zsldLPeCFHC YzlBeIbdWZsU7eoQBFrrindA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e9f87e7c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 14 Dec 2022 16:36:41 +0000 (UTC) References: <20221214155603.29381-1-maxim.cournoyer@gmail.com> <20221214155603.29381-2-maxim.cournoyer@gmail.com> From: Tobias Geerinckx-Rice To: Maxim Cournoyer Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 17:37:19 +0100 In-reply-to: <20221214155603.29381-2-maxim.cournoyer@gmail.com> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871qp2c54w.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 60069@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > - [ "${#warn}" -ne 0 ] && > - { _err "${ERR}Missing commands: ${warn[*]}."; > - return 1; } > -=20=20=20=20 > + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." > + I did not run this, but will it not itself trigger -e when the=20 test is false? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY5n7/w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW153VEBAMZc1COX05j1JvkESrO5nlRi50eA3a+azXu7O3HW KAJoAQDMJihIBA5fp84NNcckxHto8PMi+dC9sXNcDFCU23NzAg== =1EgH -----END PGP SIGNATURE----- --=-=-=--