From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 14:24:29 2022 Received: (at 60055-done) by debbugs.gnu.org; 21 Dec 2022 19:24:29 +0000 Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hZ-0001S8-8n for submit@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:29 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:39463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p84hX-0001S1-4x for 60055-done@debbugs.gnu.org; Wed, 21 Dec 2022 14:24:27 -0500 Received: by mail-qt1-f172.google.com with SMTP id s9so14472017qtx.6 for <60055-done@debbugs.gnu.org>; Wed, 21 Dec 2022 11:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=dOwoDrje2Hk7WioCqzItEj6pSXFi6Rzm9R7UDdBBGWl7fUYdhjpiVE0hnKHevz4rLp C4+AoBbr+IloR068SW9TeCftOKjIMRk4Hci1r4pvs/IIEeQ4OyrujWG3lAdpgyb7ygw1 8FXD4wISevZ0VjKr9sDf/zywE0sM06j797RdFJGG0GU9eYL3OQ7+HDtwND7Lt9x3AsrP MZkUd4W0MlAWsaVhiXZm1uF/gqhF/NL81Qnlh4jz4D7atPLv760j0PH5mE2oPndMl0W1 mFJ3B39TFQttIFnT/qQT9m8HnIIm9NR3KU/8mXJ/+aNd++hr+cZ4fkKySBl1Qho4ROYs TJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qhCiKaDnC4MyVEKTslORmzE2V0EqmHFaFc/qwFcx4DY=; b=HV+TQwxsXld0IRjBmT5toXu41n/ANu+h4/uj/Rk66yrn7fU29zQ5tPck7AzZsqNBdV 5PLe+1k5KviVX0I5DzwWvlgnSOJ4fTE53GRP8hI8tbcAa4imJCUxlAiJBfkCnEV/Vve5 6NCFuDlvQTcrrSL0V6Tvy4JAojIHuUCMOVKMBeieeV9bv3gP+0VX9EzoABjHwvluHr5z aIVlWMDUrz2CDPxfqIwMsIGclvKSIwdE29yoghKbQCJpMLinPmlCamkpEkn2hqoFrBbL Qp08gePbO6TqEoubnBm3JNhtT1Z9eHafud2yG+9lR79YfrVfIoo1uEHPIrxtvcGs+GYV KaHg== X-Gm-Message-State: AFqh2krvMXiSAd1Gf4b3GOu4pyTScCtIcyKC1/e087OjEwAnOy4TTIFe Eb+BpdgaYvXsJUcqeHni5hEu+SxwN0iJIg== X-Google-Smtp-Source: AMrXdXs7GM+sQvX2XWfrROt7fDvI5cf/xxEJn/0AKZj3E76/D7UgsZ1+Jc9eq+ZJzO0WzMtbLO9t5A== X-Received: by 2002:ac8:70d0:0:b0:3a5:1ea1:bae2 with SMTP id g16-20020ac870d0000000b003a51ea1bae2mr3185749qtp.34.1671650661039; Wed, 21 Dec 2022 11:24:21 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1002]) by smtp.gmail.com with ESMTPSA id v18-20020a05620a0f1200b006cf38fd659asm11675464qkl.103.2022.12.21.11.24.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 11:24:20 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#60055: [PATCH] scripts: system: Skip initrd modules check when using --target. References: <20221214015303.18991-1-maxim.cournoyer@gmail.com> <87wn6k518n.fsf@gnu.org> Date: Wed, 21 Dec 2022 14:24:19 -0500 In-Reply-To: <87wn6k518n.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 21 Dec 2022 14:34:48 +0100") Message-ID: <87zgbg36ho.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60055-done Cc: 60055-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MOD= ULES >> when the %current-target-system parameter is set. > > [...] > >> + (unless (%current-target-system) >> + ;; Skip the check if the user is making use of --target, as it = doesn't >> + ;; make sense in this context. >> + (check-initrd-modules os)))) > > s/doesn=E2=80=99t make sense.*/cannot be checked against the running kern= el./ > > Otherwise LGTM, thanks! Thanks for precising the comment. Applied with the suggestion! --=20 Thanks, Maxim