From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:25:16 2022 Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 22:25:16 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rEZ-00050X-On for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:25:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:50222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rEY-00050R-9V for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:25:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rEY-0006Ad-2x for guix-patches@gnu.org; Mon, 12 Dec 2022 17:25:14 -0500 Received: from smtpmciv5.myservices.hosting ([185.26.107.241]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rEW-0001fV-H5 for guix-patches@gnu.org; Mon, 12 Dec 2022 17:25:13 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.172]) by smtpmciv5.myservices.hosting (Postfix) with ESMTP id DD2922076C; Mon, 12 Dec 2022 23:25:06 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 8ACDE80097; Mon, 12 Dec 2022 23:25:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-1.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id hQwEoMRXwOUY; Mon, 12 Dec 2022 23:25:06 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 0FB7280093; Mon, 12 Dec 2022 23:25:05 +0100 (CET) Message-ID: Date: Mon, 12 Dec 2022 22:25:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [bug#60014] [PATCH] activation: make install-special-file match against pairs as well. Content-Language: en-US To: Tobias Geerinckx-Rice , Josselin Poiret References: <43e937e1625b47a80887e68847fb8a8811d3f39f.1670867103.git.mirai@makinata.eu> <87k02wfjk5.fsf@jpoiret.xyz> <87v8mgcp45.fsf@nckx> From: mirai In-Reply-To: <87v8mgcp45.fsf@nckx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.26.107.241; envelope-from=mirai@makinata.eu; helo=smtpmciv5.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60014@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 2022-12-12 20:52, Tobias Geerinckx-Rice wrote: > Josselin Poiret via Guix-patches via 写道: >> I personally would prefer keeping the special file interface as-is, and >> not mix two different kinds of entries: lists with 2 elements, and >> pairs.  That would avoid having to manage even more edge-cases down the >> line if some more processing is needed. > > I agree with this reasoning, and would go as far as to say that if this fixes anything, that thing should probably be fixed instead…? > > ‘Takes a list of As, but as a special case, a single A’ is confusing and makes it that much harder for newcomers to move beyond cargo-culting magical snippets. That's not what's happening here, right now what guix does is: take a list of tuples, where tuples are 2-element lists of path + file-like. This patch does: take a list of tuples, where tuples are pairs of path + file-like (and as a bonus, preserve existing configurations by allowing the pairs to be lists as well).