From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 04 16:50:39 2022 Received: (at 59822) by debbugs.gnu.org; 4 Dec 2022 21:50:39 +0000 Received: from localhost ([127.0.0.1]:59989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wsh-0003BL-33 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 16:50:39 -0500 Received: from relay.yourmailgateway.de ([188.68.63.166]:56547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wse-0003BF-PY for 59822@debbugs.gnu.org; Sun, 04 Dec 2022 16:50:37 -0500 Received: from mors-relay-8202.netcup.net (localhost [127.0.0.1]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4NQL2g1cjHz4BPX; Sun, 4 Dec 2022 22:50:35 +0100 (CET) Authentication-Results: mors-relay-8202.netcup.net; dkim=permerror (bad message/signature format) Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-8202.netcup.net (Postfix) with ESMTPS id 4NQL2g1DYrz4BCD; Sun, 4 Dec 2022 22:50:35 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net X-Spam-Flag: NO X-Spam-Score: -2.899 X-Spam-Level: X-Spam-Status: No, score=-2.899 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4NQL2f49MQz8sjq; Sun, 4 Dec 2022 22:50:33 +0100 (CET) Received: from florianrock64 (ip5b40a50f.dynamic.kabel-deutschland.de [91.64.165.15]) by mxe217.netcup.net (Postfix) with ESMTPSA id DE9E09FA1C; Sun, 4 Dec 2022 22:50:27 +0100 (CET) From: "pelzflorian (Florian Pelz)" To: "(" Subject: Re: [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button. References: <20221204195007.20997-1-paren@disroot.org> Date: Sun, 04 Dec 2022 22:50:26 +0100 In-Reply-To: <20221204195007.20997-1-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 4 Dec 2022 19:50:07 +0000") Message-ID: <87edterg7x.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DE9E09FA1C X-Spamd-Result: default: False [-5.00 / 15.00]; BAYES_HAM(-4.90)[98.56%]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3209, ipnet:91.64.0.0/14, country:DE]; RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: OpbhkD2TJaYZ+iYBWLUjMs2i1HtjrbExK3GMhBmv1Gi+xTJWXJNxUUm3 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59822 Cc: 59822@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello ( "( via Guix-patches" via writes: > * website/apps/base/templates/home.scm (home-t)[#:content]: Add a > 'DOWNLOAD LATEST' button. Good idea. Would you add a copyright line or copyright disclaimer line and send an updated patch? > #:label (apply string-append > (C_ "button" `("DOWNLOAD v" ,(latest-guix-versio= n) ""))) > [=E2=80=A6] > " " ; A space for readability in non-CSS browsers. > + ,(button-big > + #:label (apply string-append > + (C_ "button" `("DOWNLOAD LATEST"))) In the DOWNLOAD LATEST button, could you remove the (apply string-append and its now unmatched parenthesis? It is a trick to concatenate the translations for "DOWNLOAD v", the latest-guix-version and the translation for "". But for "DOWNLOAD LATEST", it is unneeded. And maybe untabify the lines you change. Other than that, LGTM, thank you! Regards, Florian