From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:50:20 2023 Received: (at 59792) by debbugs.gnu.org; 16 Jan 2023 14:50:20 +0000 Received: from localhost ([127.0.0.1]:32812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQoW-0000rx-7W for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:50:20 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:46703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQoT-0000rf-AY for 59792@debbugs.gnu.org; Mon, 16 Jan 2023 09:50:19 -0500 Received: by mail-qt1-f172.google.com with SMTP id x7so14621377qtv.13 for <59792@debbugs.gnu.org>; Mon, 16 Jan 2023 06:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=hO6xY9i5Z2ukO/M+8LhVoA2+5tDsxl6PGWsKPVoNTNk=; b=Fk9kA+ezZOX9YhXDKzXi9tn3Mc+G44sIjQHPUgD1yag7SUaSeI3S4duFE92tjXNIQ8 akg0RScfZMpQfoO1jSkc9ZDY7f1pQIQov4aYfffhmsW8NMAxl7WlSltG73Kj34VW2Nq/ 55AWiJ5y3sXW0EAsqrdRMMzCk4SZ31nPD1xw3eE6/9a2n7rgMi7ZIeWBqsDOybS6Y9tr TYy+xOcTpBydl68deVMKsKy5D80ieE3HDaqn91GS7kq3Zjsw2FKakq71mU9Gh8Yvuhmx ZNnM2/UfSTOdVzT3VSggaaJ12gukUDRd/UaoGBzTPsO0tJOfC4bJ3phOe+iUMIEDj8Q2 NJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hO6xY9i5Z2ukO/M+8LhVoA2+5tDsxl6PGWsKPVoNTNk=; b=buNNasQ46fW9CqVtWTcMUd7v+xXxi6VMzzzjHHuWKUDrhLekr+7KNkAvhm2Od2Tsy1 jXBabBqIAc36xQ+gtYu4+0xfq7WgWEK6/euSdgbsLhOD7VXODX8rmaknS7c65YHLmopH gzlNttQDOVRRF+N4A6CD5LGzVxwO/IoLIbtWEab1s7DPikRjk8DZaf5lBl00cSLuRG5Y iRwJ7/qcnkdAoEFIj61c0gC+T3va671U4kSDvwGAITsG88RiqHH6ersDJO9cdUoXqzvg C05rzhiIQUMCotZuChFJOb6jg4+TSzU6mPpWL7fskSYm8aXJHqo4O+P+sLbP0ea8MI8i +ATA== X-Gm-Message-State: AFqh2kq5nJVuCcn0bN6WKAKV94Bb7rvk2f0juKorv+xMlAgRafiFrlOf ZhgbwXHYaqMaRHZRHTeJl0PQ4UX+wOXgrsot X-Google-Smtp-Source: AMrXdXt7wtLSpltvHPhKc/2YuILpdpGWlPpQFxfutblyOtbJro4VLMfTECn3u7wYdVVSKfsHu7Kcfw== X-Received: by 2002:a05:622a:5147:b0:3b6:3a8f:d743 with SMTP id ew7-20020a05622a514700b003b63a8fd743mr1089320qtb.66.1673880611581; Mon, 16 Jan 2023 06:50:11 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id y6-20020a37f606000000b006fef61300fesm1494663qkj.16.2023.01.16.06.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:50:11 -0800 (PST) From: Maxim Cournoyer To: Antero Mejr Subject: Re: bug#59792: [PATCH] gnu: Add python-pynetdicom. References: <20221203050357.30524-1-antero@mailbox.org> <20221203050829.30666-1-antero@mailbox.org> Date: Mon, 16 Jan 2023 09:50:10 -0500 In-Reply-To: <20221203050829.30666-1-antero@mailbox.org> (Antero Mejr's message of "Sat, 3 Dec 2022 05:08:29 +0000") Message-ID: <87lem2a5zx.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59792 Cc: lars@6xq.net, 59792@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Antero! Antero Mejr writes: > * gnu/packages/python-science.scm (python-pydicom): New variable. Thanks for this contribution. > Please apply this patch first. > Supersedes #55989. > > gnu/packages/python-science.scm | 46 +++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/gnu/packages/python-science.scm b/gnu/packages/python-science.scm > index 52fe1460bb..00bba25a4a 100644 > --- a/gnu/packages/python-science.scm > +++ b/gnu/packages/python-science.scm > @@ -1656,6 +1656,52 @@ (define-public python-vaex-core > tabular datasets. This package provides the core modules of Vaex.") > (license license:expat))) > > +(define-public python-pydicom > + (package > + (name "python-pydicom") > + (version "2.3.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/pydicom/pydicom") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0q209i2jgwv5z1xhi7frydkplby7jaiz624pjq6vi51wvlmimpf6")))) > + (build-system python-build-system) > + (arguments > + (list #:phases #~(modify-phases %standard-phases > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (when tests? > + ;; skip tests using external data Well done! Please use a complete sentence for stand-alone comments, e.g. ";; Skip tests that require networking." > + (invoke "pytest" "-vv" "-k" > + (string-append > + " not TestDataElement" > + " and not TestDatasetOverlayArray" > + " and not TestReader" > + " and not Test_JPEG_LS_Lossless_transfer_syntax" > + " and not test_data_manager.py" > + " and not test_encaps.py" > + " and not test_encoders_pydicom.py" > + " and not test_filewriter.py" > + " and not test_gdcm_pixel_data.py" > + " and not test_handler_util.py" > + " and not test_jpeg_ls_pixel_data.py" > + " and not test_numpy_pixel_data.py" > + " and not test_overlay_np.py" > + " and not test_pillow_pixel_data.py" > + " and not test_rle_pixel_data.py")))))))) Suggestion: If you use pyproject-build-system, you can avoid overriding the test phase, instead making use of the new #:test-flags argument, to provide just the "-k" and patterns. > + (native-inputs (list python-pytest)) > + (propagated-inputs (list python-numpy python-pillow)) > + (home-page "https://github.com/pydicom/pydicom") > + (synopsis "Python library for reading and writing DICOM data") > + (description "@code{pydicom} is a Python library for reading and writing > +DICOM medical image files. It lets developers read, modify and write DICOM data > +in a pythonic way.") I'd avoid "developers", and plainly state: "It can read, modify [...]", and drop "in a pythonic way" since that's more subjective than facts. -- Thanks, Maxim