From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 21 09:53:13 2023 Received: (at 59762) by debbugs.gnu.org; 21 Mar 2023 13:53:13 +0000 Received: from localhost ([127.0.0.1]:57992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecQK-0001Zw-Jn for submit@debbugs.gnu.org; Tue, 21 Mar 2023 09:53:13 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:44868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecQI-0001Zk-SY for 59762@debbugs.gnu.org; Tue, 21 Mar 2023 09:53:11 -0400 Received: by mail-qt1-f171.google.com with SMTP id s12so17828996qtq.11 for <59762@debbugs.gnu.org>; Tue, 21 Mar 2023 06:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679406785; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=5Wd47p17fSIeGRDgtl/9qkbh7guF4F2wZsN5pUlAmOc=; b=VBUKESivatIEtV5NQ3Q4Qwd6K3vie34vA1TmbLMXgYXhZqGEbKe/VB7jSFd6nDfy+0 8uWBTaS502GSKNQky6CQHINBtt5cRtpyBCjK9/UnswgiTHyBNK5jMTTihU9QwI7NHnPU UD1oca5wuNEge9EcU3Wb1QD+vPzr0cYGjRf+lY4qR9PS0uIcjxJTVmUj5UyBJ3DCZGwW ZfcNuzadn4J+OvNBls+V+IwH+/SH1/8uRvYZPfv/8z+qqJONV9/NmIuohhtcYtfpIFJu yE1zO6uPVsbd/TK1wy7/A4ihxxdjzAID5t/uJ+SBAQ0sgHpNNAJWBWM6VLqmwRp/RYB5 JZ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679406785; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Wd47p17fSIeGRDgtl/9qkbh7guF4F2wZsN5pUlAmOc=; b=P2l3q2NAq+HpeYk5c2sml/uEZ+CXtmR+E5lgYNM36WQZ8scAGkbeGvc6ry66p9oU59 q3LMNG+iZ2lAB7yYjZceACy6f7Uuf5EPYRsSCqIdk2NwwLV8RxaFTDDzMeTh91o+xYbj wiMal0zI5ueJD+AxWpgNL12aKOysljjHwJagpgJfjmBYaYVAfiZBn2GIePqHBpCYcXyH 5KaphV9xOX9Dpp8pjhvx2aCcAMfd5nPOlanp1XwcGPEZc8EWUdUz+tUbEpcgcYmcEaZQ NS1G0vTDBFFgpJDOi7YNHaBBD6xmG1+s6my8vptAfxG1XyU/bKrBCLXSTN0apmymAnTZ 2WZA== X-Gm-Message-State: AO0yUKWpehSbQQNqQhjAA5543WeEv2ZVTIqOG8f6lGX6Lx/i9uL59ji9 zVAkKxbsqsnNqa5iMMyR/USU1bKxpz8Agg== X-Google-Smtp-Source: AK7set9ZTWqwHBWWWB0pHrcUD2DK10lyYiYuay6sZWUhbGDs0lUtFnHIfYxud3kSOofYfiNxL14etA== X-Received: by 2002:a05:622a:311:b0:3b9:b6c8:6d5b with SMTP id q17-20020a05622a031100b003b9b6c86d5bmr4360290qtw.35.1679406785253; Tue, 21 Mar 2023 06:53:05 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id 4-20020a05620a048400b007468bf8362esm3538804qkr.66.2023.03.21.06.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 06:53:04 -0700 (PDT) From: Maxim Cournoyer To: phodina Subject: Re: bug#59762: Add serial-studio References: <87pmbea6cn.fsf@gmail.com> Date: Tue, 21 Mar 2023 09:53:03 -0400 In-Reply-To: <87pmbea6cn.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Jan 2023 09:42:32 -0500") Message-ID: <87lejqqkhs.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59762 Cc: 59762@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Maxim Cournoyer writes: > Hi again! > > phodina writes: > >> Hi, >> >> this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). >> >> ---- >> Petr >> >> >> >> From 6b25d088bd158ad2c5baa7548c49a04bd0f09664 Mon Sep 17 00:00:00 2001 >> From: Petr Hodina >> Date: Wed, 19 Jan 2022 12:01:22 +0100 >> Subject: [PATCH 2/4] gnu: Add qtcsv. >> >> * gnu/packages/qt.scm (qtcsv): New variable. >> >> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm >> index 6aaa9c47c2..71c8aafe3c 100644 >> --- a/gnu/packages/qt.scm >> +++ b/gnu/packages/qt.scm >> @@ -1283,6 +1283,58 @@ (define-public qtconnectivity >> (description "The Qt Connectivity modules provides modules for interacting >> with Bluetooth and NFC."))) >> >> +(define-public qtcsv >> + (package >> + (name "qtcsv") >> + (version "1.6") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/iamantony/qtcsv") >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "109nbspnhaczm85wp1fqazmamdj2bh9wfv3anlslvll606lrfgir")))) >> + (build-system cmake-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases > > Please switch to list + gexps. > >> + (replace 'configure >> + (lambda* (#:key outputs #:allow-other-keys) >> + (invoke "qmake"))) > > Use plain lambda without arguments (lambda _). > >> + (add-after 'unpack 'fix-install >> + (lambda* (#:key outputs #:allow-other-keys) > > Ditto. >> + (let* ((out (assoc-ref outputs "out"))) >> > > Use gexps variables. > >> + (substitute* "qtcsv.pro" >> + (("/usr") out) >> + (("\\$\\$PWD") out))))) >> + (replace 'install >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) (lib (string-append >> + out "/lib")) > > Ditto :-). > >> + (include (string-append out "/include"))) >> + (mkdir-p include) >> + (mkdir-p lib) >> + (chdir "..") ;we were in dir tests > > Same comment bout active tense as earlier... but it seems that'd no > longer be needed with the next comment implemented? > >> + (copy-recursively "include" include) >> + (for-each (lambda (file) >> + (install-file (string-append file) lib)) >> + '("libqtcsv.so" "libqtcsv.so.1" >> + "libqtcsv.so.1.6" "libqtcsv.so.1.6.0"))))) >> + (replace 'check >> + (lambda* (#:key tests? test-options parallel-tests? >> + #:allow-other-keys) >> + (when tests? >> + (chdir "tests") >> + (invoke "qmake"))))))) > > If qmake has a switch like make to change directory, e.g. -C, that'd be > preferable, else "with-directory-excursion" to avoid keeping state in > other phases. > > Otherwise, this patch LGTM. Gently ping :-). There are also other review comments up-thread. -- Thanks, Maxim