From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 16 09:25:54 2023 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:25:54 +0000 Received: from localhost ([127.0.0.1]:60969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQQs-0006E7-7D for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:25:54 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:37480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQQo-0006Do-MB for 59762@debbugs.gnu.org; Mon, 16 Jan 2023 09:25:53 -0500 Received: by mail-qv1-f48.google.com with SMTP id u20so3325303qvq.4 for <59762@debbugs.gnu.org>; Mon, 16 Jan 2023 06:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sOhRwLx6KB6LcNl44TF5OhDQ+h4KsriQryoUJKbTZCE=; b=ji9Ifz1XUivkzBvxVJkfebCAmQJD3t/9boUfTTiLYKpUTl0In2lyzOK9oYcVb8l6ds e56e5M1z347gnnzXmd89VOf/9smKU9j43zcHtOn97NbtV89e+azZVjp72uqZUlgbR/gm amid0WUEhzJDAjDubthfm2pTDfxhJNxSQKItTYazzoZyODrPu+oaQMP+/A0pwXuPGPn7 0AjL034bBVi4LujpXbd4fzzrQtRUMK9MI/tXagq7HmwZJkPJCKM2NY/vHlRfER6F1bFG imv+Pn5FSI0fdy8AGmd1mDxCoedA/pmssw/rKG+laQGNkkl52K5BNzUcHxNwkWV6WAX+ tUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sOhRwLx6KB6LcNl44TF5OhDQ+h4KsriQryoUJKbTZCE=; b=oKK9sLRHi8Q+lnhKRNHJkiw7PrDD6q172PyZJfww9kNThXHWMQ1YGTnB7ZMCKBsTvJ LsLG1rya+AV8st21srgmNXg85oSdhkloljH/p847hATMyOgYwtXwhm1CLrS2cZpcTKl5 r91rNDVM+0OUbHYgDYSqyyZjFmY6DbOP4V/OV5ULhpVKw/0ZxWMl+AJrNbT8whIiIUEY sGPATR8L9wYCnO9UVVAoorJqfz7/GoTOVvcBGX8R3n48B68J4TrZ/vtnnCb3CjWaJaJA vOLa69pcvioFKZcqOEdwk/E005UaOxGnNdHTTuueNtHH3wBGtMcT48HkWJE+Ft5xZkkC eVcw== X-Gm-Message-State: AFqh2koA/GoScuxJMFkeF0HCkwTftOmS6JaCuHDtiAseiiOGI7lW8CAD DBjycbc/Nro09yT/eN3HoNUmvkwE1J+KdSZM X-Google-Smtp-Source: AMrXdXvTkw02Osr/MNVoNoy835S2y0xDdbN+cIWxmaVih0BEMyD2PcEssK5HoFsHAhMrKRanYrX52g== X-Received: by 2002:a05:6214:1186:b0:534:a801:112f with SMTP id t6-20020a056214118600b00534a801112fmr14449207qvv.46.1673879144814; Mon, 16 Jan 2023 06:25:44 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id s1-20020a05620a0bc100b006fa4ac86bfbsm18087733qki.55.2023.01.16.06.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:25:44 -0800 (PST) From: Maxim Cournoyer To: phodina Subject: Re: bug#59762: Add serial-studio References: Date: Mon, 16 Jan 2023 09:25:43 -0500 In-Reply-To: (phodina@protonmail.com's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <874jsqblp4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59762 Cc: 59762@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Petr, phodina writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > From b134cf1d200c867c6b6c8a729a4ad212687a101d Mon Sep 17 00:00:00 2001 > From: Petr Hodina > Date: Fri, 21 Jan 2022 06:30:28 +0100 > Subject: [PATCH 4/4] gnu: Add serial-studio. > > * gnu/packages/qt.scm (serial-studio): New variable. > * gnu/local.mk: Add patch. > * gnu/packages/patches/serial-studio-remove-qsimple-updater.patch: New file. > > diff --git a/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch b/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch > new file mode 100644 > index 0000000000..f8f93364d6 > --- /dev/null > +++ b/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch > @@ -0,0 +1,80 @@ > +From 22b0b5014be7911406b262aeb0864d36f1fbbab5 Mon Sep 17 00:00:00 2001 > +From: Petr Hodina > +Date: Wed, 19 Jan 2022 14:52:08 +0100 > +Subject: [PATCH] Remove code dependent on QSimpleUpdater. Don't include > + qwt.pri, qtcsv.pri and qmqtt.pri. Ideally, the disabling of QSimpleUpdater would be configurable at build time and upstreamed. The patch is not registered in gnu/local.mk in this commit, although the commit log says it should be. [...] > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 4621de0dad..d0521b4894 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -3017,6 +3017,78 @@ (define (delete-unwanted-files child stat flag base level) > system libraries.") > (license license:lgpl2.1+))) > > +(define-public serial-studio > + (package > + (name "serial-studio") > + (version "1.1.4") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Serial-Studio/Serial-Studio") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (patches (search-patches > + "serial-studio-remove-qsimple-updater.patch")) > + (modules '((guix build utils) (ice-9 ftw) > + (srfi srfi-1))) I think the only module you require in your snippet is (guix build utils). > + (snippet '(begin > + (with-directory-excursion "libs" > + (for-each > + delete-file-recursively > + '("qwt" "qtcsv" "qmqtt" > + "QSimpleUpdater"))))) > + (sha256 > + (base32 > + "0qww2pmbvmq3cjx3xk8rxq0zf54y0b0j8bykn4aq3d2dii44m85y")))) > + (build-system qt-build-system) > + (arguments > + `(#:tests? #f ;no test suite Please use (list #:tests? #f #:phases #~(modify-phases %standard-phases [...] for new packages definitions. > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs inputs #:allow-other-keys) > + (substitute* "Serial-Studio.pro" > + (("/usr") (assoc-ref outputs "out")) > + (("INCLUDEPATH \\+= src") (string-append "INCLUDEPATH += src > +INCLUDEPATH += " > + (assoc-ref inputs > + "qwt") > + "/include/qwt > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qwt") > + "/lib" > + " -lqwt > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qtcsv") > + "/lib" > + " -lqtcsv > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qmqtt") > + "/lib" > + " -lQt5Qmqtt"))) The above indentation appears squashed right :-). I'd bring the (string-append "INCLUDEPATH += src [...] on a new line, which will help the rest fit more nicely. > + (invoke "qmake")))))) > + (native-inputs (list qwt qttools pkg-config)) Please sort inputs. > + (inputs (list qtcsv > + qmqtt > + qwt > + qtbase-5 > + qtserialport > + qtsvg-5 > + qtdeclarative-5 > + qtquickcontrols2-5)) Ditto. > + (home-page "https://github.com/Serial-Studio/Serial-Studio") > + (synopsis "Multi-purpose serial data visualization & processing > program") Replace "&" with "and". > + (description > + "This package provides multi-purpose serial data visualization > +and processing GUI program.") This leaves me wanting to know a bit more, but upstream doesn't provide much help, so OK. > + (license license:expat))) > + > (define-public single-application-qt5 > ;; Change in function signature, nheko requires at least this commit > (let ((commit "dc8042b5db58f36e06ba54f16f38b16c5eea9053")) -- Thanks, Maxim