From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 29 14:38:52 2022 Received: (at 59761) by debbugs.gnu.org; 29 Dec 2022 19:38:52 +0000 Received: from localhost ([127.0.0.1]:32944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyjr-0003bH-QR for submit@debbugs.gnu.org; Thu, 29 Dec 2022 14:38:52 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAyjp-0003b4-O4 for 59761@debbugs.gnu.org; Thu, 29 Dec 2022 14:38:50 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1672342727; cv=none; d=zohomail.com; s=zohoarc; b=BHwjV9hDv66l1+8Hv/XsNzkyclhkZOf/ZJ7MYRfg8AwgnKJE1mGypv1DZrQq8Xsng3mVCs/c/iuArZNa1+Q7WtZy0V2+HrxWIpJUPrrc+YpZlloXDYrRkjo3BwOlLGFfEnHLJGIF0vm7Axb4r5c/mNXsPgvZuRytLvAlKy2iAVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672342727; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=pbbrbqLi1/lMeRmjAMBFWj4doBgMEMMGN2XL168Qau4=; b=bn8B8o6xNWbTslHSZqCTF1iQQGm2cGcISk/MiHbagbSZnWyXkWtGJzqkTBrKJFDTAm3/4B4KFDYlLIc2aGZUSHTrbSkZz64AkkH9Ns+zT3FeKgAbI/pXV6tP4lEjJ2Ogb0M/Qru7hTrAf1s/KNIZ7oq+2LF3SfzWhDdUt60Go/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672342727; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=pbbrbqLi1/lMeRmjAMBFWj4doBgMEMMGN2XL168Qau4=; b=GhQmjTl+mE38W/E/9VAA0cT+nFZaahjteVV+XlNzTBXhPohF6jgSvIdqQ9/RzduO DWN3qmM05JTXA83fREH8tQXJs2d3NWgr3uzaxXsZrUiegR4RGPo7CRAz0+rxAcI0UH+ qcalPe5EHzoRMBmZTX7PX3zt22NUiozgumV15gGM= Received: from localhost (1-108-142-46.pool.kielnet.net [46.142.108.1]) by mx.zohomail.com with SMTPS id 16723427259997.328192017408924; Thu, 29 Dec 2022 11:38:45 -0800 (PST) User-agent: mu4e 1.8.13; emacs 28.2 From: Ricardo Wurmus To: 59761@debbugs.gnu.org Subject: [PATCH 0/2] Add u-boot-ts7970-q-2g-1000mhz-c. Date: Thu, 29 Dec 2022 20:33:16 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <871qoi9f0b.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59761 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, there seems to be some overlap between this and https://issues.guix.gnu.org/60224. Looking just at v4 I only have one comment. In your substitute* replacements it=E2=80=99s better not to use string-appe= nd. You can include real line breaks in a string and escape line breaks with \. This is preferable to gluing strings together. For something as long as the replacements in this package consider using a patch file instead. This has the added advantage of failing the build when the patch cannot be applied cleanly. The rest looks good to me. --=20 Ricardo