From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 04 12:28:56 2022 Received: (at 59661) by debbugs.gnu.org; 4 Dec 2022 17:28:56 +0000 Received: from localhost ([127.0.0.1]:58827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snP-0006o1-S2 for submit@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1snN-0006nv-AZ for 59661@debbugs.gnu.org; Sun, 04 Dec 2022 12:28:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snH-00075P-4C; Sun, 04 Dec 2022 12:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a0YeV0dGfJJ7dBCOGu4lDSbobDETzKyOURQAzphYLI8=; b=Qh7NAaB83MQ8PapPoH3u 9GEv449HpiO8lOKzOMhYeqI/beZ2MvUAlOcw4Bpktd4mMLWWRGKYKjGTNfxsvCnCzCBYNXYS1TdBa 7THWbydgOHIUTjxkgqx+z7/6mNwFjQK9/GMIVxKbPLcBGJu2fC32xIYW57xWeZ1OHecY07FBnOCjj 7vt4oJt4rSCmfsjFHhZP5hhTCg/tatYa8i7qt6HcAxMkq8Le/stS+MZdI3OSpUXixY5tUYkLcGgWs XtBXrb6lAE+zHPk0JstGceevKnBMKmMxCojGyK3pYu92Llf6W2WvmwQy8shKSxOMTZCPUr6GA1fwa DApOQvODO9fVAw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1snG-00041O-Lo; Sun, 04 Dec 2022 12:28:46 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#59661: [PATCH 0/3] Add e2fsprogs to %base-packages-utils. References: <20221204044347.23147-1-maxim.cournoyer@gmail.com> <20221204044347.23147-2-maxim.cournoyer@gmail.com> <87wn77m8kw.fsf@gnu.org> Date: Sun, 04 Dec 2022 18:28:44 +0100 In-Reply-To: <87wn77m8kw.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 04 Dec 2022 17:34:23 +0100") Message-ID: <877cz7m62b.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59661 Cc: 59661@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > Maxim Cournoyer skribis: > >> * gnu/system/install.scm (%installer-disk-utilities): Add e2fsprogs. > > LGTM! > > e2fsprogs binaries are indeed missing from $PATH in > guix-system-install-1.4.0rc1.*.iso; I=E2=80=99ll cherry-pick it on > =E2=80=98version-1.4.0=E2=80=99. > > What I don=E2=80=99t get is that our manual installation tests should have > caught this issue because they use =E2=80=98mkfs.ext4=E2=80=99 and expect= to have it in > $PATH. I=E2=80=99ll take a look=E2=80=A6 Got it: Mathieu worked around it in 0f66ef9aa99d2043abccbc80d858bdeca57534ac by explicitly adding e2fsprogs and the installation system used by the tests: commit 0f66ef9aa99d2043abccbc80d858bdeca57534ac Author: Mathieu Othacehe Date: Fri Sep 30 15:19:36 2022 +0200 tests: install: Fix iso-image-installer test. This is a follow-up of: 45eac6cdf5c8d9d7b0c564b105c790d2d2007799. It fixes the following error: + mkfs.ext4 -L my-root /dev/vda2 sh: line 12: mkfs.ext4: command not found * gnu/tests/install.scm (%test-iso-image-installer): Add e2fsprogs to= the appended packages. We should be able to revert this commit once the installer provides e2fsprogs by default. Thanks, Ludo=E2=80=99.