From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 20:25:28 2022 Received: (at 59410) by debbugs.gnu.org; 20 Dec 2022 01:25:28 +0000 Received: from localhost ([127.0.0.1]:41515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7RNo-0001SM-J7 for submit@debbugs.gnu.org; Mon, 19 Dec 2022 20:25:28 -0500 Received: from knopi.disroot.org ([178.21.23.139]:48992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7RNl-0001SG-DX for 59410@debbugs.gnu.org; Mon, 19 Dec 2022 20:25:27 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id AF4E640420; Tue, 20 Dec 2022 02:25:23 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EslUQQUpp5oM; Tue, 20 Dec 2022 02:25:22 +0100 (CET) Message-ID: <6784f1f9-f631-711d-0cdc-22f101c50e3c@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1671499522; bh=MVyNa3Elho+2DCi7DTsJzqhBn/7xg/0mSEVRN7YJfjA=; h=Date:Subject:Cc:From:To; b=VD1pgfESngd68OkJ96OladrzNqtDR+ahutPacqsr0XctqdDpGOkX8oG9L3vmtjYE7 CKsNS39KUQF2SDHjP0DfK+7dQqfQOfJkb2hCVFrCyxiQwV4q6Y7qM89L5m+VpbnmbQ HcxtrLdl1/TaAX6ATvzFKtBzQSkxn6f2GA29R57AAnMenVxtmu3rUh8lkdxnX7KWAa Pr1rb94VufOkOHwKV6+KPzgAWZrBOX/3WpkbnrXGrLF8oVwNjpD19oc0n2Agd1Eowy s/cabBo7ulwsX9qYT7TYtccAE05ZeNQbgqUzvzCAhl2gDbWJTflpdQQfi5UhH8WW3x ZDNZ2IfoLD3xw== Date: Tue, 20 Dec 2022 01:25:18 +0000 MIME-Version: 1.0 Subject: [bug#59410] [PATCH] gnu: Add distrobox. Content-Language: en-US From: Adam Faiz To: 59410@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59410 Cc: rekado@elephly.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Hi, > > thanks for the patch. > > I’m always a bit worried when I see the copy-build-system, because the > lack of a configuration step often means that the tool makes possibly > invalid assumptions about the runtime environment. > > I see that you’re patching the locations of “podman”, “wget”, and > “command -v”, but the tools contain even more references, e.g. to > “curl”, “grep”, “sed”, coreutils, “host-spawn”, “sudo”, “pinentry”, > “less”, … > > It may be a better idea to wrap all the executables in a reasonable > default environment. > > What do you think? It sounds like a good idea. > -- > Ricardo