From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 23 13:17:10 2023 Received: (at 58880) by debbugs.gnu.org; 23 Jan 2023 18:17:10 +0000 Received: from localhost ([127.0.0.1]:55306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1NW-0000L7-3A for submit@debbugs.gnu.org; Mon, 23 Jan 2023 13:17:10 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34001) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pK1NT-0000KW-FB for 58880@debbugs.gnu.org; Mon, 23 Jan 2023 13:17:08 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 720945C021A; Mon, 23 Jan 2023 13:17:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 23 Jan 2023 13:17:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remworks.net; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1674497821; x=1674584221; bh=uBNwsJvaT1 Bf2mRVaTspg/2Ykx4G53AMuyWwrc6hevE=; b=PTylBwcwcwuLd1iPNQ1e2y7TWN 8BbdC4eojxTMtUvrRd94ipffTIZKuJRpmEGn0pC8oDyBRcsKKK6LZsqqs9Vh5Fx3 LJHSMEQZI99GZyq701J/mI9nUngYJLeCOIvhxels564O/ehmEPxe49rrTYY+MrlK rM7Mxg92USKos6uX0nXegO1P4WzJo0qnJzuaxqFuFK2Oq+xrnslkdzSgZb6KXHVp 5b12j7MQNF4cGkRb7H2GjthmJCoD8ogkSi8EogNoD8Yjuheo/o/AjeSALKAICvxb AEGh4jmbQ0OBtgqMCrbCcM45OozslmUqjaAUj4cbDQ3O5w+jcOOqXZ481o0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1674497821; x=1674584221; bh=uBNwsJvaT1Bf2mRVaTspg/2Ykx4G 53AMuyWwrc6hevE=; b=jUPUt7kssuMUXpKuJ2gdTXEmiut4lKo1H9ipw64E9EAn 2A3UPRfaLeFj7qmWfH/x7R2hWjYyYYJpABcws6oA9xij8CcC6rLDIOspt+844mUG pyq4oC0FpTDTziixI8i1n6I3TZNMssAMU5IQ5T+FVWjFDTfhjRq7Q0OVoldbGe5R up6GXWsermFTljTSDb6AdjJUZMRUfs5TUg6BgAW3NP6qMRHQQqUNCBAcJGBW4N62 odtlT4mKSB0/sD2VYrLh1AcRkJybuc9e39LiayGZQ9YXguHKTDW5CMkbbmePZnvS r3ETj80WgGw9Rjp6fIJhZ34GI3nEWgK9swH6ilxGaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddukedgleelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefujgffkfggtgesthdtredttdertdenucfhrhhomheptfgvmhgt ohcuvhgrnhcukdhtucggvggvrhcuoehrvghmtghosehrvghmfihorhhkshdrnhgvtheqne cuggftrfgrthhtvghrnhepkeduveegfedufeelhedvuedvhfeufedtteevkeehhfeigfev lefhgeeukedtfeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheprhgvmhgtohesrhgvmhifohhrkhhsrdhnvght X-ME-Proxy: Feedback-ID: i568842cc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Jan 2023 13:16:59 -0500 (EST) References: <20230123130126.19745-1-remco@remworks.net> <20230123130126.19745-3-remco@remworks.net> <2A87EE0B-147D-4FFB-BA80-055225EDE92A@lepiller.eu> User-agent: mu4e 1.8.13; emacs 28.2 From: Remco van 't Veer To: Julien Lepiller Subject: Re: [PATCH v2 2/2] nls: Update translation keys for guix gc In-reply-to: <2A87EE0B-147D-4FFB-BA80-055225EDE92A@lepiller.eu> Date: Mon, 23 Jan 2023 19:16:58 +0100 Message-ID: <87h6whce05.fsf@remworks.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 58880 Cc: 58880@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) 2023/01/23 14:14, Julien Lepiller: > Ah this is dangerous. You updated the msgid but not the msgstr. This > means the translation will keep using the old format string. Could you > also update the msgstr when a translation exists? The order of the arguments is still the same for all translatable strings so the danger is minimal. I'll send a v3 with the msgstrs updated too (using po-mode.el) but I'll only touch the ones having "~h" (and changed them to "~,2h") and will leave the ones having "~a" for the size argument as they were, just to be sure (don't want to break a translation). > You can also drop all the files with no translation for the affected > msgids from your patch, though this works too. Thanks for the tip but I'll leave them as is for now. Cheers, Remco