Hi Lars, On mer., 19 oct. 2022 at 11:28, Lars-Dominik Braun wrote: > the attached patches are required for guix-cran > (https://github.com/guix-science/guix-cran). import/cran already has the > ability to add a prefix to licenses, but it was not exposed. Additionally > I need to parameterize fetch/download functions, so I can cache the > tarballs/DESCRIPTION files. This is really cool! Thanks for working on that. > Subject: [PATCH 1/3] import/cran: Allow custom license prefix. > X-Debbugs-Cc: zimon.toutoune@gmail.com > X-Debbugs-Cc: dev@jpoiret.xyz > X-Debbugs-Cc: mail@cbaines.net > X-Debbugs-Cc: rekado@elephly.net > X-Debbugs-Cc: othacehe@gnu.org > X-Debbugs-Cc: ludo@gnu.org Because the patch had been sent as attachment, I have not received this X-Debbugs-CC, IIRC. Well, I have added these CC. > * guix/import/cran.scm (%license-prefix): New parameter. > (string->license): Use it. > * guix/scripts/import/cran.scm (%options): Add new parameter -p/--license-prefix. > (show-help): Document it. > (parse-options): Pass it as a parameter to importer. LGTM. Maybe a line in the manual could help. > Subject: [PATCH 2/3] import/cran: Allow overriding description fetch function. > > * guix/import/cran.scm (%fetch-description): New parameter. > (cran->guix-package): Use it. > (upstream-name): Use it. [...] > Subject: [PATCH 3/3] import/cran: Allow overriding tarball download. > > * guix/import/cran.scm (%download-source): New parameter. > (description->package): Use it. > --- > guix/import/cran.scm | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) Well, I miss what it changes – I have nothing special to comment, so LGTM. :-) Cheers, simon