From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 11 06:46:32 2022 Received: (at 58356) by debbugs.gnu.org; 11 Oct 2022 10:46:32 +0000 Received: from localhost ([127.0.0.1]:51114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCmO-0004jY-4l for submit@debbugs.gnu.org; Tue, 11 Oct 2022 06:46:32 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:37763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiCmM-0004jM-9l for 58356@debbugs.gnu.org; Tue, 11 Oct 2022 06:46:30 -0400 Received: by mail-lf1-f42.google.com with SMTP id y5so20480703lfl.4 for <58356@debbugs.gnu.org>; Tue, 11 Oct 2022 03:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=8r91ci4BbgvZkIfuOzNjTnYv0OrGFmPZDzF9RXrlmSI=; b=klmq8A9WX4sBol+nYYeSVmygrxwX3dC0nE1U837s+XH6BwiyOE8cvUbhJSI3NV61Uw WUwjHzxoXTPtMzOSgky0Mljc9kEZYWneZSC/dwCNjB0SMAoNM+BYKqQIXjrbWtUV/2hR AuMInkbtwZfMvnAhBxjojFcyyytNT0GZsXlrAbXkb72y19Xr6gyvv1Le1dRKL0EYcpLc pKumTnCnmp8y1s+s3CtP0KUwpyNrbs2zpGRvVtFXnFndJWInATdbY/HFCg+pezPYGwo7 GLjZZu17w+QZcfxgTGQLlsdoksnyvBoO8jkepTLNZA4f21ckVhoXovtGUJ2vCOjbAeZH 3nfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8r91ci4BbgvZkIfuOzNjTnYv0OrGFmPZDzF9RXrlmSI=; b=LhgppxwJoMTFAgVdpY/DH1ueB80oGzIc+/QGfjiZY2guYvFfMezvTIwiNhCSw7krsr yby3cwKMVIlVjKXYUtEriDHBeA/brd/yGKf3+pu933iJSeXyP4KOnXAF5n8nmQPlz8NI 8u1u8XyzQK/IZNFZ7bXmxS0SxRCaXp/yjjfP+zxFrKs5AF115Jxr+DedeW95uwex0RtS YgTEUEJ/2QjvD7Smr9G3ABfpLhurgoNu86N84hmNxRFlHTEkZ4ytN9hQ72PyUthZ5qWK n+yVx1MvTMbVlPP3M9b8j1b9308x0VQu0ZluL/eKSDQ9Zb228UWJuubtQP1v/P4Rm92T W/1g== X-Gm-Message-State: ACrzQf3ccLnoiJrQxciloKlMbzSe9BydyOGWV4Iv8OQcCc1MfwuV9gto keV8RCw+3DfwXwQ8Kn4hk2hfoVCptObRdGA0u7TMSQ/T3W8= X-Google-Smtp-Source: AMsMyM41axsqnFV8k0upyev7bTc7HFu992GZV233N2/VM4ugJ+WTX84BJIfImbLvcCxt3HBKW3D7cwzoEAvWW9Hxpgg= X-Received: by 2002:a19:9141:0:b0:4a2:d854:b0fe with SMTP id y1-20020a199141000000b004a2d854b0femr4389740lfj.462.1665485184022; Tue, 11 Oct 2022 03:46:24 -0700 (PDT) MIME-Version: 1.0 References: <87czb2297f.fsf@gmail.com> In-Reply-To: <87czb2297f.fsf@gmail.com> From: Mehmet Tekman Date: Tue, 11 Oct 2022 12:45:47 +0200 Message-ID: Subject: Re: bug#58356: [PATCH] Add xtrlock To: 58356@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000c5db6005eabffc9c" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 58356 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --000000000000c5db6005eabffc9c Content-Type: text/plain; charset="UTF-8" Hello, thanks again for the review! The following has been changed: * Placed into xdisorg.scm just after the xlockmore recipe * Removed the CFLAGS, but kept the LDLIBS since it won't build without them * General formatting (lint, style) * License fix I found it easier to spawn a new branch off master and create a new patch than to append to the existing branch. I hope that's okay. The patch is attached. Best, Mehmet --000000000000c5db6005eabffc9c Content-Type: application/x-patch; name="0001-gnu-Add-xtrlock.patch" Content-Disposition: attachment; filename="0001-gnu-Add-xtrlock.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l942tlop0 RnJvbSBiODdjMWU3MjRlMzZjMjQ2NGM2OWExZTMzMDhjY2QwMmM4MjdhYjE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNZWhtZXQgVGVrbWFuIDxtdGVrbWFuODlAZ21haWwuY29tPgpE YXRlOiBUdWUsIDExIE9jdCAyMDIyIDEyOjM4OjEzICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251 OiBBZGQgeHRybG9jay4KCiogZ251L3BhY2thZ2VzL3hkaXNvcmcuc2NtICh4dHJsb2NrKTogTmV3 IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy94ZGlzb3JnLnNjbSB8IDQ2ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCA0NiBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3hkaXNvcmcuc2NtIGIvZ251L3BhY2th Z2VzL3hkaXNvcmcuc2NtCmluZGV4IDk5MDhmMjkxOTEuLmYzYzQ2MzJkYjAgMTAwNjQ0Ci0tLSBh L2dudS9wYWNrYWdlcy94ZGlzb3JnLnNjbQorKysgYi9nbnUvcGFja2FnZXMveGRpc29yZy5zY20K QEAgLTU2LDYgKzU2LDcgQEAKIDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBKYWkgVmV0cml2ZWxhbiA8 amFpdmV0cml2ZWxhbkBnbWFpbC5jb20+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMjIgRGVyZWsgQ2h1 YW5rIDxkZXJla2NodWFua0BvdXRsb29rLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMiBXYW1t IEsuIEQuIDxqYWZ0LnJAb3V0bG9vay5jb20+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjIgTWVobWV0 IFRla21hbiA8bXRla21hbjg5QGdtYWlsLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0 IG9mIEdOVSBHdWl4LgogOzs7CkBAIC0xMDk5LDYgKzExMDAsNTEgQEAgKGRlZmluZS1wdWJsaWMg eGxvY2ttb3JlCiAgICAgKGxpY2Vuc2UgKGxpY2Vuc2U6bm9uLWNvcHlsZWZ0ICNmICJTZWUgeGxv Y2suYy4iKQogICAgICAgICAgICAgICkpKSA7ICsgR1BMdjIgaW4gbW9kZXMvZ2x4L2Jpb2YuYy4K IAorKGRlZmluZS1wdWJsaWMgeHRybG9jaworICAocGFja2FnZQorICAgIChuYW1lICJ4dHJsb2Nr IikKKyAgICAodmVyc2lvbiAiMi4xNSIpCisgICAgKHNvdXJjZSAob3JpZ2luCisgICAgICAgICAg ICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAgICAgICAgICAodXJpIChzdHJpbmctYXBwZW5k CisgICAgICAgICAgICAgICAgICAgICJtaXJyb3I6Ly9kZWJpYW4vcG9vbC9tYWluL3gveHRybG9j ay94dHJsb2NrXyIgdmVyc2lvbgorICAgICAgICAgICAgICAgICAgICAiLnRhci54eiIpKQorICAg ICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAg ICAgIjBtZ3B5c2J2aXBkNWg2eDZ6ejRobmc2YjEzZ3AzcWpucGdueTNhenlqOGs4ZHY4NWJwcHci KSkpKQorICAgIChidWlsZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRz CisgICAgIDs7IHRoZXNlIGZsYWdzIGFyZSByZXF1aXJlZAorICAgICAnKCM6bWFrZS1mbGFncyAo bGlzdCAiTERMSUJTPS1sWDExIC1sY3J5cHQgLWxYaSIpCisgICAgICAgIzpwaGFzZXMgKG1vZGlm eS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY29u ZmlndXJlKQorICAgICAgICAgICAgICAgICAgKGRlbGV0ZSAnY2hlY2spCisgICAgICAgICAgICAg ICAgICAoYWRkLWFmdGVyICd1bnBhY2sgJ3JlbmFtZS1tYWtlZmlsZQorICAgICAgICAgICAgICAg ICAgICAobGFtYmRhIF8KKyAgICAgICAgICAgICAgICAgICAgICAocmVuYW1lLWZpbGUgIk1ha2Vm aWxlLm5vaW1ha2UiICJNYWtlZmlsZSIpCisgICAgICAgICAgICAgICAgICAgICAgKHJlbmFtZS1m aWxlICJ4dHJsb2NrLm1hbiIgInh0cmxvY2suMSIpKSkKKyAgICAgICAgICAgICAgICAgIChyZXBs YWNlICdpbnN0YWxsCisgICAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRz ICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgICAgICAgICAobGV0KiAoKG91dCAo YXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChpbnN0 YWxsLWZpbGUgInh0cmxvY2siCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IChzdHJpbmctYXBwZW5kIG91dCAiL2Jpbi8iKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChp bnN0YWxsLWZpbGUgInh0cmxvY2suMSIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHN0cmluZy1hcHBlbmQgb3V0ICIvc2hhcmUvbWFuL21hbjEvIikpKSkpKSkpCisgICAg KGlucHV0cyAobGlzdCBsaWJ4MTEgbGlieGkgbGlieGZpeGVzKSkKKyAgICAoaG9tZS1wYWdlICJo dHRwczovL3BhY2thZ2VzLmRlYmlhbi5vcmcvc2lkL3h0cmxvY2siKQorICAgIChzeW5vcHNpcyAi TWluaW1hbCBYIGRpc3BsYXkgbG9jayBwcm9ncmFtIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAg Inh0cmxvY2sgbG9ja3MgdGhlIFggc2VydmVyIHRpbGwgdGhlIHVzZXIgZW50ZXJzIHRoZWlyIHBh c3N3b3JkIGF0IHRoZQora2V5Ym9hcmQuICBXaGlsZSB4dHJsb2NrIGlzIHJ1bm5pbmcsIHRoZSBt b3VzZSBhbmQga2V5Ym9hcmQgYXJlIGdyYWJiZWQgYW5kCit0aGUgbW91c2UgY3Vyc29yIGJlY29t ZXMgYSBwYWRsb2NrLiAgT3V0cHV0IGRpc3BsYXllZCBieSBYIHByb2dyYW1zLCBhbmQKK3dpbmRv d3MgcHV0IHVwIGJ5IG5ldyBYIGNsaWVudHMsIGNvbnRpbnVlIHRvIGJlIHZpc2libGUsIGFuZCBh bnkgbmV3IG91dHB1dCBpcworZGlzcGxheWVkIG5vcm1hbGx5LiAgVGhlIG1vdXNlIGFuZCBrZXli b2FyZCBhcmUgcmV0dXJuZWQgd2hlbiB0aGUgdXNlciB0eXBlcwordGhlaXIgcGFzc3dvcmQsIGZv bGxvd2VkIGJ5IEVudGVyIG9yIE5ld2xpbmUuICBJZiBhbiBpbmNvcnJlY3QgcGFzc3dvcmQgaXMK K2VudGVyZWQgdGhlIGJlbGwgaXMgc291bmRlZC4gIFByZXNzaW5nIEJhY2tzcGFjZSBvciBEZWxl dGUgZXJhc2VzIG9uZQorY2hhcmFjdGVyIG9mIGEgcGFzc3dvcmQgcGFydGlhbGx5IHR5cGVkOyBw cmVzc2luZyBFc2NhcGUgb3IgQ2xlYXIgY2xlYXJzCithbnl0aGluZyB0aGF0IGhhcyBiZWVuIGVu dGVyZWQuIikKKyAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCisKIChkZWZpbmUtcHVibGlj IHhvc2QKICAgKHBhY2thZ2UKICAgICAobmFtZSAieG9zZCIpCi0tIAoyLjM3LjMKCg== --000000000000c5db6005eabffc9c--