From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 23 08:51:05 2022 Received: (at 58250) by debbugs.gnu.org; 23 Dec 2022 13:51:05 +0000 Received: from localhost ([127.0.0.1]:37120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8iS0-0004pu-LB for submit@debbugs.gnu.org; Fri, 23 Dec 2022 08:51:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8iRz-0004pU-E2 for 58250@debbugs.gnu.org; Fri, 23 Dec 2022 08:51:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8iRu-0002tQ-7g; Fri, 23 Dec 2022 08:50:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=BOt+Wmwy2ZvV10idH6roZJK1lS0fU1FEr29skgQn7fU=; b=aAnOJnWmr8bAmv6wjL4E 31r8MqygfFgmb9Qnp+6bC4cBTiuEzj2ZIgm8HNwLOOzrx7phIcTxt2psztRL68zjNoV9jx7fHSADx IurkCjsMY6cUr2jqvlLM21AO5fp3HtsiHif33u5fdpYKyH/AKxwHjxbj4Gd2MmWW5NC+uCfd6uasf dyQ125NPe3ZrnAmClcAxKc0wsfNxLsHFa/L6Fq5TlEOO3WduB3Up9wZ+UjmSbRwGT/arKX7xAmhSI 04llK1o5fIyFMXToUYrD+4zqYOap19Sk5nXGnFK13PqAFYQ2bRltuUITqZL+zGgFR43VvdXflOnXk xwMmbXZKYm/78A==; Received: from [193.50.110.60] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8iRk-0003s1-11; Fri, 23 Dec 2022 08:50:57 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: itd Subject: Re: bug#58250: guix import json: GUIX_PACKAGE_PATH -- no code for module References: <871qrqfgiq.fsf@localhost> <87v8p2e1f2.fsf@localhost> Date: Fri, 23 Dec 2022 14:50:46 +0100 In-Reply-To: <87v8p2e1f2.fsf@localhost> (itd@net.in.tum.de's message of "Sun, 02 Oct 2022 16:38:09 +0200") Message-ID: <87mt7ez0sp.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58250 Cc: 58250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) itd skribis: > * guix/import/print.scm (package->code)[package-module-name]: Use > file-name->module-name to build the package module name. > --- > This patch updates the JSON importer to use (guix modules)'s > file-name->module-name to determine the module name. > > guix/import/print.scm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/guix/import/print.scm b/guix/import/print.scm > index 2f54adbd8c..04e6b0a7b1 100644 > --- a/guix/import/print.scm > +++ b/guix/import/print.scm > @@ -21,6 +21,7 @@ (define-module (guix import print) > #:use-module (guix base32) > #:use-module (guix utils) > #:use-module (guix licenses) > + #:use-module (guix modules) > #:use-module (guix packages) > #:use-module (guix search-paths) > #:use-module (guix build-system) > @@ -45,10 +46,7 @@ (define (package->code package) > when evaluated." > ;; The module in which the package PKG is defined > (define (package-module-name pkg) > - (map string->symbol > - (string-split (string-drop-right > - (location-file (package-location pkg)) 4) > - #\/))) > + (file-name->module-name (location-file (package-location pkg)))) LGTM! Ludo'.