From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 01 17:47:51 2022 Received: (at 57963) by debbugs.gnu.org; 1 Oct 2022 21:47:51 +0000 Received: from localhost ([127.0.0.1]:45790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oekKs-0003G5-Vl for submit@debbugs.gnu.org; Sat, 01 Oct 2022 17:47:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oekKr-0003FN-E5 for 57963@debbugs.gnu.org; Sat, 01 Oct 2022 17:47:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oekKl-0007I6-EF; Sat, 01 Oct 2022 17:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oQESRx1vgW5XKexo1adfBErJF/NsXmecvjmAmn/wMVg=; b=ahgrbhz5DYIpEJa9Vygw q6WJZjnDkL4cLSuHoDyu1ivi4W5324giuJnADN2wNoww7UcrRnToES8B7pcXMZyhyeW3KYagoLcQR nOPk9EVPiZWHynQSFraAbdt8tILuxxILXDQ69X0idi9scc7ctCQt6RxIBzNOXKUz34KsNvb7uxdbg v30zlg/cCqIlYuKOCosF9G4MOndko4dCZRi1uJU88gOJXx/OrelUX4/0z3JhO1idqaFjv4x4L43mI q7C7omO01rsXt9iis/l0dTBJ8VNqX7rz50J33QxaSNdZdxfzxGzpGFlkKxiq4W6/0jdxeCLT8gJES 4cZgNUUZUPFLsw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57948 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oekKk-0002t7-Ow; Sat, 01 Oct 2022 17:47:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Taiju HIGASHI Subject: Re: [PATCH v4 1/2] home-services: Add base. References: <20220929143633.28844-1-higashi@taiju.info> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 10 =?utf-8?Q?Vend=C3=A9miair?= =?utf-8?Q?e?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Cuve X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 01 Oct 2022 23:47:41 +0200 In-Reply-To: <20220929143633.28844-1-higashi@taiju.info> (Taiju HIGASHI's message of "Thu, 29 Sep 2022 23:36:32 +0900") Message-ID: <87r0zrb4hu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57963 Cc: 57963@debbugs.gnu.org, liliana.prikler@gmail.com, andrew@trop.in X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Taiju HIGASHI skribis: > * gnu/home.scm: Move home-fontconfig-service-type from > home-environment-default-essential-services to %home-base-services. > * gnu/home/services/base.scm: Add base. In addition to what Liliana wrote, please make sure to add the new file to =E2=80=98gnu/local.mk=E2=80=99. > @@ -82,7 +82,6 @@ (define (home-environment-default-essential-services he) >=20=20 > (service home-symlink-manager-service-type) >=20=20 > - (service home-fontconfig-service-type) > (service home-xdg-base-directories-service-type) > (service home-shell-profile-service-type) Like Liliana wrote, it may be that more of these can be moved from =E2=80=9Cessential=E2=80=9D to =E2=80=9Cbase=E2=80=9D, we can keep that for= a later patch. Otherwise LGTM! Ludo=E2=80=99.