From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 11:20:31 2022 Received: (at 57590) by debbugs.gnu.org; 18 Oct 2022 15:20:31 +0000 Received: from localhost ([127.0.0.1]:53797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoOM-0007l4-NI for submit@debbugs.gnu.org; Tue, 18 Oct 2022 11:20:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okoOH-0007kZ-Mx for 57590@debbugs.gnu.org; Tue, 18 Oct 2022 11:20:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38586) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoOB-0006ma-1P; Tue, 18 Oct 2022 11:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=ZxV62GULYNdjnVHdD8CkxADLKtmcNcjN+I48WR6hexs=; b=pxrgWSYMPru3xlsW6ray laLS1GiEjez4X6AGf6SNyD6nYuJjBAYLuE75JwYv7C2Tuvq2uZUFfM9C3yE1qAS73uEuYnwy8azup N9tn5TOB1wFEJHrSlCxeWpy/xYx+C4UTemCZjuyKSMTJgFJhJaXaEh0Z7fblDwOeGDADKtOh2ja1j +V1sN3XwM+NCXW6C6JNZ22R9LX+UAMQ5Hbolt0L8s0qrA48iyFaS/V51wEWVbZxjwsgf7xjQllYDS F48Q85KP11o9ux+WKBLHdbFahmYJOW+dYCdCJDZpdsoj3rMp36ejFeZcSBPKTvtvfQoqyU7dwisPt bZvC8HLjYAWUzw==; Received: from [193.50.110.209] (port=50876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okoO9-0006Bu-4u; Tue, 18 Oct 2022 11:20:18 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Lukasz Olszewski Subject: Re: bug#57590: [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. References: <87tu42ho62.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 27 =?utf-8?Q?Vend=C3=A9miaire?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Piment X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 18 Oct 2022 17:20:15 +0200 In-Reply-To: (Lukasz Olszewski's message of "Mon, 17 Oct 2022 13:12:13 +0200") Message-ID: <878rldma4w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57590 Cc: 57590@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Lukasz Olszewski skribis: >> > +++ b/gnu/packages/libldm.scm >> > @@ -0,0 +1,70 @@ >> > +(define-module (gnu packages libldm) >> >> We=E2=80=99ll need the license/copyright header as you noted. >> > > I've posted a later patch that included those, but it was posted as a pat= ch > on top of a patch so perhaps it wasn't well visible. I'll integrate it in > the next version. I did see it (thanks!). It would be great though if you could send a single =E2=80=9Cv2=E2=80=9D patch that includes everything. >> > + #:parallel-build? #t >> >> This is unnecessary. >> > > Are parallel builds enabled by default? Yes, that=E2=80=99s why. >> > + (replace 'bootstrap >> > + (lambda _ >> > + (invoke "autoreconf" "-fiv")))))) >> >> Is it necessary? The default =E2=80=98bootstrap=E2=80=99 phase does som= ething similar. >> > > I've copied this phase from another package. If I remember correctly the > configure phase failed without. I'll have to test again to check. Yes please. Thanks, Ludo=E2=80=99.