From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 08 14:21:44 2022 Received: (at 57573) by debbugs.gnu.org; 8 Sep 2022 18:21:44 +0000 Received: from localhost ([127.0.0.1]:60050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWM9n-0002Jo-Vo for submit@debbugs.gnu.org; Thu, 08 Sep 2022 14:21:44 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:41709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWM9m-0002JX-1m for 57573@debbugs.gnu.org; Thu, 08 Sep 2022 14:21:42 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3E4713200906; Thu, 8 Sep 2022 14:21:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 08 Sep 2022 14:21:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662661293; x= 1662747693; bh=slIFj35k2P4tvR6BqgJg+gqe2ZtQssaw9eU28xJ6+XA=; b=V Myg2yAPSgXu1SjFAbwj/NpFIvpvBJXUcpwkiGlEGTEslWrcxdsglhE/jWBJpDJ8F Oe2Bl7+kezQnblZlqq6mB8EIb5qOBEoNAqmeAZCQ6SMXdymTBuclds3rgV1BZdgy VARjCNgG+racHidYLLFKclKamdj2PNcEPZAsPY7DMutBGXlCr+iilugbx2Qpz/PB gXASUTGYBQEar+W4j1mTIYj277OSyYe6xHJByykvwZuHGPOReBi6/SL6OKM4Advu 9JGAB3vq8os6paLpRMndKlUOCfHh9ohouKUYK/7FUqO1aeyBS0DLq0ubS/jSniGa R/KXA0ZYyKOq9DuvWDV2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedtfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvihhm ohhthhihucfurghmphhlvgcuoehsrghmphhlvghtsehnghihrhhordgtohhmqeenucggtf frrghtthgvrhhnpedtkeevgfekveegffehtdfgveetvddukeefffehvdevteegtdevudei gfeftdetvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmphhlvghtsehnghihrhhordgtohhm X-ME-Proxy: Feedback-ID: i4721425c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Sep 2022 14:21:32 -0400 (EDT) From: Timothy Sample To: Maxime Devos Subject: Re: bug#57573: disarchive: Test "[prop] Writing is reversible" fails References: <0a60e3de-9f73-28e5-1adb-af13bfc6a870@student.kuleuven.be> <7c6a2480-072e-e88a-08d7-e22c22cfaf6d@student.kuleuven.be> <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> Date: Thu, 08 Sep 2022 12:21:31 -0600 In-Reply-To: <6a051c77-21f9-c597-7225-727020dccb25@student.kuleuven.be> (Maxime Devos's message of "Sun, 4 Sep 2022 11:05:59 +0200") Message-ID: <871qsllob8.fsf@ngyro.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57573 Cc: 57573@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Maxime, Maxime Devos writes: > (define o (make-unstructured-octal 0 (make-zero-string "0" "=E4=A4=84"))) > (unless (valid-octal? o) (error "oops")) > (test-equal "Writing is reversible (#57573)" > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 o (decode-octal (encode-octal o))) Right. That unstructured octal should be invalid. By the definition in the code, it has too much =E2=80=9Cstructure=E2=80=9D. It=E2=80=99s a test= issue, the actual code is fine. I=E2=80=99ll patch the tests and make a point release in the coming days. Thanks for the heads up and the analysis, and sorry for the inconvenience! -- Tim P.S. I=E2=80=99m excited about antioxidant =E2=80=93 good work and happy ha= cking!