From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 05:35:05 2022 Received: (at 57460) by debbugs.gnu.org; 24 Sep 2022 09:35:05 +0000 Received: from localhost ([127.0.0.1]:42316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1Yu-0001dn-PL for submit@debbugs.gnu.org; Sat, 24 Sep 2022 05:35:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc1Yr-0001dB-Pw for 57460@debbugs.gnu.org; Sat, 24 Sep 2022 05:35:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1Yl-0000V9-D8; Sat, 24 Sep 2022 05:34:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=a0C2yUQQ4wArDBomPrk3UbqG6Fq/QWFIMpzP6XqgAb0=; b=Pbwl0gMKwyrXa/b/uuui uQYI0frrxT+bqX0anABON7iRwBdsd4uII+icj2CMPUbgNfT1JP6eYnpxIevQgWUaDQ2MCnI7JjMch BwF8t9ZcKYd9XZLAN4rzHpqNkkag6BkhoFKlau+qy2Rj4uMUIck0oGGtPBbqc5p2PzJPHgpfGUHqR /95C1P80TVoZjcM2DoZqmsyPQPBbFLaoP1njBkYuOheOtStFlRSnMn38feT86jWN06x1ibRKXbuu4 TtmzaoBU2YtKp61iDUJbkmsBzI18ZY822XFNOvsGUjfTEUBEQ9cRfbxzfSeHid3ec8TspKI8TnJxR Y49vElEBjpvjbg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53580 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc1Yk-0000X5-W3; Sat, 24 Sep 2022 05:34:55 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Hartmut Goebel Subject: Re: bug#57460: [PATCH 00/19] Refresh to specific version References: Date: Sat, 24 Sep 2022 11:34:53 +0200 In-Reply-To: (Hartmut Goebel's message of "Sun, 28 Aug 2022 15:18:38 +0200") Message-ID: <87tu4xcdz6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57460 Cc: 57460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hartmut Goebel skribis: > * guix/import/kde.scm(latest-kde-release): Rename to (import-kde-release)= , add > keyword-argument 'version'. Rework the code to not sort the relevant f= iles, > but just find the requested or latest version. > [find-latest-archive-version]: New function. (Same comment.) [...] > + ;; find latest version > + (version (or version > + (and (not (null? relevant)) > + (tarball->version (find-latest-archive-versio= n relevant))))) > + ;; find archives matching this version > + (archives (filter (lambda (file) > + (string=3D? version (tarball->version file)= )) > + relevant))) I think you can remove the comments or make them proper sentences (capitalized and with a period). I=E2=80=99d prefer to keep the name =E2= =80=98tarballs=E2=80=99 rather than =E2=80=98archives=E2=80=99 because it=E2=80=99s less ambiguous = IMO. > + (match archives > + (() #f) > + (_ Please reindent it as it was.