From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 21 20:55:17 2022 Received: (at 57257) by debbugs.gnu.org; 22 Aug 2022 00:55:17 +0000 Received: from localhost ([127.0.0.1]:37153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPvim-0006XG-Ld for submit@debbugs.gnu.org; Sun, 21 Aug 2022 20:55:16 -0400 Received: from envs.net ([89.163.145.170]:55668 helo=mail.envs.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPvii-0006Wz-Cq for 57257@debbugs.gnu.org; Sun, 21 Aug 2022 20:55:14 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 2C34638A1AB5; Mon, 22 Aug 2022 00:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1661129709; bh=IuDJE9tK7WMwy7S6r89fRGxzlbkxLu4ckQsLdTnXHos=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XMii7Qf4Ut1fuqwik+yRguGKD1bBsyQ3CBbOrBvoblzacqvqn6pRvQ0gVv0+x64Xh uhhz1t0xTqc9XUhszc4LYDkM7x2COkm7KPjbKkmJaEsAL+DKXZMVG1t5EEX/H/3aXt 71ne3SGen4Zp2QQ8ALc5e5LTaDHOWn30XshT9jBAvUmblis9xluT4yScAk4ygyvx7P J55IDq8QQj3cGGKiMdJMgTelg73OjHwvAj5HxDRIufxsFY/vcNgIEnWggS60C8TMm2 rSbwU8hX93YNagzWtGIA6xYzA/QaXsYmbA+C8woG22v4pC7CSkb5MrVvAuDPEoFRYU 2OMltbVCKSYuhcdisRlc8+2qwk1gm4AEDzWV077LGe5rthkDpcbKohqz5n/5tx3aOM 1Ssv4ELvwfiyxe4tF1QPjFz4udrNi2wxZqFAckRgxBjQpkjJyKETc1dDwsZlIlLwlk dSFaNzfIWXb7j3yklH4dh2Xz15KalDU1gfZF1XRzjj7U/07YQSN0iqe9kD14+K9Ox4 cXa4HMWgDiML5/zpSAqhSwIUgPwg2AdO7krDhoPOC5dcyelbSmnEZAK4wxIkc9+a6j V6ec1ZnRBuH4Widyv8T/dgykf5ZcBK8b0bfI5ERQAtArMRni+10B7/f4dQ56YCAH97 lXxKGjf63pKOBrrD/kALX3q4= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yzqRrh2ZXSZ4; Mon, 22 Aug 2022 00:55:05 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: iyzsong@envs.net) by mail.envs.net (Postfix) with ESMTPSA; Mon, 22 Aug 2022 00:55:05 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id ebba5264; Mon, 22 Aug 2022 00:55:03 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Ricardo Wurmus Subject: Re: [PATCH 00/31] Update LXQt to 1.1.0 References: <877d313lpw.fsf@elephly.net> Date: Mon, 22 Aug 2022 08:55:03 +0800 In-Reply-To: <877d313lpw.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 21 Aug 2022 12:55:44 +0200") Message-ID: <87r119jdw8.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57257 Cc: 57257@debbugs.gnu.org, iyzsong@member.fsf.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ricardo Wurmus writes: > Hi, > > overall this looks good to me. Thank you for working on it! > > There are just a few questions: > > - does it really work to use relative file names? Would it be possible > to test this roughly in a system test? Yes, the relative file names are for install, at runtime most things works as designed with XDG_DATA_DIRS and XDG_CONFIG_DIRS. A system test could verify items in lxqt-config, will look it later... > > - you=E2=80=99re removing a lot of patch-source phases. Why are these no= longer > needed? Yeah, I find that use relative file names in LXQtConfigVars.cmake remove the need of patching other cmake files. > > - you=E2=80=99re also removing patch-translations-dir phases. Do transla= tions > still work after applying these changes? Yes, at runtime they are found under XDG_DATA_DIRS, by lxqttranslator.cpp: *searchPath << XdgDirs::dataDirs(QL1C('/') + QL1S(LXQT_RELATIVE_SHARE_TRANS= LATIONS_DIR)); > [...] > > Feel free to push this! Okay, thanks for the review!