From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 15:39:01 2022 Received: (at 57171-done) by debbugs.gnu.org; 20 Sep 2022 19:39:01 +0000 Received: from localhost ([127.0.0.1]:59757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaj5B-0000EH-Ba for submit@debbugs.gnu.org; Tue, 20 Sep 2022 15:39:01 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:51237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaj59-0000E3-Q5 for 57171-done@debbugs.gnu.org; Tue, 20 Sep 2022 15:39:00 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6077D1BF205; Tue, 20 Sep 2022 19:38:52 +0000 (UTC) From: Nicolas Goaziou To: pinoaffe Subject: Re: [bug#57171] [PATCH v2] gnu: Add emacs-pdfgrep. References: <875yiwtkgj.fsf@gmail.com> <878rmf2kq3.fsf@gmail.com> Date: Tue, 20 Sep 2022 21:38:47 +0200 In-Reply-To: <878rmf2kq3.fsf@gmail.com> (pinoaffe@gmail.com's message of "Mon, 19 Sep 2022 22:05:40 +0200") Message-ID: <87sfklx2d4.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57171-done Cc: 57171-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, pinoaffe writes: > Date: Sat, 13 Aug 2022 13:59:20 +0200 > From 28d500390c6eee5e89b9fb3c756300751b8af598 Mon Sep 17 00:00:00 2001 > * gnu/packages/emacs-xyz.scm (emacs-pdfgrep): New variable. Thank you. Applied with the following changes. > +(define-public emacs-pdfgrep > + (let ((commit "a4ca0a1e6521de93f28bb6736a5344b4974d144c") > + (revision "0")) > + (package > + (name "emacs-pdfgrep") > + (version (git-version "0" revision commit)) Latest version is actually 1.4. I also downgraded the commit to the one matching the version bump. > + (url "https://github.com/jeremy-compostella/pdfgrep.git") I removed the ".git" suffix from the URL. > + (add-after > + 'unpack > + 'patch-pdfgrep-path > + (lambda* (#:key inputs #:allow-other-keys) > + (make-file-writable "pdfgrep.el") > + (emacs-substitute-variables "pdfgrep.el" > + ("pdfgrep-program" > + (search-input-file inputs "bin/pdfgrep"))) > + #t))))) I removed the trailing #t. > + (synopsis "Run pdfgrep within Emacs and display the results.") > + (description > + "This package provides the Emacs \"grep\" facilities for the pdfgrep program.") I used the description from the repository, which seemed more clear. Regards, -- Nicolas Goaziou