From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 06:09:32 2022 Received: (at 57171) by debbugs.gnu.org; 23 Aug 2022 10:09:32 +0000 Received: from localhost ([127.0.0.1]:42692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQqi-0005ib-8e for submit@debbugs.gnu.org; Tue, 23 Aug 2022 06:09:32 -0400 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQQqg-0005iS-TC for 57171@debbugs.gnu.org; Tue, 23 Aug 2022 06:09:31 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1661249368; cv=none; d=zohomail.com; s=zohoarc; b=JnBi7otvh+GoM8BrWpJCJQ+clHOK2qULQWp8WCwlj3n7R+HZ+Jg/x85ksKHCrDTdlUTPk7G2CxSV4bNO7xSIIiOc5CI/qfCtnwe3cUQQ3wv/5Rspg25nXMFxOZ8qwGJhL9tbbjqgoCr2n4FFS0/Lmnpd7ah98QVxkGyJBZVmOTM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1661249368; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=gn/M8vy6hFYsSbjnUCynYzg38+VqBC5QC+kChyRCJUs=; b=hlqBPRlzaJBWWIV1k1kETvnqoFSJSxXkzWwEmFbQl1fmAKx4aMyYW6AgIfKG6a+HqNNuh4eponCJTN360odSyy6k6a6hjTz5PUg5kGX4jIiPOYlbr/FCoRozeXlA9c1CMfsXHxStdQ750lzABk+Yt7XU/oAtkre+IyVIZQyL6yA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1661249368; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=gn/M8vy6hFYsSbjnUCynYzg38+VqBC5QC+kChyRCJUs=; b=KMrf3qNAHUuIc0Cn3TL8T8mGJJs2oOCY+cQ9K56cL5L2VM66dYv1lKVdQAF8ubYa NSFF0eyUBXcLe8chEmpNvRqPlViN6wzVi3prTDIrkYm+cOeP1zQ9d55cK8gqwjQNiqO Cl0hBgB9zEe93ei9BTcOozFYv/h5DkKr991Fh5e8= Received: from localhost (84-109-142-46.pool.kielnet.net [46.142.109.84]) by mx.zohomail.com with SMTPS id 1661249366324252.3365939536801; Tue, 23 Aug 2022 03:09:26 -0700 (PDT) User-agent: mu4e 1.8.7; emacs 28.1 From: Ricardo Wurmus To: 57171@debbugs.gnu.org Subject: [PATCH] gnu: Add emacs-pdfgrep. Date: Tue, 23 Aug 2022 12:07:30 +0200 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87fshnz2y4.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57171 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thanks for the patch. I=E2=80=99d change the let* to let, because we don=E2=80=99t need previous = bindings to be available in later bindings. It would also be nice to avoid propagating pdfgrep. We could probably avoid propagation by patching https://github.com/jeremy-compostella/pdfgrep/blob/master/pdfgrep.el#L59 and perhaps also line 81 (executable-find "pdfgrep"). In the synopsis I=E2=80=99d remove the `=E2=80=A6' quotes, but that=E2=80= =99s a nit-pick. What do you think? --=20 Ricardo