From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 05:51:24 2022 Received: (at 57149) by debbugs.gnu.org; 12 Aug 2022 09:51:25 +0000 Received: from localhost ([127.0.0.1]:55693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMRK8-0005DS-Gl for submit@debbugs.gnu.org; Fri, 12 Aug 2022 05:51:24 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:36643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMRK5-0005DI-Mb for 57149@debbugs.gnu.org; Fri, 12 Aug 2022 05:51:23 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4M3zTB6Mzhz1LZY1; Fri, 12 Aug 2022 11:51:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4M3zTB6Mzhz1LZY1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1660297871; bh=kcMgr2A8cLCTRWH6ZdGM2Yx/HB9UF2SpVe8Cq6ESR6w=; h=Subject:From:To:Date:In-Reply-To:References:From; b=mJfcfLui3TKe6G4Cx3GB4IzNJk7oZZWhp0r5Ind7F60+NrWP7dddWyUxuXrxavG+0 ZX6zf4ff5lLveefbQrkuTuhO30MOjlFYKEz+f6DD1zEa5BQw36OZmhCv6t0N+uxi3E 8Mf5rMnj5TjMhuar3mve36ZGSme9kQbIZ30QcZic= Message-ID: Subject: Re: [PATCH] gnu: Add font-nerd-fonts-firacode From: Liliana Marie Prikler To: Benoit Joly , 57149@debbugs.gnu.org Date: Fri, 12 Aug 2022 11:51:09 +0200 In-Reply-To: <20220812042313.19198-1-benoit@benoitj.ca> References: <20220812042313.19198-1-benoit@benoitj.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -0.4 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57149 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Freitag, dem 12.08.2022 um 00:23 -0400 schrieb Benoit Joly: > * gnu/packages/fonts (font-nerd-fonts-firacode): New variable. > --- >  gnu/packages/fonts.scm | 35 +++++++++++++++++++++++++++++++++++ >  1 file changed, 35 insertions(+) > > diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm > index 20b55bce96..0ce9ba8414 100644 > --- a/gnu/packages/fonts.scm > +++ b/gnu/packages/fonts.scm > @@ -51,6 +51,7 @@ >  ;;; Copyright © 2021 Liliana Marie Prikler > >  ;;; Copyright © 2022 Jose G Perez Taveras >  ;;; Copyright © 2022 Hilton Chain > +;;; Copyright © 2022 Benoit Joly >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -2795,3 +2796,37 @@ (define-public font-chiron-hei-hk >  Kong variant of Adobe’s Source Han Sans.  The font aims at providing > a modern, >  region-agnostic glyph set adopting the “modern” glyph style that is > similar to >  prevalent typefaces in Traditional Chinese regions."))) > + > +(define-public font-nerd-fonts-fira-code > +  (package > +   (name "font-nerd-fonts-fira-code") > +   (version "2.1.0") > +   (source > +    (origin > +     (method url-fetch) > +     (uri > +      (string-append > +       "https://github.com/ryanoasis/nerd-fonts/releases/download/v" > +       version > +       "/FiraCode.zip")) > +     (sha256 > +      (base32 > +       "1rx7zrkq0584k6hrh6dx30xrnz5nq379xyw73pfd4gxaxnh9mpi1")))) Use (uri (string-append "..." "...") > +   (build-system font-build-system) > +   (arguments > +    `(#:phases > +      (modify-phases %standard-phases > +        (add-before 'install 'make-files-writable > +          (lambda _ > +            (for-each > +             make-file-writable > +             (find-files "." ".*\\.(otf|otc|ttf|ttc)$")) > +            #t))))) Why do the files need to be made writable for install? > +   (home-page "https://www.nerdfonts.com/") > +   (synopsis "Nerd fonts variant of FiraCode font") > +   (description > +    "Nerd fonts variant of FiraCode font.  Nerd Fonts is a project > that patches > +developer targeted fonts with a high number of glyphs (icons).  > Specifically to > +add a high number of extra glyphs from popular 'iconic fonts' such > as Font > +Awesome, Devicons, Octicons, and others.") > +   (license license:silofl1.1))) The description should consist of full sentences. Note that Nerd fonts pulls in icons that are licensed under CC BY-NC-ND, which makes them unfree. I'm not sure if those icons are present in the default distribution, but I'd hazard a guess that they are. More concerningly, the patches that can be applied via nerd fonts are directly coded into their font-patcher, rather than, say, distributed as a json file to be read separately. As far as I'm aware, this makes nerd-fonts (the tool) itself NG. Cheers